BudRunBun

Can I get rid of the Tile Entity?

Okay, I changed it a bit and it works now package com.budrunbun.lavalamp.tileEntities; import com.budrunbun.lavalamp.blocks.PlayerSensorBlock; import net.minecraft.entity.player.PlayerEntity; import net.minecraft.tileentity.ITickableTileEntity; import net.minecraft.tileentity.TileEntity; public class PlayerSensorTileEntity extends TileEntity implements ITickableTileEntity { public PlayerSensorTileEntity() { super(ModTileEntities.PLAYER_SENSOR_TE); } @Override public void tick() { PlayerEntity playerentity = this.world.getClosestPlayer(this.pos.getX(), this.pos.getY(), this.pos.getZ(), 3.0D, false); if (playerentity != null) { world.setBlockState(getPos(), world.getBlockState(pos).with(PlayerSensorBlock.LIT, true)); } else { world.setBlockState(getPos(), world.getBlockState(pos).with(PlayerSensorBlock.LIT, false)); } } }

I want to make a block that emits redstone signal if there is a player nearby but getClosestPlayer() always returns an empty PlayerEntity TE: package com.budrunbun.lavalamp.tileEntities; import com.budrunbun.lavalamp.blocks.PlayerSensorBlock; import net.minecraft.entity.player.PlayerEntity; import net.minecraft.tileentity.ITickableTileEntity; import net.minecraft.tileentity.TileEntity; public class PlayerSensorTileEntity extends TileEntity implements ITickableTileEntity { public PlayerSensorTileEntity() { super(ModTileEntities.PLAYER_SENSOR_TE); } @Override public void tick() { PlayerEntity playerentity = this.world.getClosestPlayer((double) ((float) this.pos.getX() + 0.5F), (double) ((float) this.pos.getY() + 0.5F), (double) ((float) this.pos.getZ() + 0.5F), 3.0D, false); if (playerentity != null) { System.out.println("Tick"); world.setBlockState(getPos(), world.getBlockState(pos).with(PlayerSensorBlock.LIT, true)); } } }

Now I have another problem. If player is in creative mode right-clicks an item in shelf I want it to disappear (I think that onBlockClicked() is for right-click and removedByPlayer() is to prevent the block from destruction), but when I right-click it item dissappears, block gets destroyed and immediately restored, even particles spawn. @Override public boolean removedByPlayer(BlockState state, World world, BlockPos pos, PlayerEntity player, boolean willHarvest, IFluidState fluid) { if (player.isCreative()) { if (canBreakBlockInCreative(state, world, pos, player)) world.setBlockState(pos, Blocks.AIR.getDefaultState(), world.isRemote() ? 11 : 3); else onBlockClicked(state, world, pos, player); return false; } return super.removedByPlayer(state, world, pos, player, false, fluid) || willHarvest; } public boolean canBreakBlockInCreative(BlockState state, World world, BlockPos pos, PlayerEntity player) { double blockReachDistance = player.getAttribute(PlayerEntity.REACH_DISTANCE).getValue() + 1; BlockRayTraceResult rayResult = rayTraceEyes(world, player, blockReachDistance + 1); return getSlot(rayResult, state, pos) == -1; } @Override public void onBlockClicked(BlockState state, World worldIn, BlockPos pos, PlayerEntity player) { if (!worldIn.isRemote()) { BlockRayTraceResult hit = rayTraceEyes(worldIn, player, player.getAttribute(PlayerEntity.REACH_DISTANCE).getValue() + 1); int slot = getSlot(hit, state, pos); ShelfTileEntity shelf = (ShelfTileEntity) worldIn.getTileEntity(pos); ItemStackHandler handler = shelf.getHandler(); if (slot != -1 && !handler.getStackInSlot(slot).isEmpty()) { ItemStack item = handler.getStackInSlot(slot); if (!player.isCreative()) { if (!player.inventory.addItemStackToInventory(item)) { dropItemStack(worldIn, pos, item); } } handler.setStackInSlot(slot, ItemStack.EMPTY); worldIn.notifyBlockUpdate(pos, state, state, 3); shelf.setHandler(handler); } }

Yes, it was the solution. Thank you very much! If anyone is interested in the code, here it is

Anyone?

Render works perfectly now but entity.getHandler().getStackInSlot() always returns empty itemstack. How to fix it? Renderer: package com.budrunbun.lavalamp.renderer; import com.budrunbun.lavalamp.blocks.HorizontalFacingBlock; import com.budrunbun.lavalamp.tileEntities.ShelfTileEntity; import com.mojang.blaze3d.platform.GlStateManager; import net.minecraft.client.Minecraft; import net.minecraft.client.renderer.ItemRenderer; import net.minecraft.client.renderer.model.ItemCameraTransforms; import net.minecraft.client.renderer.tileentity.TileEntityRenderer; import net.minecraft.item.ItemStack; import net.minecraft.item.Items; import net.minecraft.util.Direction; import net.minecraftforge.api.distmarker.Dist; import net.minecraftforge.api.distmarker.OnlyIn; public class ShelfBlockRenderer extends TileEntityRenderer<ShelfTileEntity> { private final ItemRenderer itemRenderer = Minecraft.getInstance().getItemRenderer(); private Direction FACING; @Override public void render(ShelfTileEntity entity, double x, double y, double z, float partialTicks, int destroyStage) { FACING = entity.getBlockState().get(HorizontalFacingBlock.FACING); ItemStack itemStack = new ItemStack(Items.WHEAT); renderBottomLeftItem(x, y, z, itemStack); itemStack = new ItemStack(Items.APPLE); renderTopLeftItem(x, y, z, itemStack); itemStack = new ItemStack(Items.FEATHER); renderBottomRightItem(x, y, z, itemStack); itemStack = new ItemStack(Items.LAVA_BUCKET); renderTopRightItem(x, y, z, itemStack); } private void renderBottomLeftItem(double x, double y, double z, ItemStack stack) { GlStateManager.pushMatrix(); switch (FACING) { case NORTH: GlStateManager.translated(x + 0.25, y + 0.25, z + 0.45); GlStateManager.scalef(0.35F, 0.35F, 0.35F); GlStateManager.rotatef(180, 0, 1, 0); break; case SOUTH: GlStateManager.translated(x + 0.75, y + 0.25, z + 0.45 + 0.0625); GlStateManager.scalef(0.35F, 0.35F, 0.35F); break; case EAST: GlStateManager.translated(x + 0.45 + 0.0625, y + 0.25, z + 0.25); GlStateManager.scalef(0.35F, 0.35F, 0.35F); GlStateManager.rotatef(90, 0, 1, 0); break; default: GlStateManager.translated(x + 0.45, y + 0.25, z + 0.75); GlStateManager.scalef(0.35F, 0.35F, 0.35F); GlStateManager.rotatef(270, 0, 1, 0); break; } this.itemRenderer.renderItem(stack, ItemCameraTransforms.TransformType.FIXED); GlStateManager.popMatrix(); } private void renderTopLeftItem(double x, double y, double z, ItemStack stack) { GlStateManager.pushMatrix(); switch (FACING) { case NORTH: GlStateManager.translated(x + 0.25, y + 0.75, z + 0.45); GlStateManager.scalef(0.35F, 0.35F, 0.35F); GlStateManager.rotatef(180, 0, 1, 0); break; case SOUTH: GlStateManager.translated(x + 0.75, y + 0.75, z + 0.45 + 0.0625); GlStateManager.scalef(0.35F, 0.35F, 0.35F); break; case EAST: GlStateManager.translated(x + 0.45 + 0.0625, y + 0.75, z + 0.25); GlStateManager.scalef(0.35F, 0.35F, 0.35F); GlStateManager.rotatef(90, 0, 1, 0); break; default: GlStateManager.translated(x + 0.45, y + 0.75, z + 0.75); GlStateManager.scalef(0.35F, 0.35F, 0.35F); GlStateManager.rotatef(270, 0, 1, 0); break; } this.itemRenderer.renderItem(stack, ItemCameraTransforms.TransformType.FIXED); GlStateManager.popMatrix(); } private void renderTopRightItem(double x, double y, double z, ItemStack stack) { GlStateManager.pushMatrix(); switch (FACING) { case NORTH: GlStateManager.translated(x + 0.75, y + 0.75, z + 0.45); GlStateManager.scalef(0.35F, 0.35F, 0.35F); GlStateManager.rotatef(180, 0, 1, 0); break; case SOUTH: GlStateManager.translated(x + 0.25, y + 0.75, z + 0.45 + 0.0625); GlStateManager.scalef(0.35F, 0.35F, 0.35F); break; case EAST: GlStateManager.translated(x + 0.45 + 0.0625, y + 0.75, z + 0.75); GlStateManager.scalef(0.35F, 0.35F, 0.35F); GlStateManager.rotatef(90, 0, 1, 0); break; default: GlStateManager.translated(x + 0.45, y + 0.75, z + 0.25); GlStateManager.scalef(0.35F, 0.35F, 0.35F); GlStateManager.rotatef(270, 0, 1, 0); break; } this.itemRenderer.renderItem(stack, ItemCameraTransforms.TransformType.FIXED); GlStateManager.popMatrix(); } private void renderBottomRightItem(double x, double y, double z, ItemStack stack) { GlStateManager.pushMatrix(); switch (FACING) { case NORTH: GlStateManager.translated(x + 0.75, y + 0.25, z + 0.45); GlStateManager.scalef(0.35F, 0.35F, 0.35F); GlStateManager.rotatef(180, 0, 1, 0); break; case SOUTH: GlStateManager.translated(x + 0.25, y + 0.25, z + 0.45 + 0.0625); GlStateManager.scalef(0.35F, 0.35F, 0.35F); break; case EAST: GlStateManager.translated(x + 0.45 + 0.0625, y + 0.25, z + 0.75); GlStateManager.scalef(0.35F, 0.35F, 0.35F); GlStateManager.rotatef(90, 0, 1, 0); break; default: GlStateManager.translated(x + 0.45, y + 0.25, z + 0.25); GlStateManager.scalef(0.35F, 0.35F, 0.35F); GlStateManager.rotatef(270, 0, 1, 0); break; } this.itemRenderer.renderItem(stack, ItemCameraTransforms.TransformType.FIXED); GlStateManager.popMatrix(); } } TE: package com.budrunbun.lavalamp.tileEntities; import com.budrunbun.lavalamp.containers.ShelfContainer; import mcp.MethodsReturnNonnullByDefault; import net.minecraft.entity.player.PlayerEntity; import net.minecraft.entity.player.PlayerInventory; import net.minecraft.inventory.container.Container; import net.minecraft.inventory.container.INamedContainerProvider; import net.minecraft.nbt.CompoundNBT; import net.minecraft.tileentity.TileEntity; import net.minecraft.util.text.ITextComponent; import net.minecraft.util.text.TranslationTextComponent; import net.minecraftforge.items.ItemStackHandler; import javax.annotation.Nullable; import javax.annotation.ParametersAreNonnullByDefault; public class ShelfTileEntity extends TileEntity implements INamedContainerProvider { private final ItemStackHandler handler = new ItemStackHandler(4) { @Override protected void onContentsChanged(int slot) { super.onContentsChanged(slot); markDirty(); } }; public ShelfTileEntity() { super(ModTileEntities.SHELF_TE); } public ItemStackHandler getHandler() { return handler; } @Override public void read(CompoundNBT compound) { super.read(compound); this.handler.deserializeNBT(compound.getCompound("inv")); } @Override public CompoundNBT write(CompoundNBT compound) { super.write(compound); compound.put("inv", handler.serializeNBT()); return compound; } @Override public ITextComponent getDisplayName() { return new TranslationTextComponent("shelf_block"); } @Nullable @Override public Container createMenu(int windowId, PlayerInventory playerInventory, PlayerEntity playerEntity) { return new ShelfContainer(windowId, handler, playerInventory); } }

I have also bound my renderer to TileEntity: @Mod(LavaLamp.MOD_ID) public class LavaLamp { public static final String MOD_ID = "lavalamp"; public static IProxy proxy = DistExecutor.runForDist(() -> ClientProxy::new, () -> ServerProxy::new); public LavaLamp() { FMLJavaModLoadingContext.get().getModEventBus().addListener(this::setupCommon); FMLJavaModLoadingContext.get().getModEventBus().addListener(this::setupClient); } private void setupCommon(final FMLCommonSetupEvent event) { proxy.init(); } private void setupClient(final FMLClientSetupEvent event) { ClientRegistry.bindTileEntitySpecialRenderer(ShelfTileEntity.class, new ShelfBlockRenderer()); } }

I tried using ItemRenderer but it did nothing package com.budrunbun.lavalamp.renderer; import com.budrunbun.lavalamp.tileEntities.ShelfTileEntity; import com.mojang.blaze3d.platform.GlStateManager; import net.minecraft.client.Minecraft; import net.minecraft.client.renderer.ItemRenderer; import net.minecraft.client.renderer.model.ItemCameraTransforms; import net.minecraft.client.renderer.texture.AtlasTexture; import net.minecraft.client.renderer.tileentity.TileEntityRenderer; import net.minecraft.item.ItemStack; import net.minecraft.util.math.BlockPos; import net.minecraftforge.api.distmarker.Dist; import net.minecraftforge.api.distmarker.OnlyIn; public class ShelfBlockRenderer extends TileEntityRenderer<ShelfTileEntity> { private final ItemRenderer itemRenderer = Minecraft.getInstance().getItemRenderer(); @Override public void render(ShelfTileEntity entity, double x, double y, double z, float partialTicks, int destroyStage) { GlStateManager.pushMatrix(); BlockPos blockpos = entity.getPos(); double d0 = (double) blockpos.getX() - entity.getPos().getX() + x; double d1 = (double) blockpos.getY() - entity.getPos().getY() + y; double d2 = (double) blockpos.getZ() - entity.getPos().getZ() + z; GlStateManager.translated(d0 + 0.5D, d1 + 0.5D, d2 + 0.5D); this.bindTexture(AtlasTexture.LOCATION_BLOCKS_TEXTURE); GlStateManager.pushMatrix(); GlStateManager.translatef(-0.5F, -0.5F, -0.5F); GlStateManager.popMatrix(); GlStateManager.enableLighting(); GlStateManager.translatef(0.0F, 0.0F, 0.4375F); this.renderItem(entity); GlStateManager.enableLighting(); GlStateManager.popMatrix(); } private void renderItem(ShelfTileEntity entity) { ItemStack itemstack = entity.getHandler().getStackInSlot(0); if (!itemstack.isEmpty()) { GlStateManager.pushMatrix(); GlStateManager.scalef(0.5F, 0.5F, 0.5F); this.itemRenderer.renderItem(itemstack, ItemCameraTransforms.TransformType.FIXED); GlStateManager.popMatrix(); } } }

Vanilla uses ItemRenderer to display items in item frame, do I need to use it or there is a better way?

Okay, I will try

I want to create a shelf block that can store items and dislay them like shelfs in Bibliocraft. I have looked up in the Armor Stand and Item Frame renderers and they use different superclass.I suppose that LivingEntityRenderer is not applicable here because I don't want my block to be LivingEntity. What renderer should I use: EntityRenderer or TileEntityRenderer?

Yes but getShape() method in Block class return VoxelShape and I can't make it return sth else

Is it in theory possible to make a BB via custom algorithm(convex hull) or things are hard-coded with voxelshapes?

Okay, I will lower the number of partitions. Is there any way not to display BB? It looks bizarre.