HappleAcks

May 15, 2014

I think the problem is that the rendering happens on the client but the state is probably updated (along with other mob AI and behavior) on the server. I just ran into this sort of thing myself for an elephant entity I made where I wanted it to rear up when attacked. The solution is you need to send a custom packet to sync the client.

You can see my elephant model processing the state in this Youtube video (near the end you can see the Elephant gets attacked by the tiger and rears up). Check it out here:

If you want to see how I used packets for the elephant model state sync, see my tutorial (still sort of draft but should be useful to you) here: http://jabelarminecraft.blogspot.com/p/packet-handling-for-minecraft-forge-172.html

I have other tips about doing entity animations here: http://jabelarminecraft.blogspot.com/p/complex-entity-models-including.html

You can also use other packet systems, or the dataWatcher to do this. But my way seems to work well.

Anyway, my point is that I suspect the problem is your state isn't detected by the entity on the client because it is being updated on the server side and not being synced.

This looks very helpful, but it might be a bit much just to make my pet sit. :\

May 15, 2014

Wait a minute, that is even wrong. Something like this.

if (entityhusser.getState()) == 1){

model = new modelrHusser();

}else{

model = new modelrHusser2();

}

But really, you shouldn't construct a new one each time. You need to define them up above as different variables and plug them into model as you go.

I did define them above as variables, at the top in the code I pasted earlier.

May 15, 2014

You are using the same texture for both model's? Possible, but seems odd.

Explain how you changed the model. Did you just say model = model2 or such?

Did you change it in your constructur for RenderLiving, ect? You need to look at the classes you are extending and make sure just changing model really changes everything.

How different is your new model? Your other option is to have everythign in one model and choose which peices to render.

What I did was this:

I know the state function works because it is used inside the entity file to change behaviour and that part works fine.

@SideOnly(Side.CLIENT)

public class RenderHusser extends RenderLiving {

private static final ResourceLocation EntityTexture = new ResourceLocation("darkmod:textures/mobs/Husser.png");

protected modelrHusser model;

protected modelrHusser2 model2;

public RenderrHusser(ModelBase par1ModelBase, float par2) {

super(par1ModelBase, par2);

}

public void renderrHusser(EntityLiving par1EntityLiving, double par2, double par4, double par6, float par8, float par9){

*Bind EntityHusser here*

if (entityhusser.getState()) == 1){

model = ((modelrHusser)mainModel);

}else{

model2= ((modelrHusser2)mainModel);

}

renderrHusser((EntityrHusser)par1EntityLiving, par2, par4, par6, par8, par9);

}

@Override

protected ResourceLocation getEntityTexture(Entity entity) {

return EntityTexture;

}

May 15, 2014

Just set model via the entity's state in the renderHusser function.

Tried this, but the model doesn't seem to update.

May 15, 2014

That is true.

But then again: @SideOnly on the render files is not needed. If you do NOT have it and it crashes, adding it will most likely not fix it.

So I just had this issue again, and with the previous fixes.

Particle spawn:

@Override

public void onUpdate()

{

super.onUpdate();

if (!this.worldObj.isRemote) {

for (int var3 = 0; var3 < 8; ++var3)

{

Powder var1 = new Powder(this.worldObj, this.posX, this.posY-1, this.posZ, 0.0D, 0.0D, 0.0D, 5);

FMLClientHandler.instance().getClient().effectRenderer.addEffect(var1);

}

Particle code:

@SideOnly(Side.CLIENT)

public class Powder extends EntityFX

{

public float portalParticleScale;

public int last;

public Powder (World par1World, double par2, double par4, double par6, double par8, double par10, double par12, int age)

{

super(par1World, par2, par4, par6, par8, par10, par12);

this.last = age;

this.motionX = par8 + (float)(Math.random() * 2.0D - 1.0D) * 0.05F;

this.motionY = par10 + (float)(Math.random() * 2.0D - 1.0D) * 0.05F;

this.motionZ = par12 + (float)(Math.random() * 2.0D - 1.0D) * 0.05F;

float var14 = this.rand.nextFloat() * 0.6F + 0.4F;

this.portalParticleScale = this.particleScale = this.rand.nextFloat() * 0.2F + 0.5F;

this.particleRed = this.particleGreen = this.particleBlue = 1.0F * var14;

this.particleGreen *= 0.3F;

this.particleRed *= 0.9F;

this.particleScale = this.rand.nextFloat() * this.rand.nextFloat() * 6.0F + 1.0F;

this.particleMaxAge = (int)(16.0D / (this.rand.nextFloat() * 0.8D + 0.2D)) + 2;

}

/**

* Called to update the entity's position/logic.

*/

@Override

public void onUpdate()

{

this.prevPosX = this.posX;

this.prevPosY = this.posY;

this.prevPosZ = this.posZ;

if (this.particleAge++ >= this.particleMaxAge)

{

this.setDead();

}

this.setParticleTextureIndex(7 - this.particleAge * last / this.particleMaxAge);

this.motionY += 0.004D;

this.motionX *= 0.8999999761581421D;

this.motionY *= 0.8999999761581421D;

this.motionZ *= 0.8999999761581421D;

if (this.onGround)

{

this.motionX *= 0.699999988079071D;

this.motionZ *= 0.699999988079071D;

}

May 15, 2014

So if I wanted to change a mob model depending on a state (using a method getState() in the entity file).

My current render file:

@SideOnly(Side.CLIENT)

public class RenderHusser extends RenderLiving {

private static final ResourceLocation EntityTexture = new ResourceLocation("darkmod:textures/mobs/Husser.png");

protected modelrHusser model;

protected modelrHusser2 model2;

public RenderrHusser(ModelBase par1ModelBase, float par2) {

super(par1ModelBase, par2);

model = ((modelrHusser)mainModel);

}

public void renderrHusser(EntityLiving par1EntityLiving, double par2, double par4, double par6, float par8, float par9){

renderrHusser((EntityrHusser)par1EntityLiving, par2, par4, par6, par8, par9);

}

@Override

protected ResourceLocation getEntityTexture(Entity entity) {

return EntityTexture;

}

May 12, 2014

I don't see where you are setting your value.

DataWatcher#updateObject(id, newValue) from previous post. not sure the exact syntax and I don't have my code handy right now.

You need to set this value initially with a random.

My bad..

So now it works. I forgot that I removed my random number generator at one point when I implemented the data watcher methods.

May 12, 2014

@OP The render class' getEntityTexture method has an Entity parameter, which is your entity - you can cast it to your custom entity class to access your entity class methods:
protected ResourceLocation getEntityTexture(Entity entity) {
// cast to your entity
YourEntityClass blah = (YourEntityClass) entity;

// now you can access class methods, such as my hypothetical getType() which
// returns the integer value from datawatcher used to store the mob's type, i.e. texture

switch(blah.getType()) {
case 1: return texture1;
case 2: return texture2;
etc;
}
}
DataWatcher is just for storing a single value, in this case an integer, that is synchronized between server and client - you set the value on the server, and all of the player clients will see the same value, in this case texture.

@delpi DataWatcher ranges vary from Entity to Entity - players use the most of any, and I tend to start mine at around 21 or 22 just from habit, but if you really need to know exactly which indices are still available, the most sure method of finding out is to open up all the parent classes of the entity in question and look at the constructors and entityInit methods to see which values are used. This page lists some of them, but it may be outdated.

@OP - you may want to check out that link as well, it's a tutorial on DataWatcher, though I think SanAndreasP pretty much covered it all

I'm still having the same problem as before where it only does whatever is the 'default:' in the switch, and without default there it has an error as it thinks it has a chance of not returning anything and thus would want void on the function.

My related code:

In Entity File:

protected void entityInit()

{

super.entityInit();

this.getDataWatcher().addObject(12, Byte.valueOf((byte)0));

this.getDataWatcher().addObject(13, Byte.valueOf((byte)0));

this.getDataWatcher().addObject(25, 5);

}

public int getTextureType()

{

return this.dataWatcher.getWatchableObjectInt(25);

}

In Render File:

@Override

protected ResourceLocation getEntityTexture(Entity entity) {

EntityRider thisentity = (EntityRider) entity;

switch(thisentity.getTextureType()){

case 0:

return EntityTexture1;

case 1:

return EntityTexture2;

case 2:

return EntityTexture3;

case 3:

return EntityTexture4;

case 4:

return EntityTexture5;

default:

return EntityTexture3;

}

May 12, 2014

Make sure your texture field is not static, and also that the field is visible / updated on the client. Personally, I use DataWatcher to store an integer that I can retrieve using a method such as 'entity.getType()', and place the switch in my render class as 'switch(((MyEntity) parEntity).getType())'

I haven't worked with the Data Watchers much before, so I got lost a little bit. So I'll create the method, but how do I save and read from the watcher [in order to call from 1 of my 6 possible textures].

First, you need to register a field ("object") inside the DataWatcher with the
DataWatcher#addObject(id, initialValue)
method, preferably inside the
entityInit()
method in your entity.
id
is an unique object id which you need to reference the object. Please note that there are pre-occupied IDs already, so if it crashes with the ID, try another one. Also there's a cap of max. 32 objects within a DataWatcher.
initialValue
is pretty self-explanatory. Possible data types can be:
ItemStack, String, Integer, Short, Byte, Float, ChunkCoordinates
. Either use new DataType() (e.g.
new ItemStack(...)
) or, for primitive datatypes, cast it (e.g. to have a short, use
(short) 10
)

Second, to get an object from the DataWatcher, use
DataWatcher#getWatchableObject[DataType](id)
, where
[DataType]
is the datatype you've defined previously (e.g. for integer, use getWatchableObjectInt(id)). The only exceptions where you can't use this is ChunkCoordinates.

Here's a list of datatypes and getters:
ItemStack : getWatchableObjectItemStack
String    : getWatchableObjectString
Float     : getWatchableObjectFloat
Integer   : getWatchableObjectInt
Short     : getWatchableObjectShort
Byte      : getWatchableObjectByte
Third, to write to the defined object, use
DataWatcher#updateObject(id, newValue)
, which follows the same rules as the in initialValue from the registration for the newValue. Also make sure to only update values on the server (worldObj.isRemote == false), or you get discrepancies with client and server.

This was very helpful, but I can't seem to get it to work at all. I've run into a lot of things such as:

1) It won't let me access the value from the render class because it wants it to be static to do that, but a this.x cannot be static [in this case, x is the datawatcher].

2)I don't know how data watchers will help me get any more of a random number than it did before. Because I understand I can generate a random number, saved it in the data watcher and then use it, but I can just do that without a data watcher by generating a random number and using that directly.

May 12, 2014

Make sure your texture field is not static, and also that the field is visible / updated on the client. Personally, I use DataWatcher to store an integer that I can retrieve using a method such as 'entity.getType()', and place the switch in my render class as 'switch(((MyEntity) parEntity).getType())'

I haven't worked with the Data Watchers much before, so I got lost a little bit. So I'll create the method, but how do I save and read from the watcher [in order to call from 1 of my 6 possible textures].

May 12, 2014

So if I have a mob and a few possible textures, how would I make it have a random texture [from my list] each time it spawns.

I've tried doing a switch and generating a random int, but both times it determined the texture for all of them upon startup.

May 12, 2014

That is true.

But then again: @SideOnly on the render files is not needed. If you do NOT have it and it crashes, adding it will most likely not fix it.

Okay good to know. Thank you.

May 11, 2014

@SideOnly does NOT do what you think it does.

You should never actually use it.

@SideOnly(Side.CLIENT) means the class/method/field will not be present in the minecraft_server.jar, only in the minecraft.jar. That means it WILL be present on the Integrated Server.

isRemote doesn't do this and therefor is the way to go.

Is the new place where I placed the isRemote [in previous post] correct? Also, in all my Render files I always have @SideOnly(Side.CLIENT) at the beginning because I was told a while back that's how you make things properly work for SMP. I assume this is okay for the render files though [like the mob render files]. However, for an entity I should always use the isRemote (I already had the isRemote in the weapon code for spawning the entity too)?

May 11, 2014

onUpdate get's called on both client & server.

You must a) check for the client with world.isRemote and

b) not call client-only stuff (particles) from common code (entities).

My bad for B, I didn't actually copy this part, but right before the on update there is:

@SideOnly(Side.CLIENT) <--- This

@Override

public void onUpdate()

{

super.onUpdate();

---

So I can assume the client only thing wasn't a problem. Now, for checking if the world is remote, I do this in the entity projectile file correct? So something like the following:

@SideOnly(Side.CLIENT)

@Override

public void onUpdate()

{

super.onUpdate();

if (!this.worldObj.isRemote) {

for (int var3 = 0; var3 < 8; ++var3)

{

Powder var1 = new Powder(this.worldObj, this.posX, this.posY-1, this.posZ, 0.0D, 0.0D, 0.0D, 5);

FMLClientHandler.instance().getClient().effectRenderer.addEffect(var1);

}

May 11, 2014

Still unsolved.

Mod works fine in 1024, and grants 0 errors in 1060 so I'm not sure why I'm getting the crash.

May 11, 2014

Can you show your particle spawning code?

The code spawning it from the projectile:

@Override

public void onUpdate()

{

super.onUpdate();

for (int var3 = 0; var3 < 8; ++var3)

{

Powder var1 = new Powder(this.worldObj, this.posX, this.posY-1, this.posZ, 0.0D, 0.0D, 0.0D, 5);

FMLClientHandler.instance().getClient().effectRenderer.addEffect(var1);

}

And the actual particle code:

@SideOnly(Side.CLIENT)

public class Powder extends EntityFX

{

public float portalParticleScale;

public int last;

public Powder (World par1World, double par2, double par4, double par6, double par8, double par10, double par12, int age)

{

super(par1World, par2, par4, par6, par8, par10, par12);

this.last = age;

this.motionX = par8 + (float)(Math.random() * 2.0D - 1.0D) * 0.05F;

this.motionY = par10 + (float)(Math.random() * 2.0D - 1.0D) * 0.05F;

this.motionZ = par12 + (float)(Math.random() * 2.0D - 1.0D) * 0.05F;

float var14 = this.rand.nextFloat() * 0.6F + 0.4F;

this.portalParticleScale = this.particleScale = this.rand.nextFloat() * 0.2F + 0.5F;

this.particleRed = this.particleGreen = this.particleBlue = 1.0F * var14;

this.particleGreen *= 0.3F;

this.particleRed *= 0.9F;

this.particleScale = this.rand.nextFloat() * this.rand.nextFloat() * 6.0F + 1.0F;

this.particleMaxAge = (int)(16.0D / (this.rand.nextFloat() * 0.8D + 0.2D)) + 2;

}

/**

* Called to update the entity's position/logic.

*/

@Override

public void onUpdate()

{

this.prevPosX = this.posX;

this.prevPosY = this.posY;

this.prevPosZ = this.posZ;

if (this.particleAge++ >= this.particleMaxAge)

{

this.setDead();

}

this.setParticleTextureIndex(7 - this.particleAge * last / this.particleMaxAge);

this.motionY += 0.004D;

this.motionX *= 0.8999999761581421D;

this.motionY *= 0.8999999761581421D;

this.motionZ *= 0.8999999761581421D;

if (this.onGround)

{

this.motionX *= 0.699999988079071D;

this.motionZ *= 0.699999988079071D;

}

May 10, 2014

So I got this out of bounds error, and I see it's with the particle effects. I was shooting a weapon that leaves a particle effect trail, so I'm not sure how it got out of bounds.

[19:08:26] [Client thread/FATAL]: Unreported exception thrown!

java.lang.IndexOutOfBoundsException: Index: 3999, Size: 4000

at java.util.ArrayList.rangeCheck(Unknown Source) ~[?:1.7.0_51]

at java.util.ArrayList.get(Unknown Source) ~[?:1.7.0_51]

at net.minecraft.client.particle.EffectRenderer.updateEffects(EffectRenderer.java:77) ~[EffectRenderer.class:?]

at net.minecraft.client.Minecraft.runTick(Minecraft.java:2153) ~[Minecraft.class:?]

at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:1036) ~[Minecraft.class:?]

at net.minecraft.client.Minecraft.run(Minecraft.java:951) [Minecraft.class:?]

at net.minecraft.client.main.Main.main(Main.java:112) [Main.class:?]

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.7.0_51]

at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.7.0_51]

at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.7.0_51]

at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.7.0_51]

at net.minecraft.launchwrapper.Launch.launch(Launch.java:134) [launchwrapper-1.9.jar:?]

at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.9.jar:?]

May 10, 2014

Still haven't been able to solve this, if it helps anyone here is my class path [if that is the issue] to my main class:

ForgeFolder\src\main\java\com\darkMod\common\DarkMod.java

May 8, 2014

So I just updated to forge build 1060 and I don't have any errors in the mod, but I get this error [and a crash] upon trying to start up MC within development now. The building and updating was successful in gradle.

It only happens when my mod source is in the src folder. Was something changed about the class path that I don't know about?

Description: Initializing game

java.lang.NullPointerException: Initializing game

at cpw.mods.fml.common.registry.FMLControlledNamespacedRegistry.addObjectRaw(FMLControlledNamespacedRegistry.java:393)

at cpw.mods.fml.common.registry.FMLControlledNamespacedRegistry.set(FMLControlledNamespacedRegistry.java:55)

at cpw.mods.fml.common.registry.GameData.set(GameData.java:698)

at cpw.mods.fml.common.registry.GameData.<init>(GameData.java:692)

at cpw.mods.fml.common.registry.GameData.freezeData(GameData.java:645)

at cpw.mods.fml.common.Loader.initializeMods(Loader.java:683)

at cpw.mods.fml.client.FMLClientHandler.finishMinecraftLoading(FMLClientHandler.java:268)

at net.minecraft.client.Minecraft.startGame(Minecraft.java:583)

at net.minecraft.client.Minecraft.run(Minecraft.java:890)

at net.minecraft.client.main.Main.main(Main.java:112)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

at java.lang.reflect.Method.invoke(Unknown Source)

at net.minecraft.launchwrapper.Launch.launch(Launch.java:134)

at net.minecraft.launchwrapper.Launch.main(Launch.java:28)

A detailed walkthrough of the error, its code path and all known details is as follows:

---------------------------------------------------------------------------------------

-- Head --

Stacktrace: