[[SOLVED] [1.10.2] Stairs model bug]

Well, that sucks...

 

So I just need a stairs model which is rotated upside down, how do I make that?

 

It's fixed now : link

[[SOLVED] [1.10.2] Stairs model bug]

The vanilla way is a pain, that was what I was using before, I had hundreds of files, and it took me a lot of time to generate all blockstate files correctly.

 

You say "they don't add together" but on one line, like that : "facing=west,half=top,shape=straight": { "x": 180, "y": 180 }

It works (even with vanilla file) so why not on separate lines? Shouldn't be so difficult to implement.

[[SOLVED] [1.10.2] Stairs model bug]

I don't understand, can you give me an example of how I should replace?

[[SOLVED] [1.10.2] Stairs model bug]

Hi,

 

I have a problem with the stairs in my mod: when placed upside down (except when facing east) it display the bottom east model instead of the corresponding one.

But, the properties are correctly set, as I see it when looking at the block with 'F3' enabled. So the bug have to come from the blockstate files right?

If someone could have a look at those, here, it would be great.

 

Thanks in advance

[[SOLVED] [1.10.2] World.isRemote bug ?]

It's tricky simply because there is no clean way to intercept that the integrated server has been opened to LAN. I searched for a few minutes and saw nothing: The IntegratedServer#shareToLAN method is called from the button or the command, but I didn't see any way to "register a listener" or something like that.

Like you said, it's simpler to always send it. The client can just ignore it.

[[SOLVED] [1.10.2] World.isRemote bug ?]

This is different.

Some blocks can be deactivated from the config file. If they are, so are the associated recipes. If a dedicated server deactivate blocks, the connected client should also deactivate them, because if not, the recipes will still show, but the result cannot be obtain. This is ugly.

There might be other issues I'm not thinking about, but with this, the client is always configured the same way as a dedicated server, except for client only settings but there is only one for now.

[[SOLVED] [1.10.2] World.isRemote bug ?]

Why? This sounds like a terrible idea to me.

 

Without context obviously ...

I synchronize settings between dedicated server and clients, hence the 'not singleplayer' test.

[[SOLVED] [1.10.2] World.isRemote bug ?]

Yeah, but that's the point. I wanna know, on the client, if this is a single or multiplayer game.

[[SOLVED] [1.10.2] World.isRemote bug ?]

I think I found what I want :

 

Minecraft.getMinecraft().isSingleplayer()

 

With that I can now if this is a single player game.

[[SOLVED] [1.10.2] World.isRemote bug ?]

Then how can I test if the world is not local.

[[SOLVED] [1.10.2] World.isRemote bug ?]

Hi,

 

world.isRemote should be set to false in a single player game, right ? Because I'm having an issue here :

 

@SubscribeEvent
public void onWorldLoad(WorldEvent.Load event) {
World world = event.getWorld();

if (world.isRemote) {
	// Executed even in single player
}
}

 

Is it normal ?

[[1.10] Changing village blocks]

Ok I ran genPatches and it included my changes in the patch file.

I was trying too do it manually...

[[1.10] Changing village blocks]

How can I make a pull request with a file that doesn't exist in the repo? I mean where do I put it? The Minecraft source are not in the repo, only patches.

 

Maybe I should open an issue instead and put the file in a gist?

[[1.10] Changing village blocks]

Thank you!

 

Should I edit the existing patch file ? Or make a new one beside? I'm not really comfortable with those.

Also if I rename the variables (iblockstate1,2,3...) should I do it in the patch file or there is a place for it?

I'm asking because I saw the processing of Minecraft sources is very ordered and complex.

[[1.10] Changing village blocks]

This is a real problem, GetVillageBlockID is not usable because it is called for half the blocks. It's stupid...

Can the Forge team edit Minecraft code ? It's about ten lines to change, and I can help, just tell me where to go.

[[1.10] Changing village blocks]

It's kinda working, here's what I've done:

 

 

 

private BlockPos pos;
private boolean hasChanged = false;
private UBBiome currentBiome; // UB stones biomes, not minecraft biomes!

@SubscribeEvent
public void initMapGen(InitMapGenEvent event) {
if (event.getType() == EventType.VILLAGE) {
	event.setNewGen(new MapGenVillage() {
		@Override
		public StructureStart getStructureStart(int chunkX, int chunkZ) {
			LOGGER.debug("Village start in chunk: " + chunkX + ";" + chunkZ);
			pos = new BlockPos(chunkX * 16, 0, chunkZ * 16);
			hasChanged = true;
			return super.getStructureStart(chunkX, chunkZ);
		}
	});
	event.setResult(Result.DENY);
}
}

@SubscribeEvent
public void onVillageSelectBlock(GetVillageBlockID event) {
IBlockState originalState = event.getOriginal();
Block originalBlock = originalState.getBlock();

if (hasChanged) {
	currentBiome = // getting the biome at pos...
	hasChanged = false;
}

// replace blocks
if (originalBlock == Blocks.COBBLESTONE) {
	event.setReplacement(...);
	event.setResult(Result.DENY);
}
// ...
}

 

 

 

The problem is that Minecraft don't call StructureVillagePieces.Village#getBiomeSpecificBlockState for all block of the structures.

For example in StructureVillagePieces.Church#addComponentParts:

IBlockState iblockstate = Blocks.COBBLESTONE.getDefaultState(); // Cobble is not replaced for Churches
IBlockState iblockstate1 = this.getBiomeSpecificBlockState(Blocks.STONE_STAIRS.getDefaultState().withProperty(BlockStairs.FACING, numFacing.NORTH));
IBlockState iblockstate2 = this.getBiomeSpecificBlockState(Blocks.STONE_STAIRS.getDefaultState().withProperty(BlockStairs.FACING, EnumFacing.WEST));
IBlockState iblockstate3 = this.getBiomeSpecificBlockState(Blocks.STONE_STAIRS.getDefaultState().withProperty(BlockStairs.FACING, EnumFacing.EAST));

 

I think Forge should just patch this by replacing the first line like the ones below it, It won't break anything.

If not I will use reflection but I may need some help.

[[1.10] Changing village blocks]

I may have found a solution, but I need to find a way to know if a village is done generating. Is there an event for that ? Or something else I can use ?

[[1.10] Changing village blocks]

That's a bummer... What about structures in general, is there anyway to get the coordinates of generated structures?

[[1.10] Changing village blocks]

Hi!

 

I want to change villages structures blocks depending on the coordinates. Is there a Forge event I can use for this?

I know there is GetVillageBlockID but there is no access to the coordinates from this event.

 

Thanks in advance

[[SOLVED] What is OreRecipe ?]

Hi!

 

What is the difference between ShapedRecipes/ShapelessRecipes and ShapedOreRecipe/ShapelessOreRecipe ?

[[1.10] Tutorial for mod config ?]

Ok, thanks!

What about category and property ordering?

[[1.10] Tutorial for mod config ?]

Hi!

 

Is there any tutorial about mod config file ? I would like to know how to make a GUI for the config, which can be translated with a lang file (I think I saw this functionality in Forge source).

 

Also, is there a clean way to set the categories order? Instead of prefix them with 1, 2, 3 ...

 

Thanks in advance

[[SOLVED] [1.10] Custom walls model error]

I fixed it by adding:

 

"defaults": {
"model": "builtin/generated"
}

[[SOLVED] [1.10] Custom walls model error]

Custom walls with variants. They're working, but there are annoying errors ...

 

Is there some kind of "empty model" that I can put as default model to remove those errors?

[[SOLVED] @SideOnly annotation]

Yes, of course. Thanks you very much!