[1.16.4]Custom Enchantment problem

[pervll]

I have added an enchantment to my mod and it has some problem when running the mod.

The feature of the enchantment should be:

• When the feet slot have this enchantment, the player get a speed 3 effect
• The player will hurt 1/40 of the probability for every 20 blocks movement

The register file:

public static final DeferredRegister<Enchantment> ENCHANTMENTS = DeferredRegister.create(ForgeRegistries.ENCHANTMENTS, Technology.MOD_ID);
private static final EquipmentSlotType[] LEGS = new EquipmentSlotType[]{EquipmentSlotType.FEET};
public static final RegistryObject<Enchantment> VOID_SPEED = ENCHANTMENTS.register("void_speed", () -> new VoidSpeedEnchantment(Enchantment.Rarity.VERY_RARE, EnchantmentType.ARMOR_FEET, LEGS));

 

The enchantment file:

public class VoidSpeedEnchantment extends Enchantment {
    public VoidSpeedEnchantment(Rarity rarity, EnchantmentType type, EquipmentSlotType[] slots) {
        super(rarity, EnchantmentType.ARMOR_FEET, slots);
    }

    @Override
    public int getMaxLevel() { return 4; }

    @Override
    public int getMinEnchantability(int enchantmentLevel) { return enchantmentLevel * 20; }

    @Override
    public int getMaxEnchantability(int enchantmentLevel) { return this.getMinEnchantability(enchantmentLevel) + 15; }

    @Override
    public boolean isAllowedOnBooks() {
        return true;
    }

    @Override
    public boolean canVillagerTrade() {
        return false;
    }

    @Override
    public boolean isTreasureEnchantment() {
        return true;
    }
}

The event file:

@Mod.EventBusSubscriber(modid = Technology.MOD_ID, bus = Mod.EventBusSubscriber.Bus.FORGE, value = Dist.CLIENT)
public class ModClientEvents {

    @SubscribeEvent
    public static void onFeetWithVoidSpeedEnchantment(PlayerEvent event){
        PlayerEntity player = event.getPlayer();
        World world = event.getPlayer().getEntityWorld();
        double move = event.getPlayer().getDistance(player);
        if (EnchantmentHelper.getMaxEnchantmentLevel(RegistryHandler.VOID_SPEED.get(), player) > 0){ // Problem shows on this line when debugging
            player.addPotionEffect(new EffectInstance(Effects.SPEED, 5, 3));
            if (move >= 20){
                move = 0;
                Random random = new Random();
                int d1 = random.nextInt(40);
                if (d1 == 1){
                    d1 = 0;
                    player.addPotionEffect(new EffectInstance(Effects.INSTANT_DAMAGE));
                    player.sendStatusMessage(new StringTextComponent(TextFormatting.RED + "Hurt by the void"), true);
                }
            }
        }
    }
}

 

[Luis_ST]

I guess your event won't call because
you should use a subclass here and not directly the PlayerEvent class

For example, the PlayerTick event would be conceivable
but this Event is not located in the PlayerEvent class (TickEvent§PlayerTickEvent).

Idea:
In my opinion, the ticket event is not the best solution. I would use the LivingEquipmentChangeEvent for the speed effect,
then check whether the entity is a player and the item enchatend is in your enchantment, and then add an effect to the player that is infinite (you then have to remove it the same way)

and because of the damage, check out the Damage Events(LivingDamageEvent and LivingHurtEvent) read the java docs for more information about the events.

Edited April 22, 2021 by Luis_ST

[Draco18s]

28 minutes ago, pervll said:

value = Dist.CLIENT

  

29 minutes ago, diesieben07 said:

• @Mod.EventBusSubscriber(Dist.CLIENT) - This is not what you want. Why are you doing this only on the client?

 

[pervll]

19 hours ago, Luis_ST said:

I guess your event won't call because
you should use a subclass here and not directly the PlayerEvent class

For example, the PlayerTick event would be conceivable
but this Event is not located in the PlayerEvent class (TickEvent§PlayerTickEvent).

Idea:
In my opinion, the ticket event is not the best solution. I would use the LivingEquipmentChangeEvent for the speed effect,
then check whether the entity is a player and the item enchatend is in your enchantment, and then add an effect to the player that is infinite (you then have to remove it the same way)

and because of the damage, check out the Damage Events(LivingDamageEvent and LivingHurtEvent) read the java docs for more information about the events.

I'm really new in forge modding, so how can I check if the entity is a player?

 

if (player instanceof PlayerEntity){ }

 

like this?

[Luis_ST]

32 minutes ago, pervll said:

like this?

yes

[pervll]

And how can I check the enchantment?

I used EnchantmentHelper#getMaxEnchantmentLevel but failed

[Luis_ST]

1 hour ago, pervll said:

And how can I check the enchantment?

I used EnchantmentHelper#getMaxEnchantmentLevel but failed

show what you created

[pervll]

13 minutes ago, Luis_ST said:

show what you created

The event file:

@SubscribeEvent

public static void onWithVoidSpeedEnchantment(LivingEquipmentChangeEvent event, ItemStack itemStack, LivingDamageEvent event2)

{ LivingEntity player = event.getEntityLiving(); EquipmentSlotType slot = event.getSlot();

if (player instanceof PlayerEntity)

{

if (EnchantmentHelper.getMaxEnchantmentLevel(RegistryHandler.VOID_SPEED.get(), player) > 0)

{ player.addPotionEffect(new EffectInstance(Effects.SPEED, 1, 3)); } } }

And I don't now how to do damage to player.

 

The register file:

public static final DeferredRegister<Enchantment> ENCHANTMENTS = DeferredRegister.create(ForgeRegistries.ENCHANTMENTS, Technology.MOD_ID);

public static final RegistryObject<Enchantment> VOID_SPEED = ENCHANTMENTS.register("void_speed", VoidSpeedEnchantment::new);

 

The enchantment file:

public class VoidSpeedEnchantment extends Enchantment

{ public VoidSpeedEnchantment()

{ super(Rarity.VERY_RARE, EnchantmentType.ARMOR_FEET, new EquipmentSlotType[]{EquipmentSlotType.FEET}); }

@Override public int getMaxLevel() { return 4; }

@Override public int getMinEnchantability(int enchantmentLevel)

{ return enchantmentLevel * 20; }

@Override public int getMaxEnchantability(int enchantmentLevel)

{ return this.getMinEnchantability(enchantmentLevel) + 15; }

@Override public boolean isAllowedOnBooks() { return true; }

@Override public boolean canVillagerTrade() { return false; }

@Override public boolean isTreasureEnchantment() { return true; } }

[Luis_ST]

3 minutes ago, pervll said:

The event file:

@SubscribeEvent

public static void onWithVoidSpeedEnchantment(LivingEquipmentChangeEvent event, ItemStack itemStack, LivingDamageEvent event2)

{ LivingEntity player = event.getEntityLiving(); EquipmentSlotType slot = event.getSlot();

if (player instanceof PlayerEntity)

{

if (EnchantmentHelper.getMaxEnchantmentLevel(RegistryHandler.VOID_SPEED.get(), player) > 0)

{ player.addPotionEffect(new EffectInstance(Effects.SPEED, 1, 3)); } } }

And I don't now how to do damage to player.

1. okay first of all, used the code feature to post code in the forum
2. the part with the enchantment registration is not relevant for the function (event) of the enchantment
3. this will not work because the ItemStack required in the method does not exist when the event is registered, In addition, the event would only be called if the player take damge and something changed in the equipment

   public static void onWithVoidSpeedEnchantment(LivingEquipmentChangeEvent event, ItemStack itemStack, LivingDamageEvent event2)

4. you don't want to add any damge to the player here

11 minutes ago, pervll said:

And I don't now how to do damage to player.

 

[[NoOneButNo]]

1.) Subscribing to an event requires only one parameter. Two or more won't work.

2.) PlayerTickEvent or LivingUpdateEvent is your best option. You need to track the travelled blocks of the player and then do the random chance.

(On the side note: I don't like using speed status effect, I'd rather use an attribute modifier to achieve the same thing. This makes it stackable to other movement speed giving items/abilities/whatever)

3.) Check if you properly registered the events. Sometimes this is the usual problem after a long hour session of coding.

4.) Profit.

[pervll]

Ok. I got it.

Thanks and I'm almost done.😀