Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.16.x] How to register custom signs using Deferred Registries?


Quaint34
 Share

Recommended Posts

I am currently trying to make custom signs using deferred registries but its not working. The issue I am having is the sign classes do not support registry objects. Does anyone know how I can work around this?

Sign Item:    
public static final RegistryObject<Item> MAGICA_SIGN = itemHolder.register("magica_sign", () ->
            new SignItem(new Item.Properties().group(ItemGroup.DECORATIONS), blockInit.MAGICA_SIGN, blockInit.WALL_MAGICA_SIGN));
}

Sign Blocks:
      public static final RegistryObject<Block> MAGICA_SIGN = blockHolder.register("magica_sign", () ->
            new StandingSignBlock(AbstractBlock.Properties.create(Material.WOOD).doesNotBlockMovement().hardnessAndResistance(1.0F).sound(SoundType.WOOD), ModWoodType.MAGICA));

    public static final RegistryObject<Block> WALL_MAGICA_SIGN = blockHolder.register("magica_sign", () ->
            new WallSignBlock((AbstractBlock.Properties.create(Material.WOOD).doesNotBlockMovement().hardnessAndResistance(1.0F).sound(SoundType.WOOD).lootFrom(Blocks.OAK_SIGN)), ModWoodType.MAGICA));

 

Link to comment
Share on other sites

2 minutes ago, DietmarKracht said:

RegistryObject.get() is what you need here

Now I am getting an error about the .get method not being able to use static methods. Is this something I should care about? If so what can I do to fix it.

Link to comment
Share on other sites

1 hour ago, Quaint34 said:

Now I am getting an error about the .get method not being able to use static methods. Is this something I should care about? If so what can I do to fix it.

post the updated code

Link to comment
Share on other sites

8 hours ago, Quaint34 said:

Now I am getting an error about the .get method not being able to use static methods. Is this something I should care about? If so what can I do to fix it.

he meant RegistryObject#get, but if you don't know what that message means you shold take some time to learn java first.

your Sign BlockItem takes references to an Item, not to an RegistryObject, RegistryObjects work like Suppliers, you create them statically, you need to call .get() on the instance to get the object that it supplies. note that RegistryObjects only get populated after the registration events, therefore you can't call them before that (such as in statically initialization)

registering custom signs is not a simple task, I had to go through it a while ago, I can point you towards the topic I made on this thread on some of the errors I was getting: https://forums.minecraftforge.net/topic/96417-solved-116-custom-sign-wont-render/

 

Link to comment
Share on other sites

  • 1 month later...
On 4/25/2021 at 3:40 AM, kiou.23 said:

he meant RegistryObject#get, but if you don't know what that message means you shold take some time to learn java first.

your Sign BlockItem takes references to an Item, not to an RegistryObject, RegistryObjects work like Suppliers, you create them statically, you need to call .get() on the instance to get the object that it supplies. note that RegistryObjects only get populated after the registration events, therefore you can't call them before that (such as in statically initialization)

registering custom signs is not a simple task, I had to go through it a while ago, I can point you towards the topic I made on this thread on some of the errors I was getting: https://forums.minecraftforge.net/topic/96417-solved-116-custom-sign-wont-render/

 

I have my signs working but the textures do not show in game. I have them properly applied in the jsons but they are invisible and crash the game when placed. I have tried looking at your github but it is a broken link. Could you please guide me through on how to fix this?

Link to comment
Share on other sites

Posted (edited)
1 hour ago, Quaint34 said:

I have my signs working but the textures do not show in game. I have them properly applied in the jsons but they are invisible and crash the game when placed. I have tried looking at your github but it is a broken link. Could you please guide me through on how to fix this?

Updated Code

 

SignTileEntity Registration:

public class tileEntityTypeInit <T extends TileEntity> extends net.minecraftforge.registries.ForgeRegistryEntry<TileEntityType<?>>{

    public static final DeferredRegister<TileEntityType<?>> ENTITY_TYPE_DEFERRED_REGISTER = DeferredRegister.create(
            ForgeRegistries.TILE_ENTITIES, SwaysVanilla.modID
    );

    public static final TileEntityType<SignTileEntity> SIGN_TILE_ENTITY_TYPE = ENTITY_TYPE_DEFERRED_REGISTER.register(
            "sign", TileEntityType.Builder.create(SignTileEntity::new, blockInit.MAGICA_SIGN, blockInit.WALL_MAGICA_SIGN));
}

How do I apply the RegistryObjects in the field above? I have tried the .get() method but it doesn't work for some reason.

 

FakeBakery:

class FakeBakery extends ModelBakery {

    private FakeBakery (IResourceManager resourceManager, BlockColors blockColors, IProfiler profiler, int maxMiniMapLvl)
    {
        super(resourceManager, blockColors, profiler, maxMiniMapLvl);
    }

    static Set<RenderMaterial> Texturesget() {
        return ModelBakery.LOCATIONS_BUILTIN_TEXTURES;
    }
}

How do I apply the Fake Model Bakery to my signs?

 

Block Registration:

public static final RegistryObject<Block> MAGICA_SIGN = blockHolder.register("magica_sign", () ->
            new StandingSignBlock(AbstractBlock.Properties.create(Material.WOOD).doesNotBlockMovement().hardnessAndResistance(1.0F).sound(SoundType.WOOD), ModWoodType.MAGICA));

    public static final RegistryObject<Block> WALL_MAGICA_SIGN = blockHolder.register("magica_wall_sign", () ->
            new WallSignBlock((AbstractBlock.Properties.create(Material.WOOD).doesNotBlockMovement().hardnessAndResistance(1.0F).sound(SoundType.WOOD).lootFrom(Blocks.OAK_SIGN)), ModWoodType.MAGICA));

Item Registration:

    public static final RegistryObject<Item> MAGICA_SIGN_ITEM = itemHolder.register("magica_sign", () ->
            new SignItem(new Item.Properties().group(ItemGroup.DECORATIONS), blockInit.MAGICA_SIGN.get(), blockInit.WALL_MAGICA_SIGN.get()));

 

Edited by Quaint34
Link to comment
Share on other sites

1 hour ago, Quaint34 said:

public class tileEntityTypeInit <T extends TileEntity> extends net.minecraftforge.registries.ForgeRegistryEntry<TileEntityType<?>>{

    public static final DeferredRegister<TileEntityType<?>> ENTITY_TYPE_DEFERRED_REGISTER = DeferredRegister.create(
            ForgeRegistries.TILE_ENTITIES, SwaysVanilla.modID
    );

    public static final TileEntityType<SignTileEntity> SIGN_TILE_ENTITY_TYPE = ENTITY_TYPE_DEFERRED_REGISTER.register(
            "sign", TileEntityType.Builder.create(SignTileEntity::new, blockInit.MAGICA_SIGN, blockInit.WALL_MAGICA_SIGN));
}

How do I apply the RegistryObjects in the field above? I have tried the .get() method but it doesn't work for some reason.

you should call .get() on the registry objects. any time you're dealing with registry objects, and you need the actual thing "inside" the registry object, you use .get() (that's because a registry object is just a fancy supplier)

the problem is that when registering to a deferred register, you need to pass a supplier which returns the actual object. but in the code you're just passing the object (in your "sign" tile entity registration)

also, the DeferredRegister::register(string, supplier) returns a RegistryObject, not a TileEntityType

also, don't name your tile entity type deferred register a "entity type deferred register", entity types are another thing entirely (for entities, and not tile entities)

 

also also, please properly type your Registry Objects, if it's a SignItem, don't type it to RegistryObject<Item>, but use the more specific RegistryObject<SignItem>, same goes for your blocks

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Thanks for your reply! I have done it using data generation now. It works well for world generation, and I have realised that I don't care about saplings, so it works well. For anyone looking to do something similar, I include files to show what I did. They are just a bit hacky and incomplete now, but they can probably easily be generalised.   import static net.anju.larus.data.ResourceLocationUtil.prefix; import static net.anju.larus.data.ResourceLocationUtil.slash; @MethodsReturnNonnullByDefault @ParametersAreNonnullByDefault public abstract class LarusFeatureProvider<T> implements DataProvider { private static final Gson GSON = new GsonBuilder().setPrettyPrinting().disableHtmlEscaping().create(); protected final Set<FeatureEntry> featureEntries = new HashSet<>(); private final DataGenerator generator; protected LarusFeatureProvider(DataGenerator generator, Registry<T> registry) { this.generator = generator; for (Map.Entry<ResourceKey<T>, T> entry : registry.entrySet()) { ResourceKey<T> key = entry.getKey(); T feature = entry.getValue(); JsonElement jsonElement = getJson(feature); if (jsonElement != null) { FeatureEntry featureEntry = new FeatureEntry(prefix(key.location(), key.getRegistryName()), jsonElement); featureEntries.add(featureEntry); } } } private void addFeatures() { for (FeatureEntry featureEntry : featureEntries) { modifyFeatureEntry(featureEntry); } } protected abstract void modifyFeatureEntry(FeatureEntry featureEntry); @Override public void run(HashCache cache) { addFeatures(); writeFiles(cache, this.generator.getOutputFolder(), featureEntries); } // Actually write out the tables in the output folder private static void writeFiles(HashCache cache, Path outputFolder, Set<FeatureEntry> featureEntries) { for (FeatureEntry featureEntry : featureEntries) { if (featureEntry.isModified()) { ResourceLocation key = featureEntry.resourceLocation; JsonElement jsonElement = featureEntry.jsonElement; Path path = getPath(outputFolder, key); try { DataProvider.save(GSON, cache, jsonElement, path); } catch (IOException e) { LarusMod.LOGGER.error("Couldn't write data {}", key, e); } } } } @Override public String getName() { return "Larus features"; } @Nullable public JsonElement getJson(T feature) { if (feature instanceof ConfiguredFeature<?, ?> configuredFeature) { Optional<JsonElement> optional = ConfiguredFeature.DIRECT_CODEC.encodeStart(JsonOps.INSTANCE, configuredFeature).result(); return optional.orElse(null); } return null; } public static Path getPath(Path outputFolder, ResourceLocation key) { return outputFolder.resolve("data/" + slash(key) + ".json"); } protected static class FeatureEntry { boolean modified = false; private final ResourceLocation resourceLocation; private final JsonElement jsonElement; private FeatureEntry(ResourceLocation resourceLocation, JsonElement jsonElement) { this.resourceLocation = resourceLocation; this.jsonElement = jsonElement; } public JsonElement getJsonElement() { return jsonElement; } protected void markModified() { this.modified = true; } private boolean isModified() { return this.modified; } } } public class LarusLeavesFeatureProvider extends LarusFeatureProvider<ConfiguredFeature<?, ?>> { public LarusLeavesFeatureProvider(DataGenerator generator) { super(generator, BuiltinRegistries.CONFIGURED_FEATURE); } @Override protected void modifyFeatureEntry(FeatureEntry featureEntry) { JsonElement jsonElement = featureEntry.getJsonElement(); if (jsonElement.isJsonObject()) { JsonObject jsonObject = jsonElement.getAsJsonObject(); if (jsonObject.has("config")) { JsonObject config = jsonObject.get("config").getAsJsonObject(); if (config.has("foliage_provider")) { JsonObject mcFoliage = config.get("foliage_provider").getAsJsonObject(); JsonObject larusFoliage = larusFoliage(mcFoliage); if (larusFoliage != null) { config.add("foliage_provider", larusFoliage); featureEntry.markModified(); } } } } } @Nullable protected JsonObject larusFoliage(JsonObject mcFoliage) { JsonElement type = mcFoliage.get("type"); if (type.getAsString().equals("minecraft:simple_state_provider")) { JsonObject state = mcFoliage.get("state").getAsJsonObject(); // Change leaves String mcLeaves = state.get("Name").getAsString(); LarusLeavesBlock larusLeavesBlock = larusLeavesBlock(mcLeaves); if (larusLeavesBlock == null || larusLeavesBlock.getRegistryName() == null) return null; String larusLeaves = larusLeavesBlock.getRegistryName().toString(); state.add("Name", new JsonPrimitive(larusLeaves)); // Transform properties JsonObject mcProperties = state.get("Properties").getAsJsonObject(); transformProperties(mcProperties, larusLeavesBlock); } else { LarusMod.LOGGER.warn("Unexpected type for MC foliage " + mcFoliage); } return mcFoliage; } protected void transformProperties(JsonObject properties, LarusLeavesBlock larusLeavesBlock) { if (larusLeavesBlock instanceof LarusDeciduousLeavesBlock) properties.add("leafy", new JsonPrimitive("green")); } @Nullable protected LarusLeavesBlock larusLeavesBlock(String mcLeaves) { switch (mcLeaves) { case "minecraft:oak_leaves" -> { return LarusBlocks.OAK_LEAVES.get(); } case "minecraft:birch_leaves" -> { return LarusBlocks.BIRCH_LEAVES.get(); } case "minecraft:acacia_leaves" -> { return LarusBlocks.ACACIA_LEAVES.get(); } case "minecraft:jungle_leaves" -> { return LarusBlocks.JUNGLE_LEAVES.get(); } case "minecraft:dark_oak_leaves" -> { return LarusBlocks.DARK_OAK_LEAVES.get(); } case "minecraft:spruce_leaves" -> { return LarusBlocks.SPRUCE_LEAVES.get(); } } return null; } }  
    • the reason for that is the PlayerModel positions and rotations are set after the RenderPlayerEvent.Pre is fired change to Event to RenderPlayerEvent.Post
    • you can use BiomeLoadingEvent, loop through the Features you get from the Event and remove the Feature if it's the AmethystGeode Feature
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.