Jump to content

Event "setSecondsOnFire" won't connect to SwordItem


Skullblade

Recommended Posts

I've been stuck on this for three days now, and I can't find any answer online that makes sense. I'm creating a sword that, among other things, sets mobs and players on fire upon damage. I wrote the following code, and it doesn't seem to apply to the sword.

@SubscribeEvent

public static void setOnFire(final LivingDamageEvent event)

{

if (event.getSource().equals(ItemInit.EMBERCLEAVE))

{

event.getEntity().setSecondsOnFire(10);

}

}

"EMBERCLEAVE" is what the sword is registered as. I have tried removing the setSecondsOnFire code from the If statement and having it run regardless, and it works (it just means that any source of damage sets things on fire for 10 seconds, including its own fire ticks, leading to infinite seconds on fire).

When hovering above equals, my IDE says "'equals' between objects of inconvertible types 'DamageSource' and 'RegistryObject<SwordItem>'." I'm guessing that this is the issue, and the event can't figure out how to convert the values, but I don't know how to fix this issue.

 

Edited by Skullblade
Link to comment
Share on other sites

  • Skullblade changed the title to Event "setSecondsOnFire" won't connect to SwordItem

I don't think ItemInit.EMBERCLEAVE is a type of DamageSource.

You should be checking if the item of the attacker is holding is the sword (DamageSource#getTrueSource gives you the entity).

However this can be abused in multiple ways, such as swap to the sword as soon as the shot arrow hits the target, or even a thrown splash poison potion will be able to burn the target to death.

Try AttackEntityEvent instead.

Link to comment
Share on other sites

1 hour ago, Skullblade said:

I took a swing at both solutions, but it wasn't working for me.

show what you create

 

1 hour ago, Skullblade said:

Could you give me an example of how you would implement those suggestions?

and this is basic java, not really complicated
you have already used an event so change the event to AttackEntityEvent
and use this to get the DamagSource as an entity (you should then test whether the entity is a LivingEntity)

Entity entity = event.getSource().getTrueSource();

and then

10 hours ago, poopoodice said:

You should be checking if the item of the attacker is holding is the sword

 

Link to comment
Share on other sites

23 minutes ago, Skullblade said:

where to put or how to use DamageSource

23 minutes ago, Skullblade said:

ItemInit.EMBERCLEAVE is inconvertible

 

I WONDER IF THESE THINGS ARE RELATED

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

I know this might be stupid but for deferedRegisters, that error normally goes away when you put .get() at the end. Something like this:

if (event.getSource().equals(ItemInit.EMBERCLEAVE.get()))

I have only coded blocks and potions in 1.16 so I am a little rusty on items but this might work.

Link to comment
Share on other sites

Unfortunately no, you can't ever compare a DamageSource to an Item.

In fact instead of using an event, if it's your own item you can just override onLeftClickEntity (or named something similar, where is called on the item after AttackEntityEvent) and set the target on fire there.

Edited by poopoodice
Link to comment
Share on other sites

12 minutes ago, Skullblade said:

I would like help, not to get yelled at.

What MonkeyKnight just said will work just fine, because the items in ItemInit are stored as RegistryObjects you have to use .get() to get the actual item

Link to comment
Share on other sites

I tried MonkeyKnight's suggestion, but I think what PooPooDice said also applies. I can't compare Embercleave to DamageSource. So when I tried it, it didn't work. I'll keep that one in my pocket though, thanks

Could I get a more in depth explanation about onLeftClickEntity? Like, what class does it go in? Do I use @Override?

Lastly, thank you everyone for helping me this far. It means a lot, as I'm new at this, and I didn't want this to be another of my abandoned projects.

 

Link to comment
Share on other sites

38 minutes ago, Skullblade said:

I tried MonkeyKnight's suggestion, but I think what PooPooDice said also applies. I can't compare Embercleave to DamageSource. So when I tried it, it didn't work. I'll keep that one in my pocket though, thanks

Could I get a more in depth explanation about onLeftClickEntity? Like, what class does it go in? Do I use @Override?

Lastly, thank you everyone for helping me this far. It means a lot, as I'm new at this, and I didn't want this to be another of my abandoned projects.

 

If you are using SwordItem it has a method

public boolean hurtEnemy(ItemStack p_77644_1_, LivingEntity p_77644_2_, LivingEntity p_77644_3_) {

which you could override but make sure to add the lines of code that were previously there as well as your extra code

 p_77644_1_.hurtAndBreak(1, p_77644_3_, (p_220045_0_) -> {
         p_220045_0_.broadcastBreakEvent(EquipmentSlotType.MAINHAND);
 });

 

Link to comment
Share on other sites

In the Item class, (Item#hitEntity seems to be better than IForgeItem#onLeftClickEntity)

@Override is just an annotation that is not necessary, but highly recommended to make sure you are actually overriding the method.

DamageSource is a class that contains the information of the attack, such as the type of the attack (fire? explosion? where blast protection checks for this), the attacker, and even the direct attacker like arrows (IndirectDamageSource). Therefore the DamageSource will never match to a single item, where you can only obtain the information of the weapon from the attacker stored.

Link to comment
Share on other sites

8 hours ago, Skullblade said:

This is getting confusing. What do I put where?

If I need to show my classes I can.

In your item class override the hitEntity()(might be called something else depending on your version) method 

If you don't understand share your item class and i will show you 

Link to comment
Share on other sites

8 hours ago, eggpasta said:

In your item class override the hitEntity()(might be called something else depending on your version) method 

If you don't understand share your item class and i will show you 

Okay, so the tutorial I was watching wasn't super clear which one was my item class, so here's the four main ones I have been working with.

ItemInit.java:

package com.skullblade.planeswalkermod.core.init;

 

import com.skullblade.planeswalkermod.ModItemTier;

import com.skullblade.planeswalkermod.PlaneswalkerMod;

import net.minecraft.item.Item;

import net.minecraft.item.ItemGroup;

import net.minecraft.item.SwordItem;

import net.minecraftforge.fml.RegistryObject;

import net.minecraftforge.registries.DeferredRegister;

import net.minecraftforge.registries.ForgeRegistries;

public class ItemInit

{

public static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS, PlaneswalkerMod.MOD_ID);

public static final RegistryObject<SwordItem> EMBERCLEAVE = ITEMS.register("embercleave", () -> new SwordItem(ModItemTier.EMBERCLEAVE, 5, -2.8f, (new Item.Properties()).tab(ItemGroup.TAB_COMBAT)));

}

 

PlaneswalkerMod.java:

package com.skullblade.planeswalkermod;

 

import com.skullblade.planeswalkermod.core.init.ItemInit;

import net.minecraft.item.Item;

import net.minecraftforge.common.MinecraftForge;

import net.minecraftforge.eventbus.api.IEventBus;

import net.minecraftforge.fml.common.Mod;

import net.minecraftforge.fml.event.lifecycle.FMLCommonSetupEvent;

import net.minecraftforge.fml.javafmlmod.FMLJavaModLoadingContext;

import net.minecraftforge.registries.DeferredRegister;

import net.minecraftforge.registries.ForgeRegistries;

import org.apache.logging.log4j.LogManager;

import org.apache.logging.log4j.Logger;

@Mod("planeswalker")

public class PlaneswalkerMod

{

public static final Logger LOGGER = LogManager.getLogger();

public static final String MOD_ID = "planeswalker";

public PlaneswalkerMod()

{

IEventBus bus = FMLJavaModLoadingContext.get().getModEventBus();

bus.addListener(this::setup);

ItemInit.ITEMS.register(bus);

MinecraftForge.EVENT_BUS.register(this);

}

public static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS, PlaneswalkerMod.MOD_ID);

private void setup(final FMLCommonSetupEvent event)

{

}

}

 

EventHandler.java:

package com.skullblade.planeswalkermod.core.event;

 

import com.skullblade.planeswalkermod.PlaneswalkerMod;

import com.skullblade.planeswalkermod.core.init.ItemInit;

import net.minecraftforge.event.entity.player.AttackEntityEvent;

import net.minecraftforge.eventbus.api.SubscribeEvent;

import net.minecraftforge.fml.common.Mod;

import net.minecraftforge.fml.common.Mod.EventBusSubscriber.Bus;

@Mod.EventBusSubscriber(modid = PlaneswalkerMod.MOD_ID, bus = Bus.FORGE)

public class EventHandler

{

@SubscribeEvent public static void setOnFire(final AttackEntityEvent event)

{

if (event.getEntity().equals(ItemInit.EMBERCLEAVE.get()))

{

event.getEntity().setSecondsOnFire(10);

}

}

}

 

ModItemTier.java:

package com.skullblade.planeswalkermod;

 

import mcp.MethodsReturnNonnullByDefault;

import net.minecraft.item.IItemTier;

import net.minecraft.item.Items;

import net.minecraft.item.crafting.Ingredient;

import java.util.function.Supplier;

@MethodsReturnNonnullByDefault

public enum ModItemTier implements IItemTier

{

EMBERCLEAVE(1, 1000, 4.0f, 3.0f, 5, () -> Ingredient.of(Items.IRON_INGOT));

private final Supplier<Ingredient> repairmaterial;

private final int enchantability;

private final float attackDamage;

private final float efficiency;

private final int maxUses;

private final int harvestLevel;

ModItemTier(int harvestLevel, int maxUses, float efficiency, float attackDamage, int enchantability, Supplier<Ingredient> repairmaterial)

{

this.harvestLevel = harvestLevel;

this.maxUses = maxUses;

this.efficiency = efficiency;

this.attackDamage = attackDamage;

this.enchantability = enchantability;

this.repairmaterial = repairmaterial;

}

@Override public int getUses() { return 1000; }

@Override public float getSpeed() { return 1.2f; }

@Override public float getAttackDamageBonus() { return 14; }

@Override public int getLevel() { return 1; }

@Override public int getEnchantmentValue() { return 5; }

@Override public Ingredient getRepairIngredient() { return Ingredient.of(Items.IRON_INGOT); } }

 

Edited by Skullblade
Link to comment
Share on other sites

21 minutes ago, Skullblade said:

Okay, so the tutorial I was watching wasn't super clear which one was my item class, so here's the four main ones I have been working with.

ItemInit.java:

package com.skullblade.planeswalkermod.core.init;

 

import com.skullblade.planeswalkermod.ModItemTier;

import com.skullblade.planeswalkermod.PlaneswalkerMod;

import net.minecraft.item.Item;

import net.minecraft.item.ItemGroup;

import net.minecraft.item.SwordItem;

import net.minecraftforge.fml.RegistryObject;

import net.minecraftforge.registries.DeferredRegister;

import net.minecraftforge.registries.ForgeRegistries;

public class ItemInit

{

public static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS, PlaneswalkerMod.MOD_ID);

public static final RegistryObject<SwordItem> EMBERCLEAVE = ITEMS.register("embercleave", () -> new SwordItem(ModItemTier.EMBERCLEAVE, 5, -2.8f, (new Item.Properties()).tab(ItemGroup.TAB_COMBAT)));

}

 

PlaneswalkerMod.java:

package com.skullblade.planeswalkermod;

 

import com.skullblade.planeswalkermod.core.init.ItemInit;

import net.minecraft.item.Item;

import net.minecraftforge.common.MinecraftForge;

import net.minecraftforge.eventbus.api.IEventBus;

import net.minecraftforge.fml.common.Mod;

import net.minecraftforge.fml.event.lifecycle.FMLCommonSetupEvent;

import net.minecraftforge.fml.javafmlmod.FMLJavaModLoadingContext;

import net.minecraftforge.registries.DeferredRegister;

import net.minecraftforge.registries.ForgeRegistries;

import org.apache.logging.log4j.LogManager;

import org.apache.logging.log4j.Logger;

@Mod("planeswalker")

public class PlaneswalkerMod

{

public static final Logger LOGGER = LogManager.getLogger();

public static final String MOD_ID = "planeswalker";

public PlaneswalkerMod()

{

IEventBus bus = FMLJavaModLoadingContext.get().getModEventBus();

bus.addListener(this::setup);

ItemInit.ITEMS.register(bus);

MinecraftForge.EVENT_BUS.register(this);

}

public static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS, PlaneswalkerMod.MOD_ID);

private void setup(final FMLCommonSetupEvent event)

{

}

}

 

EventHandler.java:

package com.skullblade.planeswalkermod.core.event;

 

import com.skullblade.planeswalkermod.PlaneswalkerMod;

import com.skullblade.planeswalkermod.core.init.ItemInit;

import net.minecraftforge.event.entity.player.AttackEntityEvent;

import net.minecraftforge.eventbus.api.SubscribeEvent;

import net.minecraftforge.fml.common.Mod;

import net.minecraftforge.fml.common.Mod.EventBusSubscriber.Bus;

@Mod.EventBusSubscriber(modid = PlaneswalkerMod.MOD_ID, bus = Bus.FORGE)

public class EventHandler

{

@SubscribeEvent public static void setOnFire(final AttackEntityEvent event)

{

if (event.getEntity().equals(ItemInit.EMBERCLEAVE.get()))

{

event.getEntity().setSecondsOnFire(10);

}

}

}

 

ModItemTier.java:

package com.skullblade.planeswalkermod;

 

import mcp.MethodsReturnNonnullByDefault;

import net.minecraft.item.IItemTier;

import net.minecraft.item.Items;

import net.minecraft.item.crafting.Ingredient;

import java.util.function.Supplier;

@MethodsReturnNonnullByDefault

public enum ModItemTier implements IItemTier

{

EMBERCLEAVE(1, 1000, 4.0f, 3.0f, 5, () -> Ingredient.of(Items.IRON_INGOT));

private final Supplier<Ingredient> repairmaterial;

private final int enchantability;

private final float attackDamage;

private final float efficiency;

private final int maxUses;

private final int harvestLevel;

ModItemTier(int harvestLevel, int maxUses, float efficiency, float attackDamage, int enchantability, Supplier<Ingredient> repairmaterial)

{

this.harvestLevel = harvestLevel;

this.maxUses = maxUses;

this.efficiency = efficiency;

this.attackDamage = attackDamage;

this.enchantability = enchantability;

this.repairmaterial = repairmaterial;

}

@Override public int getUses() { return 1000; }

@Override public float getSpeed() { return 1.2f; }

@Override public float getAttackDamageBonus() { return 14; }

@Override public int getLevel() { return 1; }

@Override public int getEnchantmentValue() { return 5; }

@Override public Ingredient getRepairIngredient() { return Ingredient.of(Items.IRON_INGOT); } }

 

Oh ok you don't have an item class so you will need to make one,

So create a new class called FlamingSword

inside it put 

public class FlamingSword extends SwordItem{

	public FlamingSword() {
		super(ModItemTier.EMBERCLEAVE, 5, -2.8f, new Item.Properties().tab(ItemGroup.TAB_COMBAT));
		// TODO Auto-generated constructor stub
	}
	@Override
	  public boolean hurtEnemy(ItemStack p_77644_1_, LivingEntity p_77644_2_, LivingEntity p_77644_3_) {
	      p_77644_1_.hurtAndBreak(1, p_77644_3_, (p_220045_0_) -> {
	         p_220045_0_.broadcastBreakEvent(EquipmentSlotType.MAINHAND);
	         //Put your fire method here on p_77644_3
	      });
	      return true;
	   }

}

and then in ItemInit replace

 new SwordItem(ModItemTier.EMBERCLEAVE, 5, -2.8f, (new Item.Properties()).tab(ItemGroup.TAB_COMBAT)));

with

 FlamingSword::new);

and then it should work

Edited by eggpasta
fix code
Link to comment
Share on other sites

Ok, so I did that, but FlamingSword.java is throwing 10 different errors.

Here's the code now. ItemInit and FlamingSword are having a related issue, super(ModItemTier.EMBERCLEAVE is saying "Object()' in 'java.lang.Object' cannot be applied to '(com.skullblade.planeswalkermod.ModItemTier, int, float, net.minecraft.item.Item.Properties)", the code doesn't like p_220045_0_, and I'm not sure I implemented the setFire code right.

ItemInit.java (just the errored code):

private static SwordItem FlamingSword;

public static final RegistryObject<SwordItem> EMBERCLEAVE = ITEMS.register("embercleave", () -> FlamingSword: :new);

 

FlamingSword.java (again, just the errored code):

public class FlamingSword

{

public FlamingSword()

{

super(ModItemTier.EMBERCLEAVE, 5, -2.8f, new Item.Properties().tab(ItemGroup.TAB_COMBAT));

// TODO Auto-generated constructor stub

}

@Override public boolean hurtEnemy(ItemStack p_77644_1_, LivingEntity p_77644_2_, LivingEntity p_77644_3_)

{

p_77644_1_.hurtAndBreak(1, p_77644_3_, (p_220045_0_)) -> {

p_220045_0_.broadcastBreakEvent(EquipmentSlotType.MAINHAND);

p_77644_3_.if (event.getEntity().equals(ItemInit.EMBERCLEAVE.get()))

{

event.getEntity().setSecondsOnFire(10); } return true;

}

}

}

Link to comment
Share on other sites

9 minutes ago, Skullblade said:

Ok, so I did that, but FlamingSword.java is throwing 10 different errors.

Here's the code now. ItemInit and FlamingSword are having a related issue, super(ModItemTier.EMBERCLEAVE is saying "Object()' in 'java.lang.Object' cannot be applied to '(com.skullblade.planeswalkermod.ModItemTier, int, float, net.minecraft.item.Item.Properties)", the code doesn't like p_220045_0_, and I'm not sure I implemented the setFire code right.

ItemInit.java (just the errored code):

private static SwordItem FlamingSword;

public static final RegistryObject<SwordItem> EMBERCLEAVE = ITEMS.register("embercleave", () -> FlamingSword: :new);

 

FlamingSword.java (again, just the errored code):

public class FlamingSword

{

public FlamingSword()

{

super(ModItemTier.EMBERCLEAVE, 5, -2.8f, new Item.Properties().tab(ItemGroup.TAB_COMBAT));

// TODO Auto-generated constructor stub

}

@Override public boolean hurtEnemy(ItemStack p_77644_1_, LivingEntity p_77644_2_, LivingEntity p_77644_3_)

{

p_77644_1_.hurtAndBreak(1, p_77644_3_, (p_220045_0_)) -> {

p_220045_0_.broadcastBreakEvent(EquipmentSlotType.MAINHAND);

p_77644_3_.if (event.getEntity().equals(ItemInit.EMBERCLEAVE.get()))

{

event.getEntity().setSecondsOnFire(10); } return true;

}

}

}

p_77644_3_.if (event.getEntity().equals(ItemInit.EMBERCLEAVE.get()))

Remove this just make it

p_77644_3_.setSecondsOnFire(10);

 

so that the method look like this:

	@Override
	  public boolean hurtEnemy(ItemStack p_77644_1_, LivingEntity p_77644_2_, LivingEntity p_77644_3_) {
	      p_77644_1_.hurtAndBreak(1, p_77644_3_, (p_220045_0_) -> {
	         p_220045_0_.broadcastBreakEvent(EquipmentSlotType.MAINHAND);
	         p_77644_3_.setSecondsOnFire(10)
	      });
	      return true;
	   }

As the checking has already been done

What other errors are you getting?

Link to comment
Share on other sites

17 minutes ago, Skullblade said:

p_77644_3_.if(

This isn't valid Java.

Also name your locals with nice names so you know what they are. You don't have to use the obfuscated decompiled names.

20 minutes ago, Skullblade said:

super(ModItemTier.EMBERCLEAVE is saying "Object()' in 'java.lang.Object' cannot be applied to '(com.skullblade.planeswalkermod.ModItemTier, int, float, net.minecraft.item.Item.Properties)",

Yes, because:

20 minutes ago, Skullblade said:

public class FlamingSword {

Your FlamingSword is not a subclass of anything.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

23 minutes ago, Skullblade said:

Ok, so I did that, but FlamingSword.java is throwing 10 different errors.

Here's the code now. ItemInit and FlamingSword are having a related issue, super(ModItemTier.EMBERCLEAVE is saying "Object()' in 'java.lang.Object' cannot be applied to '(com.skullblade.planeswalkermod.ModItemTier, int, float, net.minecraft.item.Item.Properties)", the code doesn't like p_220045_0_, and I'm not sure I implemented the setFire code right.

ItemInit.java (just the errored code):

private static SwordItem FlamingSword;

public static final RegistryObject<SwordItem> EMBERCLEAVE = ITEMS.register("embercleave", () -> FlamingSword: :new);

 

FlamingSword.java (again, just the errored code):

public class FlamingSword

{

public FlamingSword()

{

super(ModItemTier.EMBERCLEAVE, 5, -2.8f, new Item.Properties().tab(ItemGroup.TAB_COMBAT));

// TODO Auto-generated constructor stub

}

@Override public boolean hurtEnemy(ItemStack p_77644_1_, LivingEntity p_77644_2_, LivingEntity p_77644_3_)

{

p_77644_1_.hurtAndBreak(1, p_77644_3_, (p_220045_0_)) -> {

p_220045_0_.broadcastBreakEvent(EquipmentSlotType.MAINHAND);

p_77644_3_.if (event.getEntity().equals(ItemInit.EMBERCLEAVE.get()))

{

event.getEntity().setSecondsOnFire(10); } return true;

}

}

}

As @Draco18s was saying, your FlamingSword class needs to extend SwordItem

Link to comment
Share on other sites

Ok, that got rid of some errors. super is fine now, along with some clearer labels. public class FlamingSword now extends SwordItem (I forgot to do that part, sorry eggpasta). I'm still having an issue with p_220045_0_. It says it can't resolve it. Also, I'm not exactly sure where to put my code, and what changes to make. (I'm more of a visual learner, so an example like the last one would be sweet.) Lastly, ItemInit is saying the following about "() -> FlamingSword::new);"

Required type:
RegistryObject
<SwordItem>
Provided:
RegistryObject
<I>
I is not a functional interface

Link to comment
Share on other sites

1 minute ago, Skullblade said:

Ok, that got rid of some errors. super is fine now, along with some clearer labels. public class FlamingSword now extends SwordItem (I forgot to do that part, sorry eggpasta). I'm still having an issue with p_220045_0_. It says it can't resolve it. Also, I'm not exactly sure where to put my code, and what changes to make. (I'm more of a visual learner, so an example like the last one would be sweet.) Lastly, ItemInit is saying the following about "() -> FlamingSword::new);"

Required type:
RegistryObject
<SwordItem>
Provided:
RegistryObject
<I>
I is not a functional interface

For the iteminit error get rid of

() ->

so it's just

FlamingSword::new

and for p_220045_0_ it's whatever you put here 

p_77644_1_.hurtAndBreak(1, p_77644_3_, (p_220045_0_) -> {

so check you dont have any typos

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hello, I'm trying to modify the effects of native enchantments for bows and arrows in Minecraft. After using a decompilation tool, I found that the specific implementations of native bow and arrow enchantments (including `ArrowDamageEnchantment`, `ArrowKnockbackEnchantment`, `ArrowFireEnchantment`, `ArrowInfiniteEnchantment`, `ArrowPiercingEnchantment`) do not contain any information about the enchantment effects (such as the `getDamageProtection` function for `ProtectionEnchantment`, `getDamageBonus` function for `DamageEnchantment`, etc.). Upon searching for the base class of arrows, `AbstractArrow`, I found a function named setEnchantmentEffectsFromEntity`, which seems to be used to retrieve the enchantment levels of the tool held by a `LivingEntity` and calculate the specific values of the enchantment effects. However, after testing with the following code, I found that this function is not being called:   @Mixin(AbstractArrow.class) public class ModifyArrowEnchantmentEffects {     private static final Logger LOGGER = LogUtils.getLogger();     @Inject(         method = "setEnchantmentEffectsFromEntity",         at = @At("HEAD")     )     private void logArrowEnchantmentEffectsFromEntity(CallbackInfo ci) {         LOGGER.info("Arrow enchantment effects from entity");     } }   Upon further investigation, I found that within the onHitEntity method, there are several lines of code:               if (!this.level().isClientSide &amp;&amp; entity1 instanceof LivingEntity) {                EnchantmentHelper.doPostHurtEffects(livingentity, entity1);                EnchantmentHelper.doPostDamageEffects((LivingEntity)entity1, livingentity);             }   These lines of code actually call the doPostHurt and doPostAttack methods of each enchantment in the enchantment list. However, this leads back to the issue because native bow and arrow enchantments do not implement these functions. Although their base class defines the functions, they are empty. At this point, I'm completely stumped and seeking assistance. Thank you.
    • I have been trying to make a server with forge but I keep running into an issue. I have jdk 22 installed as well as Java 8. here is the debug file  
    • it crashed again     What the console says : [00:02:03] [Server thread/INFO] [Easy NPC/]: [EntityManager] Server started! [00:02:03] [Server thread/INFO] [co.gi.al.ic.IceAndFire/]: {iceandfire:fire_dragon_roost=true, iceandfire:fire_lily=true, iceandfire:spawn_dragon_skeleton_fire=true, iceandfire:lightning_dragon_roost=true, iceandfire:spawn_dragon_skeleton_lightning=true, iceandfire:ice_dragon_roost=true, iceandfire:ice_dragon_cave=true, iceandfire:lightning_dragon_cave=true, iceandfire:cyclops_cave=true, iceandfire:spawn_wandering_cyclops=true, iceandfire:spawn_sea_serpent=true, iceandfire:frost_lily=true, iceandfire:hydra_cave=true, iceandfire:lightning_lily=true, iceandfireixie_village=true, iceandfire:myrmex_hive_jungle=true, iceandfire:myrmex_hive_desert=true, iceandfire:silver_ore=true, iceandfire:siren_island=true, iceandfire:spawn_dragon_skeleton_ice=true, iceandfire:spawn_stymphalian_bird=true, iceandfire:fire_dragon_cave=true, iceandfire:sapphire_ore=true, iceandfire:spawn_hippocampus=true, iceandfire:spawn_death_worm=true} [00:02:03] [Server thread/INFO] [co.gi.al.ic.IceAndFire/]: {TROLL_S=true, HIPPOGRYPH=true, AMPHITHERE=true, COCKATRICE=true, TROLL_M=true, DREAD_LICH=true, TROLL_F=true} [00:02:03] [Server thread/INFO] [ne.be.lo.WeaponRegistry/]: Encoded Weapon Attribute registry size (with package overhead): 41976 bytes (in 5 string chunks with the size of 10000) [00:02:03] [Server thread/INFO] [patchouli/]: Sending reload packet to clients [00:02:03] [Server thread/WARN] [voicechat/]: [voicechat] Running in offline mode - Voice chat encryption is not secure! [00:02:03] [VoiceChatServerThread/INFO] [voicechat/]: [voicechat] Using server-ip as bind address: 0.0.0.0 [00:02:03] [Server thread/WARN] [ModernFix/]: Dedicated server took 22.521 seconds to load [00:02:03] [VoiceChatServerThread/INFO] [voicechat/]: [voicechat] Voice chat server started at 0.0.0.0:25565 [00:02:03] [Server thread/WARN] [minecraft/SynchedEntityData]: defineId called for: class net.minecraft.world.entity.player.Player from class tschipp.carryon.common.carry.CarryOnDataManager [00:02:03] [Server thread/INFO] [ne.mi.co.AdvancementLoadFix/]: Using new advancement loading for net.minecraft.server.PlayerAdvancements@2941ffd5 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 0 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 1 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 2 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 3 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 4 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 5 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 6 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 7 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 8 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 9 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 10 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 11 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 12 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 13 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 14 [00:02:19] [Server thread/INFO] [ne.mi.co.AdvancementLoadFix/]: Using new advancement loading for net.minecraft.server.PlayerAdvancements@ebc7ef2 [00:02:19] [Server thread/INFO] [minecraft/PlayerList]: ZacAdos[/90.2.17.162:49242] logged in with entity id 1062 at (-1848.6727005281205, 221.0, -3054.2468255848935) [00:02:19] [Server thread/ERROR] [ModernFix/]: Skipping entity ID sync for com.talhanation.smallships.world.entity.ship.Ship: java.lang.NoClassDefFoundError: net/minecraft/client/CameraType [00:02:19] [Server thread/INFO] [minecraft/MinecraftServer]: - Gloop - ZacAdos joined the game [00:02:19] [Server thread/INFO] [xa.pa.OpenPartiesAndClaims/]: Updating all forceload tickets for cc56befd-d376-3526-a760-340713c478bd [00:02:19] [Server thread/INFO] [se.mi.te.da.DataManager/]: Sending data to client: ZacAdos [00:02:19] [Server thread/INFO] [voicechat/]: [voicechat] Received secret request of - Gloop - ZacAdos (17) [00:02:19] [Server thread/INFO] [voicechat/]: [voicechat] Sent secret to - Gloop - ZacAdos [00:02:21] [VoiceChatPacketProcessingThread/INFO] [voicechat/]: [voicechat] Successfully authenticated player cc56befd-d376-3526-a760-340713c478bd [00:02:22] [VoiceChatPacketProcessingThread/INFO] [voicechat/]: [voicechat] Successfully validated connection of player cc56befd-d376-3526-a760-340713c478bd [00:02:22] [VoiceChatPacketProcessingThread/INFO] [voicechat/]: [voicechat] Player - Gloop - ZacAdos (cc56befd-d376-3526-a760-340713c478bd) successfully connected to voice chat stop [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: Stopping the server [00:02:34] [Server thread/INFO] [mo.pl.ar.ArmourersWorkshop/]: stop local service [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: Stopping server [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: Saving players [00:02:34] [Server thread/INFO] [minecraft/ServerGamePacketListenerImpl]: ZacAdos lost connection: Server closed [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: - Gloop - ZacAdos left the game [00:02:34] [Server thread/INFO] [xa.pa.OpenPartiesAndClaims/]: Updating all forceload tickets for cc56befd-d376-3526-a760-340713c478bd [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: Saving worlds [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: Saving chunks for level 'ServerLevel[world]'/minecraft:overworld [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: Saving chunks for level 'ServerLevel[world]'/minecraft:the_end [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: Saving chunks for level 'ServerLevel[world]'/minecraft:the_nether [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: ThreadedAnvilChunkStorage (world): All chunks are saved [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: ThreadedAnvilChunkStorage (DIM1): All chunks are saved [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: ThreadedAnvilChunkStorage (DIM-1): All chunks are saved [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: ThreadedAnvilChunkStorage: All dimensions are saved [00:02:34] [Server thread/INFO] [xa.pa.OpenPartiesAndClaims/]: Stopping IO worker... [00:02:34] [Server thread/INFO] [xa.pa.OpenPartiesAndClaims/]: Stopped IO worker! [00:02:34] [Server thread/INFO] [Calio/]: Removing Dynamic Registries for: net.minecraft.server.dedicated.DedicatedServer@7dc879e1 [MineStrator Daemon]: Checking server disk space usage, this could take a few seconds... [MineStrator Daemon]: Updating process configuration files... [MineStrator Daemon]: Ensuring file permissions are set correctly, this could take a few seconds... [MineStrator Daemon]: Pulling Docker container image, this could take a few minutes to complete... [MineStrator Daemon]: Finished pulling Docker container image container@pterodactyl~ java -version openjdk version "17.0.10" 2024-01-16 OpenJDK Runtime Environment Temurin-17.0.10+7 (build 17.0.10+7) OpenJDK 64-Bit Server VM Temurin-17.0.10+7 (build 17.0.10+7, mixed mode, sharing) container@pterodactyl~ java -Xms128M -Xmx6302M -Dterminal.jline=false -Dterminal.ansi=true -Djline.terminal=jline.UnsupportedTerminal -p libraries/cpw/mods/bootstraplauncher/1.1.2/bootstraplauncher-1.1.2.jar:libraries/cpw/mods/securejarhandler/2.1.4/securejarhandler-2.1.4.jar:libraries/org/ow2/asm/asm-commons/9.5/asm-commons-9.5.jar:libraries/org/ow2/asm/asm-util/9.5/asm-util-9.5.jar:libraries/org/ow2/asm/asm-analysis/9.5/asm-analysis-9.5.jar:libraries/org/ow2/asm/asm-tree/9.5/asm-tree-9.5.jar:libraries/org/ow2/asm/asm/9.5/asm-9.5.jar:libraries/net/minecraftforge/JarJarFileSystems/0.3.16/JarJarFileSystems-0.3.16.jar --add-modules ALL-MODULE-PATH --add-opens java.base/java.util.jar=cpw.mods.securejarhandler --add-opens java.base/java.lang.invoke=cpw.mods.securejarhandler --add-exports java.base/sun.security.util=cpw.mods.securejarhandler --add-exports jdk.naming.dns/com.sun.jndi.dns=java.naming -Djava.net.preferIPv6Addresses=system -DignoreList=bootstraplauncher-1.1.2.jar,securejarhandler-2.1.4.jar,asm-commons-9.5.jar,asm-util-9.5.jar,asm-analysis-9.5.jar,asm-tree-9.5.jar,asm-9.5.jar,JarJarFileSystems-0.3.16.jar -DlibraryDirectory=libraries -DlegacyClassPath=libraries/cpw/mods/securejarhandler/2.1.4/securejarhandler-2.1.4.jar:libraries/org/ow2/asm/asm/9.5/asm-9.5.jar:libraries/org/ow2/asm/asm-commons/9.5/asm-commons-9.5.jar:libraries/org/ow2/asm/asm-tree/9.5/asm-tree-9.5.jar:libraries/org/ow2/asm/asm-util/9.5/asm-util-9.5.jar:libraries/org/ow2/asm/asm-analysis/9.5/asm-analysis-9.5.jar:libraries/net/minecraftforge/accesstransformers/8.0.4/accesstransformers-8.0.4.jar:libraries/org/antlr/antlr4-runtime/4.9.1/antlr4-runtime-4.9.1.jar:libraries/net/minecraftforge/eventbus/6.0.3/eventbus-6.0.3.jar:libraries/net/minecraftforge/forgespi/6.0.0/forgespi-6.0.0.jar:libraries/net/minecraftforge/coremods/5.0.1/coremods-5.0.1.jar:libraries/cpw/mods/modlauncher/10.0.8/modlauncher-10.0.8.jar:libraries/net/minecraftforge/unsafe/0.2.0/unsafe-0.2.0.jar:libraries/com/electronwill/night-config/core/3.6.4/core-3.6.4.jar:libraries/com/electronwill/night-config/toml/3.6.4/toml-3.6.4.jar:libraries/org/apache/maven/maven-artifact/3.8.5/maven-artifact-3.8.5.jar:libraries/net/jodah/typetools/0.8.3/typetools-0.8.3.jar:libraries/net/minecrell/terminalconsoleappender/1.2.0/terminalconsoleappender-1.2.0.jar:libraries/org/jline/jline-reader/3.12.1/jline-reader-3.12.1.jar:libraries/org/jline/jline-terminal/3.12.1/jline-terminal-3.12.1.jar:libraries/org/spongepowered/mixin/0.8.5/mixin-0.8.5.jar:libraries/org/openjdk/nashorn/nashorn-core/15.3/nashorn-core-15.3.jar:libraries/net/minecraftforge/JarJarSelector/0.3.16/JarJarSelector-0.3.16.jar:libraries/net/minecraftforge/JarJarMetadata/0.3.16/JarJarMetadata-0.3.16.jar:libraries/net/minecraftforge/fmlloader/1.19.2-43.3.0/fmlloader-1.19.2-43.3.0.jar:libraries/net/minecraft/server/1.19.2-20220805.130853/server-1.19.2-20220805.130853-extra.jar:libraries/com/github/oshi/oshi-core/5.8.5/oshi-core-5.8.5.jar:libraries/com/google/code/gson/gson/2.8.9/gson-2.8.9.jar:libraries/com/google/guava/failureaccess/1.0.1/failureaccess-1.0.1.jar:libraries/com/google/guava/guava/31.0.1-jre/guava-31.0.1-jre.jar:libraries/com/mojang/authlib/3.11.49/authlib-3.11.49.jar:libraries/com/mojang/brigadier/1.0.18/brigadier-1.0.18.jar:libraries/com/mojang/datafixerupper/5.0.28/datafixerupper-5.0.28.jar:libraries/com/mojang/javabridge/1.2.24/javabridge-1.2.24.jar:libraries/com/mojang/logging/1.0.0/logging-1.0.0.jar:libraries/commons-io/commons-io/2.11.0/commons-io-2.11.0.jar:libraries/io/netty/netty-buffer/4.1.77.Final/netty-buffer-4.1.77.Final.jar:libraries/io/netty/netty-codec/4.1.77.Final/netty-codec-4.1.77.Final.jar:libraries/io/netty/netty-common/4.1.77.Final/netty-common-4.1.77.Final.jar:libraries/io/netty/netty-handler/4.1.77.Final/netty-handler-4.1.77.Final.jar:libraries/io/netty/netty-resolver/4.1.77.Final/netty-resolver-4.1.77.Final.jar:libraries/io/netty/netty-transport/4.1.77.Final/netty-transport-4.1.77.Final.jar:libraries/io/netty/netty-transport-classes-epoll/4.1.77.Final/netty-transport-classes-epoll-4.1.77.Final.jar:libraries/io/netty/netty-transport-native-epoll/4.1.77.Final/netty-transport-native-epoll-4.1.77.Final-linux-x86_64.jar:libraries/io/netty/netty-transport-native-epoll/4.1.77.Final/netty-transport-native-epoll-4.1.77.Final-linux-aarch_64.jar:libraries/io/netty/netty-transport-native-unix-common/4.1.77.Final/netty-transport-native-unix-common-4.1.77.Final.jar:libraries/it/unimi/dsi/fastutil/8.5.6/fastutil-8.5.6.jar:libraries/net/java/dev/jna/jna/5.10.0/jna-5.10.0.jar:libraries/net/java/dev/jna/jna-platform/5.10.0/jna-platform-5.10.0.jar:libraries/net/sf/jopt-simple/jopt-simple/5.0.4/jopt-simple-5.0.4.jar:libraries/org/apache/commons/commons-lang3/3.12.0/commons-lang3-3.12.0.jar:libraries/org/apache/logging/log4j/log4j-api/2.17.0/log4j-api-2.17.0.jar:libraries/org/apache/logging/log4j/log4j-core/2.17.0/log4j-core-2.17.0.jar:libraries/org/apache/logging/log4j/log4j-slf4j18-impl/2.17.0/log4j-slf4j18-impl-2.17.0.jar:libraries/org/slf4j/slf4j-api/1.8.0-beta4/slf4j-api-1.8.0-beta4.jar cpw.mods.bootstraplauncher.BootstrapLauncher --launchTarget forgeserver --fml.forgeVersion 43.3.0 --fml.mcVersion 1.19.2 --fml.forgeGroup net.minecraftforge --fml.mcpVersion 20220805.130853 [00:02:42] [main/INFO] [cp.mo.mo.Launcher/MODLAUNCHER]: ModLauncher running: args [--launchTarget, forgeserver, --fml.forgeVersion, 43.3.0, --fml.mcVersion, 1.19.2, --fml.forgeGroup, net.minecraftforge, --fml.mcpVersion, 20220805.130853] [00:02:42] [main/INFO] [cp.mo.mo.Launcher/MODLAUNCHER]: ModLauncher 10.0.8+10.0.8+main.0ef7e830 starting: java version 17.0.10 by Eclipse Adoptium; OS Linux arch amd64 version 6.1.0-12-amd64 [00:02:43] [main/INFO] [mixin/]: SpongePowered MIXIN Subsystem Version=0.8.5 Source=union:/home/container/libraries/org/spongepowered/mixin/0.8.5/mixin-0.8.5.jar%2363!/ Service=ModLauncher Env=SERVER [00:02:43] [main/WARN] [ne.mi.fm.lo.mo.ModFileParser/LOADING]: Mod file /home/container/libraries/net/minecraftforge/fmlcore/1.19.2-43.3.0/fmlcore-1.19.2-43.3.0.jar is missing mods.toml file [00:02:43] [main/WARN] [ne.mi.fm.lo.mo.ModFileParser/LOADING]: Mod file /home/container/libraries/net/minecraftforge/javafmllanguage/1.19.2-43.3.0/javafmllanguage-1.19.2-43.3.0.jar is missing mods.toml file [00:02:43] [main/WARN] [ne.mi.fm.lo.mo.ModFileParser/LOADING]: Mod file /home/container/libraries/net/minecraftforge/lowcodelanguage/1.19.2-43.3.0/lowcodelanguage-1.19.2-43.3.0.jar is missing mods.toml file [00:02:43] [main/WARN] [ne.mi.fm.lo.mo.ModFileParser/LOADING]: Mod file /home/container/libraries/net/minecraftforge/mclanguage/1.19.2-43.3.0/mclanguage-1.19.2-43.3.0.jar is missing mods.toml file [00:02:44] [main/WARN] [ne.mi.ja.se.JarSelector/]: Attempted to select two dependency jars from JarJar which have the same identification: Mod File: and Mod File: . Using Mod File: [00:02:44] [main/WARN] [ne.mi.ja.se.JarSelector/]: Attempted to select a dependency jar for JarJar which was passed in as source: resourcefullib. Using Mod File: /home/container/mods/resourcefullib-forge-1.19.2-1.1.24.jar [00:02:44] [main/INFO] [ne.mi.fm.lo.mo.JarInJarDependencyLocator/]: Found 13 dependencies adding them to mods collection Latest log [29Mar2024 00:02:42.803] [main/INFO] [cpw.mods.modlauncher.Launcher/MODLAUNCHER]: ModLauncher running: args [--launchTarget, forgeserver, --fml.forgeVersion, 43.3.0, --fml.mcVersion, 1.19.2, --fml.forgeGroup, net.minecraftforge, --fml.mcpVersion, 20220805.130853] [29Mar2024 00:02:42.805] [main/INFO] [cpw.mods.modlauncher.Launcher/MODLAUNCHER]: ModLauncher 10.0.8+10.0.8+main.0ef7e830 starting: java version 17.0.10 by Eclipse Adoptium; OS Linux arch amd64 version 6.1.0-12-amd64 [29Mar2024 00:02:43.548] [main/INFO] [mixin/]: SpongePowered MIXIN Subsystem Version=0.8.5 Source=union:/home/container/libraries/org/spongepowered/mixin/0.8.5/mixin-0.8.5.jar%2363!/ Service=ModLauncher Env=SERVER [29Mar2024 00:02:43.876] [main/WARN] [net.minecraftforge.fml.loading.moddiscovery.ModFileParser/LOADING]: Mod file /home/container/libraries/net/minecraftforge/fmlcore/1.19.2-43.3.0/fmlcore-1.19.2-43.3.0.jar is missing mods.toml file [29Mar2024 00:02:43.877] [main/WARN] [net.minecraftforge.fml.loading.moddiscovery.ModFileParser/LOADING]: Mod file /home/container/libraries/net/minecraftforge/javafmllanguage/1.19.2-43.3.0/javafmllanguage-1.19.2-43.3.0.jar is missing mods.toml file [29Mar2024 00:02:43.877] [main/WARN] [net.minecraftforge.fml.loading.moddiscovery.ModFileParser/LOADING]: Mod file /home/container/libraries/net/minecraftforge/lowcodelanguage/1.19.2-43.3.0/lowcodelanguage-1.19.2-43.3.0.jar is missing mods.toml file [29Mar2024 00:02:43.878] [main/WARN] [net.minecraftforge.fml.loading.moddiscovery.ModFileParser/LOADING]: Mod file /home/container/libraries/net/minecraftforge/mclanguage/1.19.2-43.3.0/mclanguage-1.19.2-43.3.0.jar is missing mods.toml file [29Mar2024 00:02:44.033] [main/WARN] [net.minecraftforge.jarjar.selection.JarSelector/]: Attempted to select two dependency jars from JarJar which have the same identification: Mod File: and Mod File: . Using Mod File: [29Mar2024 00:02:44.034] [main/WARN] [net.minecraftforge.jarjar.selection.JarSelector/]: Attempted to select a dependency jar for JarJar which was passed in as source: resourcefullib. Using Mod File: /home/container/mods/resourcefullib-forge-1.19.2-1.1.24.jar [29Mar2024 00:02:44.034] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.JarInJarDependencyLocator/]: Found 13 dependencies adding them to mods collection
    • I am unable to do that. Brigadier is a mojang library that parses commands.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.