Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

Event "setSecondsOnFire" won't connect to SwordItem


Recommended Posts

20 minutes ago, eggpasta said:

and for p_220045_0_ it's whatever you put here 

p_77644_1_.hurtAndBreak(1, p_77644_3_, (p_220045_0_) -> {

so check you dont have any typos

Hence giving it an intelligible name.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to post
Share on other sites
26 minutes ago, eggpasta said:

For the iteminit error get rid of


() ->

so it's just


FlamingSword::new

and for p_220045_0_ it's whatever you put here 

p_77644_1_.hurtAndBreak(1, p_77644_3_, (p_220045_0_) -> {

so check you dont have any typos

Well, I got rid of () ->, but I have no typos. I've typed it correctly, but I still have this:image.thumb.png.14838a1fbcd35768f4de61762a89d647.png

Link to post
Share on other sites
Posted (edited)

 

2 minutes ago, Skullblade said:

Well, I got rid of () ->, but I have no typos. I've typed it correctly, but I still have this:image.thumb.png.14838a1fbcd35768f4de61762a89d647.png

You have an extra unnecessary bracket after p_22045_0_ 

also you still dont need the the check if it's embercleave because the method can only fire if it's embercleave so remove the check

Edited by eggpasta
Link to post
Share on other sites

Oh, that makes sense. The only remaining problems (we're almost done, thank you so much for your help) is "event" in event.getEntity().setSecondsOnFire(10); remaining unresolved and two brackets at the bottom, the higher one saying ')' expected (perhaps the one I just deleted) and the lower one before the final bracket for class FlamingSword saying ';" expected.

Link to post
Share on other sites
14 minutes ago, eggpasta said:

 

You have an extra unnecessary bracket after p_22045_0_ 

also you still dont need the the check if it's embercleave because the method can only fire if it's embercleave so remove the check

Oh, that makes sense. The only remaining problems (we're almost done, thank you so much for your help) is "event" in event.getEntity().setSecondsOnFire(10); remaining unresolved and two brackets at the bottom, the higher one saying ')' expected (perhaps the one I just deleted) and the lower one before the final bracket for class FlamingSword saying ';" expected.

Link to post
Share on other sites

Why do you have your "on-hit effect" code located in the lambda? It will only be triggered upon item break.

Also the easiest way to do it is just set the target on fire and then return super, two lines of code.

 

Link to post
Share on other sites
Posted (edited)

 

remove event.getEntity() from it and change it to p_77644_3_ and also as @poopoodice said , move the fire code out of the lambda like so

      p_77644_1_.hurtAndBreak(1, p_77644_3_, (p_220045_0_) -> {
         p_220045_0_.broadcastBreakEvent(EquipmentSlotType.MAINHAND);
      });
      p_77644_3_.setSecondsOnFire(10);

 

 

Edited by eggpasta
Link to post
Share on other sites
14 minutes ago, Skullblade said:

Oh, that makes sense. The only remaining problems (we're almost done, thank you so much for your help) is "event" in event.getEntity().setSecondsOnFire(10); remaining unresolved and two brackets at the bottom, the higher one saying ')' expected (perhaps the one I just deleted) and the lower one before the final bracket for class FlamingSword saying ';" expected.

 

Just now, eggpasta said:

 

remove event.getEntity() from it and change it to p_77644_3_ and also as @poopoodice said , move the fire code out of the lambda like so



      p_77644_1_.hurtAndBreak(1, p_77644_3_, (p_220045_0_) -> {
         p_220045_0_.broadcastBreakEvent(EquipmentSlotType.MAINHAND);
      });
      p_77644_3_.setSecondsOnFire(10);

 

 

 

Link to post
Share on other sites

Nice! (I didn't really know how Lambda worked before, so that was really helpful.)

Well, I tested it, as all the errors were fixed (i figured out the last few on their own, they were either in the wrong place or were no longer necessary). I ran the client, and Embercleave didn't set anything on fire...

Link to post
Share on other sites
26 minutes ago, Skullblade said:

Nice! (I didn't really know how Lambda worked before, so that was really helpful.)

Well, I tested it, as all the errors were fixed (i figured out the last few on their own, they were either in the wrong place or were no longer necessary). I ran the client, and Embercleave didn't set anything on fire...

Hmm ok well it's a start. so we can know if the method is triggering, add System.out.println("Triggered") Under the fire code and then run the code and check the logs for Tr

Link to post
Share on other sites
42 minutes ago, eggpasta said:

Hmm ok well it's a start. so we can know if the method is triggering, add System.out.println("Triggered") Under the fire code and then run the code and check the logs for Tr

I created a new world, spawned a Vindicator, and hit it with Embercleave. It took the right amount of damage, but it wasn't set on fire. Also, I checked the logs and there was nothing.

Link to post
Share on other sites
12 hours ago, poopoodice said:

All parts that are related to the item.

Ok, here it is. Keep in mind that I renamed FlamingSword.java to Embercleave.java for 1, troubleshooting, and 2, I don't intend to reuse the exact code for any other item, so I gave it its final name and I'll just take pieces of it I need for other items later.image.thumb.png.1b87d394b06f0017e77435af881d3e50.png

image.thumb.png.cc84cd07c7939d50c17012030de91f5e.png

image.thumb.png.805dc390909a45d811658fce7dc6b572.png

image.thumb.png.1d91450c0e0023acda0584e5a1da2958.png

image.thumb.png.de063b8ce120073d155bf64be34f334d.png

Link to post
Share on other sites

Well.. I have no idea why it doesn't work, and I don't see any problems except you should set a max damage (durability) in your item properties, and your entity2 is in fact the attacker. Entity1 is the target.

Link to post
Share on other sites
22 minutes ago, poopoodice said:

Well.. I have no idea why it doesn't work, and I don't see any problems except you should set a max damage (durability) in your item properties, and your entity2 is in fact the attacker. Entity1 is the target.

You absolute genius. I had been testing in creative, so there was no way for me to get set on fire to know that. Thank you so much for all of the help. You too eggpasta.

  • Haha 1
Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.