Jump to content

[1.16.5] Help with Remove World Features and custom WorldCarver


Luis_ST

Recommended Posts

okay as the title says I have problems with some world features
I am currently creating a custom dimension that will expand the overworld downwards
(because the current save format, as I know, does not allow the world to be enlarged, so this is the only way i that is also possible to do this).

  1. does the vanilla carvers only replace stone? since these no matter how I add them to the dimension, they do not generate.
  2. if 1. yes how do i create my own caves, or can I change the replace block for vanilla's?
  3. I also want to change a few of the vanilla ores, which is why I tried to replace the features with BiomeLoadingEvent,
    but when I try to remove it, nothing happens, this is the code of my event:
    	@SubscribeEvent(priority = EventPriority.NORMAL)
    	public static void biomeLoading(BiomeLoadingEvent event) {
    		
    		ResourceLocation biomeName = event.getName();
    		Category category = event.getCategory();
    		BiomeGenerationSettingsBuilder generationBuilder = event.getGeneration();
    		
    		if (category == Category.THEEND) {
    			
    		} else if (category == Category.NETHER) {
    			
    		} else {
    			
    			generationBuilder.getFeatures(Decoration.UNDERGROUND_ORES).removeIf((supplier) -> {
    				ConfiguredFeature<?, ?> feature = supplier.get();
    				if (feature.config instanceof OreFeatureConfig) {
    					OreFeatureConfig oreConfig = (OreFeatureConfig) feature.config;
    					if (oreConfig.state.getBlock() == Blocks.COAL_ORE) {
    						return true;
    					} else if (oreConfig.state.getBlock() == Blocks.IRON_ORE) {
    						return true;
    					} else if (oreConfig.state.getBlock() == Blocks.GOLD_ORE) {
    						return true;
    					} else if (oreConfig.state.getBlock() == Blocks.LAPIS_ORE) {
    						return true;
    					} else if (oreConfig.state.getBlock() == Blocks.REDSTONE_ORE) {
    						return true;
    					} else if (oreConfig.state.getBlock() == Blocks.DIAMOND_ORE) {
    						return true;
    					}
    				}
    				return false;
    			}); 
    			
    		}
    		
    	}

a few other questions about the world features:

  1. my dimension is completely made of stone (custom, 0-256) but still generate mineshafts far down in the world,
    what is the value of the generation height based on i have already looked at the feature and found something with the sea level but this has not changed anything

thanks for replies

Edited by Luis_ST
Link to comment
Share on other sites

1 hour ago, Luis_ST said:

my dimension is completely made of stone (custom, 0-256) but still generate mineshafts far down in the world,
what is the value of the generation height based on i have already looked at the feature and found something with the sea level but this has not changed anything

small update: after testing a bit, I found that the mineshaft generation is dependent on the SeaLevel (mineshafts generate below the SeaLevel),
I fixed my problem by setting the SeaLevel to the maximum height of the dimension

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.