Jump to content

[1.16.5] Getting unexpected results for BlockState#getHarvestLevel()


olihewi

Recommended Posts

Hi there,

I'm having some difficulty getting a block's actual harvest level - for context, I am implementing a ranged pickaxe which has a variable mining level depending on "oxidation".

To determine whether a block should be mined, I am using BlockState#getHarvestLevel(), however with certain blocks (e.g. glass and every block from other mods), it is returning -1, which I expect to be the value for unbreakable blocks e.g. bedrock, so I was checking against that.

Am I supposed to use a different method to get a block's harvest level? Or should I ignore the -1 check and simply hardcode in unbreakable blocks?

private boolean shouldMine(BlockState blockState)
  {
    int blockHardness = blockState.getHarvestLevel();
    int oxidationStage = 0;
    if (this.getItemStack().getItem() instanceof PickOnAStickItem)
    {
      PickOnAStickItem pickOnAStickItem = (PickOnAStickItem) this.getItemStack().getItem();
      oxidationStage = pickOnAStickItem.oxidationStage;
    }
    return !blockState.isStickyBlock() &&
        blockState.getPistonPushReaction() != PushReaction.PUSH_ONLY &&
        blockState.getBlock() != Blocks.TARGET &&
        blockHardness >= 0 &&
        blockHardness <= 2 - oxidationStage;
  }

 

Link to comment
Share on other sites

30 minutes ago, olihewi said:

pickOnAStickItem.oxidationStage;

This doesn't work. There is only one instance of your item class, so ALL copies for ALL players will share the same oxidation stage. You need to use Capabilities.

 

32 minutes ago, olihewi said:

it is returning -1, which I expect to be the value for unbreakable blocks e.g. bedrock, so I was checking against that.

Hardness of -1 is unbreakable. Harvest Level of -1 means something else.

  • Like 1

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.