Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

Creating an custom cactus plant


LuccaPossamai
 Share

Recommended Posts

I'm creating a cactus plant for a custom desert biome. I'm having trouble with the blocks that sustain the plant. I'm trying to override the "canSustainPlant" method, but, in the game, the cactus could only be planted in normal sand. Other trouble I have is with the model of the cacti.

My code:

Spoiler

public class DenseCactus extends CactusBlock {

    public DenseCactus(Properties p_i48435_1_) {
        super(p_i48435_1_);
    }


    @Override
    public boolean canSustainPlant(BlockState state, IBlockReader world, BlockPos pos, Direction facing, IPlantable plantable) {
        BlockState plant = plantable.getPlant(world, pos.relative(facing));

        if (plant.getBlock() instanceof DenseCactus) {
            return BlockTags.SAND.contains(state.getBlock()) || state.getBlock() instanceof DenseCactus;
        }
        return super.canSustainPlant(state, world, pos, facing, plantable);
    }

    @Override
    public BlockState getPlant(IBlockReader world, BlockPos pos) {
        return defaultBlockState();
    }
}

 

And my actual cactus model:

Spoiler

image.thumb.png.06d17e1ba653cd3e802dec7e99deec49.png

 

Link to comment
Share on other sites

12 hours ago, LuccaPossamai said:

I'm trying to override the "canSustainPlant" method, but, in the game, the cactus could only be planted in normal sand.

Have you tried stepping through your code with the debugger? I'd set a breakpoint at the beginning of the canSustainPlant method and step through it to see what's going down.

Link to comment
Share on other sites

13 hours ago, LuccaPossamai said:

Other trouble I have is with the model of the cacti.

your model is a full block (in pixel 16*16*16) but the texture is of the cactus is not a full block (in pixel 14*16*14)
take a look at the vanilla cactus model, simple copy the model and change the texture

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Could you explain what you mean by that, just to clarify I am trying to create a recipe type that handles potions and I'm pretty sure the standard recipe type cannot handle nbt data within the recipe. Do you mean use minecraft:crafting_shapeless as the type in the json file or am I misinterpreting 
    • Use the same recipe type as the crafting table. The recipe and serializer is the only thing that needs to be unique.
    • I have a custom recipe type that has successfully registered into minecraft, however I am trying to get it to work on the standard crafting table as it doesn't need a custom table for it.   { "type": "randomfhings:potion_edible", "ingredients": [ { "item" : "minecraft:glass", "data": "" }, { "item" : "minecraft:diamond" } ], "output": { "item": "randomfhings:ruby", "count": 3 } } This is a test recipe so far . package org.multicoder.randomfhings.recipe; import com.google.gson.JsonArray; import com.google.gson.JsonObject; import net.minecraft.core.NonNullList; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.resources.ResourceLocation; import net.minecraft.util.GsonHelper; import net.minecraft.world.inventory.CraftingContainer; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.crafting.*; import net.minecraft.world.level.Level; import org.multicoder.randomfhings.RandomFhings; import javax.annotation.Nullable; public class PotionRecipe implements Recipe<CraftingContainer> { private final ResourceLocation id; private final ItemStack output; private final NonNullList<Ingredient> input; public PotionRecipe(ResourceLocation id, ItemStack output, NonNullList<Ingredient> input) { this.id = id; this.output = output; this.input = input; } @Override public NonNullList<Ingredient> getIngredients() { return input; } @Override public boolean matches(CraftingContainer p_44002_, Level p_44003_) { return input.get(0).test(p_44002_.getItem(0)); } @Override public ItemStack assemble(CraftingContainer p_44001_) { return output.copy(); } @Override public boolean canCraftInDimensions(int p_43999_, int p_44000_) { return true; } @Override public ItemStack getResultItem() { return output; } @Override public ResourceLocation getId() { return id; } @Override public RecipeSerializer<?> getSerializer() { return Serializer.INSTANCE; } @Override public RecipeType<?> getType() { return Type.INSTANCE; } public static class Type implements RecipeType<PotionRecipe> { private Type() { } public static final Type INSTANCE = new Type(); public static final String ID = "potion_edible"; } public static class Serializer implements RecipeSerializer<PotionRecipe> { public static final Serializer INSTANCE = new Serializer(); public static final ResourceLocation ID = new ResourceLocation(RandomFhings.MOD_ID,"potion_edible"); @Override public PotionRecipe fromJson(ResourceLocation id, JsonObject json) { ItemStack output = ShapedRecipe.itemStackFromJson(GsonHelper.getAsJsonObject(json, "output")); JsonArray ingredients = GsonHelper.getAsJsonArray(json, "ingredients"); NonNullList<Ingredient> inputs = NonNullList.withSize(2, Ingredient.EMPTY); for (int i = 0; i < inputs.size(); i++) { inputs.set(i, Ingredient.fromJson(ingredients.get(i))); } return new PotionRecipe(id, output, inputs); } @Override public PotionRecipe fromNetwork(ResourceLocation id, FriendlyByteBuf buf) { NonNullList<Ingredient> inputs = NonNullList.withSize(buf.readInt(), Ingredient.EMPTY); for (int i = 0; i < inputs.size(); i++) { inputs.set(i, Ingredient.fromNetwork(buf)); } ItemStack output = buf.readItem(); return new PotionRecipe(id, output, inputs); } @Override public void toNetwork(FriendlyByteBuf buf, PotionRecipe recipe) { buf.writeInt(recipe.getIngredients().size()); for (Ingredient ing : recipe.getIngredients()) { ing.toNetwork(buf); } buf.writeItemStack(recipe.getResultItem(), false); } @Override public RecipeSerializer<?> setRegistryName(ResourceLocation name) { return INSTANCE; } @Nullable @Override public ResourceLocation getRegistryName() { return ID; } @Override public Class<RecipeSerializer<?>> getRegistryType() { return Serializer.castClass(RecipeSerializer.class); } @SuppressWarnings("unchecked") // Need this wrapper, because generics private static <G> Class<G> castClass(Class<?> cls) { return (Class<G>)cls; } } } This is my recipe type class and it is registered via a deferred register.
    • The version you are using is no longer supported on this forum. Please update to a modern version of Minecraft to receive support. Currently supported versions are 1.19.2 (Latest) and 1.18.2 (LTS).
    • The version you are using is no longer supported on this forum. Please update to a modern version of Minecraft to receive support. Currently supported versions are 1.19.2 (Latest) and 1.18.2 (LTS).
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.