Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[SOLVED][1.16.5] Custom Biome not generating in overworld dimension


Justin1205
 Share

Recommended Posts

Hi,

I am working on a mod which adds a custom biome to the overworld, the /locatebiome command lists my biome as well, but it shows that the type "tutorial:tutorial_biome"  cannot be found in "minecraft:overworld".

My Biome JSON file: https://pastebin.com/8QUJcSxJ

My Surface Builder JSON file: https://pastebin.com/hVJBEjSd

My Main.java File: https://pastebin.com/c288ptJ7

 

Also, please mention an alternative to extending the Biome class, as it's no longer possible. I am tired of JSONs.

Thanks in advance!

Link to comment
Share on other sites

Like this?

public void commonSetup(FMLCommonSetupEvent e) {
		e.enqueueWork(() -> {
			BiomeEntry entry = new BiomeEntry(stony, 1);
			BiomeManager.addBiome(BiomeType.COOL, entry);
			BiomeManager.addAdditionalOverworldBiomes(stony);
		}
		);

 

Edited by Justin1205
Link to comment
Share on other sites

Overall, I have made these changes to my Main (and only) class.

package com.hastev.biomes;


import net.minecraft.util.RegistryKey;
...

@Mod("tutorial")

public class Main {
	public static final RegistryKey<Biome> stony = RegistryKey.create(Registry.BIOME_REGISTRY, new ResourceLocation("tutorial", "tutorial_biome"));
	
	public Main() {
		IEventBus bus = FMLJavaModLoadingContext.get().getModEventBus();
	        bus.addListener(EventPriority.LOWEST, this::commonSetup);
	}

	public void commonSetup(FMLCommonSetupEvent e) {
		e.enqueueWork(() -> {
			BiomeManager.addBiome(BiomeType.COOL, new BiomeEntry(stony, 1));
			BiomeDictionary.addTypes(stony, Type.SANDY);
		}
		);
	}
	
}

And, Minecraft is now crashing with the errors:

1. java.lang.IllegalStateException: Unknown biome id emitted by layers: -1

 

Crash Report: https://pastebin.com/9nYUpA5v

 

Edited by Justin1205
Link to comment
Share on other sites

You can add biomes without json. this is how i do it

    public static final DeferredRegister<Biome> Mod_biomes = DeferredRegister.create(ForgeRegistries.BIOMES, test.MOD_ID);

    public static final RegistryObject<Biome> test_forest = Mod_biomes.register("test_forest",()-> TestForestBiome.makeTestForestBiome(0.4f,0.6f));


    public static final RegistryKey<Biome> TEST_FOREST_KEY = RegistryKey.create(Registry.BIOME_REGISTRY, new ResourceLocation(test.MOD_ID, "test_forest"));


    public static void addBiomesToOverworld() {
        BiomeManager.addBiome(BiomeManager.BiomeType.WARM, new BiomeManager.BiomeEntry(TEST_FOREST_KEY, 1));
    }

Link to comment
Share on other sites

2 minutes ago, UserMC123 said:

You can add biomes without json. this is how i do it

    public static final DeferredRegister<Biome> Mod_biomes = DeferredRegister.create(ForgeRegistries.BIOMES, test.MOD_ID);

    public static final RegistryObject<Biome> test_forest = Mod_biomes.register("test_forest",()-> TestForestBiome.makeTestForestBiome(0.4f,0.6f));


    public static final RegistryKey<Biome> TEST_FOREST_KEY = RegistryKey.create(Registry.BIOME_REGISTRY, new ResourceLocation(test.MOD_ID, "test_forest"));


    public static void addBiomesToOverworld() {
        BiomeManager.addBiome(BiomeManager.BiomeType.WARM, new BiomeManager.BiomeEntry(TEST_FOREST_KEY, 1));
    }

Hi UserMC123,

Thanks for your reply, but I actually know how to do this stuff. I am confused with the Custom Biome Class (In yours, I think it's TestForestBiome). It would be great if you could post your Custom Biome class in a Git repo or some other site.

Link to comment
Share on other sites

this is the class for the biome:

 private static int getSkyColorWithTemperatureModifier(float p_244206_0_) {
        float lvt_1_1_ = p_244206_0_ / 3.0F;
        lvt_1_1_ = MathHelper.clamp(lvt_1_1_, -1.0F, 1.0F);
        return MathHelper.hsvToRgb(0.62222224F - lvt_1_1_ * 0.05F, 0.5F + lvt_1_1_ * 0.1F, 1.0F);
    }


    public static Biome makeTestForestBiome(float depth, float scale) {
        MobSpawnInfo.Builder spawnInf = new MobSpawnInfo.Builder();
        DefaultBiomeFeatures.farmAnimals(spawnInf);
        DefaultBiomeFeatures.commonSpawns(spawnInf);
        spawnInf.setPlayerCanSpawn();
        net.minecraft.world.biome.BiomeGenerationSettings.Builder builder = (new net.minecraft.world.biome.BiomeGenerationSettings.Builder()).surfaceBuilder(ConfiguredSurfaceBuilders.GRASS);
        DefaultBiomeFeatures.addDefaultCarvers(builder);
        DefaultBiomeFeatures.addDefaultLakes(builder);
        DefaultBiomeFeatures.baseJungleSpawns(spawnInf);
        DefaultBiomeFeatures.addDefaultMonsterRoom(builder);
        DefaultBiomeFeatures.addDefaultUndergroundVariety(builder);
        DefaultBiomeFeatures.addDefaultOres(builder);
        DefaultBiomeFeatures.addDefaultSoftDisks(builder);
        DefaultBiomeFeatures.addForestGrass(builder);
        DefaultBiomeFeatures.addForestGrass(builder);
        DefaultBiomeFeatures.addFerns(builder);
        DefaultBiomeFeatures.addJungleTrees(builder);
        DefaultBiomeFeatures.addDefaultMushrooms(builder);
        DefaultBiomeFeatures.addDefaultSprings(builder);
        DefaultBiomeFeatures.addJungleGrass(builder);
        DefaultBiomeFeatures.addLightBambooVegetation(builder);
        return (new net.minecraft.world.biome.Biome.Builder()).precipitation(Biome.RainType.RAIN).biomeCategory(Biome.Category.JUNGLE).depth(depth).scale(scale).temperature(0.6F).downfall(0.2F).specialEffects((new net.minecraft.world.biome.BiomeAmbience.Builder()).waterColor(3124991).waterFogColor(5541815).fogColor(14412287).foliageColorOverride(8640564).skyColor(getSkyColorWithTemperatureModifier(0.6F)).ambientMoodSound(MoodSoundAmbience.LEGACY_CAVE_SETTINGS).build()).mobSpawnSettings(spawnInf.build()).generationSettings(builder.build()).build();
    }

  • Thanks 1
Link to comment
Share on other sites

  • Justin1205 changed the title to [SOLVED][1.16.5] Custom Biome not generating in overworld dimension

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • This is what I have for two ModelFiles, the first only applying one overlay and the second apply the first overlay + another. public ModelFile scuffedWarenaiBlockModel(Block block) { return models().getBuilder("scuffed_" + name(block)) .parent(existingMcModel("block")) .texture("particle", warenaiBlockTexture(block)) .texture("underlay", warenaiBlockTexture(block)) .texture("overlay", scuffedTexture()) .element().from(0, 0, 0).to(16, 16, 16).allFaces((direction, faceBuilder) -> faceBuilder.uvs(0, 0, 16, 16).texture("#underlay").cullface(direction)).end() .element().from(0, 0, 0).to(16, 16, 16).allFaces((direction, faceBuilder) -> faceBuilder.uvs(0, 0, 16, 16).texture("#overlay").cullface(direction)).end(); } public ModelFile crackedWarenaiBlockModel(Block block, int crackedLevel) { return models().getBuilder("cracked" + crackedLevel + "_" + name(block)) .parent(existingMcModel("block")) .texture("particle", warenaiBlockTexture(block)) .texture("underlay", warenaiBlockTexture(block)) .texture("overlay1", scuffedTexture()) .texture("overlay2", crackedTexture(crackedLevel)) .element().from(0, 0, 0).to(16, 16, 16).allFaces((direction, faceBuilder) -> faceBuilder.uvs(0, 0, 16, 16).texture("#underlay").cullface(direction)).end() .element().from(0, 0, 0).to(16, 16, 16).allFaces((direction, faceBuilder) -> faceBuilder.uvs(0, 0, 16, 16).texture("#overlay1").cullface(direction)).end() .element().from(0, 0, 0).to(16, 16, 16).allFaces((direction, faceBuilder) -> faceBuilder.uvs(0, 0, 16, 16).texture("#overlay2").cullface(direction)).end(); }   This works, but it doesn't seem so simple for a stair block.  I copied the stair stuff from the forge BlockStateProvider class to get started with a normal stair model that works:  public void warenaiStairBlock(StairsBlock block, ResourceLocation texture) { warenaiStairBlockInternal1(block, texture, texture, texture); } public void warenaiStairBlockInternal1(StairsBlock block, ResourceLocation side, ResourceLocation bottom, ResourceLocation top) { warenaiStairBlockInternal2(block, block.getRegistryName().toString(), side, bottom, top); } public void warenaiStairBlockInternal2(StairsBlock block, String baseName, ResourceLocation side, ResourceLocation bottom, ResourceLocation top) { ModelFile normal_stairs = models().stairs(baseName, side, bottom, top); ModelFile normal_stairsInner = models().stairsInner(baseName + "_inner", side, bottom, top); ModelFile normal_stairsOuter = models().stairsOuter(baseName + "_outer", side, bottom, top); warenaiStairsBlock(block, normal_stairs, normal_stairsInner, normal_stairsOuter); } public void warenaiStairsBlock(StairsBlock block, ModelFile stairs, ModelFile stairsInner, ModelFile stairsOuter) { getVariantBuilder(block) .forAllStatesExcept(state -> { Direction facing = state.getValue(StairsBlock.FACING); Half half = state.getValue(StairsBlock.HALF); StairsShape shape = state.getValue(StairsBlock.SHAPE); int yRot = (int) facing.getClockWise().toYRot(); // Stairs model is rotated 90 degrees clockwise for some reason yRot %= 360; boolean uvlock = yRot != 0 || half == Half.TOP; // Don't set uvlock for states that have no rotation ModelFile shapeDependentModel = shape == StairsShape.STRAIGHT ? stairs : shape == StairsShape.INNER_LEFT || shape == StairsShape.INNER_RIGHT ? stairsInner : stairsOuter; if (shape == StairsShape.INNER_LEFT || shape == StairsShape.OUTER_LEFT) { yRot += 270; // Left facing stairs are rotated 90 degrees clockwise } if (shape != StairsShape.STRAIGHT && half == Half.TOP) { yRot += 90; // Top stairs are rotated 90 degrees clockwise } return ConfiguredModel.builder() .modelFile(shapeDependentModel) .rotationX(half == Half.BOTTOM ? 0 : 180) .rotationY(yRot) .uvLock(uvlock) .build(); }, StairsBlock.WATERLOGGED); }   Now I have no idea where to go. I could take the time and figure it out all on my own, but since I really should be working on a college essay I thought I would see if anyone else knew what to do first. If not, then I will just do it myself when I get the time.
    • O well i tried to fix a bug in the stone age mod and my plan failed after trying to insert the json directly into the jar.
    • You spawn the entity on the server. The server then ensures it is spawned on all clients that can see it.
    • Then what do I do? My entity just animates a block model going up then places it. Is there another way to do it? P.S the server places that block independently without syncing it.
    • Seems to be an issue with stone age.
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.