Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.17.1] Villager Point of interest


AurenX
 Share

Recommended Posts

I had this working in 1.16 but the same method doesn't seem to have the same effect.

I have a new block that replaces the fletching table but this breaks the villager point of interest so no more fletchers.
In 1.16 i had this


public static void fixVillagerPOI(FMLCommonSetupEvent event) {
     Map<BlockState, PointOfInterestType> types = ReflectionHelper.getPrivateValue(PointOfInterestType.class, null, ASMAPI.mapField("field_221073_u"));
     Blocks.FLETCHING_TABLE.getStateContainer().getValidStates().forEach(s -> types.put(s, PointOfInterestType.FLETCHER));
}

field_221073_u no longer exists and, unless I don't understand, is now f_27323_ . while this does not give an error it also does not effect the villagers

Is there a new method to get villagers to become an existing type with a new block?

Link to comment
Share on other sites

7 hours ago, AurenX said:

So nothing at the moment to register villagers profession point of interests? Or just nothing for existing professions?

you can register them the same way you register Items, Blocks, etc.

Link to comment
Share on other sites

  • 4 weeks later...

Sorry for the delayed response i got busy with work.

I was able to get this working, with the gap between and my other bad habit of getting frustrated and deleting code that doesnt work i do not remember exactly what i did that did not work.
What i found was i had to create both a profession and a poitype and was not able to just override the poitype individually, this is probably what i was missing to be honest as the method i was using only needed the poi.

Thank you for the help you guys did provide.


note: The registry name for the profession uses minecraft so no new textures are needed
note: Was able to just pull trade data over but had to re-register that as well
note: Event subscription handled in other location but nothing special there

was able to get it working with Deferred registry

 

    public static final DeferredRegister<PoiType> POINT_OF_INTEREST_TYPES = DeferredRegister.create(ForgeRegistries.POI_TYPES, Reference.MOD_ID);
    public static final DeferredRegister<VillagerProfession> VILLAGER_PROFESSIONS = DeferredRegister.create(ForgeRegistries.PROFESSIONS, "minecraft");
    
    public static final RegistryObject<PoiType> FLETCHER_POI = POINT_OF_INTEREST_TYPES.register("fletcher", () -> new PoiType("fletcher", PoiType.getBlockStates(BlockHandler.FletchingTable), 1, 1));
    public static final RegistryObject<VillagerProfession> FLETCHER = VILLAGER_PROFESSIONS.register("fletcher", () -> new VillagerProfession("fletcher", FLETCHER_POI.get(), ImmutableSet.of(), ImmutableSet.of(Blocks.FLETCHING_TABLE), SoundEvents.VILLAGER_WORK_FLETCHER));
    
    public static void commonSetup(FMLCommonSetupEvent event) {
        event.enqueueWork(() -> {
            VillagerHandler.tradeData();
            VillagerHandler.registerFletherPOI();
        });
    }

    public static void registerFletherPOI() {
        try {
            ObfuscationReflectionHelper.findMethod(PoiType.class, "registerBlockStates", PoiType.class).invoke(null, FLETCHER_POI.get());
        } catch (InvocationTargetException | IllegalAccessException e) {
            e.printStackTrace();
        }
    }
    
    private static void tradeData() {
        VillagerTrades.TRADES.put(FLETCHER.get(), VillagerTrades.TRADES.get(VillagerProfession.FLETCHER));
    }



I was also able to get normal registry working with 

 


    public static final PoiType FLETCHER_POI = new PoiType("fletcher", PoiType.getBlockStates(BlockHandler.FletchingTable), 1, 1);
    public static final VillagerProfession FLETCHER = new VillagerProfession("fletcher", FLETCHER_POI, ImmutableSet.of(), ImmutableSet.of(Blocks.FLETCHING_TABLE), SoundEvents.VILLAGER_WORK_FLETCHER);
    
    public static void setupPOIType(Register<PoiType> event) {
        event.getRegistry().register(FLETCHER_POI.setRegistryName(Reference.MOD_ID, "fletcher"));
    }
    
    public static void setupProffessions(Register<VillagerProfession> event) {
        event.getRegistry().register(FLETCHER.setRegistryName("minecraft", "fletcher"));
    }
    
    private static void tradeData() {
        VillagerTrades.TRADES.put(FLETCHER, VillagerTrades.TRADES.get(VillagerProfession.FLETCHER));
    }
 
    public static void commonSetup(FMLCommonSetupEvent event) {
        VillagerHandler.tradeData();
    }
    }

Edited by AurenX
Link to comment
Share on other sites

10 hours ago, AurenX said:

I was also able to get normal registry working with 

This is not correct! When using normal registry events you must create the registry entries in the RegistryEvent handler and use @ObjectHolder (or RegistryObject) to inject the objects into the fields.

Link to comment
Share on other sites

I mean must is a strong word when this is functional.

"Should" yes probably 

But as a hey this worked and I'm going to optimize it after then I'll stick with yes "I got it working"

Edited by AurenX
Link to comment
Share on other sites

You must have a licence to drive a car. "Must is a strong word, the car runs without it".

Just because it works doesn't mean that it won't cause you problems down the line. And if you do it correctly from the start, you won't have to spend the time finding and fixing bugs later on.

Link to comment
Share on other sites

1 hour ago, Alpvax said:

You must have a licence to drive a car. "Must is a strong word, the car runs without it".

Just because it works doesn't mean that it won't cause you problems down the line. And if you do it correctly from the start, you won't have to spend the time finding and fixing bugs later on.

Yes but when proving a proof of concept you don't drive on the open road so no a license technically isn't needed as they would use a test track or heck test parts individually before assembly. And a poor example as a working car and a street legal car are different; there are concept cars, race cars, plastic cars for kids, etc.

So when I am just starting to update mods to a newer version of forge and enough changed that a proof of concept test mod is advisable then no doing it perfect is not needed and instead just a waste.

Yes when updating the actual mod you should I stated that above. Again all I showed was that I got it working, not hey here is this perfect thing all learn from me as I am the smart perfect person.

Again I will say, it works fine how it is. And again I will say yes you should use object holders. But saying needed is wrong.

If you would like to provide people with a "here is the proper way to code this" instead of an example that "works" then go ahead and post it. I have no more need of advancing this as I have learned what I needed to from it.

22 hours ago, diesieben07 said:

This is why we can't have nice things.

I probably shouldn't show you how I work with blocks and items when I just need to bulk create things ;)

Edited by AurenX
Link to comment
Share on other sites

13 minutes ago, AurenX said:

Again I will say, it works fine how it is.

It does not.

13 minutes ago, AurenX said:

But saying needed is wrong.

It is not.

13 minutes ago, AurenX said:

If you would like to provide people with a "here is the proper way to code this" instead of an example that "works" then go ahead and post it. I have no more need of advancing this as I have learned what I needed to from it.

Proper registry usage is explained in the documentation: https://mcforge.readthedocs.io/en/latest/concepts/registries/.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • @RideableEntitiesModElements.ModElement.Tag public class BabytigerEntity extends RideableEntitiesModElements.ModElement { public static EntityType entity = (EntityType.Builder.<CustomEntity>create(CustomEntity::new, EntityClassification.MONSTER) .setShouldReceiveVelocityUpdates(true).setTrackingRange(64).setUpdateInterval(3).setCustomClientFactory(CustomEntity::new) .size(0.6f, 1.8f)).build("babytiger").setRegistryName("babytiger"); public BabytigerEntity(RideableEntitiesModElements instance) { super(instance, 4); FMLJavaModLoadingContext.get().getModEventBus().register(new BabytigerRenderer.ModelRegisterHandler()); FMLJavaModLoadingContext.get().getModEventBus().register(new EntityAttributesRegisterHandler()); MinecraftForge.EVENT_BUS.register(this); } @Override public void initElements() { elements.entities.add(() -> entity); elements.items .add(() -> new SpawnEggItem(entity, -1, -1, new Item.Properties().group(ItemGroup.MISC)).setRegistryName("babytiger_spawn_egg")); } @SubscribeEvent public void addFeatureToBiomes(BiomeLoadingEvent event) { event.getSpawns().getSpawner(EntityClassification.MONSTER).add(new MobSpawnInfo.Spawners(entity, 20, 4, 4)); } @Override public void init(FMLCommonSetupEvent event) { EntitySpawnPlacementRegistry.register(entity, EntitySpawnPlacementRegistry.PlacementType.ON_GROUND, Heightmap.Type.MOTION_BLOCKING_NO_LEAVES, MonsterEntity::canMonsterSpawn); } private static class EntityAttributesRegisterHandler { @SubscribeEvent public void onEntityAttributeCreation(EntityAttributeCreationEvent event) { AttributeModifierMap.MutableAttribute ammma = MobEntity.func_233666_p_(); ammma = ammma.createMutableAttribute(Attributes.MOVEMENT_SPEED, 0.8); ammma = ammma.createMutableAttribute(Attributes.MAX_HEALTH, 10); ammma = ammma.createMutableAttribute(Attributes.ARMOR, 0); ammma = ammma.createMutableAttribute(Attributes.ATTACK_DAMAGE, 3); event.put(entity, ammma.create()); } } public static class CustomEntity extends CreatureEntity { public CustomEntity(FMLPlayMessages.SpawnEntity packet, World world) { this(entity, world); } public CustomEntity(EntityType<CustomEntity> type, World world) { super(type, world); experienceValue = 0; setNoAI(false); } @Override public IPacket<?> createSpawnPacket() { return NetworkHooks.getEntitySpawningPacket(this); } @Override protected void registerGoals() { super.registerGoals(); this.goalSelector.addGoal(1, new MeleeAttackGoal(this, 1.2, false)); this.goalSelector.addGoal(2, new RandomWalkingGoal(this, 1)); this.targetSelector.addGoal(3, new HurtByTargetGoal(this)); this.goalSelector.addGoal(4, new LookRandomlyGoal(this)); this.goalSelector.addGoal(5, new SwimGoal(this)); } @Override public CreatureAttribute getCreatureAttribute() { return CreatureAttribute.UNDEFINED; } @Override public net.minecraft.util.SoundEvent getHurtSound(DamageSource ds) { return (net.minecraft.util.SoundEvent) ForgeRegistries.SOUND_EVENTS.getValue(new ResourceLocation("entity.generic.hurt")); } @Override public net.minecraft.util.SoundEvent getDeathSound() { return (net.minecraft.util.SoundEvent) ForgeRegistries.SOUND_EVENTS.getValue(new ResourceLocation("entity.generic.death")); } @Override public ActionResultType func_230254_b_(PlayerEntity sourceentity, Hand hand) { ItemStack itemstack = sourceentity.getHeldItem(hand); ActionResultType retval = ActionResultType.func_233537_a_(this.world.isRemote()); super.func_230254_b_(sourceentity, hand); sourceentity.startRiding(this); return retval; } @Override public void travel(Vector3d dir) { Entity entity = this.getPassengers().isEmpty() ? null : (Entity) this.getPassengers().get(0); if (this.isBeingRidden()) { this.rotationYaw = entity.rotationYaw; this.prevRotationYaw = this.rotationYaw; this.rotationPitch = entity.rotationPitch * 0.5F; this.setRotation(this.rotationYaw, this.rotationPitch); this.jumpMovementFactor = this.getAIMoveSpeed() * 0.15F; this.renderYawOffset = entity.rotationYaw; this.rotationYawHead = entity.rotationYaw; this.stepHeight = 1.0F; if (entity instanceof LivingEntity) { this.setAIMoveSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED)); float forward = ((LivingEntity) entity).moveForward; float strafe = ((LivingEntity) entity).moveStrafing; super.travel(new Vector3d(strafe, 0, forward)); } this.prevLimbSwingAmount = this.limbSwingAmount; double d1 = this.getPosX() - this.prevPosX; double d0 = this.getPosZ() - this.prevPosZ; float f1 = MathHelper.sqrt(d1 * d1 + d0 * d0) * 4.0F; if (f1 > 1.0F) f1 = 1.0F; this.limbSwingAmount += (f1 - this.limbSwingAmount) * 0.4F; this.limbSwing += this.limbSwingAmount; return; } this.stepHeight = 0.5F; this.jumpMovementFactor = 0.02F; super.travel(dir); } } } ok thanks and for the people that want to copy paste here is the code
    • I did download the latest forge-1.18-38.0.6-installer and installed it correctly into the right place. Also downloaded  38.0.5 to test (didn't work) and downloaded 38.0.0 None of those worked.
    • Unknown module securejarhandler implies that some libraries were missed during the installation. I suggest you redownload the latest installer and run it again.
    • Forge Version: 38.0.6 Minecraft Version: 1.18 Downloads: Changelog: (Direct) Installer: (AdFocus) (Direct) MDK: (AdFocus) (Direct) However, as this is the start of a new version, it is recommended that you check the Downloads Page and use the latest version to receive any bug fixes. Intro: 1.17 was a stepping stone, and 1.18 is the real target. The culmination of the Caves & Cliffs update, with few real code changes from 1.17 except those required to plug in the new biome system. This is our new Latest version. As we had some time before the release, we handled some refactors beforehand. Those will be listed here. Changelog: Refactors (not comprehensive): 99% of the fmllegacy package. Most classes were simply moved from x.y.fmllegacy.z to x.y.z. All instances of Gui -> Screen (GuiOpenEvent -> ScreenOpenEvent, for example) GuiScreenEvent -> ScreenEvent, GuiOverlayDebugForge -> ForgeDebugScreenOverlay All instances of GameMode -> GameType (ClientPlayerChangeGameModeEvent -> ClientPlayerChangedGameTypeEvent, for example) All instances of MatrixStack -> PoseStack (DrawSelectionEvent.matrix -> DrawSelectionEvent.poseStack, for example All instances of KeyBinding -> KeyMapping (ClickInputEvent.keyBinding -> ClickInputEvent.keyMapping, for example All instances of World -> Level All instances of WorldType -> WorldPreset (ForgeHooksClient.getDefaultWorldType -> ForgeHooksClient.getDefaultWorldPreset, for example All instances of NBT -> Tag (BlockSnapshot.getNbt -> BlockSnapshot.getTag, for example) All instances of Container -> Menu (IForgeContainerType -> IForgeMenuType, for example) PlaySoundEvent.sound -> PlaySoundEvent.originalSound PlaySoundEvent.result -> PlaySoundEvent.sound SoundEvent.manager -> SoundEvent.engine SoundEvent.SoundSourceEvent.source -> SoundEvent.SoundSourceEvent.channel FOVUpdateEvent -> FOVModifierEvent EntityViewRenderEvent.FOVModiier -> EntityViewRenderEvent.FieldOfView InputUpdateEvent -> MovementInputUpdateEvent InitScreenEvent.{...Widget...} -> {...Listener...} ForgeItemTagsProvider.func_240521_a_Colored -> copyColored MobSpawnInfoBuilder -> MobSpawnSettingBuilder BasicTrade -> BasicItemListing ModelLoader -> ForgeModelBakery ForgeWorldTypeScreens -> ForgeWorldPresetEditors StackList -> MultItemValue Removals: Entire Animation API IForgeTextureAtlasSprite IForgeItem.{showDurabiityBar, getDurabilityForDisplay, getRGBDurabilityForDisplay} ForgeHooksClient.refreshResources ModelBuilder.gui3d BlockInfo.{updateShift, getShx, getShy, getShz} CapabilityInject CapabilityManager.register ConditionalAdvancement.processConditions IForgeItem.isShield IForgeStructureFeature.{getDefaultSpawnList, getDefaultCreatureSpawnList} Forge's Constants class VanillaResourceType ForgeHooksClient.worldRenderPass (+ accessor) ForgeHooksClient.{preDraw, postDraw, getColorIndex} ScrollPanel.drawBackground Screen.{RenderToolTip, RenderComponentToolTip} ResourceManager.getResourceType LootPool.bonusRolls ForgeConfig - selectiveResourceReload PotionEvent.PotionAddedEvent ClientHooks ModFileResourcePack ResourcePackLoader.getResourcePackFor ResourcePackLoader.IPackInfoFinder ServerLifecycleHooks.buildPackFinder IResourceType ReloadRequirements CommandSetDimension
    • This is the error that I'm getting. WARNING: Unknown module: cpw.mods.securejarhandler specified to --add-exports WARNING: Unknown module: cpw.mods.securejarhandler specified to --add-opens Exception in thread "main" java.lang.module.FindException: Module org.objectweb.asm.util not found, required by org.openjdk.nashorn at java.base/java.lang.module.Resolver.findFail(Resolver.java:893) at java.base/java.lang.module.Resolver.resolve(Resolver.java:192) at java.base/java.lang.module.Resolver.resolve(Resolver.java:141) at java.base/java.lang.module.Configuration.resolveAndBind(Configuration.java:492) at java.base/java.lang.module.Configuration.resolveAndBind(Configuration.java:298) at cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:83)   Tried various java versions,   8 and 16 to no avail. even tried bellsoft liberica full jre  and openjre   No clue what is going on and why there are such problems with Java now, seems like Oracle took their ball and wants to go home with the Java project. So many issues with various versions of it.  Any advice? Thanks,.
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.