Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.17.1] Villager Point of interest


AurenX
 Share

Recommended Posts

I had this working in 1.16 but the same method doesn't seem to have the same effect.

I have a new block that replaces the fletching table but this breaks the villager point of interest so no more fletchers.
In 1.16 i had this


public static void fixVillagerPOI(FMLCommonSetupEvent event) {
     Map<BlockState, PointOfInterestType> types = ReflectionHelper.getPrivateValue(PointOfInterestType.class, null, ASMAPI.mapField("field_221073_u"));
     Blocks.FLETCHING_TABLE.getStateContainer().getValidStates().forEach(s -> types.put(s, PointOfInterestType.FLETCHER));
}

field_221073_u no longer exists and, unless I don't understand, is now f_27323_ . while this does not give an error it also does not effect the villagers

Is there a new method to get villagers to become an existing type with a new block?

Link to comment
Share on other sites

7 hours ago, AurenX said:

So nothing at the moment to register villagers profession point of interests? Or just nothing for existing professions?

you can register them the same way you register Items, Blocks, etc.

Link to comment
Share on other sites

  • 4 weeks later...

Sorry for the delayed response i got busy with work.

I was able to get this working, with the gap between and my other bad habit of getting frustrated and deleting code that doesnt work i do not remember exactly what i did that did not work.
What i found was i had to create both a profession and a poitype and was not able to just override the poitype individually, this is probably what i was missing to be honest as the method i was using only needed the poi.

Thank you for the help you guys did provide.


note: The registry name for the profession uses minecraft so no new textures are needed
note: Was able to just pull trade data over but had to re-register that as well
note: Event subscription handled in other location but nothing special there

was able to get it working with Deferred registry

 

    public static final DeferredRegister<PoiType> POINT_OF_INTEREST_TYPES = DeferredRegister.create(ForgeRegistries.POI_TYPES, Reference.MOD_ID);
    public static final DeferredRegister<VillagerProfession> VILLAGER_PROFESSIONS = DeferredRegister.create(ForgeRegistries.PROFESSIONS, "minecraft");
    
    public static final RegistryObject<PoiType> FLETCHER_POI = POINT_OF_INTEREST_TYPES.register("fletcher", () -> new PoiType("fletcher", PoiType.getBlockStates(BlockHandler.FletchingTable), 1, 1));
    public static final RegistryObject<VillagerProfession> FLETCHER = VILLAGER_PROFESSIONS.register("fletcher", () -> new VillagerProfession("fletcher", FLETCHER_POI.get(), ImmutableSet.of(), ImmutableSet.of(Blocks.FLETCHING_TABLE), SoundEvents.VILLAGER_WORK_FLETCHER));
    
    public static void commonSetup(FMLCommonSetupEvent event) {
        event.enqueueWork(() -> {
            VillagerHandler.tradeData();
            VillagerHandler.registerFletherPOI();
        });
    }

    public static void registerFletherPOI() {
        try {
            ObfuscationReflectionHelper.findMethod(PoiType.class, "registerBlockStates", PoiType.class).invoke(null, FLETCHER_POI.get());
        } catch (InvocationTargetException | IllegalAccessException e) {
            e.printStackTrace();
        }
    }
    
    private static void tradeData() {
        VillagerTrades.TRADES.put(FLETCHER.get(), VillagerTrades.TRADES.get(VillagerProfession.FLETCHER));
    }



I was also able to get normal registry working with 

 


    public static final PoiType FLETCHER_POI = new PoiType("fletcher", PoiType.getBlockStates(BlockHandler.FletchingTable), 1, 1);
    public static final VillagerProfession FLETCHER = new VillagerProfession("fletcher", FLETCHER_POI, ImmutableSet.of(), ImmutableSet.of(Blocks.FLETCHING_TABLE), SoundEvents.VILLAGER_WORK_FLETCHER);
    
    public static void setupPOIType(Register<PoiType> event) {
        event.getRegistry().register(FLETCHER_POI.setRegistryName(Reference.MOD_ID, "fletcher"));
    }
    
    public static void setupProffessions(Register<VillagerProfession> event) {
        event.getRegistry().register(FLETCHER.setRegistryName("minecraft", "fletcher"));
    }
    
    private static void tradeData() {
        VillagerTrades.TRADES.put(FLETCHER, VillagerTrades.TRADES.get(VillagerProfession.FLETCHER));
    }
 
    public static void commonSetup(FMLCommonSetupEvent event) {
        VillagerHandler.tradeData();
    }
    }

Edited by AurenX
Link to comment
Share on other sites

10 hours ago, AurenX said:

I was also able to get normal registry working with 

This is not correct! When using normal registry events you must create the registry entries in the RegistryEvent handler and use @ObjectHolder (or RegistryObject) to inject the objects into the fields.

Link to comment
Share on other sites

I mean must is a strong word when this is functional.

"Should" yes probably 

But as a hey this worked and I'm going to optimize it after then I'll stick with yes "I got it working"

Edited by AurenX
Link to comment
Share on other sites

You must have a licence to drive a car. "Must is a strong word, the car runs without it".

Just because it works doesn't mean that it won't cause you problems down the line. And if you do it correctly from the start, you won't have to spend the time finding and fixing bugs later on.

Link to comment
Share on other sites

1 hour ago, Alpvax said:

You must have a licence to drive a car. "Must is a strong word, the car runs without it".

Just because it works doesn't mean that it won't cause you problems down the line. And if you do it correctly from the start, you won't have to spend the time finding and fixing bugs later on.

Yes but when proving a proof of concept you don't drive on the open road so no a license technically isn't needed as they would use a test track or heck test parts individually before assembly. And a poor example as a working car and a street legal car are different; there are concept cars, race cars, plastic cars for kids, etc.

So when I am just starting to update mods to a newer version of forge and enough changed that a proof of concept test mod is advisable then no doing it perfect is not needed and instead just a waste.

Yes when updating the actual mod you should I stated that above. Again all I showed was that I got it working, not hey here is this perfect thing all learn from me as I am the smart perfect person.

Again I will say, it works fine how it is. And again I will say yes you should use object holders. But saying needed is wrong.

If you would like to provide people with a "here is the proper way to code this" instead of an example that "works" then go ahead and post it. I have no more need of advancing this as I have learned what I needed to from it.

22 hours ago, diesieben07 said:

This is why we can't have nice things.

I probably shouldn't show you how I work with blocks and items when I just need to bulk create things ;)

Edited by AurenX
Link to comment
Share on other sites

13 minutes ago, AurenX said:

Again I will say, it works fine how it is.

It does not.

13 minutes ago, AurenX said:

But saying needed is wrong.

It is not.

13 minutes ago, AurenX said:

If you would like to provide people with a "here is the proper way to code this" instead of an example that "works" then go ahead and post it. I have no more need of advancing this as I have learned what I needed to from it.

Proper registry usage is explained in the documentation: https://mcforge.readthedocs.io/en/latest/concepts/registries/.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Minecraft 1.16 requires java 8-15, you currently using java 16, downgrade your java to 8-15 and the problem should be fixed.
    • Hi So Im trying to set up a Server for 1.16.4 now but when I go to launch it doesn't work, Im using the Life in the Village 2 server pack thats already pre-made but it still wont launch no matter what I try. If I can get some help that would be great thanks. D:\Modded Mc\LITV2-Serverpack-1.28a\LITV2-Serverpack-1.28a>java -Xmx4G -jar forge-1.16.5-36.2.4.jar nogui 2021-11-29 13:43:08,050 main WARN Advanced terminal features are not available in this environment [13:43:08] [main/INFO] [cp.mo.mo.Launcher/MODLAUNCHER]: ModLauncher running: args [--gameDir, ., --launchTarget, fmlserver, --fml.forgeVersion, 36.2.4, --fml.mcpVersion, 20210115.111550, --fml.mcVersion, 1.16.5, --fml.forgeGroup, net.minecraftforge, nogui] [13:43:08] [main/INFO] [cp.mo.mo.Launcher/MODLAUNCHER]: ModLauncher 8.0.9+86+master.3cf110c starting: java version 16.0.2 by Oracle Corporation Exception in thread "main" java.lang.IllegalAccessError: class cpw.mods.modlauncher.SecureJarHandler (in unnamed module @0x4de5031f) cannot access class sun.security.util.ManifestEntryVerifier (in module java.base) because module java.base does not export sun.security.util to unnamed module @0x4de5031f at cpw.mods.modlauncher.SecureJarHandler.lambda$static$1(SecureJarHandler.java:41) at cpw.mods.modlauncher.api.LamdbaExceptionUtils.uncheck(LamdbaExceptionUtils.java:95) at cpw.mods.modlauncher.SecureJarHandler.<clinit>(SecureJarHandler.java:41) at cpw.mods.modlauncher.Launcher.lambda$new$6(Launcher.java:55) at java.base/java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1708) at cpw.mods.modlauncher.api.TypesafeMap.computeIfAbsent(TypesafeMap.java:52) at cpw.mods.modlauncher.api.TypesafeMap.computeIfAbsent(TypesafeMap.java:47) at cpw.mods.modlauncher.Environment.computePropertyIfAbsent(Environment.java:62) at cpw.mods.modlauncher.Launcher.<init>(Launcher.java:55) at cpw.mods.modlauncher.Launcher.main(Launcher.java:66) at net.minecraftforge.server.ServerMain$Runner.runLauncher(ServerMain.java:63) at net.minecraftforge.server.ServerMain$Runner.access$100(ServerMain.java:60) at net.minecraftforge.server.ServerMain.main(ServerMain.java:57) D:\Modded Mc\LITV2-Serverpack-1.28a\LITV2-Serverpack-1.28a>pause Press any key to continue . . .  
    • Still waiting on the issue.
    • Registering in static fields isn't ideal. You have a method that registers your deferred register to the event bus, right? leave your RegistryObject fields as non-final and empty, and set their reference in that method, right after registering the deferred register on the bus.
    • This is my event: p.s i tried the subclasses.   Above this line, I am also registering my GUI event listener with RenderGameOverlay, which works fine.  
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.