Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.16.4]After worldGen, remove block and drop its item


Cratthorax
 Share

Recommended Posts

Good evening,

I'm using a NoFeature generator to spawn block types of ores, that resemble deposits at lower layers. Right now they look the same as the ore blocks some levels lower, but I actually want them to exist as items on the surface.

In the past I was utilizing onBlockAdded(), and dropBlockAsItem() directly inside my blocks to do exactly that, but this does no longer seem to be an option, because any of the block methods, that handle "BlockAdded" logic can't be used during world generation, when starting a new game. Which is unfortunate to say the least.

The problem I'm facing right now: dropping an item from block after it is placed in the world, without player interaction, doesn't seem to be an option either or I just fail to find it. At least none of the block or item .classes contain anything useful.

Can someone direct me where to look, please?

Link to comment
Share on other sites

3 hours ago, diesieben07 said:

My question would, why you're even spawning a block in the first place, if you're just gonna remove it immediately anyways? You can spawn entities during worldgen, too.

Because I was used to doing it like that in the past. Also, a block is very sparse in code quantity. Also, also, I would use the blocks to check against blocks of same type at lower levels, to mark as an indicator to what can be found digging deeper into the ground. Doing that with anything but the same object type is just unnecessarily bloating code.

However, I had to use creative ways to get something working. What I did was rendering my block and its voxel shape invisible, make it nonsolid and notBlockMovement, then apply the randomTick() method, and using this: worldIn.destroyBlock(pos, true);...which basically drops the item after the blocks gets randomly destroyed.

The good thing about that is, with the new DataPack function, I can do all that stuff with a single block object, and then just use instances of other block registers and their properties. I can also customize the loot tables for any of them, but don't need an actual block.class for any of them. Given how I have more then 60 ore blocks in my old mod, that is a really great thing about newer MC versions.

The final solution was actually found in vanilla Block.AIR, after messing around with various methods, none of them doing what was easily done in the past MC versions with onBlockAdded(), and dropBlockAsItem(). I'll just leave the block code, and register code here for reference, which should give you a picture of the many things I was trying without success:

 
	public class BlockRock extends Block implements IWaterLoggable {
    
    public static final BooleanProperty WATERLOGGED = BlockStateProperties.WATERLOGGED;
    PlayerEntity player;
	    public BlockRock() {
        super(Properties.create(Material.ROCK, MaterialColor.STONE)
                .hardnessAndResistance(3.0F, 30.0F).sound(SoundType.STONE).doesNotBlockMovement()
                .notSolid()/*.harvestLevel(3)
                .harvestTool(ToolType.PICKAXE)*/.tickRandomly());
        this.setDefaultState(this.stateContainer.getBaseState().with(WATERLOGGED, Boolean.FALSE));
    }
	    @Override
    public BlockState getStateForPlacement(BlockItemUseContext context) {
        if (context.getWorld().getBlockState(context.getPos()).getBlock() == Blocks.WATER) {
            return this.getDefaultState().with(WATERLOGGED, Boolean.TRUE);
        }
        return this.getDefaultState();
    }
    
    @Override
    public BlockRenderType getRenderType(BlockState state) {
        return BlockRenderType.INVISIBLE;
    } 
    
    @Override
    public VoxelShape getShape(BlockState state, IBlockReader worldIn, BlockPos pos, ISelectionContext context) {
        return VoxelShapes.empty();
    }
	    @Override
    public void onFallenUpon(World worldIn, BlockPos pos, Entity entityIn, float fallDistance) {
        super.onFallenUpon(worldIn, pos, entityIn, fallDistance);
        // One in ten chance for the sample to break when fallen on
        Random random = new Random();
        if (((int) fallDistance) > 0) {
            if (random.nextInt((int) fallDistance) > 5) {
                worldIn.destroyBlock(pos, true);
            }
        }
    }
	    @Override
    public ActionResultType onBlockActivated(BlockState state, World worldIn, BlockPos pos,
            PlayerEntity player, Hand handIn, BlockRayTraceResult hit) {
        if (!player.isCrouching()) {
            worldIn.destroyBlock(pos, true);
            player.swingArm(handIn);
            return ActionResultType.SUCCESS;
        }
        return ActionResultType.PASS;
    }
	    @Override
    public boolean isValidPosition(BlockState state, IWorldReader worldIn, BlockPos pos) {
        return hasEnoughSolidSide(worldIn, pos.down(), Direction.UP);
    }
	    @Override
    protected void fillStateContainer(StateContainer.Builder<Block, BlockState> builder) {
        builder.add(WATERLOGGED);
    }
    @Override
    @Nonnull
    @SuppressWarnings("deprecation")
    public FluidState getFluidState(BlockState state) {
        return state.get(WATERLOGGED) ? Fluids.WATER.getStillFluidState(false)
                : super.getFluidState(state);
    }
	    @Override
    @SuppressWarnings("deprecation")
    public void neighborChanged(BlockState state, World worldIn, BlockPos pos, Block blockIn,//pos is your block, fromPos is a neighboring block
            BlockPos fromPos, boolean isMoving) {
        //System.out.println(blockIn.toString() + state.getBlockState() + worldIn.getBlockState(pos) + worldIn.getBlockState(fromPos));
        super.neighborChanged(state, worldIn, pos, blockIn, fromPos, isMoving);
        if (!this.isValidPosition(state, worldIn, pos)) {
            worldIn.destroyBlock(pos, true);
        }
        else if (state.get(WATERLOGGED)) {
            worldIn.getPendingFluidTicks().scheduleTick(pos, Fluids.WATER,
                    Fluids.WATER.getTickRate(worldIn));
        }
    }
	    public BlockState asWaterlogged() {
        return this.getDefaultState().with(WATERLOGGED, Boolean.TRUE);
    }
	    @Override
    public boolean isReplaceable(BlockState state, BlockItemUseContext useContext) {
        if (useContext.getItem().getItem() instanceof BlockItem) {
            if (((BlockItem) useContext.getItem().getItem()).getBlock() instanceof BlockRock) {
                return false;
            }
        }
        return ConfigSpecHandler.ARE_ROCKS_REPLACEABLE.get();
    }
    
    @Override
    @SuppressWarnings("resource")
    @Deprecated
    public void randomTick(BlockState state, ServerWorld worldIn, BlockPos pos, Random random) {
        
        player = Minecraft.getInstance().player;
        if (!worldIn.isRemote && player != null) {
                
            worldIn.destroyBlock(pos, true);
            System.out.println(this.getBlock().toString() + " destroyed!");
            state.tick(worldIn, pos, worldIn.rand); 
            worldIn.getPendingBlockTicks().scheduleTick(pos, this, 1);
        }
    }
    
    @Override
    public void onBlockAdded(BlockState state, World worldIn, BlockPos pos, BlockState oldState, boolean isMoving) {
        worldIn.getPendingBlockTicks().scheduleTick(pos, this, 1);
    }  
    
    public void tick(BlockState state, ServerWorld worldIn, BlockPos pos, Random rand) {
        worldIn.getPendingBlockTicks().scheduleTick(pos, this, 1);//MathHelper.nextInt(rand, 1, 1));
     }
    
    /*@Override
    @SuppressWarnings({ "deprecation", "resource" })
    public BlockState updatePostPlacement(BlockState stateIn, Direction facing, BlockState facingState, IWorld worldIn, BlockPos currentPos, BlockPos facingPos) {
        
        player = Minecraft.getInstance().player;
        if (!this.isValidPosition(stateIn, worldIn, currentPos)) {
            worldIn.getPendingBlockTicks().scheduleTick(currentPos, this, 1);
        }
        
        if(player == null) {
            
            return this.getDefaultState();
        
        } else if (player != null && !worldIn.isRemote()) {
                
            if(worldIn.isBlockLoaded(currentPos)) {
                worldIn.destroyBlock(currentPos, true);
                System.out.println(this.getBlock().toString() + " destroyed!");
                return this.getDefaultState();
            }
        }
        return this.getDefaultState();
    } */   
	}
 
public class RegisterRocks {
	
    public static HashMap<Block, Block> blocksToRocks = new HashMap<>();
    private static ArrayList<Block> matLibBlocks = new ArrayList<>();

    private static void registerRocks(String modid, String path) {
        ResourceLocation oreRL = new ResourceLocation(modid, path);
        ResourceLocation rockRL = new ResourceLocation(MatLibMain.MODID,
                (modid.toLowerCase() == "minecraft" ? "" : ("")) + path + "rock");
        Block blocks = ForgeRegistries.BLOCKS.getValue(oreRL);

        if (blocks != null && blocks != Blocks.AIR) {
            Block blockRock = new BlockRock().setRegistryName(rockRL);
            matLibBlocks.add(blockRock);
            blocksToRocks.put(blocks, blockRock);
        } else {
        	//ConfigDebug.debug("Missing replacer, no rocks placed!");
        }
    }

    public static void registerBlocks(final RegistryEvent.Register<Block> blockRegistryEvent) {
        
        //minecraft
    	registerRocks("minecraft", "andesite");
    	registerRocks("minecraft", "diorite");
    	registerRocks("minecraft", "granite");
    	registerRocks("minecraft", "sandstone");
    	registerRocks("minecraft", "red_sandstone");
        
    	//matlib
    	registerRocks("matlib", "blockbasalt");
    	registerRocks("matlib", "blockbluestone");
    	registerRocks("matlib", "blockdiabase");
        //registerRocks("matlib", "blockgranite");
    	registerRocks("matlib", "blocklimestone");
    	registerRocks("matlib", "blockmarble");
    	registerRocks("matlib", "blockquartzite");
        //registerRocks("matlib", "blocksandstone");
    	registerRocks("matlib", "blockslate");
    	registerRocks("matlib", "blocktuff");

        for (Block block : matLibBlocks) {
            blockRegistryEvent.getRegistry().register(block);
        }
    }

    public static void registerBlockItems(final RegistryEvent.Register<Item> itemRegistryEvent) {
        for (Block block : matLibBlocks) {
            if (block instanceof BlockRock) {
                Item iBlock = new BlockRockItem(block)
                        .setRegistryName(Objects.requireNonNull(block.getRegistryName()));
                itemRegistryEvent.getRegistry().register(iBlock);
            } else {
                Item iBlock = new BlockItem(block,
                        new Item.Properties().group(RegisterMain.MATLIB_GROUP))
                                .setRegistryName(Objects.requireNonNull(block.getRegistryName()));
                itemRegistryEvent.getRegistry().register(iBlock);
            }
        }
    }
}

 

Edited by Cratthorax
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • These are my particle effect classes, they are all copied from a tutorial.   public class Juan1ParticalType extends ParticleType { public Juan1ParticalType() { super(false, Juan1ParticalData.DESERIALIZER); } @Override public Codec<Juan1ParticalData> func_230522_e_() { return Codec.unit(new Juan1ParticalData(new Vector3d(0, 0, 0), new Color(0xF63900), 0)); } }   public class Juan1ParticalData implements IParticleData { private final Vector3d speed; private final Color color; private final float diameter; public static final IDeserializer<Juan1ParticalData> DESERIALIZER = new IDeserializer<Juan1ParticalData>() { @Override public Juan1ParticalData deserialize(ParticleType<Juan1ParticalData> particleTypeIn, StringReader reader) throws CommandSyntaxException { final int MIN_COLOUR = 0; final int MAX_COLOUR = 255;reader.expect(' '); double speedX = reader.readDouble(); reader.expect(' '); double speedY = reader.readDouble(); reader.expect(' '); double speedZ = reader.readDouble(); reader.expect(' '); int red = MathHelper.clamp(reader.readInt(), MIN_COLOUR, MAX_COLOUR); reader.expect(' '); int green = MathHelper.clamp(reader.readInt(), MIN_COLOUR, MAX_COLOUR); reader.expect(' '); int blue = MathHelper.clamp(reader.readInt(), MIN_COLOUR, MAX_COLOUR);reader.expect(' ');  int alpha = MathHelper.clamp(reader.readInt(), 1, MAX_COLOUR);reader.expect(' '); float diameter = reader.readFloat();  return new Juan1ParticalData(new Vector3d(speedX, speedY, speedZ), new Color(red, green, blue, alpha), diameter); } @Override public Juan1ParticalData read(ParticleType<Juan1ParticalData> particleTypeIn, PacketBuffer buffer) { final int MIN_COLOUR = 0; final int MAX_COLOUR = 255; double speedX = buffer.readDouble(); double speedY = buffer.readDouble(); double speedZ = buffer.readDouble(); int red = MathHelper.clamp(buffer.readInt(), MIN_COLOUR, MAX_COLOUR); int green = MathHelper.clamp(buffer.readInt(), MIN_COLOUR, MAX_COLOUR); int blue = MathHelper.clamp(buffer.readInt(), MIN_COLOUR, MAX_COLOUR); int alpha = MathHelper.clamp(buffer.readInt(), 1, MAX_COLOUR); float diameter = buffer.readFloat(); return new Juan1ParticalData(new Vector3d(speedX, speedY, speedZ), new Color(red, green, blue, alpha), diameter); } }; public Juan1ParticalData(Vector3d speed, Color color, float diameter) { this.speed = speed; this.color = color; this.diameter = diameter; } @Override public ParticleType<?> getType() { return Utils.ParticleRegistry.JUAN_1_PARTICLE.get(); } @Override public void write(PacketBuffer buffer) { buffer.writeDouble(this.speed.x); buffer.writeDouble(this.speed.y); buffer.writeDouble(this.speed.z); buffer.writeInt(this.color.getRed()); buffer.writeInt(this.color.getGreen()); buffer.writeInt(this.color.getBlue()); buffer.writeInt(this.color.getAlpha()); buffer.writeFloat(this.diameter); } @Override public String getParameters() { return String.format(Locale.ROOT, "%s %.2f %i %i %i %i %.2d %.2d %.2d", this.getType().getRegistryName(), diameter, color.getRed(), color.getGreen(), color.getBlue(), color.getAlpha(), speed.getX(), speed.getY(), speed.getZ()); } public Vector3d getSpeed() { return speed; } public Color getColor() { return color; } public float getDiameter() { return diameter; } }   public class Juan1Particle extends SpriteTexturedParticle { public Juan1Particle(ClientWorld world, double x, double y, double z, Vector3d speed, Color color, float diameter) { super(world, x, y, z, speed.x, speed.y, speed.z); maxAge = 100; setColor(color.getRed() / 255F,color.getGreen() / 255F,color.getBlue() / 255); this.setAlphaF(color.getAlpha()); final float PARTICLE_SCALE_FOR_ONE_METER = 0.1F; particleScale = PARTICLE_SCALE_FOR_ONE_METER * diameter; this.canCollide = true; } @Override public IParticleRenderType getRenderType(){ return IParticleRenderType.PARTICLE_SHEET_TRANSLUCENT; } }   public class Juan1ParticleFactory implements IParticleFactory<Juan1ParticalData> { private final IAnimatedSprite sprites; public Juan1ParticleFactory(IAnimatedSprite sprite) { this.sprites = sprite; } @Override public Particle makeParticle(Juan1ParticalData typeIn, ClientWorld worldIn, double x, double y, double z, double xSpeed, double ySpeed, double zSpeed) { Juan1Particle particle = new Juan1Particle(worldIn, x, y, z, typeIn.getSpeed(), typeIn.getColor(), typeIn.getDiameter()); particle.selectSpriteWithAge(sprites); return particle; } }
    • This is where I want to call the addParticle() method, it is in the livingTick() in an entity. But it shows no particle effect. @Override public void livingTick() { double x = rand.nextGaussian() * 0.02D; double y = rand.nextGaussian() * 0.02D; double z = rand.nextGaussian() * 0.02D; double px = this.getPosX() + 4.0D * rand.nextDouble() - 2.0D; double py = this.getPosY() + rand.nextDouble() - 0.5D; double pz = this.getPosZ() + 4.0D * rand.nextDouble() - 2.0D; world.addParticle(new Juan1ParticalData(new Vector3d(x, y, z), new Color(0xae6be2), 0), px, py, pz, x, y, z);  } When I change "new Juan1ParticalData(new Vector3d(x, y, z), new Color(0xae6be2), 0)" to "ParticleTypes.DRAGON_BREATH" , the particle effects appeared.
    • can you get any useful info from your crash reports?
    • I made a particle effect of my own, and I can only display the particle effect in the game through the command : /particle mymod:juan1particle 0 0 0 0 0 255 100 3.   When I want add the particle through World.addParticle(IParticleData particleData, double x, double y, double z, double xSpeed, double ySpeed, double zSpeed), it does not show at all.   But when I change the particleData Parameter from my particledata's instance to those in the ParticleTypes in the vanilla, It works without problem. So it seems that only my particle effect can't be added into the game, but those in the vanilla can be added.
    • Ok, so, that's really helpful. I guess i need to learn how to make a custom sound instance for my sound.
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.