Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

Issue with capability


matthew123
 Share

Recommended Posts

This is my capability provider.

public class MyCapabilityProvider implements ICapabilitySerializable<INBT> {
    @CapabilityInject(IMyCapability.class)
    public static Capability<IMyCapability> My_CAPABILITY = null;

    private final LazyOptional<IMyCapability> lazyOptional = LazyOptional.of(MyCapability::new);

    @Nonnull
    @Override
    public <T> LazyOptional<T> getCapability(@Nonnull Capability<T> capability, @Nullable Direction side) {
        if (capability == My_CAPABILITY) {
            return lazyOptional.cast();
        }
        return LazyOptional.empty();
    }

    @Override
    public INBT serializeNBT() {
        return My_CAPABILITY.getStorage().writeNBT(My_CAPABILITY, lazyOptional.orElseThrow(() -> new IllegalArgumentException("LazyOptional must not be empty!")), null);
    }

    @Override
    public void deserializeNBT(INBT nbt) {
        My_CAPABILITY.getStorage().readNBT(My_CAPABILITY, lazyOptional.orElseThrow(() -> new IllegalArgumentException("LazyOptional must not be empty!")), null, nbt);
    }
}

 

The issue is that the values written to the disk are the default values for my capability data. I added some logging to the storage class, and this confirms it.

Why is that happening? 

Link to comment
Share on other sites

3 minutes ago, diesieben07 said:

Show where you are changing the values.

I am actually changing it in many places. My interface accesses the capability on the player to draw it.

This is where it gets updated on the server:

public static void handlePacket(ClientSyncOverlayMessage message, Supplier<NetworkEvent.Context> ctx) {
    LogManager.getLogger().info("Got sync overlay message! Selected: " + message.getSelectedTechnique().getId() + " nature: " + message.getSelectedTechnique().getNature());

    ServerPlayerEntity playerEntity = ctx.get().getSender();
    playerEntity.getCapability(TechniqueCapabilityProvider.Technique_CAPABILITY).ifPresent(TechniqueCapability -> {
       
        TechniqueCapability.setSelectedTechniqueFor(message.getSelectedTechnique().getNature(), message.getSelectedTechnique());
        LOGGER.info("Updated selected Technique to " + message.getSelectedTechnique().getId() + ", power level: " + message.getSelectedTechnique().getPower());
        LOGGER.info("PW after update: " + TechniqueCapability.getSelectedTechniqueFor(TechniqueCapability.getSelectedNatureOrDefault()).getPower());
    });
}

P.S i renamed the capability to TechniqueCapability in this example.

Edited by matthew123
Link to comment
Share on other sites

12 hours ago, diesieben07 said:

Examples are not useful, as the issue is with your code, not with some example.

Is this code executed? Does it do the correct thing?

The code above is used to synchronize the capability on the server. The correct values are printed out by the logger, but when I check the values with NBTExplorer, they are the default ones. Thus, when re-joining the singleplayer world, the capability has the default values.

Link to comment
Share on other sites

 

17 hours ago, diesieben07 said:

Show where you are changing the values.

private static int executeCommand(CommandContext<CommandSource> commandContext) throws CommandSyntaxException {
    Entity entity = commandContext.getSource().getEntity();
    TranslationTextComponent finalText = new TranslationTextComponent("chat.type.announcement",
            commandContext.getSource().getDisplayName(), new StringTextComponent("ok"));
    commandContext.getSource().getServer().getPlayerList().broadcastMessage(finalText, ChatType.CHAT, entity.getUUID());
        ServerPlayerEntity playerEntity =  commandContext.getSource().getPlayerOrException();
        playerEntity.getCapability(AbilityCapabilityProvider.Ability_CAPABILITY).ifPresent(AbilityData -> {
            AbilityData.addAbility(NatureTypes.A, new AbilityData(NatureTypes.A, "mymod:a", 0, 0, 1));
            AbilityData.addAbility(NatureTypes.A, new AbilityData(NatureTypes.A, "mymod:b", 0, 0, 1));
            AbilityData.addAbility(NatureTypes.B, new AbilityData(NatureTypes.B, "mymod:c", 0, 0, 1));
            AbilityData.addAbility(NatureTypes.B, new AbilityData(NatureTypes.B, "mymod:d", 0, 0, 1));
            AbilityData.addAbility(NatureTypes.D, new AbilityData(NatureTypes.D, "mymod:e", 0, 0, 1));
            AbilityData.addAbility(NatureTypes.E, new AbilityData(NatureTypes.E, "mymod:f", 0, 0, 1));
            ModNetwork.sendTo(new ServerSyncAbilityMessage(AbilityData), playerEntity);
            ModNetwork.sendTo(new ServerSyncPowerMessage(42, 42), playerEntity);
        });
    return 1;
}

 

Link to comment
Share on other sites

From what I can tell it functions correctly.

Your NBT format is absolutely bizarre though:

  • Why on earth is "Selected Nature" in the same compound tag as all the Jutsu data?
  • Why are you using spaces in the keys?
  • Why on earth did you decide that putting "[SELECTED] " in front of the key was a good way to mark an entry as selected instead of just... you know... a boolean?
  • Why on earth does JutsuData.serialize / deserialize use a random ad-hoc string format instead of, you know, serializing its values to a NBT compound tag?
Link to comment
Share on other sites

12 hours ago, diesieben07 said:

From what I can tell it functions correctly.

Your NBT format is absolutely bizarre though:

  • Why on earth is "Selected Nature" in the same compound tag as all the Jutsu data?
  • Why are you using spaces in the keys?
  • Why on earth did you decide that putting "[SELECTED] " in front of the key was a good way to mark an entry as selected instead of just... you know... a boolean?
  • Why on earth does JutsuData.serialize / deserialize use a random ad-hoc string format instead of, you know, serializing its values to a NBT compound tag?

I am not sure how to serialize all of it to NBT. When my data was only using integers, I used an integer array, but that is not possible now. Could you show me how? Also, do you have recommendations on the capability? I believe that my current approach is very messy.

Link to comment
Share on other sites

An issue still persists. It appears as if the power level is the only thing that is not serializing. The selected nature AND selected jutsu seems to be synchronizing fine, but the power level does not, even though it is clearly updated:

NZRzgqo.png

4HZ03gL.png

 

nuwdyJ1.png

 

Jorum9U.png

The selected jutsu seems to work fine, as indicated by that bool and in-game testing. Thus, I added logging in the exact place the jutsu serializes it's power level:

vwA2AEK.png

And then after updating values:

xtQxUTg.png

 

What the hell is going on?! I am at a loss. Why is everything else working but that integer?

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • For anyone looking here in the future, I never solved this problem, but I found a workaround by simply ungrabbing the mouse, preventing mouse movement.
    • [Info: 2022-01-23 01:24:44.6727079: NetQueue.cpp(157)] NetQueue: Setting up. [Info: 2022-01-23 01:24:44.6754351: mainWindows.cpp(80)] Running launcher bootstrap (version 1037) [Info: 2022-01-23 01:24:44.6753897: NetQueue.cpp(575)] NetQueue: worker thread started. [Error: 2022-01-23 01:24:44.8622618: localization.cpp(110)] No translation found for "Unable to download <game>. Please try again later." [Error: 2022-01-23 01:24:44.8624151: localization.cpp(110)] No translation found for "Unable to download the <game> Native Launcher." [Error: 2022-01-23 01:24:44.8625217: localization.cpp(110)] No translation found for "Unable to update the <game> Game Launcher." [Error: 2022-01-23 01:24:44.8626168: localization.cpp(110)] No translation found for "Unable to download the <game> Runtime Environment." [Error: 2022-01-23 01:24:44.8626822: localization.cpp(110)] No translation found for "Unable to update the <game> Game Launcher." [Error: 2022-01-23 01:24:44.8627756: localization.cpp(110)] No translation found for "Unable to update the <game> Runtime Environment." [Error: 2022-01-23 01:24:44.8629294: localization.cpp(110)] No translation found for "Unable to update the <game> Native Launcher." [Error: 2022-01-23 01:24:44.8630314: localization.cpp(110)] No translation found for "Unable to relaunch the Minecraft bootstrap." [Error: 2022-01-23 01:24:44.8630933: localization.cpp(110)] No translation found for "Unable to start the <game> Runtime Environment. This is most likely caused by a corruption. Please try to reinstall <game>." [Error: 2022-01-23 01:24:44.8632362: localization.cpp(110)] No translation found for "Unable to start <game>, if you are running from a dmg, please drag to Applications and try again." [Error: 2022-01-23 01:24:44.8633546: localization.cpp(110)] No translation found for "Unable to initialize the network library." [Error: 2022-01-23 01:24:44.8634209: localization.cpp(110)] No translation found for "<game> Launcher" [Info: 2022-01-23 01:24:44.8668528: mainWindows.cpp(167)] Triggering reopen event... [Info: 2022-01-23 01:24:44.8670715: mainWindows.cpp(170)] Success         [Info: 2022-01-23 01:24:44.6727079: NetQueue.cpp(157)] NetQueue: Setting up. [Info: 2022-01-23 01:24:44.6754351: mainWindows.cpp(80)] Running launcher bootstrap (version 1037) [Info: 2022-01-23 01:24:44.6753897: NetQueue.cpp(575)] NetQueue: worker thread started. [Error: 2022-01-23 01:24:44.8622618: localization.cpp(110)] No translation found for "Unable to download <game>. Please try again later." [Error: 2022-01-23 01:24:44.8624151: localization.cpp(110)] No translation found for "Unable to download the <game> Native Launcher." [Error: 2022-01-23 01:24:44.8625217: localization.cpp(110)] No translation found for "Unable to update the <game> Game Launcher." [Error: 2022-01-23 01:24:44.8626168: localization.cpp(110)] No translation found for "Unable to download the <game> Runtime Environment." [Error: 2022-01-23 01:24:44.8626822: localization.cpp(110)] No translation found for "Unable to update the <game> Game Launcher." [Error: 2022-01-23 01:24:44.8627756: localization.cpp(110)] No translation found for "Unable to update the <game> Runtime Environment." [Error: 2022-01-23 01:24:44.8629294: localization.cpp(110)] No translation found for "Unable to update the <game> Native Launcher." [Error: 2022-01-23 01:24:44.8630314: localization.cpp(110)] No translation found for "Unable to relaunch the Minecraft bootstrap." [Error: 2022-01-23 01:24:44.8630933: localization.cpp(110)] No translation found for "Unable to start the <game> Runtime Environment. This is most likely caused by a corruption. Please try to reinstall <game>." [Error: 2022-01-23 01:24:44.8632362: localization.cpp(110)] No translation found for "Unable to start <game>, if you are running from a dmg, please drag to Applications and try again." [Error: 2022-01-23 01:24:44.8633546: localization.cpp(110)] No translation found for "Unable to initialize the network library." [Error: 2022-01-23 01:24:44.8634209: localization.cpp(110)] No translation found for "<game> Launcher" [Info: 2022-01-23 01:24:44.8668528: mainWindows.cpp(167)] Triggering reopen event... [Info: 2022-01-23 01:24:44.8670715: mainWindows.cpp(170)] Success                 that is everything in my .minecraft launcher_log.txt          
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.