Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

Specifying potion type for input in brewing recipe


DerpyNinjaFrog
 Share

Recommended Posts

Hello, I'm trying to figure out how to specify the type of potion for the input of a brewing recipe. I can get the recipe to work with the basic Items.POTION but then you can use any potion for the input. I think you have to use NBT data but what I have currently doesn't seem to be working (it simply won't let you brew the recipe at all). I've seen some people using a different way of creating brewing recipes by creating a implementation of IBrewingRecipe, do I need to do that or is there a way to do it the way I have it now and I'm just missing something? (I made a getPotion() function to get an instance of the potion ItemStack with the NBT tag for the type of potion)

package com.derpyninjafrog.worldoffood.init;

import com.derpyninjafrog.worldoffood.WorldOfFood;
import com.derpyninjafrog.worldoffood.effects.Nourished;
import net.minecraft.item.ItemStack;
import net.minecraft.item.Items;
import net.minecraft.item.crafting.Ingredient;
import net.minecraft.nbt.CompoundNBT;
import net.minecraft.potion.*;
import net.minecraftforge.common.brewing.BrewingRecipeRegistry;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.RegistryObject;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber.Bus;
import net.minecraftforge.fml.event.lifecycle.FMLCommonSetupEvent;
import net.minecraftforge.registries.DeferredRegister;
import net.minecraftforge.registries.ForgeRegistries;

@Mod.EventBusSubscriber(bus = Bus.MOD, modid = "world_of_food")
public class ModPotions {

    public static final DeferredRegister<Effect> EFFECTS = DeferredRegister.create(ForgeRegistries.POTIONS, WorldOfFood.MOD_ID);
    public static final DeferredRegister<Potion> POTIONS = DeferredRegister.create(ForgeRegistries.POTION_TYPES, WorldOfFood.MOD_ID);

    public static final RegistryObject<Effect> NOURISHED = EFFECTS.register("nourished", () -> new Nourished(EffectType.BENEFICIAL, 3087634));
    public static final RegistryObject<Potion> HOT_COCOA = POTIONS.register("hot_cocoa", () -> new Potion(new EffectInstance(NOURISHED.get(), 3600)));
    public static final RegistryObject<Potion> APPLE_JUICE = POTIONS.register("apple_juice", () -> new Potion(new EffectInstance(NOURISHED.get(), 3600)));
    public static final RegistryObject<Potion> APPLE_CIDER = POTIONS.register("apple_cider", () -> new Potion(new EffectInstance(NOURISHED.get(), 3600)));
    public static final RegistryObject<Potion> VINEGAR = POTIONS.register("vinegar", () -> new Potion(new EffectInstance(NOURISHED.get(), 3600)));

    @SubscribeEvent
    public static void registerPotions(FMLCommonSetupEvent event) {
        event.enqueueWork( ()->
            BrewingRecipeRegistry.addRecipe(Ingredient.of(Items.POTION), Ingredient.of(Items.COCOA_BEANS), PotionUtils.setPotion(getPotion("minecraft:water"), HOT_COCOA.get()))
        );
        event.enqueueWork( ()->
            BrewingRecipeRegistry.addRecipe(Ingredient.of(Items.POTION), Ingredient.of(Items.APPLE), PotionUtils.setPotion(getPotion("minecraft:water"), APPLE_JUICE.get()))
        );
        event.enqueueWork( ()->
            BrewingRecipeRegistry.addRecipe(Ingredient.of(Items.POTION), Ingredient.of(Items.APPLE), PotionUtils.setPotion(getPotion("world_of_food:apple_juice"), APPLE_CIDER.get()))
        );
        event.enqueueWork( ()->
            BrewingRecipeRegistry.addRecipe(Ingredient.of(Items.POTION), Ingredient.of(Items.SUGAR), PotionUtils.setPotion(getPotion("world_of_food:apple_juice"), VINEGAR.get()))
        );
    }

    public static ItemStack getPotion(String potion)
    {
        ItemStack itemstack = new ItemStack(Items.POTION);
        CompoundNBT tag = itemstack.getTag();
        tag.putString("Potion", potion);
        return itemstack;
    }
}

 

Link to comment
Share on other sites

  • 2 weeks later...

Ok, here's what I've come up with. For some reason, I can't put the potions in the brewing stand though, they're not recognized as ingredients, I guess. I think I need to initialize the super with something other than "null", but I don't know what to put there, it's expecting a Stream<IItemList>

package com.derpyninjafrog.worldoffood.init;

import net.minecraft.item.ItemStack;
import net.minecraft.item.Items;
import net.minecraft.item.crafting.Ingredient;
import net.minecraftforge.common.brewing.IBrewingRecipe;

import java.util.function.Predicate;

public class PotionIngredient extends Ingredient implements Predicate<ItemStack> {

    String potion;

    public PotionIngredient(String potion) {
        super(null);
        this.potion = potion;
    }

    @Override
    public boolean test(ItemStack itemStack) {
        return itemStack.getTag().getString("Potion").equals(this.potion);
    }

    @Override
    public Predicate<ItemStack> and(Predicate<? super ItemStack> other) {
        return Predicate.super.and(other);
    }
}

 

Link to comment
Share on other sites

  • ItemStack#getTag can return null, you must handle this.
  • Passing null to super will immediately crash. You must pass an empty list at least.
  • You must implement getSerializer for custom ingredients and register your serializer with CraftingHelper.
  • Use PotionUtils.getPotion(ItemStack) instead of just comparing the strings.
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • 1.12 is no longer supported on this forum. Please update to a modern version of Minecraft to receive support.
    • I've been trying to install Forge version 1.12.2 to play a minecraft server with some friends but it is not working. I saw another post with the same issue as me; that being that a certain library will not install. The recommendation for that post was running the installer through CMD. I have tried that and am still getting the same error.   Logs JVM info: Oracle Corporation - 1.8.0_321 - 25.321-b07 java.net.preferIPv4Stack=true Found java version 1.8.0_321 Extracting json Considering minecraft client jar Downloading libraries Found 0 additional library directories Considering library net.minecraftforge:forge:1.12.2-14.23.5.2859   File exists: Checksum validated. Considering library org.ow2.asm:asm-debug-all:5.2   File exists: Checksum validated. Considering library net.minecraft:launchwrapper:1.12   File exists: Checksum validated. Considering library org.jline:jline:3.5.1   File exists: Checksum validated. Considering library com.typesafe.akka:akka-actor_2.11:2.3.3   File exists: Checksum validated. Considering library com.typesafe:config:1.2.1   File exists: Checksum validated. Considering library org.scala-lang:scala-actors-migration_2.11:1.1.0   File exists: Checksum validated. Considering library org.scala-lang:scala-compiler:2.11.1   File exists: Checksum invalid, deleting file:     Expected: 56ea2e6c025e0821f28d73ca271218b8dd04926a     Actual:   e36a29a94e39c5b4215e88a2bf5c044539cf3203   Downloading library from https://maven.minecraftforge.net/org/scala-lang/scala-compiler/2.11.1/scala-compiler-2.11.1.jar java.net.SocketTimeoutException: Read timed out     at java.net.SocketInputStream.socketRead0(Native Method)     at java.net.SocketInputStream.socketRead(Unknown Source)     at java.net.SocketInputStream.read(Unknown Source)     at java.net.SocketInputStream.read(Unknown Source)     at sun.security.ssl.SSLSocketInputRecord.read(Unknown Source)     at sun.security.ssl.SSLSocketInputRecord.readFully(Unknown Source)     at sun.security.ssl.SSLSocketInputRecord.decodeInputRecord(Unknown Source)     at sun.security.ssl.SSLSocketInputRecord.decode(Unknown Source)     at sun.security.ssl.SSLTransport.decode(Unknown Source)     at sun.security.ssl.SSLSocketImpl.decode(Unknown Source)     at sun.security.ssl.SSLSocketImpl.readApplicationRecord(Unknown Source)     at sun.security.ssl.SSLSocketImpl.access$300(Unknown Source)     at sun.security.ssl.SSLSocketImpl$AppInputStream.read(Unknown Source)     at java.io.BufferedInputStream.read1(Unknown Source)     at java.io.BufferedInputStream.read(Unknown Source)     at sun.net.www.MeteredStream.read(Unknown Source)     at java.io.FilterInputStream.read(Unknown Source)     at sun.net.www.protocol.http.HttpURLConnection$HttpInputStream.read(Unknown Source)     at sun.net.www.protocol.http.HttpURLConnection$HttpInputStream.read(Unknown Source)     at java.nio.file.Files.copy(Unknown Source)     at java.nio.file.Files.copy(Unknown Source)     at net.minecraftforge.installer.DownloadUtils.download(DownloadUtils.java:186)     at net.minecraftforge.installer.DownloadUtils.download(DownloadUtils.java:174)     at net.minecraftforge.installer.DownloadUtils.downloadLibrary(DownloadUtils.java:159)     at net.minecraftforge.installer.actions.Action.downloadLibraries(Action.java:89)     at net.minecraftforge.installer.actions.ClientInstall.run(ClientInstall.java:110)     at net.minecraftforge.installer.InstallerPanel.run(InstallerPanel.java:423)     at net.minecraftforge.installer.SimpleInstaller.launchGui(SimpleInstaller.java:175)     at net.minecraftforge.installer.SimpleInstaller.main(SimpleInstaller.java:147) Considering library org.scala-lang.plugins:scala-continuations-library_2.11:1.0.2_mc   File exists: Checksum validated. Considering library org.scala-lang.plugins:scala-continuations-plugin_2.11.1:1.0.2_mc   File exists: Checksum validated. Considering library org.scala-lang:scala-library:2.11.1   File exists: Checksum validated. Considering library org.scala-lang:scala-parser-combinators_2.11:1.0.1   File exists: Checksum validated. Considering library org.scala-lang:scala-reflect:2.11.1   File exists: Checksum validated. Considering library org.scala-lang:scala-swing_2.11:1.0.1   File exists: Checksum validated. Considering library org.scala-lang:scala-xml_2.11:1.0.2   File exists: Checksum validated. Considering library lzma:lzma:0.0.1   File exists: Checksum validated. Considering library java3d:vecmath:1.5.2   File exists: Checksum validated. Considering library net.sf.trove4j:trove4j:3.0.3   File exists: Checksum validated. Considering library org.apache.maven:maven-artifact:3.5.3   File exists: Checksum validated. Considering library net.sf.jopt-simple:jopt-simple:5.0.3   File exists: Checksum validated. Considering library org.apache.logging.log4j:log4j-api:2.15.0   File exists: Checksum validated. Considering library org.apache.logging.log4j:log4j-core:2.15.0   File exists: Checksum validated. Considering library org.apache.logging.log4j:log4j-slf4j18-impl:2.15.0   File exists: Checksum validated. These libraries failed to download. Try again. org.scala-lang:scala-compiler:2.11.1
    • I locally hosted a modpack server and it takes 10 minutes for my friend to join the world. He is stuck on "Joining World" without the option to cancel for 10 minutes and hes just impatient and this never happened before with other modpacks we used to play.   There are 0 errors or fails in the logs.
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.