Jump to content

[1.16.5] I don't think I fully understand how capabilities work...


cwJn

Recommended Posts

So I thought that when a capability is attached to an item/entity/etc... the capability will stay until whatever it's attached to is gone. But this doesn't seem to be the case, as when I printed to console whenever a capability is attached, it seems as though a new version of the capability is attached to an item every time I select it in my hotbar, hover over it in inventory, etc. Is this how it's supposed to work? If so, why?

Link to comment
Share on other sites

Show your code.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

@SubscribeEvent
    public static void ItemHandler(AttachCapabilitiesEvent<ItemStack> event) {
        ItemStack item = event.getObject();
        if (GearApi.isGear(item)) {
            SGearTraitHelperProvider provider = new SGearTraitHelperProvider();
            event.addCapability(TRAIT_HELPER_KEY, provider);
            event.addListener(provider::invalidate);
        }
        if (isArmour(item) || item.getItem() instanceof ICoreArmor) {
            DamageResistanceProvider provider = new DamageResistanceProvider(0, 0, 0, 0, 0, 0, 0, 0, 0);
            event.addCapability(RES_KEY, provider);
            event.addListener(provider::invalidate);
        } else if (isWeapon(item) || item.getItem() instanceof ICoreTool) {
            DamageTypesProvider provider = new DamageTypesProvider(0, 0, 0, 0, 0, 0, 0, 0, 0, "IMPACT");
            event.addCapability(DMG_KEY, provider);
            event.addListener(provider::invalidate);
        }
    }

 

Link to comment
Share on other sites

 

This is the capability inject and provider for one of my capabilities. All of them are coded the exact same way.

public class CapabilityDamageTypes {

    @CapabilityInject(IDamageTypes.class)
    public static Capability<IDamageTypes> DAMAGE_TYPES_CAPABILITY = null;

    public static void register() {
        CapabilityManager.INSTANCE.register(IDamageTypes.class, new Storage(), new Factory());
    }

    private static class Storage implements Capability.IStorage<IDamageTypes> {

        @Nullable
        @Override
        public INBT writeNBT(Capability<IDamageTypes> capability, IDamageTypes instance, Direction side) {
            CompoundNBT tag = new CompoundNBT();
            tag.putFloat("slash", instance.getSlashDamage());
            tag.putFloat("impact", instance.getImpactDamage());
            tag.putFloat("puncture", instance.getPunctureDamage());
            tag.putFloat("fire", instance.getFireDamage());
            tag.putFloat("lightning", instance.getLightningDamage());
            tag.putFloat("ice", instance.getIceDamage());
            tag.putFloat("dark", instance.getDarkDamage());
            tag.putFloat("holy", instance.getHolyDamage());
            tag.putFloat("magic", instance.getMagicDamage());
            tag.putString("mobDamageType", instance.getMobDamageType());
            return tag;
        }

        @Override
        public void readNBT(Capability<IDamageTypes> capability, IDamageTypes instance, Direction side, INBT nbt) {
            float slash = ((CompoundNBT) nbt).getFloat("slash");
            float impact = ((CompoundNBT) nbt).getFloat("impact");
            float puncture = ((CompoundNBT) nbt).getFloat("puncture");
            float fire = ((CompoundNBT) nbt).getFloat("fire");
            float lightning = ((CompoundNBT) nbt).getFloat("lightning");
            float ice = ((CompoundNBT) nbt).getFloat("ice");
            float dark = ((CompoundNBT) nbt).getFloat("dark");
            float holy = ((CompoundNBT) nbt).getFloat("holy");
            float magic = ((CompoundNBT) nbt).getFloat("magic");
            String mobDamageType = ((CompoundNBT) nbt).getString("mobDamageType");

            instance.setSlashDamage(slash);
            instance.setImpactDamage(impact);
            instance.setPunctureDamage(puncture);
            instance.setFireDamage(fire);
            instance.setLightningDamage(lightning);
            instance.setIceDamage(ice);
            instance.setDarkDamage(dark);
            instance.setHolyDamage(holy);
            instance.setMagicDamage(magic);
            instance.setMobDamageType(mobDamageType);
        }
    }

    private static class Factory implements Callable<IDamageTypes> {

        @Override
        public IDamageTypes call() throws Exception {
            return new DamageTypes(0, 0, 0, 0, 0, 0, 0, 0, 0, "IMPACT");
        }

    }

}
package com.cwjn.hardstuckintegration.Capabilities.DamageTypes;

import net.minecraft.nbt.CompoundNBT;
import net.minecraft.util.Direction;
import net.minecraftforge.common.capabilities.Capability;
import net.minecraftforge.common.capabilities.ICapabilitySerializable;
import net.minecraftforge.common.util.LazyOptional;

import javax.annotation.Nonnull;
import javax.annotation.Nullable;

public class DamageTypesProvider implements ICapabilitySerializable<CompoundNBT> {

    //private final DamageTypes damage = new DamageTypes();
    //private final LazyOptional<IDamageTypes> damageOptional = LazyOptional.of(() -> damage);
    private DamageTypes damage;
    private LazyOptional<IDamageTypes> damageOptional;

    public void invalidate() {
        damageOptional.invalidate();
    }

    public DamageTypesProvider(float I, float P, float S, float F, float L, float IC, float D, float H, float M, String mobDamageType) {
        damage = new DamageTypes(I, P, S, F, L, IC, D, H, M, mobDamageType);
        damageOptional = LazyOptional.of(() -> damage);
    }

    @Nonnull
    @Override
    public <T> LazyOptional<T> getCapability(@Nonnull Capability<T> cap, @Nullable Direction side) {
        return cap == CapabilityDamageTypes.DAMAGE_TYPES_CAPABILITY ? damageOptional.cast() : LazyOptional.empty();
    }

    @Override
    public CompoundNBT serializeNBT() {
        if (CapabilityDamageTypes.DAMAGE_TYPES_CAPABILITY == null) {
            return new CompoundNBT();
        } else {
            return (CompoundNBT) CapabilityDamageTypes.DAMAGE_TYPES_CAPABILITY.writeNBT(damage, null);
        }
    }

    @Override
    public void deserializeNBT(CompoundNBT nbt) {
        if (CapabilityDamageTypes.DAMAGE_TYPES_CAPABILITY != null) {
            CapabilityDamageTypes.DAMAGE_TYPES_CAPABILITY.readNBT(damage, null, nbt);
        }
    }

}

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
    • It is an issue with quark - update it to this build: https://www.curseforge.com/minecraft/mc-mods/quark/files/3642325
    • Remove Instant Massive Structures Mod from your server     Add new crash-reports with sites like https://paste.ee/  
    • Update your drivers: https://www.amd.com/en/support/graphics/amd-radeon-r9-series/amd-radeon-r9-200-series/amd-radeon-r9-280x
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.