Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.17.1] Replacing leaves on trees / Generating world generation data


Anrza
 Share

Recommended Posts

Hello!

I want to replace the leaves on trees that generate in the world with other blocks. One way I've found to do this is to manually create files in data/minecraft/worldgen/configured_feature that correspond to vanilla's features and replacing the block in "foliage_provider" with the one I want. Doing it manually works well, but it's not convenient to do at a large scale, and obviously has other drawbacks.

I'd ideally use the data generator system, like I do for recipes and loot tables. Unfortunately, there is no built in support for specifically world generation, like there is for recipes and loot tables. I could create the json files if I managed to convert the features to JsonElements, but I don't know how I would do that.

To summarise, I have one objective:

  • Replacing leaves on trees placed in the world by
    • world generation and
    • saplings.

But I would gladly receive help on how to generate json files of ConfiguredFeatures such as Features.OAK.

Thanks in advance!

Link to comment
Share on other sites

19 hours ago, Luis_ST said:

you need to create your own FoliagePlacer, then use BiomeLoadingEvent to loop through the Features, check if the Feature is an TreeFeature then replace the original FoliagePlacer with Reflection or use an AT

Thanks for your reply! I have done it using data generation now. It works well for world generation, and I have realised that I don't care about saplings, so it works well.

For anyone looking to do something similar, I include files to show what I did. They are just a bit hacky and incomplete now, but they can probably easily be generalised.

 

import static net.anju.larus.data.ResourceLocationUtil.prefix;
import static net.anju.larus.data.ResourceLocationUtil.slash;

@MethodsReturnNonnullByDefault
@ParametersAreNonnullByDefault
public abstract class LarusFeatureProvider<T> implements DataProvider {

    private static final Gson GSON = new GsonBuilder().setPrettyPrinting().disableHtmlEscaping().create();

    protected final Set<FeatureEntry> featureEntries = new HashSet<>();

    private final DataGenerator generator;

    protected LarusFeatureProvider(DataGenerator generator, Registry<T> registry) {
        this.generator = generator;
        for (Map.Entry<ResourceKey<T>, T> entry : registry.entrySet()) {
            ResourceKey<T> key = entry.getKey();
            T feature = entry.getValue();
            JsonElement jsonElement = getJson(feature);
            if (jsonElement != null) {
                FeatureEntry featureEntry = new FeatureEntry(prefix(key.location(), key.getRegistryName()), jsonElement);
                featureEntries.add(featureEntry);
            }
        }
    }

    private void addFeatures() {
        for (FeatureEntry featureEntry : featureEntries) {
            modifyFeatureEntry(featureEntry);
        }
    }

    protected abstract void modifyFeatureEntry(FeatureEntry featureEntry);

    @Override
    public void run(HashCache cache) {
        addFeatures();
        writeFiles(cache, this.generator.getOutputFolder(), featureEntries);
    }

    // Actually write out the tables in the output folder
    private static void writeFiles(HashCache cache, Path outputFolder, Set<FeatureEntry> featureEntries) {
        for (FeatureEntry featureEntry : featureEntries) {
            if (featureEntry.isModified()) {
                ResourceLocation key = featureEntry.resourceLocation;
                JsonElement jsonElement = featureEntry.jsonElement;
                Path path = getPath(outputFolder, key);
                try {
                    DataProvider.save(GSON, cache, jsonElement, path);
                } catch (IOException e) {
                    LarusMod.LOGGER.error("Couldn't write data {}", key, e);
                }
            }
        }
    }

    @Override
    public String getName() {
        return "Larus features";
    }

    @Nullable
    public JsonElement getJson(T feature) {
        if (feature instanceof ConfiguredFeature<?, ?> configuredFeature) {
            Optional<JsonElement> optional = ConfiguredFeature.DIRECT_CODEC.encodeStart(JsonOps.INSTANCE, configuredFeature).result();
            return optional.orElse(null);
        }
        return null;
    }

    public static Path getPath(Path outputFolder, ResourceLocation key) {
        return outputFolder.resolve("data/" + slash(key) + ".json");
    }

    protected static class FeatureEntry {

        boolean modified = false;
        private final ResourceLocation resourceLocation;
        private final JsonElement jsonElement;

        private FeatureEntry(ResourceLocation resourceLocation, JsonElement jsonElement) {
            this.resourceLocation = resourceLocation;
            this.jsonElement = jsonElement;
        }

        public JsonElement getJsonElement() {
            return jsonElement;
        }

        protected void markModified() {
            this.modified = true;
        }

        private boolean isModified() {
            return this.modified;
        }

    }

}
public class LarusLeavesFeatureProvider extends LarusFeatureProvider<ConfiguredFeature<?, ?>> {

    public LarusLeavesFeatureProvider(DataGenerator generator) {
        super(generator, BuiltinRegistries.CONFIGURED_FEATURE);
    }

    @Override
    protected void modifyFeatureEntry(FeatureEntry featureEntry) {
        JsonElement jsonElement = featureEntry.getJsonElement();
        if (jsonElement.isJsonObject()) {
            JsonObject jsonObject = jsonElement.getAsJsonObject();
            if (jsonObject.has("config")) {
                JsonObject config = jsonObject.get("config").getAsJsonObject();
                if (config.has("foliage_provider")) {
                    JsonObject mcFoliage = config.get("foliage_provider").getAsJsonObject();
                    JsonObject larusFoliage = larusFoliage(mcFoliage);
                    if (larusFoliage != null) {
                        config.add("foliage_provider", larusFoliage);
                        featureEntry.markModified();
                    }
                }
            }
        }
    }

    @Nullable
    protected JsonObject larusFoliage(JsonObject mcFoliage) {
        JsonElement type = mcFoliage.get("type");
        if (type.getAsString().equals("minecraft:simple_state_provider")) {
            JsonObject state = mcFoliage.get("state").getAsJsonObject();

            // Change leaves
            String mcLeaves = state.get("Name").getAsString();
            LarusLeavesBlock larusLeavesBlock = larusLeavesBlock(mcLeaves);
            if (larusLeavesBlock == null || larusLeavesBlock.getRegistryName() == null)
                return null;
            String larusLeaves = larusLeavesBlock.getRegistryName().toString();
            state.add("Name", new JsonPrimitive(larusLeaves));

            // Transform properties
            JsonObject mcProperties = state.get("Properties").getAsJsonObject();
            transformProperties(mcProperties, larusLeavesBlock);
        } else {
            LarusMod.LOGGER.warn("Unexpected type for MC foliage " + mcFoliage);
        }
        return mcFoliage;
    }

    protected void transformProperties(JsonObject properties, LarusLeavesBlock larusLeavesBlock) {
        if (larusLeavesBlock instanceof LarusDeciduousLeavesBlock)
            properties.add("leafy", new JsonPrimitive("green"));
    }

    @Nullable
    protected LarusLeavesBlock larusLeavesBlock(String mcLeaves) {
        switch (mcLeaves) {
            case "minecraft:oak_leaves" -> {
                return LarusBlocks.OAK_LEAVES.get();
            }
            case "minecraft:birch_leaves" -> {
                return LarusBlocks.BIRCH_LEAVES.get();
            }
            case "minecraft:acacia_leaves" -> {
                return LarusBlocks.ACACIA_LEAVES.get();
            }
            case "minecraft:jungle_leaves" -> {
                return LarusBlocks.JUNGLE_LEAVES.get();
            }
            case "minecraft:dark_oak_leaves" -> {
                return LarusBlocks.DARK_OAK_LEAVES.get();
            }
            case "minecraft:spruce_leaves" -> {
                return LarusBlocks.SPRUCE_LEAVES.get();
            }
        }
        return null;
    }


}

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • C:\Users\Lorenz\Desktop\KAYN>java -Xmx3000M -jar forge-1.16.5-36.2.0.jar nogui 2022-01-28 20:08:20,278 main WARN Advanced terminal features are not available in this environment [20:08:20] [main/INFO] [cp.mo.mo.Launcher/MODLAUNCHER]: ModLauncher running: args [--gameDir, ., --launchTarget, fmlserver, --fml.forgeVersion, 36.2.0, --fml.mcpVersion, 20210115.111550, --fml.mcVersion, 1.16.5, --fml.forgeGroup, net.minecraftforge, nogui] [20:08:20] [main/INFO] [cp.mo.mo.Launcher/MODLAUNCHER]: ModLauncher 8.0.9+86+master.3cf110c starting: java version 1.8.0_321 by Oracle Corporation [20:08:20] [main/INFO] [ne.mi.fm.lo.FixSSL/CORE]: Added Lets Encrypt root certificates as additional trust [20:08:20] [main/INFO] [mixin/]: SpongePowered MIXIN Subsystem Version=0.8.2 Source=file:/C:/Users/Lorenz/Desktop/KAYN/libraries/org/spongepowered/mixin/0.8.2/mixin-0.8.2.jar Service=ModLauncher Env=SERVER [20:08:21] [main/INFO] [cp.mo.mo.LaunchServiceHandler/MODLAUNCHER]: Launching target 'fmlserver' with arguments [--gameDir, ., nogui] Exception in thread "main" [20:08:21] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:-1]: java.lang.NoSuchMethodError: sun.security.util.ManifestEntryVerifier.<init>(Ljava/util/jar/Manifest;)V [20:08:21] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:-1]:         at cpw.mods.modlauncher.SecureJarHandler.createCodeSource(SecureJarHandler.java:66) [20:08:21] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:-1]:         at cpw.mods.modlauncher.TransformingClassLoader$DelegatedClassLoader.findClass(TransformingClassLoader.java:275) [20:08:21] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:-1]:         at cpw.mods.modlauncher.TransformingClassLoader.loadClass(TransformingClassLoader.java:136) [20:08:21] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:-1]:         at cpw.mods.modlauncher.TransformingClassLoader.loadClass(TransformingClassLoader.java:98) [20:08:21] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:-1]:         at java.lang.ClassLoader.loadClass(Unknown Source) [20:08:21] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:-1]:         at java.lang.Class.forName0(Native Method) [20:08:21] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:-1]:         at java.lang.Class.forName(Unknown Source) [20:08:21] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:-1]:         at net.minecraftforge.fml.loading.FMLServerLaunchProvider.lambda$launchService$0(FMLServerLaunchProvider.java:51) [20:08:21] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:-1]:         at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [20:08:21] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:-1]:         at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) [20:08:21] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:-1]:         at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) [20:08:21] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:-1]:         at cpw.mods.modlauncher.Launcher.run(Launcher.java:82) [20:08:21] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:-1]:         at cpw.mods.modlauncher.Launcher.main(Launcher.java:66) [20:08:21] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:-1]:         at net.minecraftforge.server.ServerMain$Runner.runLauncher(ServerMain.java:63) [20:08:21] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:-1]:         at net.minecraftforge.server.ServerMain$Runner.access$100(ServerMain.java:60) [20:08:21] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:-1]:         at net.minecraftforge.server.ServerMain.main(ServerMain.java:57) C:\Users\Lorenz\Desktop\KAYN>PAUSE Drücken Sie eine beliebige Taste . . .   HOW CAN I FIX THIS
    • Can someone help me with block generation using forge? I made a custom berry bush but I am having a hard time figuring out how to get it to generate on the surface. 
    • writing noclip and then sendPlayerAbilities didnt work either
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.