Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[Solved][1.17.1] Best way to overwrite the default cross bow render (ItemInHandRenderer and PlayerRender) ...


Kaworru
 Share

Recommended Posts

Hi,

I'm not new to forge modding, but new to client render with 1.17 and working on a mod which adds steel tools and weapons.

Currently I'm stuck with the crossbow item by using the default CrossbowItem with a different registration name and texture for a steel version, see:

https://github.com/MarkusBordihn/BOs-Steel-Armor-Tools-Weapons/blob/main/src/main/java/de/markusbordihn/steelarmortoolsweapons/item/ModItems.java#L56

 

My currently problem is that it seems that the ItemInHandRender and PlayerRender has a hard reference to Items.CROSSBOW, which mean that the render is not working for my steel crossbow version.

Normally I would somehow register a listener for the render event and replace it with a custom one as soon I detect my item in the hand.

But have not really an idea how to do this correct with the version 1.17.1.

I took a look at the original code but was not able to see how these render a register or how I could intercept the existing ones.

Would be thankful for any pointers in the right direction (e.g. registration / listener methods) or maybe a basic example how this works in general.

Thanks a lot.

Edited by Kaworru
Solved
Link to comment
Share on other sites

5 hours ago, Kaworru said:

My currently problem is that it seems that the ItemInHandRender and PlayerRender has a hard reference to Items.CROSSBOW, which mean that the render is not working for my steel crossbow version

The crossbow does not use a custom Renderer, it only use a few models. Did you looked at the vanilla models?

Link to comment
Share on other sites

Sorry, but this is not correct. If you search for "Items.CROSSBOW" in the vanilla source code you will see some references in the ItemInHandRenderer.java and PlayerRenderer.java for the animation for e.g. which hand should be visible at which state.

The models works fine in the 3rd person view and the inventory slot, but not in the first person view which use the custom render mentioned above.

Link to comment
Share on other sites

Quote

I will look at this, and try to find a solution for your problem 

Thanks for the feedback. But it seems there is not really an easy way for this, most of the code is hard-coded and could not be accessed directly. 😞

I worked around this by using the "RenderHandEvent" and "RenderPlayerEvent" to create a dedicated render for my crossbow item.

Edited by Kaworru
Link to comment
Share on other sites

3 hours ago, Kaworru said:

Thanks for the feedback. But it seems there is not really an easy way for this, most of the code is hard-coded and could not be accessed directly. 😞

Unfortunately it looks like, that's only possible with mixin/core modding (which is not supported on this forum)

Link to comment
Share on other sites

14 hours ago, Luis_ST said:

Unfortunately it looks like, that's only possible with mixin/core modding (which is not supported on this forum)

Yeah this is exactly the thing I want to avoid. I got so many false positive error reports with other mods which using mixin/core modifications.

But no worries, I got a working version and learned more about the render events.  

Link to comment
Share on other sites

  • Kaworru changed the title to [Solved][1.17.1] Best way to overwrite the default cross bow render (ItemInHandRenderer and PlayerRender) ...

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • 2022-01-22 07:41:00,800 main WARN Advanced terminal features are not available in this environment [07:41:00] [main/INFO] [cp.mo.mo.Launcher/MODLAUNCHER]: ModLauncher running: args [--gameDir, ., --launchTarget, fmlserver, --fml.forgeVersion, 36.2.23, --fml.mcpVersion, 20210115.111550, --fml.mcVersion, 1.16.5, --fml.forgeGroup, net.minecraftforge, nogui] [07:41:00] [main/INFO] [cp.mo.mo.Launcher/MODLAUNCHER]: ModLauncher 8.0.9+86+master.3cf110c starting: java version 17.0.2 by Oracle Corporation Exception in thread "main" java.lang.IllegalAccessError: class cpw.mods.modlauncher.SecureJarHandler (in unnamed module @0x7ff95560) cannot access class sun.security.util.ManifestEntryVerifier (in module java.base) because module java.base does not export sun.security.util to unnamed module @0x7ff95560         at cpw.mods.modlauncher.SecureJarHandler.lambda$static$1(SecureJarHandler.java:41)         at cpw.mods.modlauncher.api.LamdbaExceptionUtils.uncheck(LamdbaExceptionUtils.java:95)         at cpw.mods.modlauncher.SecureJarHandler.<clinit>(SecureJarHandler.java:41)         at cpw.mods.modlauncher.Launcher.lambda$new$6(Launcher.java:55)         at java.base/java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1708)         at cpw.mods.modlauncher.api.TypesafeMap.computeIfAbsent(TypesafeMap.java:52)         at cpw.mods.modlauncher.api.TypesafeMap.computeIfAbsent(TypesafeMap.java:47)         at cpw.mods.modlauncher.Environment.computePropertyIfAbsent(Environment.java:62)         at cpw.mods.modlauncher.Launcher.<init>(Launcher.java:55)         at cpw.mods.modlauncher.Launcher.main(Launcher.java:66)         at net.minecraftforge.server.ServerMain$Runner.runLauncher(ServerMain.java:63)         at net.minecraftforge.server.ServerMain$Runner.access$100(ServerMain.java:60)         at net.minecraftforge.server.ServerMain.main(ServerMain.java:57) i have the same how do i fix it  
    • Hi, I'm facing an issue that a custom datapack is always loaded before the mod's datapack. Means the users/players are not able to override mod's configurations/data at all. I've tried to alternate the order of datapack by using the /datapack commands, however the actual loading order does not change at all. (I can confirm that both datapacks are working as usual by disabling one of them at a time, the correspond data is loaded correctly), is it the mod's problem or...? Thanks.
    • I'm trying to play a custom modpack with a few dozen mods, but when I try to create a world it hits 100% and then crashes and I can't figure out why. Here's the crash log:  
    • I already created a github account to upload the debug logs but i dont know where to find them also when it disconnects it say something like io.netty.util.illegalreferencecountexception
    • Hello again sorry for that post i searched further and found à project that re implemented item render
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.