Jump to content

Entity not rendering


matthew123

Recommended Posts

The entity creates a pillar of blocks. It appears to work fine; the blocks are getting placed. But the entity is not rendering. It should be displaying interpolated movement upwards. Instead, the blocks just appear (so the entity is invisible).

    public void tick() {
        LogManager.getLogger().info("ticks: " + ticks++ + " current " + blockPosition() + " old " + oldPos);
        if(blockPosition().equals(endBlockPos)){
            if(releaseJutsuOnce != null){
                releaseJutsuOnce.execute();
            }
            remove();
            return;
        }
        if(blockPosition().equals(oldPos.above())){
            oldPos = blockPosition();
            level.setBlockAndUpdate(blockPosition(), blockState);
        }
        setDeltaMovement(0, 0.1, 0);
        move(MoverType.SELF, getDeltaMovement());
    }

Renderer (copied from falling block):

public class MudWallBlockEntityRenderer extends EntityRenderer<MudWallBlockEntity> {
    public MudWallBlockEntityRenderer(EntityRendererManager entityRendererManager) {
        super(entityRendererManager);
        this.shadowRadius = 0.5F;
    }

    @Override
    public void render(MudWallBlockEntity entity, float entityYaw, float partialTicks, MatrixStack matrixStack, IRenderTypeBuffer buffer, int packedLight) {
        BlockState blockstate = entity.getBlockState();
        if (blockstate.getRenderShape() == BlockRenderType.MODEL) {
            World world = entity.getCommandSenderWorld();
            if (blockstate != world.getBlockState(entity.blockPosition()) && blockstate.getRenderShape() != BlockRenderType.INVISIBLE) {
                matrixStack.pushPose();
                BlockPos blockpos = new BlockPos(entity.getX(), entity.getBoundingBox().maxY, entity.getZ());
                matrixStack.translate(-0.5D, 0.0D, -0.5D);
                BlockRendererDispatcher blockrendererdispatcher = Minecraft.getInstance().getBlockRenderer();
                for (net.minecraft.client.renderer.RenderType type : net.minecraft.client.renderer.RenderType.chunkBufferLayers()) {
                    if (RenderTypeLookup.canRenderInLayer(blockstate, type)) {
                        net.minecraftforge.client.ForgeHooksClient.setRenderLayer(type);
                        blockrendererdispatcher.getModelRenderer().tesselateBlock(world, blockrendererdispatcher.getBlockModel(blockstate), blockstate, blockpos, matrixStack, buffer.getBuffer(type), false, new Random(), blockstate.getSeed(entity.getStartingBlockPos()), OverlayTexture.NO_OVERLAY);
                    }
                }
                net.minecraftforge.client.ForgeHooksClient.setRenderLayer(null);
                matrixStack.popPose();
                super.render(entity, entityYaw, partialTicks, matrixStack, buffer, packedLight);
            }
        }
    }

    @Override
    public ResourceLocation getTextureLocation(MudWallBlockEntity pEntity) {
        return AtlasTexture.LOCATION_BLOCKS;
    }
}

Registration:

RenderingRegistry.registerEntityRenderingHandler(ModEntities.MUD_WALL_BLOCK_ENTITY.get(), MudWallBlockEntityRenderer::new);

 

Link to comment
Share on other sites

2 minutes ago, diesieben07 said:

Show the whole entity class.

public class MudWallBlockEntity extends Entity {
    private static final BlockState blockState = ModBlocks.TEMPORARY_DIRT_BLOCK.get().defaultBlockState();

    private int height;
    private OneTimeRunnable finishJutsuOnce;

    private BlockPos startingBlockPos;
    private BlockPos endBlockPos;
    private BlockPos oldPos;

    private int ticks;

    public MudWallBlockEntity(EntityType<? extends MudWallBlockEntity> entityType, World level) {
        super(entityType, level);
    }

    @OnlyIn(Dist.CLIENT)
    public MudWallBlockEntity(EntityType<? extends MudWallBlockEntity> entityType, World level, BlockPos position, int height, OneTimeRunnable releaseJutsu) {
        super(entityType, level);

        this.startingBlockPos = position;
        this.endBlockPos = new BlockPos(startingBlockPos.getX(), height, startingBlockPos.getZ());
        this.oldPos = position;

        this.height = height;
        this.finishJutsuOnce = releaseJutsu;

        this.setPos(position.getX(), position.getY(), position.getZ());
        this.ticks = 0;
    }

    @Override
    protected void defineSynchedData() {
    }

    @Override
    protected void readAdditionalSaveData(@Nonnull CompoundNBT pCompound) {
        startingBlockPos = new BlockPos(pCompound.getInt("StartX"), pCompound.getInt("StartY"),pCompound.getInt("StartZ"));
        endBlockPos = new BlockPos(startingBlockPos.getX(), pCompound.getInt("Height"), startingBlockPos.getZ());
        oldPos = new BlockPos(startingBlockPos.getX(), pCompound.getInt("CurrentHeight"), startingBlockPos.getZ());
    }

    @Override
    protected void addAdditionalSaveData(@Nonnull CompoundNBT pCompound) {
        pCompound.putInt("StartX", startingBlockPos.getX());
        pCompound.putInt("StartY", startingBlockPos.getY());
        pCompound.putInt("StartZ", startingBlockPos.getZ());
        pCompound.putInt("Height", height);
        pCompound.putInt("CurrentHeight", oldPos.getY());
    }

    @Nonnull
    @Override
    public IPacket<?> getAddEntityPacket() {
        return new SSpawnObjectPacket(this, Block.getId(this.getBlockState()));
    }

    @Override
    public void tick() {
        LogManager.getLogger().info("ticks: " + ticks++ + " current " + blockPosition() + " old " + oldPos);

        if(blockPosition().equals(endBlockPos)){
            if(finishJutsuOnce != null){
                finishJutsuOnce.execute();
            }

            remove();
            return;
        }

        if(blockPosition().equals(oldPos.above())){
            oldPos = blockPosition();
            level.setBlockAndUpdate(blockPosition(), blockState);
        }

        setDeltaMovement(0, 0.1, 0);
        move(MoverType.SELF, getDeltaMovement());
    }

    public BlockState getBlockState() {
        return blockState;
    }

    public BlockPos getStartingBlockPos() { return startingBlockPos; }

    @Override
    public boolean canBeCollidedWith() {
        return false;
    }

    @Override
    protected boolean canAddPassenger(Entity pPassenger) {
        return false;
    }

    @Override
    public boolean canChangeDimensions() {
        return false;
    }
}

 

Link to comment
Share on other sites

4 minutes ago, diesieben07 said:

This is not at all the correct usage for @OnlyIn. Yes, @OnlyIn does cause issues. Do not use it.

I will create my own annotation for marking things. It is better than using a comment. It would be interesting if I could somehow intercept method calls for methods annotated with it, and check the side. I am not sure If I can do that with my limited java expertise.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
    • It is an issue with quark - update it to this build: https://www.curseforge.com/minecraft/mc-mods/quark/files/3642325
    • Remove Instant Massive Structures Mod from your server     Add new crash-reports with sites like https://paste.ee/  
    • Update your drivers: https://www.amd.com/en/support/graphics/amd-radeon-r9-series/amd-radeon-r9-200-series/amd-radeon-r9-280x
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.