Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

Entity not rendering


matthew123
 Share

Recommended Posts

The entity creates a pillar of blocks. It appears to work fine; the blocks are getting placed. But the entity is not rendering. It should be displaying interpolated movement upwards. Instead, the blocks just appear (so the entity is invisible).

    public void tick() {
        LogManager.getLogger().info("ticks: " + ticks++ + " current " + blockPosition() + " old " + oldPos);
        if(blockPosition().equals(endBlockPos)){
            if(releaseJutsuOnce != null){
                releaseJutsuOnce.execute();
            }
            remove();
            return;
        }
        if(blockPosition().equals(oldPos.above())){
            oldPos = blockPosition();
            level.setBlockAndUpdate(blockPosition(), blockState);
        }
        setDeltaMovement(0, 0.1, 0);
        move(MoverType.SELF, getDeltaMovement());
    }

Renderer (copied from falling block):

public class MudWallBlockEntityRenderer extends EntityRenderer<MudWallBlockEntity> {
    public MudWallBlockEntityRenderer(EntityRendererManager entityRendererManager) {
        super(entityRendererManager);
        this.shadowRadius = 0.5F;
    }

    @Override
    public void render(MudWallBlockEntity entity, float entityYaw, float partialTicks, MatrixStack matrixStack, IRenderTypeBuffer buffer, int packedLight) {
        BlockState blockstate = entity.getBlockState();
        if (blockstate.getRenderShape() == BlockRenderType.MODEL) {
            World world = entity.getCommandSenderWorld();
            if (blockstate != world.getBlockState(entity.blockPosition()) && blockstate.getRenderShape() != BlockRenderType.INVISIBLE) {
                matrixStack.pushPose();
                BlockPos blockpos = new BlockPos(entity.getX(), entity.getBoundingBox().maxY, entity.getZ());
                matrixStack.translate(-0.5D, 0.0D, -0.5D);
                BlockRendererDispatcher blockrendererdispatcher = Minecraft.getInstance().getBlockRenderer();
                for (net.minecraft.client.renderer.RenderType type : net.minecraft.client.renderer.RenderType.chunkBufferLayers()) {
                    if (RenderTypeLookup.canRenderInLayer(blockstate, type)) {
                        net.minecraftforge.client.ForgeHooksClient.setRenderLayer(type);
                        blockrendererdispatcher.getModelRenderer().tesselateBlock(world, blockrendererdispatcher.getBlockModel(blockstate), blockstate, blockpos, matrixStack, buffer.getBuffer(type), false, new Random(), blockstate.getSeed(entity.getStartingBlockPos()), OverlayTexture.NO_OVERLAY);
                    }
                }
                net.minecraftforge.client.ForgeHooksClient.setRenderLayer(null);
                matrixStack.popPose();
                super.render(entity, entityYaw, partialTicks, matrixStack, buffer, packedLight);
            }
        }
    }

    @Override
    public ResourceLocation getTextureLocation(MudWallBlockEntity pEntity) {
        return AtlasTexture.LOCATION_BLOCKS;
    }
}

Registration:

RenderingRegistry.registerEntityRenderingHandler(ModEntities.MUD_WALL_BLOCK_ENTITY.get(), MudWallBlockEntityRenderer::new);

 

Link to comment
Share on other sites

2 minutes ago, diesieben07 said:

Show the whole entity class.

public class MudWallBlockEntity extends Entity {
    private static final BlockState blockState = ModBlocks.TEMPORARY_DIRT_BLOCK.get().defaultBlockState();

    private int height;
    private OneTimeRunnable finishJutsuOnce;

    private BlockPos startingBlockPos;
    private BlockPos endBlockPos;
    private BlockPos oldPos;

    private int ticks;

    public MudWallBlockEntity(EntityType<? extends MudWallBlockEntity> entityType, World level) {
        super(entityType, level);
    }

    @OnlyIn(Dist.CLIENT)
    public MudWallBlockEntity(EntityType<? extends MudWallBlockEntity> entityType, World level, BlockPos position, int height, OneTimeRunnable releaseJutsu) {
        super(entityType, level);

        this.startingBlockPos = position;
        this.endBlockPos = new BlockPos(startingBlockPos.getX(), height, startingBlockPos.getZ());
        this.oldPos = position;

        this.height = height;
        this.finishJutsuOnce = releaseJutsu;

        this.setPos(position.getX(), position.getY(), position.getZ());
        this.ticks = 0;
    }

    @Override
    protected void defineSynchedData() {
    }

    @Override
    protected void readAdditionalSaveData(@Nonnull CompoundNBT pCompound) {
        startingBlockPos = new BlockPos(pCompound.getInt("StartX"), pCompound.getInt("StartY"),pCompound.getInt("StartZ"));
        endBlockPos = new BlockPos(startingBlockPos.getX(), pCompound.getInt("Height"), startingBlockPos.getZ());
        oldPos = new BlockPos(startingBlockPos.getX(), pCompound.getInt("CurrentHeight"), startingBlockPos.getZ());
    }

    @Override
    protected void addAdditionalSaveData(@Nonnull CompoundNBT pCompound) {
        pCompound.putInt("StartX", startingBlockPos.getX());
        pCompound.putInt("StartY", startingBlockPos.getY());
        pCompound.putInt("StartZ", startingBlockPos.getZ());
        pCompound.putInt("Height", height);
        pCompound.putInt("CurrentHeight", oldPos.getY());
    }

    @Nonnull
    @Override
    public IPacket<?> getAddEntityPacket() {
        return new SSpawnObjectPacket(this, Block.getId(this.getBlockState()));
    }

    @Override
    public void tick() {
        LogManager.getLogger().info("ticks: " + ticks++ + " current " + blockPosition() + " old " + oldPos);

        if(blockPosition().equals(endBlockPos)){
            if(finishJutsuOnce != null){
                finishJutsuOnce.execute();
            }

            remove();
            return;
        }

        if(blockPosition().equals(oldPos.above())){
            oldPos = blockPosition();
            level.setBlockAndUpdate(blockPosition(), blockState);
        }

        setDeltaMovement(0, 0.1, 0);
        move(MoverType.SELF, getDeltaMovement());
    }

    public BlockState getBlockState() {
        return blockState;
    }

    public BlockPos getStartingBlockPos() { return startingBlockPos; }

    @Override
    public boolean canBeCollidedWith() {
        return false;
    }

    @Override
    protected boolean canAddPassenger(Entity pPassenger) {
        return false;
    }

    @Override
    public boolean canChangeDimensions() {
        return false;
    }
}

 

Link to comment
Share on other sites

4 minutes ago, diesieben07 said:

This is not at all the correct usage for @OnlyIn. Yes, @OnlyIn does cause issues. Do not use it.

I will create my own annotation for marking things. It is better than using a comment. It would be interesting if I could somehow intercept method calls for methods annotated with it, and check the side. I am not sure If I can do that with my limited java expertise.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • dude see me code, drawTexturedModalRect(X,Y,IMAGEOFFSETX,IMAGEOFFSETY,1920,1080,ZLEVEL) with drawTexturedModalRect the max size of the image is 1920x1080?, what method should i use
    • The code:   public class AncientFruitBlock extends CropsBlock { public static final IntegerProperty AGE = BlockStateProperties.AGE_0_5; public static final EnumProperty<DoubleBlockHalf> HALF = BlockStateProperties.DOUBLE_BLOCK_HALF; private static final VoxelShape[] SHAPE_BY_AGE = new VoxelShape[]{ Block.makeCuboidShape(0.0D, 0.0D, 0.0D, 16.0D, 6.0D, 16.0D), Block.makeCuboidShape(0.0D, 0.0D, 0.0D, 16.0D, 8.0D, 16.0D), Block.makeCuboidShape(0.0D, 0.0D, 0.0D, 16.0D, 10.0D, 16.0D), Block.makeCuboidShape(0.0D, 0.0D, 0.0D, 16.0D, 12.0D, 16.0D), Block.makeCuboidShape(0.0D, 0.0D, 0.0D, 16.0D, 14.0D, 16.0D), Block.makeCuboidShape(0.0D, 0.0D, 0.0D, 16.0D, 16.0D, 16.0D)}; public AncientFruitBlock(Properties builder) { super(builder); this.setDefaultState(this.stateContainer.getBaseState().with(HALF, DoubleBlockHalf.LOWER)); } public BlockState updatePostPlacement(BlockState stateIn, Direction facing, BlockState facingState, IWorld worldIn, BlockPos currentPos, BlockPos facingPos) { DoubleBlockHalf doubleblockhalf = stateIn.get(HALF); if (facing.getAxis() != Direction.Axis.Y || doubleblockhalf == DoubleBlockHalf.LOWER != (facing == Direction.UP) || facingState.isIn(this) && facingState.get(HALF) != doubleblockhalf) { return doubleblockhalf == DoubleBlockHalf.LOWER && facing == Direction.DOWN && !stateIn.isValidPosition(worldIn, currentPos) ? Blocks.AIR.getDefaultState() : super.updatePostPlacement(stateIn, facing, facingState, worldIn, currentPos, facingPos); } else { return Blocks.AIR.getDefaultState(); } } @Nullable public BlockState getStateForPlacement(BlockItemUseContext context) { BlockPos blockpos = context.getPos(); return blockpos.getY() < 255 && context.getWorld().getBlockState(blockpos.up()).isReplaceable(context) ? super.getStateForPlacement(context) : null; } public void onBlockPlacedBy(World worldIn, BlockPos pos, BlockState state, LivingEntity placer, ItemStack stack) { worldIn.setBlockState(pos.up(), this.getDefaultState().with(HALF, DoubleBlockHalf.UPPER), 3); } public boolean isValidPosition(BlockState state, IWorldReader worldIn, BlockPos pos) { if (state.get(HALF) != DoubleBlockHalf.UPPER) { return super.isValidPosition(state, worldIn, pos); } else { BlockState blockstate = worldIn.getBlockState(pos.down()); if (state.getBlock() != this) return super.isValidPosition(state, worldIn, pos); return blockstate.isIn(this) && blockstate.get(HALF) == DoubleBlockHalf.LOWER; } } public void placeAt(IWorld worldIn, BlockPos pos, int flags) { worldIn.setBlockState(pos, this.getDefaultState().with(HALF, DoubleBlockHalf.LOWER), flags); worldIn.setBlockState(pos.up(), this.getDefaultState().with(HALF, DoubleBlockHalf.UPPER), flags); } public void onBlockHarvested(World worldIn, BlockPos pos, BlockState state, PlayerEntity player) { if (!worldIn.isRemote) { if (player.isCreative()) { removeBottomHalf(worldIn, pos, state, player); } else { spawnDrops(state, worldIn, pos, (TileEntity)null, player, player.getHeldItemMainhand()); } } super.onBlockHarvested(worldIn, pos, state, player); } public void harvestBlock(World worldIn, PlayerEntity player, BlockPos pos, BlockState state, @Nullable TileEntity te, ItemStack stack) { super.harvestBlock(worldIn, player, pos, Blocks.AIR.getDefaultState(), te, stack); } protected static void removeBottomHalf(World world, BlockPos pos, BlockState state, PlayerEntity player) { DoubleBlockHalf doubleblockhalf = state.get(HALF); if (doubleblockhalf == DoubleBlockHalf.UPPER) { BlockPos blockpos = pos.down(); BlockState blockstate = world.getBlockState(blockpos); if (blockstate.getBlock() == state.getBlock() && blockstate.get(HALF) == DoubleBlockHalf.LOWER) { world.setBlockState(blockpos, Blocks.AIR.getDefaultState(), 35); world.playEvent(player, 2001, blockpos, Block.getStateId(blockstate)); } } } protected void fillStateContainer(StateContainer.Builder<Block, BlockState> builder) { builder.add(HALF); } @Override protected IItemProvider getSeedsItem() { return ItemInit.ANCIENT_SEED.get(); } @Override public int getMaxAge() { return 5; } @Override public VoxelShape getShape(BlockState state, IBlockReader worldIn, BlockPos pos, ISelectionContext context) { return SHAPE_BY_AGE[state.get(this.getAgeProperty())]; } }  
    • Yes I have, however, when I put the code from the vanilla block into the block class, the game just throws me an error. Log Crash Report
    • Have you looked at the vanilla 2-tall blocks?
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.