Jump to content

Mysterious Disappearing blocks


tlr38usd

Recommended Posts

I have a custom block with a tile entity and when I place it in-game it's fine and works as it should. But when I quit the game and reopen the block is gone! I narrowed the problem down to the read / write nbt methods because when I comment them out the block doesn't disappear.

 

Here's the code

public void writeToNBT(NBTTagCompound nbt) {
	super.writeToNBT(nbt);

	nbt.setIntArray("group", this.group);
	nbt.setIntArray("partners", this.partners);
	nbt.setInteger("speed", this.speed);
	nbt.setInteger("ticksTillCheck", this.ticksTillCheck);
}

public void readFromNBT(NBTTagCompound nbt) {
	super.readFromNBT(nbt);

	this.group = nbt.getIntArray("group");
	this.partners = nbt.getIntArray("partners");
	this.speed = nbt.getInteger("speed");
	this.ticksTillCheck = nbt.getInteger("ticksTillCheck");
}

Link to comment
Share on other sites

try commenting only the inside of the methods

 

public void readagaw(nbt){

super.readagwa(nbt);

 

}

 

 

but not the "super"

 

also try

try{

nbt.setIntArray("group", this.group);

nbt.setIntArray("partners", this.partners);

nbt.setInteger("speed", this.speed);

nbt.setInteger("ticksTillCheck", this.ticksTillCheck);

}catch(Exception e){

e.printStackTrace();

System.out.println("\n\n\n SHIT IS NOT WORKING EEEEUUUUUUUUGGGGG WAAAIIII \n\n\n");

}

 

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

I don't see anything calling blockBreak or setBlockToAir... :P

The issue isn't here, though if commenting out this method solve the issue...

what do you need those data [group,partners,speed,ticksTillCheck] for ?

 

Their plants and those variables store the breeding mechanics for each individual plant

 

 

try commenting only the inside of the methods

 

 

Neither of those suggestions worked =/

 

 

I'm suspecting that you're placing the block only client side. Are you placing the block that's holding the TileEntity in a strange way?

 

Actually I am, I'm using seeds that are based off of the itemReeds code.

 

public boolean onItemUse(ItemStack par1ItemStack,
            EntityPlayer par2EntityPlayer, World par3World, int par4, int par5,
            int par6, int par7, float par8, float par9, float par10)
    {
        
        int i1 = par3World.getBlockId(par4, par5, par6);

        if (i1 == Block.snow.blockID
                && (par3World.getBlockMetadata(par4, par5, par6) & 7) < 1)
        {
            par7 = 1;
        }
        else if (i1 != Block.vine.blockID && i1 != Block.tallGrass.blockID
                && i1 != Block.deadBush.blockID)
        {
            if (par7 == 0)
            {
                --par5;
            }

            if (par7 == 1)
            {
                ++par5;
            }

            if (par7 == 2)
            {
                --par6;
            }

            if (par7 == 3)
            {
                ++par6;
            }

            if (par7 == 4)
            {
                --par4;
            }

            if (par7 == 5)
            {
                ++par4;
            }
        }

        if (!par2EntityPlayer.canPlayerEdit(par4, par5, par6, par7,
                par1ItemStack))
        {
            return false;
        }
        else if (par1ItemStack.stackSize == 0)
        {
            return false;
        }
        else
        {
            if (par3World.canPlaceEntityOnSide(this.spawnIDP, par4, par5, par6,
                    false, par7, (Entity) null, par1ItemStack))
            {
                Block block = Block.blocksList[this.spawnIDP];
                int j1 = block.onBlockPlaced(par3World, par4, par5, par6, par7,
                        par8, par9, par10, 0);

                if (par3World.setBlock(par4, par5, par6, this.spawnIDP, j1, 3))
                {
                    if (par3World.getBlockId(par4, par5, par6) == this.spawnIDP)
                    {
                        Block.blocksList[this.spawnIDP].onBlockPlacedBy(
                                par3World, par4, par5, par6, par2EntityPlayer,
                                par1ItemStack);
                        Block.blocksList[this.spawnIDP].onPostBlockPlaced(
                                par3World, par4, par5, par6, j1);
                    }

                    par3World.playSoundEffect((double) ((float) par4 + 0.5F),
                            (double) ((float) par5 + 0.5F),
                            (double) ((float) par6 + 0.5F),
                            block.stepSound.getPlaceSound(),
                            (block.stepSound.getVolume() + 1.0F) / 2.0F,
                            block.stepSound.getPitch() * 0.8F);
                    --par1ItemStack.stackSize;
                }
            }

            return true;
        }
    }

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.