Jump to content

Sync blockstate


matthew123

Recommended Posts

I am making a pipe mod. The blocks also use a block entity. I added boolean properties for north, south, east, west, up, down and wrote to them on the setPlaced method. In my blockstate json, I use a multipart model to apply the pieces of the pipe to each side. 

It does not seem to be working. How can I synchronize the new blockstate values so that my pipe gets rendered properly?

Link to comment
Share on other sites

1 hour ago, diesieben07 said:

Show your code.

I am using BlockState.setValue on the overriden setPlacedBy method. The values are getting set, i added some logging there. I am using BlockStateProperties.NORTH, SOUTH, ... .

I also made sure they are added in the createBlockStateDefinition method and registerDefaultState in the constructor.

this is the blockstate:

{
    "multipart": [
        {
            "apply": { "model": "cables:/block/cables/without_connections" }
        },
        {
            "when": { "north": true },
            "apply": { "model": "cables:/block/cables/connection", "uvlock": true }
        },
        {
            "when": { "west": true },
            "apply": { "model": "cables:/block/cables/connection", "y": 90, "uvlock": true }
        },
        {
            "when": { "south": true },
            "apply": { "model": "cables:/block/cables/connection", "y": 180, "uvlock": true }
        },
        {
            "when": { "east": true },
            "apply": { "model": "cables:/block/cables/connection", "y": 270, "uvlock": true }
        }
    ]
}

 

Link to comment
Share on other sites

8 minutes ago, diesieben07 said:

That achieves nothing. BlockState is immutable. You should override getStateForPlacement instead and return the modified BlockState.

That sucks. I have some logic on the tile entity that will be used to get those values. Do I really have to move that logic out of the tile entity? I assume the tile entity is placed after that method.

Link to comment
Share on other sites

29 minutes ago, diesieben07 said:

Why are you duplicating data? Either store the info in the BlockState or in the TileEntity. Don't do both.

the logic I am referring to gets the Directions where other pipes that can be connected are. To set the right values in the block state, I would have to move that logic out of the tile entity so i can use it from the block. Preferably, I should move it to the block class. Is that correct?

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
    • It is an issue with quark - update it to this build: https://www.curseforge.com/minecraft/mc-mods/quark/files/3642325
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.