Jump to content

My crafting manager "addRecipe" returns a Null Pointer Exception


SteampunkRBot

Recommended Posts

I am working on a crafting manager for my mod, but when I try to use my addRecipe I get a null pointer exception.

 

My IBrewingManager

package RV97.Drinks.Utils.Crafting;

import java.util.List;
import net.minecraft.item.ItemStack;
import net.minecraftforge.liquids.LiquidStack;

public abstract interface IBrewingManager
{
public abstract void addRecipe(ItemStack inputItemStack1, LiquidStack outputLiquidStack, int brewingTime);
public abstract void addRecipe(ItemStack inputItemStack1, ItemStack inputItemStack2, LiquidStack outputLiquidStack, int brewingTime);
public abstract void addRecipe(ItemStack inputItemStack1, LiquidStack inputLiquidStack, LiquidStack outputLiquidStack, int brewingTime);
public abstract void addRecipe(ItemStack inputItemStack1, ItemStack inputItemStack2, LiquidStack inputLiquidStack, LiquidStack outputLiquidStack, int brewingTime);

public abstract IBrewingRecipe getRecipe(ItemStack inputStack, ItemStack inputStack2, LiquidStack inputLiquid);

public abstract List getRecipes();
}

 

My CraftingManager

package RV97.Drinks.Utils.Crafting;

public class CraftingManager {
public static IBrewingManager brewery;
}

 

My IBrewingRecipe

package RV97.Drinks.Utils.Crafting;

import net.minecraft.item.ItemStack;
import net.minecraftforge.liquids.LiquidStack;

public abstract interface IBrewingRecipe {

public abstract int getBrewTime();

public abstract ItemStack getInput1();
  
public abstract ItemStack getInput2();
  
public abstract LiquidStack getLiquidInput();

public abstract LiquidStack getLiquidOutput();

}

 

My attempt at addRecipe

CraftingManager.brewery.addRecipe(new ItemStack(Item.sugar), new ItemStack(Item.appleRed), new LiquidStack(Block.waterStill.blockID, 1000), new LiquidStack(applejackDaniels, 1000), 300);

 

And the error I get is as follows:

 

2013-08-18 18:56:08 [sEVERE] [ForgeModLoader] Caught exception from RV97Drinks

java.lang.NullPointerException

at RV97.Drinks.Liquids.registerLiquidRecipes(Liquids.java:33)

at RV97.Drinks.DrinksCore.preInit(DrinksCore.java:44)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

at java.lang.reflect.Method.invoke(Unknown Source)

at cpw.mods.fml.common.FMLModContainer.handleModStateEvent(FMLModContainer.java:494)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

at java.lang.reflect.Method.invoke(Unknown Source)

at com.google.common.eventbus.EventHandler.handleEvent(EventHandler.java:74)

at com.google.common.eventbus.SynchronizedEventHandler.handleEvent(SynchronizedEventHandler.java:45)

at com.google.common.eventbus.EventBus.dispatch(EventBus.java:314)

at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:296)

at com.google.common.eventbus.EventBus.post(EventBus.java:267)

at cpw.mods.fml.common.LoadController.sendEventToModContainer(LoadController.java:192)

at cpw.mods.fml.common.LoadController.propogateStateMessage(LoadController.java:172)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

at java.lang.reflect.Method.invoke(Unknown Source)

at com.google.common.eventbus.EventHandler.handleEvent(EventHandler.java:74)

at com.google.common.eventbus.SynchronizedEventHandler.handleEvent(SynchronizedEventHandler.java:45)

at com.google.common.eventbus.EventBus.dispatch(EventBus.java:314)

at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:296)

at com.google.common.eventbus.EventBus.post(EventBus.java:267)

at cpw.mods.fml.common.LoadController.distributeStateMessage(LoadController.java:103)

at cpw.mods.fml.common.Loader.loadMods(Loader.java:515)

at cpw.mods.fml.client.FMLClientHandler.beginMinecraftLoading(FMLClientHandler.java:163)

at net.minecraft.client.Minecraft.startGame(Minecraft.java:411)

at net.minecraft.client.MinecraftAppletImpl.startGame(MinecraftAppletImpl.java:44)

at net.minecraft.client.Minecraft.run(Minecraft.java:733)

at java.lang.Thread.run(Unknown Source)

2013-08-18 18:56:08 [iNFO] [sTDERR] java.lang.NullPointerException

2013-08-18 18:56:08 [iNFO] [sTDERR] at RV97.Drinks.Liquids.registerLiquidRecipes(Liquids.java:33)

2013-08-18 18:56:08 [iNFO] [sTDERR] at RV97.Drinks.DrinksCore.preInit(DrinksCore.java:44)

2013-08-18 18:56:08 [iNFO] [sTDERR] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

2013-08-18 18:56:08 [iNFO] [sTDERR] at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

2013-08-18 18:56:08 [iNFO] [sTDERR] at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

2013-08-18 18:56:08 [iNFO] [sTDERR] at java.lang.reflect.Method.invoke(Unknown Source)

2013-08-18 18:56:08 [iNFO] [sTDERR] at cpw.mods.fml.common.FMLModContainer.handleModStateEvent(FMLModContainer.java:494)

2013-08-18 18:56:08 [iNFO] [sTDERR] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

2013-08-18 18:56:08 [iNFO] [sTDERR] at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

2013-08-18 18:56:08 [iNFO] [sTDERR] at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

2013-08-18 18:56:08 [iNFO] [sTDERR] at java.lang.reflect.Method.invoke(Unknown Source)

2013-08-18 18:56:08 [iNFO] [sTDERR] at com.google.common.eventbus.EventHandler.handleEvent(EventHandler.java:74)

2013-08-18 18:56:08 [iNFO] [sTDERR] at com.google.common.eventbus.SynchronizedEventHandler.handleEvent(SynchronizedEventHandler.java:45)

2013-08-18 18:56:08 [iNFO] [sTDERR] at com.google.common.eventbus.EventBus.dispatch(EventBus.java:314)

2013-08-18 18:56:08 [iNFO] [sTDERR] at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:296)

2013-08-18 18:56:08 [iNFO] [sTDERR] at com.google.common.eventbus.EventBus.post(EventBus.java:267)

2013-08-18 18:56:08 [iNFO] [sTDERR] at cpw.mods.fml.common.LoadController.sendEventToModContainer(LoadController.java:192)

2013-08-18 18:56:08 [iNFO] [sTDERR] at cpw.mods.fml.common.LoadController.propogateStateMessage(LoadController.java:172)

2013-08-18 18:56:08 [iNFO] [sTDERR] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

2013-08-18 18:56:08 [iNFO] [sTDERR] at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

2013-08-18 18:56:08 [iNFO] [sTDERR] at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

2013-08-18 18:56:08 [iNFO] [sTDERR] at java.lang.reflect.Method.invoke(Unknown Source)

2013-08-18 18:56:08 [iNFO] [sTDERR] at com.google.common.eventbus.EventHandler.handleEvent(EventHandler.java:74)

2013-08-18 18:56:08 [iNFO] [sTDERR] at com.google.common.eventbus.SynchronizedEventHandler.handleEvent(SynchronizedEventHandler.java:45)

2013-08-18 18:56:08 [iNFO] [sTDERR] at com.google.common.eventbus.EventBus.dispatch(EventBus.java:314)

2013-08-18 18:56:08 [iNFO] [sTDERR] at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:296)

2013-08-18 18:56:08 [iNFO] [sTDERR] at com.google.common.eventbus.EventBus.post(EventBus.java:267)

2013-08-18 18:56:08 [iNFO] [sTDERR] at cpw.mods.fml.common.LoadController.distributeStateMessage(LoadController.java:103)

2013-08-18 18:56:08 [iNFO] [sTDERR] at cpw.mods.fml.common.Loader.loadMods(Loader.java:515)

2013-08-18 18:56:08 [iNFO] [sTDERR] at cpw.mods.fml.client.FMLClientHandler.beginMinecraftLoading(FMLClientHandler.java:163)

2013-08-18 18:56:08 [iNFO] [sTDERR] at net.minecraft.client.Minecraft.startGame(Minecraft.java:411)

2013-08-18 18:56:08 [iNFO] [sTDERR] at net.minecraft.client.MinecraftAppletImpl.startGame(MinecraftAppletImpl.java:44)

2013-08-18 18:56:08 [iNFO] [sTDERR] at net.minecraft.client.Minecraft.run(Minecraft.java:733)

2013-08-18 18:56:08 [iNFO] [sTDERR] at java.lang.Thread.run(Unknown Source)

 

 

RV97.Drinks.Liquids.registerLiquidRecipes(Liquids.java:33) Refers to where I have the addRecipe I show above, and RV97.Drinks.DrinksCore.preInit(DrinksCore.java:44) refers to when I register that piece of code (I have addRecipe under a function I run during the mod initialisation)

 

Any and all help is appreciated. :)

Link to comment
Share on other sites

Man, the abstract code is useless to us. Your implementation is what is important.

public class CraftingManager {
public static IBrewingManager brewery;
}

This looks a bit...empty, don't you think ?

 

By the way...interfaces are always abstract.

Link to comment
Share on other sites

@Mazetar

Ok, im now getting this:

 

2013-08-18 20:05:52 [iNFO] [sTDOUT] CONFLICT @ 0 item slot already occupied by net.minecraft.item.ItemSpade@7deb98f6 while adding net.minecraft.item.Item@76877f0f

2013-08-18 20:05:52 [iNFO] [fml.ItemTracker] The mod RV97Drinks is overwriting existing item at 256 (net.minecraft.item.ItemSpade from Minecraft) with net.minecraft.item.Item

2013-08-18 20:05:52 [iNFO] [sTDOUT] CONFLICT @ 0 item slot already occupied by net.minecraft.item.Item@76877f0f while adding net.minecraft.item.Item@4aea4e2e

2013-08-18 20:05:52 [iNFO] [fml.ItemTracker] The mod RV97Drinks is overwriting existing item at 256 (net.minecraft.item.Item from RV97Drinks) with net.minecraft.item.Item

 

 

I have no idea why its mentioning the Spade item... Unless I accidentally conflicted with it with one of my items.

 

@GotoLink

I plan to add more types of crafting, so that will be the central crafting class where I, and possibly other mods, may access these crafting managers.

Link to comment
Share on other sites

Here are my BrewingManager and BrewingRecipe classes (Not to be mistaken for IBrewingManager and IBrewingRecipe), which handle adding the recipes etc.

 

BrewingManager:

package RV97.Drinks.Utils.Crafting;

import java.util.ArrayList;
import java.util.List;

import net.minecraft.item.ItemStack;
import net.minecraftforge.liquids.LiquidStack;

public class BrewingManager implements IBrewingManager{

private final List recipes;

public BrewingManager()
{
	this.recipes = new ArrayList();
}

public static IBrewingManager getInstance(){
	return CraftingManager.brewery;
}

public void addRecipe(ItemStack inputItemStack1, LiquidStack outputLiquidStack, int brewingTime) {
	if(inputItemStack1 == null){
		return;
	}
	this.recipes.add(new BrewingRecipe(inputItemStack1, outputLiquidStack, brewingTime));
}


public void addRecipe(ItemStack inputItemStack1, ItemStack inputItemStack2, LiquidStack outputLiquidStack, int brewingTime) {
	if((inputItemStack1 == null) || (inputItemStack2 == null)){
		return;
	}
	this.recipes.add(new BrewingRecipe(inputItemStack1, inputItemStack2, outputLiquidStack, brewingTime));
}


public void addRecipe(ItemStack inputItemStack1, LiquidStack inputLiquidStack, LiquidStack outputLiquidStack, int brewingTime) {
	if((inputItemStack1 == null) || (inputLiquidStack == null)){
		return;
	}
	this.recipes.add(new BrewingRecipe(inputItemStack1, inputLiquidStack, outputLiquidStack, brewingTime));
}


public void addRecipe(ItemStack inputItemStack1, ItemStack inputItemStack2, LiquidStack inputLiquidStack, LiquidStack outputLiquidStack, int brewingTime) {
	if((inputItemStack1 == null) || (inputItemStack2 == null) || (inputLiquidStack == null)){
		return;
	}
	this.recipes.add(new BrewingRecipe(inputItemStack1, inputItemStack2, inputLiquidStack, outputLiquidStack, brewingTime));
}


public IBrewingRecipe getRecipe(ItemStack inputStack) {
	if (inputStack == null){
		return null;
	}
	for (BrewingRecipe r : this.recipes){
		if(inputStack.isItemEqual(r.getInput1())){
			return r;
		}
	}
	return null;
}

public IBrewingRecipe getRecipe(ItemStack inputStack, ItemStack inputStack2) {
	if ((inputStack == null)||(inputStack2 == null)){
		return null;
	}
	for (BrewingRecipe r : this.recipes){
		if((inputStack.isItemEqual(r.getInput1())) && (inputStack2.isItemEqual(r.getInput2()))){
			return r;
		}
	}
	return null;
}

public IBrewingRecipe getRecipe(ItemStack inputStack, LiquidStack inputLiquid) {
	if ((inputStack == null)||(inputLiquid == null)){
		return null;
	}
	for (BrewingRecipe r : this.recipes){
		if((inputStack.isItemEqual(r.getInput1())) && (inputLiquid.isLiquidEqual(r.getLiquidInput()))){
			return r;
		}
	}
	return null;
}

public IBrewingRecipe getRecipe(ItemStack inputStack, ItemStack inputStack2, LiquidStack inputLiquid) {
	if ((inputStack == null)|| (inputStack2 == null) ||(inputLiquid == null)){
		return null;
	}
	for (BrewingRecipe r : this.recipes){
		if((inputStack.isItemEqual(r.getInput1())) && (inputStack2.isItemEqual(r.getInput2())) && (inputLiquid.isLiquidEqual(r.getLiquidInput()))){
			return r;
		}
	}
	return null;
}

public List getRecipes() {
	return this.recipes;
}


}

 

BrewingRecipe:

package RV97.Drinks.Utils.Crafting;

import net.minecraft.item.ItemStack;
import net.minecraftforge.liquids.LiquidStack;

public class BrewingRecipe implements IBrewingRecipe{
private final ItemStack inputStack;
private final ItemStack inputStack2;
private final LiquidStack inputLiquid;
private final LiquidStack resultLiquid;
private final int brewTime;

public BrewingRecipe(ItemStack inputStack, LiquidStack resultLiquid, int brewTime){
	this.inputStack = inputStack;
	this.resultLiquid = resultLiquid;
	this.brewTime = brewTime;
}

public BrewingRecipe(ItemStack inputStack, ItemStack inputStack2, LiquidStack resultLiquid, int brewTime){
	this.inputStack = inputStack;
	this.inputStack2 = inputStack2;
	this.resultLiquid = resultLiquid;
	this.brewTime = brewTime;
}

public BrewingRecipe(ItemStack inputStack, LiquidStack inputLiquid, LiquidStack resultLiquid, int brewTime){
	this.inputStack = inputStack;
	this.inputLiquid = inputLiquid;
	this.resultLiquid = resultLiquid;
	this.brewTime = brewTime;
}

public BrewingRecipe(ItemStack inputStack, ItemStack inputStack2, LiquidStack inputLiquid, LiquidStack resultLiquid, int brewTime){
	this.inputStack = inputStack;
	this.inputStack2 = inputStack2;
	this.inputLiquid = inputLiquid;
	this.resultLiquid = resultLiquid;
	this.brewTime = brewTime;
}

public int getBrewTime() {

	return this.brewTime;
}

public ItemStack getInput1() {

	return this.inputStack.copy();
}

public ItemStack getInput2() {

	if(this.inputStack2 == null){
	return null;
	}
	return this.inputStack2.copy();
}

public LiquidStack getLiquidInput() {

	if(this.inputLiquid == null){
	return null;
	}
	return this.inputLiquid.copy();
}

public LiquidStack getLiquidOutput() {

	return this.resultLiquid.copy();
}
}

Link to comment
Share on other sites

I moved the BrewingRecipe code into my brewing manager, so that should be fine. Still need to solve this crash though... I shall try re-adding all my items, just to check none of them are conflicting with 0. Shall Report back shortly.

 

EDIT: Ok, now the breakline no longer refers to id conflicts of 0 (turns out I forgot to change my config class to use my ID's for 2 items... Silly mistake ¬¬)

 

However, we are back to the original crash of:

 

2013-08-19 16:16:17 [iNFO] [sTDERR] java.lang.NullPointerException

2013-08-19 16:16:17 [iNFO] [sTDERR] at RV97.Drinks.Liquids.registerLiquidRecipes(Liquids.java:33)

2013-08-19 16:16:17 [iNFO] [sTDERR] at RV97.Drinks.DrinksCore.preInit(DrinksCore.java:44)

2013-08-19 16:16:17 [iNFO] [sTDERR] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

2013-08-19 16:16:17 [iNFO] [sTDERR] at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

2013-08-19 16:16:17 [iNFO] [sTDERR] at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

2013-08-19 16:16:17 [iNFO] [sTDERR] at java.lang.reflect.Method.invoke(Unknown Source)

2013-08-19 16:16:17 [iNFO] [sTDERR] at cpw.mods.fml.common.FMLModContainer.handleModStateEvent(FMLModContainer.java:494)

2013-08-19 16:16:17 [iNFO] [sTDERR] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

2013-08-19 16:16:17 [iNFO] [sTDERR] at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

2013-08-19 16:16:17 [iNFO] [sTDERR] at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

2013-08-19 16:16:17 [iNFO] [sTDERR] at java.lang.reflect.Method.invoke(Unknown Source)

2013-08-19 16:16:17 [iNFO] [sTDERR] at com.google.common.eventbus.EventHandler.handleEvent(EventHandler.java:74)

2013-08-19 16:16:17 [iNFO] [sTDERR] at com.google.common.eventbus.SynchronizedEventHandler.handleEvent(SynchronizedEventHandler.java:45)

2013-08-19 16:16:17 [iNFO] [sTDERR] at com.google.common.eventbus.EventBus.dispatch(EventBus.java:314)

2013-08-19 16:16:17 [iNFO] [sTDERR] at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:296)

2013-08-19 16:16:17 [iNFO] [sTDERR] at com.google.common.eventbus.EventBus.post(EventBus.java:267)

2013-08-19 16:16:17 [iNFO] [sTDERR] at cpw.mods.fml.common.LoadController.sendEventToModContainer(LoadController.java:192)

2013-08-19 16:16:17 [iNFO] [sTDERR] at cpw.mods.fml.common.LoadController.propogateStateMessage(LoadController.java:172)

2013-08-19 16:16:17 [iNFO] [sTDERR] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

2013-08-19 16:16:17 [iNFO] [sTDERR] at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

2013-08-19 16:16:17 [iNFO] [sTDERR] at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

2013-08-19 16:16:17 [iNFO] [sTDERR] at java.lang.reflect.Method.invoke(Unknown Source)

2013-08-19 16:16:17 [iNFO] [sTDERR] at com.google.common.eventbus.EventHandler.handleEvent(EventHandler.java:74)

2013-08-19 16:16:17 [iNFO] [sTDERR] at com.google.common.eventbus.SynchronizedEventHandler.handleEvent(SynchronizedEventHandler.java:45)

2013-08-19 16:16:17 [iNFO] [sTDERR] at com.google.common.eventbus.EventBus.dispatch(EventBus.java:314)

2013-08-19 16:16:17 [iNFO] [sTDERR] at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:296)

2013-08-19 16:16:17 [iNFO] [sTDERR] at com.google.common.eventbus.EventBus.post(EventBus.java:267)

2013-08-19 16:16:17 [iNFO] [sTDERR] at cpw.mods.fml.common.LoadController.distributeStateMessage(LoadController.java:103)

2013-08-19 16:16:17 [iNFO] [sTDERR] at cpw.mods.fml.common.Loader.loadMods(Loader.java:515)

2013-08-19 16:16:17 [iNFO] [sTDERR] at cpw.mods.fml.client.FMLClientHandler.beginMinecraftLoading(FMLClientHandler.java:163)

2013-08-19 16:16:17 [iNFO] [sTDERR] at net.minecraft.client.Minecraft.startGame(Minecraft.java:411)

2013-08-19 16:16:17 [iNFO] [sTDERR] at net.minecraft.client.MinecraftAppletImpl.startGame(MinecraftAppletImpl.java:44)

2013-08-19 16:16:17 [iNFO] [sTDERR] at net.minecraft.client.Minecraft.run(Minecraft.java:733)

2013-08-19 16:16:17 [iNFO] [sTDERR] at java.lang.Thread.run(Unknown Source)

 

Link to comment
Share on other sites

2013-08-19 16:16:17  [sTDERR] java.lang.NullPointerException

2013-08-19 16:16:17  [sTDERR]    at RV97.Drinks.Liquids.registerLiquidRecipes(Liquids.java:33)

 

can we see those lines ?, actually the whole class and everythign related to it, its a NPE it shouldnt be that hard

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

@hydroFlame

My Liquids class as requested:

package RV97.Drinks;

import cpw.mods.fml.common.registry.LanguageRegistry;
import RV97.Drinks.Config.ItemInfo;
import RV97.Drinks.Items.Items;
import RV97.Drinks.Utils.Crafting.CraftingManager;
import net.minecraft.block.Block;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraftforge.liquids.LiquidContainerData;
import net.minecraftforge.liquids.LiquidContainerRegistry;
import net.minecraftforge.liquids.LiquidDictionary;
import net.minecraftforge.liquids.LiquidStack;

public class Liquids {
public static Item applejackDaniels;
public static Item goldApplejackDaniels;
public static Item witherWine;
public static Item zambambooze;
public static Item spiderSpirit;

public static void init(){
	applejackDaniels = new Item(ItemInfo.LIQUID_ID).setUnlocalizedName("applejackDaniels");
	LanguageRegistry.addName(applejackDaniels, "Apple JackDaniels");
}

public static void registerLiquids(){
	LiquidDictionary.getOrCreateLiquid("Apple JackDaniels", new LiquidStack(applejackDaniels, 1));
	LiquidContainerRegistry.registerLiquid(new LiquidContainerData(LiquidDictionary.getLiquid("Apple JackDaniels", 1000), new ItemStack(Items.drink,1,1), new ItemStack(Items.mug)));
}

public static void registerLiquidRecipes(){
	CraftingManager.brewery.addRecipe(new ItemStack(Item.sugar), new ItemStack(Item.appleRed), new LiquidStack(Block.waterStill.blockID, 1000), new LiquidStack(Block.lavaStill, 1000), 300);
}
}

 

Line 33 is: CraftingManager.brewery.addRecipe(new ItemStack(Item.sugar), new ItemStack(Item.appleRed), new LiquidStack(Block.waterStill.blockID, 1000), new LiquidStack(Block.lavaStill, 1000), 300);

 

@GotoLink

I moved that code into the BrewingManager code, which is the only class that tries to access those lines, so that should fix it (atleast, for now).

Link to comment
Share on other sites

@hydroflame

I am not sure... Where should it be? (I might have forgotten to create a class or two, as this is my first crafting system.)

 

@GotoLink

I did indeed remove the "final" keyword :)

Nice ;)

 

In your CraftingManager constructor maybe ?  ::)

public class CraftingManager {
public static IBrewingManager brewery;
public CraftingManager(IBrewingManager brewingMnger)
{
this.brewery = brewingMnger;
}
}

Link to comment
Share on other sites

I am not sure... Where should it be? (I might have forgotten to create a class or two, as this is my first crafting system.)

"somewhere" xD

literally, the NullPointerException is due to that

you are trying to call a method on a object that doesnt exists

 

public static IBrewingManager brewery;

this mean "yeah i have a IBreingManager" (but only that i have one, it doesnt say what or who it is)

 

then you go

CraftingManager.brewery.addRecipe(args)

and the JVM goes ragemode yelling

WHO THE F*** ARE YOU TALKING ABOUT, THERE'S NOTHING THERE !!!

 

so probably in your main mod class during preinit or wtv you should make:

CraftingManager.brewery = new BrewingManager();

 

actually it doesnt matter WHERE you place that, as long as its before

 

2013-08-18 18:56:08 [sEVERE] [ForgeModLoader] Caught exception from RV97Drinks

java.lang.NullPointerException

  at RV97.Drinks.Liquids.registerLiquidRecipes(Liquids.java:33)

  at RV97.Drinks.DrinksCore.preInit(DrinksCore.java:44)

line 44 of the method preInit in class DrinksCore. because thats when the code needs it ;)

 

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

Ok, that solved it! Thanks for the explaination, I have never heard someone explain something like that xD

 

Just to use this thread a little more, I seem to be having trouble with searching through recipes. In my BrewingManager, I try to make a getRecipe function, but on my "for (BrewingRecipe r : this.recipe)" line, eclipse is telling me "Type mismatch: cannot convert from element type Object to BrewingManager.BrewingRecipe" and as I am still kinda nooby (as you may have gathered :P) I cant't figure out a solution... (Basically, just tell me how to solve this :3)

 

Thanks for all the help so far, I really appreciate it! :)

Link to comment
Share on other sites

that actually simple, your for loop should work but your List does not specify a generic type

 

google "java generic types" and you should find a butload of info on that

but basicly you want to make a

 

private List<BrewingRecipe> theList;

instead of a

private List theList;

the first one specify its a list of Brewing recipe while the 2nd will accept anything :\

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

Guest
This topic is now closed to further replies.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hello. I've been having a problem when launching minecraft forge. It just doesn't open the game, and leaves me with this "(exit code 1)" error. Both regular and optifine versions of minecraft launch just fine, tried both with 1.18.2 and 1.20.1. I can assure that my drivers are updated so that can't be it, and i've tried using Java 17, 18 and 21 to no avail. Even with no mods installed, the thing won't launch. I'll leave the log here, although it's in spanish: https://jmp.sh/s/FPqGBSi30fzKJDt2M1gc My specs are this: Ryzen 3 4100 || Radeon R9 280x || 16gb ram || Windows 10 I'd appreciate any help, thank you in advance.
    • Hey, Me and my friends decided to start up a Server with "a few" mods, the last few days everything went well we used all the items we wanted. Now our Game crashes the moment we touch a Lava Bucket inside our Inventory. It just instantly closes and gives me an "Alc Cleanup"  Crash screen (Using GDLauncher). I honestly dont have a clue how to resolve this error. If anyone could help id really appreciate it, I speak German and Englisch so you can choose whatever you speak more fluently. Thanks in Advance. Plus I dont know how to link my Crash Report help for that would be nice too whoops
    • I hosted a minecraft server and I modded it, and there is always an error on the console which closes the server. If someone knows how to repair it, it would be amazing. Thank you. I paste the crash report down here: ---- Minecraft Crash Report ---- WARNING: coremods are present:   llibrary (llibrary-core-1.0.11-1.12.2.jar)   WolfArmorCore (WolfArmorAndStorage-1.12.2-3.8.0-universal-signed.jar)   AstralCore (astralsorcery-1.12.2-1.10.27.jar)   CreativePatchingLoader (CreativeCore_v1.10.71_mc1.12.2.jar)   SecurityCraftLoadingPlugin ([1.12.2] SecurityCraft v1.9.8.jar)   ForgelinPlugin (Forgelin-1.8.4.jar)   midnight (themidnight-0.3.5.jar)   FutureMC (Future-MC-0.2.19.jar)   SpartanWeaponry-MixinLoader (SpartanWeaponry-1.12.2-1.5.3.jar)   Backpacked (backpacked-1.4.3-1.12.2.jar)   LoadingPlugin (Reskillable-1.12.2-1.13.0.jar)   LoadingPlugin (Bloodmoon-MC1.12.2-1.5.3.jar) Contact their authors BEFORE contacting forge // There are four lights! Time: 3/28/24 12:17 PM Description: Exception in server tick loop net.minecraftforge.fml.common.LoaderException: java.lang.NoClassDefFoundError: net/minecraft/client/multiplayer/WorldClient     at net.minecraftforge.fml.common.AutomaticEventSubscriber.inject(AutomaticEventSubscriber.java:89)     at net.minecraftforge.fml.common.FMLModContainer.constructMod(FMLModContainer.java:612)     at sun.reflect.GeneratedMethodAccessor10.invoke(Unknown Source)     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)     at java.lang.reflect.Method.invoke(Method.java:498)     at com.google.common.eventbus.Subscriber.invokeSubscriberMethod(Subscriber.java:91)     at com.google.common.eventbus.Subscriber$SynchronizedSubscriber.invokeSubscriberMethod(Subscriber.java:150)     at com.google.common.eventbus.Subscriber$1.run(Subscriber.java:76)     at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:399)     at com.google.common.eventbus.Subscriber.dispatchEvent(Subscriber.java:71)     at com.google.common.eventbus.Dispatcher$PerThreadQueuedDispatcher.dispatch(Dispatcher.java:116)     at com.google.common.eventbus.EventBus.post(EventBus.java:217)     at net.minecraftforge.fml.common.LoadController.sendEventToModContainer(LoadController.java:219)     at net.minecraftforge.fml.common.LoadController.propogateStateMessage(LoadController.java:197)     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)     at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)     at java.lang.reflect.Method.invoke(Method.java:498)     at com.google.common.eventbus.Subscriber.invokeSubscriberMethod(Subscriber.java:91)     at com.google.common.eventbus.Subscriber$SynchronizedSubscriber.invokeSubscriberMethod(Subscriber.java:150)     at com.google.common.eventbus.Subscriber$1.run(Subscriber.java:76)     at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:399)     at com.google.common.eventbus.Subscriber.dispatchEvent(Subscriber.java:71)     at com.google.common.eventbus.Dispatcher$PerThreadQueuedDispatcher.dispatch(Dispatcher.java:116)     at com.google.common.eventbus.EventBus.post(EventBus.java:217)     at net.minecraftforge.fml.common.LoadController.distributeStateMessage(LoadController.java:136)     at net.minecraftforge.fml.common.Loader.loadMods(Loader.java:595)     at net.minecraftforge.fml.server.FMLServerHandler.beginServerLoading(FMLServerHandler.java:98)     at net.minecraftforge.fml.common.FMLCommonHandler.onServerStart(FMLCommonHandler.java:333)     at net.minecraft.server.dedicated.DedicatedServer.func_71197_b(DedicatedServer.java:125)     at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:486)     at java.lang.Thread.run(Thread.java:750) Caused by: java.lang.NoClassDefFoundError: net/minecraft/client/multiplayer/WorldClient     at java.lang.Class.getDeclaredMethods0(Native Method)     at java.lang.Class.privateGetDeclaredMethods(Class.java:2701)     at java.lang.Class.privateGetPublicMethods(Class.java:2902)     at java.lang.Class.getMethods(Class.java:1615)     at net.minecraftforge.fml.common.eventhandler.EventBus.register(EventBus.java:82)     at net.minecraftforge.fml.common.AutomaticEventSubscriber.inject(AutomaticEventSubscriber.java:82)     ... 31 more Caused by: java.lang.ClassNotFoundException: net.minecraft.client.multiplayer.WorldClient     at net.minecraft.launchwrapper.LaunchClassLoader.findClass(LaunchClassLoader.java:191)     at java.lang.ClassLoader.loadClass(ClassLoader.java:418)     at java.lang.ClassLoader.loadClass(ClassLoader.java:351)     ... 37 more Caused by: net.minecraftforge.fml.common.asm.ASMTransformerWrapper$TransformerException: Exception in class transformer net.minecraftforge.fml.common.asm.transformers.SideTransformer@4e558728 from coremod FMLCorePlugin     at net.minecraftforge.fml.common.asm.ASMTransformerWrapper$TransformerWrapper.transform(ASMTransformerWrapper.java:260)     at net.minecraft.launchwrapper.LaunchClassLoader.runTransformers(LaunchClassLoader.java:279)     at net.minecraft.launchwrapper.LaunchClassLoader.findClass(LaunchClassLoader.java:176)     ... 39 more Caused by: java.lang.RuntimeException: Attempted to load class bsb for invalid side SERVER     at net.minecraftforge.fml.common.asm.transformers.SideTransformer.transform(SideTransformer.java:62)     at net.minecraftforge.fml.common.asm.ASMTransformerWrapper$TransformerWrapper.transform(ASMTransformerWrapper.java:256)     ... 41 more A detailed walkthrough of the error, its code path and all known details is as follows: --------------------------------------------------------------------------------------- -- System Details -- Details:     Minecraft Version: 1.12.2     Operating System: Linux (amd64) version 5.10.0-28-cloud-amd64     Java Version: 1.8.0_382, Temurin     Java VM Version: OpenJDK 64-Bit Server VM (mixed mode), Temurin     Memory: 948745536 bytes (904 MB) / 1564999680 bytes (1492 MB) up to 7635730432 bytes (7282 MB)     JVM Flags: 2 total; -Xmx8192M -Xms256M     IntCache: cache: 0, tcache: 0, allocated: 0, tallocated: 0     FML: MCP 9.42 Powered by Forge 14.23.5.2860 63 mods loaded, 63 mods active     States: 'U' = Unloaded 'L' = Loaded 'C' = Constructed 'H' = Pre-initialized 'I' = Initialized 'J' = Post-initialized 'A' = Available 'D' = Disabled 'E' = Errored     | State | ID                 | Version                 | Source                                                | Signature                                |     |:----- |:------------------ |:----------------------- |:----------------------------------------------------- |:---------------------------------------- |     | LC    | minecraft          | 1.12.2                  | minecraft.jar                                         | None                                     |     | LC    | mcp                | 9.42                    | minecraft.jar                                         | None                                     |     | LC    | FML                | 8.0.99.99               | forge-1.12.2-14.23.5.2860.jar                         | e3c3d50c7c986df74c645c0ac54639741c90a557 |     | LC    | forge              | 14.23.5.2860            | forge-1.12.2-14.23.5.2860.jar                         | e3c3d50c7c986df74c645c0ac54639741c90a557 |     | LC    | creativecoredummy  | 1.0.0                   | minecraft.jar                                         | None                                     |     | LC    | backpacked         | 1.4.2                   | backpacked-1.4.3-1.12.2.jar                           | None                                     |     | LC    | itemblacklist      | 1.4.3                   | ItemBlacklist-1.4.3.jar                               | None                                     |     | LC    | securitycraft      | v1.9.8                  | [1.12.2] SecurityCraft v1.9.8.jar                     | None                                     |     | LC    | aiimprovements     | 0.0.1.3                 | AIImprovements-1.12-0.0.1b3.jar                       | None                                     |     | LC    | jei                | 4.16.1.301              | jei_1.12.2-4.16.1.301.jar                             | None                                     |     | LC    | appleskin          | 1.0.14                  | AppleSkin-mc1.12-1.0.14.jar                           | None                                     |     | LC    | baubles            | 1.5.2                   | Baubles-1.12-1.5.2.jar                                | None                                     |     | LC    | astralsorcery      | 1.10.27                 | astralsorcery-1.12.2-1.10.27.jar                      | a0f0b759d895c15ceb3e3bcb5f3c2db7c582edf0 |     | LC    | attributefix       | 1.0.12                  | AttributeFix-Forge-1.12.2-1.0.12.jar                  | None                                     |     | LC    | atum               | 2.0.20                  | Atum-1.12.2-2.0.20.jar                                | None                                     |     | LC    | bloodmoon          | 1.5.3                   | Bloodmoon-MC1.12.2-1.5.3.jar                          | d72e0dd57935b3e9476212aea0c0df352dd76291 |     | LC    | forgelin           | 1.8.4                   | Forgelin-1.8.4.jar                                    | None                                     |     | LC    | bountiful          | 2.2.2                   | Bountiful-2.2.2.jar                                   | None                                     |     | LC    | camera             | 1.0.10                  | camera-1.0.10.jar                                     | None                                     |     | LC    | chisel             | MC1.12.2-1.0.2.45       | Chisel-MC1.12.2-1.0.2.45.jar                          | None                                     |     | LC    | collective         | 3.0                     | collective-1.12.2-3.0.jar                             | None                                     |     | LC    | reskillable        | 1.12.2-1.13.0           | Reskillable-1.12.2-1.13.0.jar                         | None                                     |     | LC    | compatskills       | 1.12.2-1.17.0           | CompatSkills-1.12.2-1.17.0.jar                        | None                                     |     | LC    | creativecore       | 1.10.0                  | CreativeCore_v1.10.71_mc1.12.2.jar                    | None                                     |     | LC    | customnpcs         | 1.12                    | CustomNPCs_1.12.2-(05Jul20).jar                       | None                                     |     | LC    | darknesslib        | 1.1.2                   | DarknessLib-1.12.2-1.1.2.jar                          | 220f10d3a93b3ff5fbaa7434cc629d863d6751b9 |     | LC    | dungeonsmod        | @VERSION@               | DungeonsMod-1.12.2-1.0.8.jar                          | None                                     |     | LC    | enhancedvisuals    | 1.3.0                   | EnhancedVisuals_v1.4.4_mc1.12.2.jar                   | None                                     |     | LC    | extrautils2        | 1.0                     | extrautils2-1.12-1.9.9.jar                            | None                                     |     | LC    | futuremc           | 0.2.6                   | Future-MC-0.2.19.jar                                  | None                                     |     | LC    | geckolib3          | 3.0.30                  | geckolib-forge-1.12.2-3.0.31.jar                      | None                                     |     | LC    | gottschcore        | 1.15.1                  | GottschCore-mc1.12.2-f14.23.5.2859-v1.15.1.jar        | None                                     |     | LC    | hardcorerevival    | 1.2.0                   | HardcoreRevival_1.12.2-1.2.0.jar                      | None                                     |     | LC    | waila              | 1.8.26                  | Hwyla-1.8.26-B41_1.12.2.jar                           | None                                     |     | LE    | imsm               | 1.12                    | Instant Massive Structures Mod 1.12.2.jar             | None                                     |     | L     | journeymap         | 1.12.2-5.7.1p2          | journeymap-1.12.2-5.7.1p2.jar                         | None                                     |     | L     | mobsunscreen       | @version@               | mobsunscreen-1.12.2-3.1.5.jar                         | None                                     |     | L     | morpheus           | 1.12.2-3.5.106          | Morpheus-1.12.2-3.5.106.jar                           | None                                     |     | L     | llibrary           | 1.7.20                  | llibrary-1.7.20-1.12.2.jar                            | None                                     |     | L     | mowziesmobs        | 1.5.8                   | mowziesmobs-1.5.8.jar                                 | None                                     |     | L     | nocubessrparmory   | 3.0.0                   | NoCubes_SRP_Combat_Addon_3.0.0.jar                    | None                                     |     | L     | nocubessrpnests    | 3.0.0                   | NoCubes_SRP_Nests_Addon_3.0.0.jar                     | None                                     |     | L     | nocubessrpsurvival | 3.0.0                   | NoCubes_SRP_Survival_Addon_3.0.0.jar                  | None                                     |     | L     | nocubesrptweaks    | V4.1                    | nocubesrptweaks-V4.1.jar                              | None                                     |     | L     | patchouli          | 1.0-23.6                | Patchouli-1.0-23.6.jar                                | None                                     |     | L     | artifacts          | 1.1.2                   | RLArtifacts-1.1.2.jar                                 | None                                     |     | L     | rsgauges           | 1.2.8                   | rsgauges-1.12.2-1.2.8.jar                             | None                                     |     | L     | rustic             | 1.1.7                   | rustic-1.1.7.jar                                      | None                                     |     | L     | silentlib          | 3.0.13                  | SilentLib-1.12.2-3.0.14+168.jar                       | None                                     |     | L     | scalinghealth      | 1.3.37                  | ScalingHealth-1.12.2-1.3.42+147.jar                   | None                                     |     | L     | lteleporters       | 1.12.2-3.0.2            | simpleteleporters-1.12.2-3.0.2.jar                    | None                                     |     | L     | spartanshields     | 1.5.5                   | SpartanShields-1.12.2-1.5.5.jar                       | None                                     |     | L     | spartanweaponry    | 1.5.3                   | SpartanWeaponry-1.12.2-1.5.3.jar                      | None                                     |     | L     | srparasites        | 1.9.18                  | SRParasites-1.12.2v1.9.18.jar                         | None                                     |     | L     | treasure2          | 2.2.0                   | Treasure2-mc1.12.2-f14.23.5.2859-v2.2.1.jar           | None                                     |     | L     | treeharvester      | 4.0                     | treeharvester_1.12.2-4.0.jar                          | None                                     |     | L     | twilightforest     | 3.11.1021               | twilightforest-1.12.2-3.11.1021-universal.jar         | None                                     |     | L     | variedcommodities  | 1.12.2                  | VariedCommodities_1.12.2-(31Mar23).jar                | None                                     |     | L     | voicechat          | 1.12.2-2.4.32           | voicechat-forge-1.12.2-2.4.32.jar                     | None                                     |     | L     | wolfarmor          | 3.8.0                   | WolfArmorAndStorage-1.12.2-3.8.0-universal-signed.jar | None                                     |     | L     | worldborder        | 2.3                     | worldborder_1.12.2-2.3.jar                            | None                                     |     | L     | midnight           | 0.3.5                   | themidnight-0.3.5.jar                                 | None                                     |     | L     | structurize        | 1.12.2-0.10.277-RELEASE | structurize-1.12.2-0.10.277-RELEASE.jar               | None                                     |     Loaded coremods (and transformers):  llibrary (llibrary-core-1.0.11-1.12.2.jar)   net.ilexiconn.llibrary.server.core.plugin.LLibraryTransformer   net.ilexiconn.llibrary.server.core.patcher.LLibraryRuntimePatcher WolfArmorCore (WolfArmorAndStorage-1.12.2-3.8.0-universal-signed.jar)    AstralCore (astralsorcery-1.12.2-1.10.27.jar)    CreativePatchingLoader (CreativeCore_v1.10.71_mc1.12.2.jar)    SecurityCraftLoadingPlugin ([1.12.2] SecurityCraft v1.9.8.jar)    ForgelinPlugin (Forgelin-1.8.4.jar)    midnight (themidnight-0.3.5.jar)   com.mushroom.midnight.core.transformer.MidnightClassTransformer FutureMC (Future-MC-0.2.19.jar)   thedarkcolour.futuremc.asm.CoreTransformer SpartanWeaponry-MixinLoader (SpartanWeaponry-1.12.2-1.5.3.jar)    Backpacked (backpacked-1.4.3-1.12.2.jar)   com.mrcrayfish.backpacked.asm.BackpackedTransformer LoadingPlugin (Reskillable-1.12.2-1.13.0.jar)   codersafterdark.reskillable.base.asm.ClassTransformer LoadingPlugin (Bloodmoon-MC1.12.2-1.5.3.jar)   lumien.bloodmoon.asm.ClassTransformer     Profiler Position: N/A (disabled)     Is Modded: Definitely; Server brand changed to 'fml,forge'     Type: Dedicated Server (map_server.txt)
    • When i add mods like falling leaves, visuality and kappas shaders, even if i restart Minecraft they dont show up in the mods menu and they dont work
    • Delete the forge-client.toml file in your config folder  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.