Jump to content

Best Way to Store a List of Patterns? [1.18.2]


MWR
 Share

Recommended Posts

I'm making a mod that lets you add an emblem to your armor. You can make your own by combining patterns like banners. However, I also want it to be possible to add your own patterns without Java code. I thought of make a custom tag that contains all the patterns, but they're not items. They're just PNGs, and if I understand correctly, I would need to create a custom registry to create the custom TagKey. Is there a better/simpler way to achieve this?

Link to comment
Share on other sites

Registries require a special flag to be dynamic. Banner patterns currently do not do this. As such you will have to write a completely custom system for this which does not use the vanilla banner pattern registry. Look at how loot tables or tags are loaded from data packs.

Link to comment
Share on other sites

On 8/7/2022 at 7:04 AM, diesieben07 said:

Registries require a special flag to be dynamic. Banner patterns currently do not do this. As such you will have to write a completely custom system for this which does not use the vanilla banner pattern registry. Look at how loot tables or tags are loaded from data packs.

So to be clear, to make a new tag type, alongside "blocks", "fluids", "items", etc., I need a registry, right? I want to have a directory just for emblems in the tags folder.

Link to comment
Share on other sites

Unless I have misunderstood your requirements, I don't think what you are trying to do is going to work.

 

The closest things in minecraft are banner patterns or paintings.

But these are registered in code (not what you want) on both the client and the server.

Then when it loads resource packs on the client it looks up the texture for each one.

 

It does it this way because the game defines what should exist, then lets the user/modpack developer give them textures (with you providing a default texture).

 

You seem to want to populate a registry from what textures exist in a resource pack? So kind of the reverse.

This isn't going to work for at least 2 reasons:

* By the time resource packs are loaded, the registries are frozen - It is too late.

* Servers don't even load resource packs, so there is no way it can use this mechanism 

 

You need some other mechanism to populate your registry.

e.g. a configuration file holding the names of what should exist, but it doesn't sound like what you want?

Edited by warjort

Boilerplate:

If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one.

If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install

Large files should be posted to a file sharing site like https://gist.github.com  You should also read the support forum sticky post.

Link to comment
Share on other sites

Quote

e.g. a configuration file holding the names of what should exist, but it doesn't sound like what you want?

Although that too has issues.

The forge defined configuration files are loaded after registration

Boilerplate:

If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one.

If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install

Large files should be posted to a file sharing site like https://gist.github.com  You should also read the support forum sticky post.

Link to comment
Share on other sites

2 hours ago, warjort said:

Unless I have misunderstood your requirements, I don't think what you are trying to do is going to work.

 

The closest things in minecraft are banner patterns or paintings.

But these are registered in code (not what you want) on both the client and the server.

Then when it loads resource packs on the client it looks up the texture for each one.

 

It does it this way because the game defines what should exist, then lets the user/modpack developer give them textures (with you providing a default texture).

 

You seem to want to populate a registry from what textures exist in a resource pack? So kind of the reverse.

This isn't going to work for at least 2 reasons:

* By the time resource packs are loaded, the registries are frozen - It is too late.

* Servers don't even load resource packs, so there is no way it can use this mechanism 

 

You need some other mechanism to populate your registry.

e.g. a configuration file holding the names of what should exist, but it doesn't sound like what you want?

I really don't know if I need the registry to hold anything. I just want it so I can put emblems under the tags folder. If I can't do that, I won't. My pre-made emblem patterns currently are not registered and are simply textures. I ran into problems with this method when creating a menu with all the patterns. I need some way to store them, and I want them to be easily expandable. I thought of config files, but datapacks seem more user-friendly. If the menu only appears in-game when you click on the special block, then I don't see a need to register anything. The packs are already loaded at that point, so my idea was for the menu to access the list of patterns, whether it be in a JSON or config file, to get whatever information it needed. I prefer to go the datapack route, so if I need a registry to create a new tag type, can I create one without filling it?

Link to comment
Share on other sites

I don't see what the tag does for you if there is nothing in the registry. You will always have empty tags?

Boilerplate:

If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one.

If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install

Large files should be posted to a file sharing site like https://gist.github.com  You should also read the support forum sticky post.

Link to comment
Share on other sites

4 hours ago, warjort said:

I don't see what the tag does for you if there is nothing in the registry. You will always have empty tags?

No, my idea was that the tag just stores the names of the patterns.

So for example, in tags/emblem_pattern/patterns.json:

{
"values": [
"border",
"square", …
]
}

Link to comment
Share on other sites

And when it tries to load the tag file it will look for "minecraft:border" in the registry and fail.

Boilerplate:

If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one.

If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install

Large files should be posted to a file sharing site like https://gist.github.com  You should also read the support forum sticky post.

Link to comment
Share on other sites

2 hours ago, warjort said:

And when it tries to load the tag file it will look for "minecraft:border" in the registry and fail.

Hmmmm… By loading the tag, do you mean when the game is initially loaded or when something is trying to access the tag?

Link to comment
Share on other sites

when it is loading the datapack

Boilerplate:

If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one.

If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install

Large files should be posted to a file sharing site like https://gist.github.com  You should also read the support forum sticky post.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I am trying to play a vanilla Minecraft sound when I am spawning an item into the world. I think I am close but the sound does not play when the item spawns into the world.   @SubscribeEvent public static void onRightClickBlock(RightClickBlock event) { Player player = event.getEntity(); Level level = event.getLevel(); InteractionHand hand = event.getHand(); BlockState blockState = event.getLevel().getBlockState(event.getPos()); Block block = blockState.getBlock(); if (player.isShiftKeyDown() && hand == InteractionHand.MAIN_HAND && block == Blocks.MOSS_BLOCK && !level.isClientSide){ player.drop(ItemInit.STONE_PEBBLE.get().getDefaultInstance(), false); level.playSound(player, event.getPos(), SoundEvents.MOSS_PLACE, SoundSource.BLOCKS, 1f, 1f); }   I am still new to modding and coding so this may be a little ugly haha. Trying to learn!
    • I have a custom recipe that uses JSON to work properly. And everything works right except I cant seem to figure out how to find the stack count for each ingredient of my recipe.   Recipe class: public class AlloyKilnRecipe implements Recipe<SimpleContainer> { private final ResourceLocation id; private final ItemStack output; private final NonNullList<Ingredient> ingredients; public AlloyKilnRecipe(ResourceLocation id, ItemStack output, NonNullList<Ingredient> ingredients) { this.id = id; this.output = output; this.ingredients = ingredients; } @Override public boolean matches(SimpleContainer pContainer, Level pLevel) { if (pLevel.isClientSide()) return false; return (ingredients.get(0).test(pContainer.getItem(0)) && ingredients.get(1).test(pContainer.getItem(1))) || (ingredients.get(0).test(pContainer.getItem(1)) && ingredients.get(1).test(pContainer.getItem(0))); } public int getIngAmnt(int index) { ItemStack[] stacks = ingredients.get(index).getItems(); for (ItemStack stack : stacks) { return stack.getCount(); } return 0; } @Override public NonNullList<Ingredient> getIngredients() { return ingredients; } @Override public ItemStack assemble(SimpleContainer pContainer) { return output; } @Override public boolean canCraftInDimensions(int pWidth, int pHeight) { return true; } @Override public ItemStack getResultItem() { return output.copy(); } @Override public ResourceLocation getId() { return id; } @Override public RecipeSerializer<?> getSerializer() { return Serializer.INSTANCE; } @Override public RecipeType<?> getType() { return Type.INSTANCE; } public static class Type implements RecipeType<AlloyKilnRecipe> { private Type() {} public static final Type INSTANCE = new Type(); public static final String ID = "alloy_kiln_recipe"; } public static class Serializer implements RecipeSerializer<AlloyKilnRecipe> { public static final Serializer INSTANCE = new Serializer(); public static final ResourceLocation ID = new ResourceLocation(FF.MOD_ID, "alloy_kiln_recipe"); @Override public AlloyKilnRecipe fromJson(ResourceLocation pRecipeId, JsonObject pSerializedRecipe) { ItemStack output = ShapedRecipe.itemStackFromJson(GsonHelper.getAsJsonObject(pSerializedRecipe, "output")); JsonArray ingredients = GsonHelper.getAsJsonArray(pSerializedRecipe, "ingredients"); NonNullList<Ingredient> inputs = NonNullList.withSize(2, Ingredient.EMPTY); for (int i = 0; i < ingredients.size(); i++) { inputs.set(i, Ingredient.fromJson(ingredients.get(i))); } return new AlloyKilnRecipe(pRecipeId, output, inputs); } @Override public @Nullable AlloyKilnRecipe fromNetwork(ResourceLocation pRecipeId, FriendlyByteBuf pBuffer) { NonNullList<Ingredient> inputs = NonNullList.withSize(pBuffer.readInt(), Ingredient.EMPTY); for (int i = 0; i < inputs.size(); i++) { inputs.set(i, Ingredient.fromNetwork(pBuffer)); } ItemStack output = pBuffer.readItem(); return new AlloyKilnRecipe(pRecipeId, output, inputs); } @Override public void toNetwork(FriendlyByteBuf pBuffer, AlloyKilnRecipe pRecipe) { pBuffer.writeInt(pRecipe.getIngredients().size()); for (Ingredient ing : pRecipe.getIngredients()) { ing.toNetwork(pBuffer); } pBuffer.writeItemStack(pRecipe.getResultItem(), false); } } } And here is my recipe.json { "type": "forgedfactory:alloy_kiln_recipe", "ingredients": [ { "item": "minecraft:iron_ingot", "count": 3 }, { "item": "minecraft:gold_ingot" } ], "output": { "item": "minecraft:diamond", "count": 3 } } Could someone tell me what I would have to do? The getIngAmount method just returns 1 even though I have a count defined for the iron ingots.
    • forge installer version 43.1.7 for 1.19.2 won't download the jar file, only the json 
    • Stop bumping your post. This sounds like a issue with your install. Try deleting your .minecraft folder and re-installing the launcher. Beyond that it's not something we control. As we don't control the launcher.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.