[1.19] Registering Sounds

[Luckydel]

Hello, sorry to disturb you. I can't hear the sound in the game.
I tried to register.

@Mod(Main.MODID)
public class Main
{   
	public static final String MODID = "mymod";
    public Main() {
        IEventBus modEventBus = FMLJavaModLoadingContext.get().getModEventBus();
        ForgeModSounds.REGISTRY.register(modEventBus);
    }
}

@Mod.EventBusSubscriber(modid = Main.MODID, bus = Mod.EventBusSubscriber.Bus.MOD)
public class ForgeModSounds {
    public static final DeferredRegister<SoundEvent> REGISTRY = DeferredRegister.create(ForgeRegistries.SOUND_EVENTS, Main.MODID);
    public static final RegistryObject<SoundEvent> empty = REGISTRY.register("empty",
            () -> new SoundEvent(new ResourceLocation(Main.MODID, "empty")));
}

 

I use in Range item.
 

public static BulletEntity shoot(Level world, LivingEntity entity, float power, double damage, int knockback, String soundName) {
		...
        world.playSound(null, entity.getX(), entity.getY(), entity.getZ(),
                ForgeRegistries.SOUND_EVENTS.getValue(new ResourceLocation(Main.MODID, "empty")), SoundSource.PLAYERS, 1, 1.0F / 		  		     (world.getRandom().nextFloat() * 0.4F + 1.2F) * 0.5F);

		//OR


        //world.playSound(null, entity.getX(), entity.getY(), entity.getZ(),
        //        ForgeModSounds.empty.get(), SoundSource.PLAYERS, 1, 1.0F / (world.getRandom().nextFloat() * 0.4F + 1.2F) * 0.5F);
        //return entitybullet;
    }

assets/mymod/sounds.json

{
  "empty": {
    "category": "neutral",
    "sounds": [
      {
        "name": "warmod_perekur:empty",
        "stream": false
      }
    ]
  }
}

assets/mymod/sounds/empty.ogg

 

Edited August 21, 2022 by Luckydel

[vemerion]

2 hours ago, Luckydel said:

Hello, sorry to disturb you. I can't hear the sound in the game.
I tried to register.

Looks like your modid is "mymod", but you specified it as "warmod_perekur" in the sounds file!

Edited August 21, 2022 by vemerion

[Luckydel]

Oh, I renamed this when I posted the code on the site, I didn’t want to say the name of the mod =), in fact, warmod_perekur is indicated everywhere instead of mymod, sorry for the deception 😃
So the question is open.

[warjort]

It's difficult to say since you only post source snippets without context.

Whether your configuration is correct (e.g. typos or files in the wrong place in the filesystem), only you will know since you don't show what it really is, including you modifying it before posting.

 

Passing null as the player (first parameter) is intended for broadcasting to all players in range of the sound, it only works on the server.

On the client you need to pass in the player and it must match Minecraft.getInstance().player otherwise the sound won't play.

 

As a test, try replacing your sound with a vanilla one, e.g. SoundEvents.ARROW_SHOOT

If that works, you know the problem is with your sound config or the sound itself.

If it doesn't work, you know the problem is with the logic/parameters of the method call. Debuggers are your friend. 🙂 

 

Finally, whenever you have something that is not working as expected look at your run/logs/debug.log and look for errors/warnings.

You should post a link to it here as well if you don't understand what it is telling you, or maybe we can spot something you didn't notice.

[poopoodice]

Can you find your sound in command /playsound?

Is there any error in the log?

Have you configured your sound in sounds.json?

Is your sound in the correct directory?

Is your sound low-volumed?

Is your sound in .ogg format?