Jump to content

[SOLVED] BlockEntity rendering too dark


GhostGaming

Recommended Posts

I have a custom block entity and whenever it renders something it appears completely dark.

In it's render method, the value of packedLight is always 0.

@Override
public void render(CustomBlockEntity blockEntity, float partialTick, PoseStack poseStack, MultiBufferSource bufferSource, int packedLight, int packedOverlay) {
	// packedLight is always 0?
}

If I disable ambient occlusion in the corresponding block's properties, the block entity doesn't render dark anymore but the lighting still isn't correct.

I'm basically only trying to render a solid block.

Can anyone help me with this?

Edited by GhostGaming
Link to comment
Share on other sites

Not really my area of expertise.

 

But if you want to render a solid block, why not just override getRenderShape() to return RenderShape.MODEL?

You can then use a json model. Vanilla does this for many block entities, e.g. BarrelBlock

 

You don't show any relevant code, but if your block is a full block it is not suprising its lightlevel is 0 - light cannot pass through or into it.

 

If you really want to handle the lighting yourself, you can find the simple version for a solid block in

ModelBlockRenderer.tesselateWithoutAO()

Note the use of LevelRenderer.getLightColor() to get the light level of the neighbouring block on each face.

 

You can also see the more complicated code for doing it with ambient occlusion in that class. Don't ask me to explain that code. 🙂 

  • Thanks 1

Boilerplate:

If you don't post your logs/debug.log we can't help you. For curseforge you need to enable the forge debug.log in its minecraft settings. You should also post your crash report if you have one.

If there is no error in the log file and you don't have a crash report then post the launcher_log.txt from the minecraft folder. Again for curseforge this will be in your curseforge/minecraft/Install

Large files should be posted to a file sharing site like https://gist.github.com  You should also read the support forum sticky post.

Link to comment
Share on other sites

5 minutes ago, warjort said:

Not really my area of expertise.

 

But if you want to render a solid block, why not just override getRenderShape() to return RenderShape.MODEL?

You can then use a json model. Vanilla does this for many block entities, e.g. BarrelBlock

 

You don't show any relevant code, but if your block is a full block it is not suprising its lightlevel is 0 - light cannot pass through or into it.

 

If you really want to handle the lighting yourself, you can find the simple version for a solid block in

ModelBlockRenderer.tesselateWithoutAO()

Note the use of LevelRenderer.getLightColor() to get the light level of the neighbouring block on each face.

 

You can also see the more complicated code for doing it with ambient occlusion in that class. Don't ask me to explain that code. 🙂 

Well, I'm actually trying to draw the enchanting glint over a block and that turned out way more difficult than it should be :D

But I think your answer pushed me in the right direction. Thanks!

Link to comment
Share on other sites

I finally got it working!

For anyone wanting to achieve this in the future:

public void render(CustomBlockEntity blockEntity, float partialTick, PoseStack poseStack, MultiBufferSource bufferSource, int packedLight, int packedOverlay) {
    VertexConsumer vertexConsumer = VertexMultiConsumer.create(bufferSource.getBuffer(RenderType.glintDirect()), bufferSource.getBuffer(RenderType.solid()));

    BlockState blockState = CustomBlocks.CUSTOM_BLOCK.get().defaultBlockState();
    Level level = blockEntity.getLevel();

    BakedModel model = this.blockRenderer.getBlockModel(blockState);
    this.modelRenderer.tesselateBlock(level, model, blockState, blockEntity.getBlockPos(), poseStack, vertexConsumer, false, level.getRandom(), 0, packedOverlay);
}

@warjort, thank you so much again! 

Link to comment
Share on other sites

  • GhostGaming changed the title to [SOLVED] BlockEntity rendering too dark

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.