[SOLVED] [1.19.2] Renderer With Incorrect combinedLightIn

[NovaMachina]

I have two renderers, one works correctly and has a non-zero value for combinedLightIn. The other always has 0 as the combinedLightIn value. From what I can tell these two renderers are nearly identical and they worked in 1.18. At this point I'm totally lost on what the issue is and hope that a second (or more) pairs of eyes may be able to see something that I don't.

Thanks in advance.

Working renderer: https://github.com/NovaMachina-Mods/ExNihiloSequentia/blob/1.19/src/main/java/novamachina/exnihilosequentia/client/render/CrucibleRender.java

Broken renderer: https://github.com/NovaMachina-Mods/ExNihiloSequentia/blob/1.19/src/main/java/novamachina/exnihilosequentia/client/render/BarrelRender.java

Edited January 7, 2023 by NovaMachina

[warjort]

Not really my area of expertise, but that value is the calculated lighting value of your block.

Your crucible has noOcclusion which allows light to pass through it:

https://github.com/NovaMachina-Mods/ExNihiloSequentia/blob/cb9490413242e4480551433299127e9066243a7a/src/main/java/novamachina/exnihilosequentia/common/block/crucibles/WoodCrucibleBlock.java#L24

Your barrel does not:

https://github.com/NovaMachina-Mods/ExNihiloSequentia/blob/cb9490413242e4480551433299127e9066243a7a/src/main/java/novamachina/exnihilosequentia/common/block/barrels/WoodBarrelBlock.java#L23

so it is probably not letting light into your block according to the shape?

 

Look at how ModelBlockRenderer.tesselateWithoutAO uses LevelRenderer.getLightColor() of the neighbouring block/side as the light level when light cannot enter the block.

[NovaMachina]

That was it. Thanks