Need help with mod version

[Neometron]

Hi,

 

I'm having troubles with version numbers with my mod. My mod is designed to be backward compatible with my older version of my mod. My server contains an older version and my client has a newer version. When I attempt to log on the server, I get rejected for the missing older version of my mod. How can I have my server allow newer client versions of the mod?

 

[edit]

 

I suppose I should also mention that I have:

              @VersionCheckHandler
public boolean VersionCheck(String var, INetworkManager netManager)
{
	return true;
}

 

However, adding a breakpoint here never gets hit.

[GotoLink]

To use VersionCheckHandler annotation, you must have a @NetworkMod and put it in the same class, with a public method accepting a String as only argument.

See NetworkModHandler class for details on how it work.

[Neometron]

To use VersionCheckHandler annotation, you must have a @NetworkMod and put it in the same class, with a public method accepting a String as only argument. See NetworkModHandler class for details on how it work.

 

I had done this, unless I'm doing it wrong. I have @NetworkMod as part of my class.

 

@NetworkMod(clientSideRequired=true,
       	       serverSideRequired=false,
       channels={
	          "CLIENT_INITSYNC",
	          "CLIENT_TIMESYNC",
	          "SERVER_INITSYNC",
	          "SERVER_TIMESYNC",
	          "CLIENT_CALENDAR",
	          "SERVER_CALENDAR"
  	       },
       packetHandler = AdvanceTimePackets.class,
       connectionHandler = AdvanceTimeConnections.class)


public class AdvanceTimeMod
{...

    @VersionCheckHandler
    public boolean VersionCheck(String var, INetworkManager netManager)
   {
     return true;
   }

...

 

I originally had @VersionCheckHandler like this:

 

   @VersionCheckHandler
    public boolean VersionCheck(String var)
   {
     return true;
   }

 

The reason I placed INetworkManager as a parameter was because it said it needed a string and a NetworkManager. In both cases, it does not reach my breakpoint in the VersionCheck method.

[GotoLink]

NetworkModHandler is searching for a method with String as a parameter.

Method checkHandlerMethod = networkModClass.getDeclaredMethod(versionCheckHandlerMethod, String.class);
                if (checkHandlerMethod.isAnnotationPresent(NetworkMod.VersionCheckHandler.class))
                {
                    this.checkHandler = checkHandlerMethod;
                }

And invoking it with "version", which is a String...

if (checkHandler != null)
        {
            try
            {
                return (Boolean)checkHandler.invoke(container.getMod(), version);
}
            catch (Exception e)
            {
                FMLLog.log(Level.WARNING, e, "There was a problem invoking the checkhandler method %s for network mod id %s", checkHandler.getName(), container.getModId());
                return false;
            }

This should work unless this is actually deprecated.

Did you get any warning in your log when you tried with String as only parameter ?

I would try with Boolean as return type, just in case.

[Neometron]

I tried everything suggested, however it appears that checkHandler is always null.

 

But, what is this in the same method of NetworkModHandler.acceptVersion(String version)

 

if (acceptableRange!=null)
{
   return acceptableRange.containsVersion(new DefaultArtifactVersion(version));
}

 

acceptableRange seems to always be valid. How do I use this?

[Neometron]

Will this correctly allow my mod to accept newer versions?

 

@Mod(modid="advancetime", name="Advance Time", version="1.1")

@NetworkMod( clientSideRequired=true,
             serverSideRequired=false,
             versionBounds="[1.1, )",
                  ...)

[Neometron]

Will this correctly allow my mod to accept newer versions?

 

@Mod(modid="advancetime", name="Advance Time", version="1.1")

@NetworkMod( clientSideRequired=true,
             serverSideRequired=false,
             versionBounds="[1.1, )",
                  ...)

 

I'll answer myself - Yes