The IGlobalLootModifier is not working

[mimi2023]

I followed a tutorial on how to modify the grass loot table and add my modded item but my loot is not generated

here is my loot class:

package net.meme2001.farmsimmod.loot;

import com.google.common.base.Supplier;
import com.google.common.base.Suppliers;
import com.mojang.serialization.Codec;
import com.mojang.serialization.codecs.RecordCodecBuilder;
import it.unimi.dsi.fastutil.objects.ObjectArrayList;
import net.minecraft.resources.ResourceLocation;
import net.minecraft.world.item.Item;
import net.minecraft.world.item.ItemStack;
import net.minecraft.world.level.storage.loot.LootContext;
import net.minecraft.world.level.storage.loot.predicates.LootItemCondition;
import net.minecraftforge.common.data.GlobalLootModifierProvider;
import net.minecraftforge.common.loot.IGlobalLootModifier;
import net.minecraftforge.common.loot.LootModifier;
import net.minecraftforge.data.event.GatherDataEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.registries.ForgeRegistries;
import org.jetbrains.annotations.NotNull;

import static net.meme2001.farmsimmod.Farmsimmod.MODID;

public class DeleteItemModifier extends LootModifier {
public static final Supplier<Codec<DeleteItemModifier>> CODEC = Suppliers.memoize(()
-> RecordCodecBuilder.create(inst -> codecStart(inst).and(ForgeRegistries.ITEMS.getCodec()
.fieldOf("item").forGetter(m -> m.item)).apply(inst,DeleteItemModifier::new)));
private final Item item;






protected DeleteItemModifier(LootItemCondition[] conditionsIn ,Item item) {
super(conditionsIn);

this.item=item;


}

@Override
protected @NotNull ObjectArrayList<ItemStack> doApply(ObjectArrayList<ItemStack> generatedLoot, LootContext context) {
if (context.getRandom().nextFloat() >= 0.2) {
generatedLoot.add(new ItemStack(item));
}




return generatedLoot;
}


@Override
public Codec<? extends IGlobalLootModifier> codec() {
return CODEC.get();
}


}

 

and here is my first JSON file:

{
"type": "farmsimmod:delete_item",
"conditions": [
{
"condition": "block_state_property",
"block": "minecraft:grass"
}
],
"item": "framsimmod:tomateo_seed"

}

and my second JSON file

{
"replace": false,
"entries": [
"farmsimmod:remove_loot_from_grass"
]
}

[warjort]

Don't post snippits in the forum. and what you posted is horribly formatted.

It also gives no clue to where those json files are located, what they are called or show all the necessary code (like the registration process).

Put your code  on github where we can see everything in context.

 

Here's one I  made a while ago, explaining all the steps: https://forums.minecraftforge.net/topic/113816-1182-method-for-iterating-over-blocks-belonging-to-a-tag/#comment-505993

although the part about the "block tag loot item condition" is optional unless you want to use block tags.

[mimi2023]

here my github

https://github.com/meme2023/my_mod.git

[warjort]

Look in your logs/debug.log

Quote

[11:49:25] [Render thread/WARN] [ne.mi.co.lo.LootModifierManager/]: Could not decode GlobalLootModifier with json id farmsimmod:remove_loot_from_grass - error: Unknown registry key in ResourceKey[minecraft:root / minecraft:item]: framsimmod:tomateo_seed

You misspelt farm. 🙂

https://github.com/meme2023/my_mod/blob/838b11405464e28ac3d4f46b9f06adf159b95e40/src/main/resources/data/farmsimmod/loot_modifiers/remove_loot_from_grass.json#L9

Edited April 26, 2023 by warjort