RESOLVED - [1.19.2] Recipe Book not fully opening

[Warren Tode]

So I got the recipe book added and everything is working correctly, except that the book does not fully open and the main GUI doesn't slide over to make room for it. I've tried playing around with parameters for the sizing and whatnot to fix this, but no dice. I even went so far as to start over from scratch a few times to try to figure out where I messed up, and while I figured out other things along the way, it's still doing this. At this point I know I'm missing something and would like to know what I need to be checking.

Edited May 2, 2023 by Warren Tode

[warjort]

We can't debug screenshots. You need to put the all relevant code on github.

[Warren Tode]

23 minutes ago, warjort said:

We can't debug screenshots. You need to put the all relevant code on github.

Okay, I understand. The question is, what exactly do you need to look at? I can just put the entire test mod up there.

[warjort]

We need enough to reproduce the problem, i.e. we should be able to build the mod and run the game.

So the whole thing would be okay.

[Warren Tode]

Sorry it took me so long to posting this.

https://github.com/toadie-odie/TodeCoins/tree/1.2.4

[warjort]

Looks like a trivial issue to me?

You are miscalculating the x position of the background.

https://github.com/toadie-odie/TodeCoins/blob/e63ed9728c9aa222f5a09799fe7938bdd188e71b/src/main/java/net/warrentode/todecoins/gui/CoinPressScreen.java#L86

Compare your code with CraftingScreen which uses the value calculated based on whether the recipe book is displayed

int x = leftPos;

 

Edited May 2, 2023 by warjort

[Warren Tode]

1 hour ago, warjort said:

Looks like a trivial issue to me?

You are miscalculating the x position of the background.

https://github.com/toadie-odie/TodeCoins/blob/e63ed9728c9aa222f5a09799fe7938bdd188e71b/src/main/java/net/warrentode/todecoins/gui/CoinPressScreen.java#L86

Compare your code with CraftingScreen which uses the value calculated based on whether the recipe book is displayed

int x = leftPos;

 

Yes, this fixed the problem completely. The devil is always in the details. Thank you.