Jump to content

How do I create a custom liquid that has potion effects? [NOT SOLVED: HARD]


leonardude

Recommended Posts

Well, first take a look at the method, how it should look in your code:

@Override
public void onEntityCollidedWithBlock( World world, int x, int y, int z, Entity entity ) {}

 

Now, we have an Entity. What can we do with an Entity? Yeah, add the potion effect:

public void onEntityCollidedWithBlock( World world, int x, int y, int z, Entity entity ) 
{
   // Dont know if you need to check if the world is remote
  entity.addPotionEffect( new MyPotionEffect() )
  // The argument obviously must be instanceof PotionEffect
}

From here you are on you're own!

I am fairly new to Java and modding, so my answers are not always 100% correct. Sorry for that!

Link to comment
Share on other sites

Try something like this (didn't tested it):

@Override
public void onEntityCollidedWithBlock(World world, int x, int y, int z, Entity entity) {
if (entity instanceof EntityPlayer) {
	((EntityPlayer) entity).addPotionEffect(new PotionEffect(yourArgumentsHere));
}
}

Link to comment
Share on other sites

I have written the code that you said into my liquid block file and it didn't work.

 

This is the code for my that has to do with the liquid in my mod's main class:

//Define Fluids
public static Fluid fluidCorrosiveAcid;
public static Block blockCorrosiveAcid;

//Initialize Fluids
fluidCorrosiveAcid = new FluidCorrosiveAcid();
blockCorrosiveAcid = new BlockCorrosiveAcid(3200);

//Register Fluids To The Game
GameRegistry.registerBlock(blockCorrosiveAcid);

//Register Names Of Fluids
LanguageRegistry.addName(blockCorrosiveAcid, "Corrosive Acid");

 

This is the code that has to do with the potion in my mod's main class:

//Define Potions
public static Potion corrosiveAcid;

@PreInit
public void preInit(FMLPreInitializationEvent event) {
	Potion[] potionTypes = null;

	for (Field f : Potion.class.getDeclaredFields()) {
		f.setAccessible(true);
		try {
			if (f.getName().equals("potionTypes") || f.getName().equals("field_76425_a")) {
				Field modfield = Field.class.getDeclaredField("modifiers");
				modfield.setAccessible(true);
				modfield.setInt(f, f.getModifiers() & ~Modifier.FINAL);

				potionTypes = (Potion[])f.get(null);
				final Potion[] newPotionTypes = new Potion[256];
				System.arraycopy(potionTypes, 0, newPotionTypes, 0, potionTypes.length);
				f.set(null, newPotionTypes);
			}
		}
		catch (Exception e) {
			System.err.println("Severe error, please report this to the mod author:");
			System.err.println(e);
		}
	}

	MinecraftForge.EVENT_BUS.register(new ZetherEventHooks());
}

//Initialize Potions
corrosiveAcid = new PotionCorrosiveAcid(32, false, 0).setPotionName("corrosiveAcid");

 

This is the code for my FluidCorrosiveAcid:

package com.leonardude.zether.blocks;

import net.minecraftforge.fluids.Fluid;
import net.minecraftforge.fluids.FluidRegistry;

public class FluidCorrosiveAcid extends Fluid {

public FluidCorrosiveAcid() {
	super("fluidCorrosiveAcid");
	this.setDensity(10);
	this.setViscosity(1000);
	FluidRegistry.registerFluid(this);
}

}

 

This is the code for my BlockCorrosiveAcid:

package com.leonardude.zether.blocks;

import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLiving;
import net.minecraft.potion.PotionEffect;
import net.minecraft.util.Icon;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import net.minecraftforge.fluids.BlockFluidClassic;

import com.leonardude.zether.main.Zether;

import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;

public class BlockCorrosiveAcid extends BlockFluidClassic {

public BlockCorrosiveAcid(int id) {
	super(id, Zether.fluidCorrosiveAcid, Material.water);
	this.setCreativeTab(CreativeTabs.tabBlock);
	Zether.fluidCorrosiveAcid.setBlockID(id);
}

@Override
public void onEntityCollidedWithBlock( World world, int x, int y, int z, Entity entity ) {
	if (entity instanceof EntityLiving) {
		((EntityLiving)entity).addPotionEffect(new PotionEffect(Zether.corrosiveAcid.id, 200, 0));
	}
}

@Override
@SideOnly(Side.CLIENT)
public Icon getIcon(int side, int meta) {
	return Block.waterMoving.getIcon(side, meta);
}

@Override
public int colorMultiplier(IBlockAccess iblockaccess, int x, int y, int z) {
	return 0x66FF00;
}

}

 

This is the code for my PotionCorrosiveAcid:

package com.leonardude.zether.potions;

import net.minecraft.potion.Potion;

public class PotionCorrosiveAcid extends Potion {

public PotionCorrosiveAcid(int id, boolean par2, int par3) {
	super(id, par2, par3);

}

}

 

And this is the code for the event hook that has to do with the potion:

package com.leonardude.zether.event;

import net.minecraft.util.DamageSource;
import net.minecraftforge.event.ForgeSubscribe;
import net.minecraftforge.event.entity.living.LivingEvent.LivingUpdateEvent;

import com.leonardude.zether.main.Zether;

public class ZetherEventHooks {

@ForgeSubscribe
public void onEntityUpdate(LivingUpdateEvent event) {
	if (event.entityLiving.isPotionActive(Zether.corrosiveAcid)) {
		if (event.entityLiving.worldObj.rand.nextInt(20) == 0) {
			event.entityLiving.attackEntityFrom(DamageSource.lava, 2);
			if (event.entityLiving.getActivePotionEffect(Zether.corrosiveAcid).getDuration()==0) {
				event.entityLiving.removePotionEffect(Zether.corrosiveAcid.id);
				return;
			}
		}
	}
}

}

 

Do I have to register the potion to the game? If so how do I do that?

Please help me, as I have no idea what I am doing wrong!!!

Thanks, in advance!

Link to comment
Share on other sites

  • 2 years later...
Guest
This topic is now closed to further replies.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Add crash-reports with sites like https://paste.ee/ Maybe an issue with blur, essentials or cumulus_menus
    • Add the crash-report or latest.log (logs-folder) with sites like https://paste.ee/ and paste the link to it here  
    • I have a problem, I am trying to put two different effects to two different armors but when I run it only the emerald armor effect works. This is the code public class ModArmorItem extends ArmorItem{ private static final Map<ArmorMaterial, MobEffectInstance> MATERIAL_TO_EFFECT_MAP = (new ImmutableMap.Builder<ArmorMaterial, MobEffectInstance>()) .put(ModArmorMaterials.EMERALD, new MobEffectInstance(MobEffects.HERO_OF_THE_VILLAGE,200, 1,false,false, true)) .put(ModArmorMaterials.OBSIDIAN, new MobEffectInstance(MobEffects.FIRE_RESISTANCE,200, 1,false,false, true)).build(); public ModArmorItem(ArmorMaterial pMaterial, Type pType, Properties pProperties) { super(pMaterial, pType, pProperties); } @Override public void onArmorTick(ItemStack stack, Level world, Player player){ if (!world.isClientSide()) { if (hasFullSuitOfArmorOn(player)) { evaluateArmorEffects(player); } } } private void evaluateArmorEffects(Player player) { for (Map.Entry<ArmorMaterial,MobEffectInstance> entry : MATERIAL_TO_EFFECT_MAP.entrySet()){ ArmorMaterial mapArmorMaterial = entry.getKey(); MobEffectInstance mapStatusEffect = entry.getValue(); if (hasCorrectArmorOn(mapArmorMaterial, player)) { addStatusEffectForMaterial(player, mapArmorMaterial, mapStatusEffect); } } } private void addStatusEffectForMaterial(Player player, ArmorMaterial mapArmorMaterial, MobEffectInstance mapStatusEffect) { boolean hasPlayerEffect = player.hasEffect(mapStatusEffect.getEffect()); if (hasCorrectArmorOn(mapArmorMaterial, player) && !hasPlayerEffect) { player.addEffect(new MobEffectInstance(mapStatusEffect)); } } private boolean hasCorrectArmorOn(ArmorMaterial material, Player player) { for (ItemStack armorStack : player.getInventory().armor){ if (!(armorStack.getItem() instanceof ArmorItem)) { return false; } } ArmorItem helmet = ((ArmorItem)player.getInventory().getArmor(3).getItem()); ArmorItem breastplace = ((ArmorItem)player.getInventory().getArmor(2).getItem()); ArmorItem leggins = ((ArmorItem)player.getInventory().getArmor(1).getItem()); ArmorItem boots = ((ArmorItem)player.getInventory().getArmor(0).getItem()); return helmet.getMaterial() == material && breastplace.getMaterial() == material && leggins.getMaterial() == material && boots.getMaterial() == material; } private boolean hasFullSuitOfArmorOn(Player player){ ItemStack helmet = player.getInventory().getArmor(3); ItemStack breastplace = player.getInventory().getArmor(2); ItemStack leggins = player.getInventory().getArmor(1); ItemStack boots = player.getInventory().getArmor(0); return !helmet.isEmpty() && !breastplace.isEmpty() && !leggins.isEmpty() && !boots.isEmpty(); } } Also when I place two effects on the same armor, the game crashes. Here is the crash file. The code is the same, only this part is different   private static final Map<ArmorMaterial, MobEffectInstance> MATERIAL_TO_EFFECT_MAP = (new ImmutableMap.Builder<ArmorMaterial, MobEffectInstance>()) .put(ModArmorMaterials.EMERALD, new MobEffectInstance(MobEffects.HERO_OF_THE_VILLAGE,200, 1,false,false, true)) .put(ModArmorMaterials.EMERALD, new MobEffectInstance(MobEffects.FIRE_RESISTANCE,200, 1,false,false, true)).build(); I hope you guys can help me. Thanks.
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.