Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

Looking for a better way [semi-solid block][Solved]


ShetiPhian
 Share

Recommended Posts

I'm looking for a better way to do my semi-solid cloud blocks.

 

Effect I'm after:

Entities fall through the block unless the cloudWalk flag return true, then it is just like any other solid block.

The cloudWalk flag is true when the player can fly or has equipped special armor.

 

How it is Currently working.

The block is solid.

in "onEntityWalking" and "onFallenUpon" the flag gets checked, if false the entity gets nudged into the block.

in "onEntityCollidedWithBlock" the flag gets checked, if false "entity.setInWeb()" & "entity.setVelocity(0.0D, -2.0D, 0.0D)"

 

 

In 1.2.5 this method worked well in SSP, but on the server it worked poorly on players.

Issue #1 --Solved with new server side noClip hook added in #237

Even though the server was pushing the player it was seen as an invalid move and NetServerHandler would push the player back.

The only way I found to get around this was to edit the base class and override the check while falling through the cloud block

 

Issue #2

Minecraft seen the block as a valid spawn spot, many times you'd fall to your death.

To hack around this I edited my generator so clouds wouldn't be placed withing the spawn zone (this looked dumb)

 

Issue #3 --Solved with new hook added in #237or at least it appears to be

If the clouds where thicker then one block (almost always) sometimes you'd get stuck while falling through because "onEntityWalking" and "onFallenUpon" didn't trigger on the block bellow. By wiggling you could get unstuck.

 

 

My thoughts for reworking:

I think the best thing to do is set the getCollisionBoundingBox to null.

That should solve the getting stuck problem, remove the base edit, and maybe solve the spawn problem.

But then I have to find a way to collide with a block that has no collision box  :o

For the y value I could check if there is a cloud bellow and change it to counter the fall, if done at LivingUpdateEvent there shouldn't be any noticeable jitter, but I've got no ideas for x and z.

Link to comment
Share on other sites

Colliding without the colliding box; have you considered putting a test in getCollisionBoundingBoxFromPool for cloudWalk?

 

so perhaps something like:

 

public AxisAlignedBB getCollisionBoundingBoxFromPool(World par1World, int par2, int par3, int par4)
    {        
        if (!cloudWalk)
        {
            return null; //fall to your death.
        }
        else
        {
            return AxisAlignedBB.getBoundingBox(par2, par3, par4, par2 + 1, par3 + 1, par4 + 1); //i.e a solid cloud.
        }
    }

 

So unless you have cloudWalk, you cant fall. At the very least, this should solve issue#3. As for issue#2, perhaps you could make it so players aren't given cloudWalk until after spawning? Perhaps add something like

 if (world.worldInfo.getWorldTime < youllhavetocheckwhattheworldtimeisafewsecondsafterspawn) { cloudWalk = true; } //i can see this being a little bit dodgey though

 

Alternatively, perhaps you could see if you can find a way to get number of generated chunks, and if it's > 8 or 16 or something, then apply cloudWalk?

 

As for issue#1, you're not moving the player, so maybe it will be fixed?

 

Just my 2 cents. Apologies if it's useless, I'm quite tired.

Link to comment
Share on other sites

"have you considered putting a test in getCollisionBoundingBoxFromPool for cloudWalk?"

Yep with funny results too, the block became pass through for everyone when one who couldn't walk on them touched it.

Another thing I tried in 1.2.3 was setting the box to null on the server but a full cube on the client. I don't remember what problems I had with that but it was scrapped.

Got through this one though, I submitted a hook that allows server mods to use noClip to stop NetServerHandler from freaking out.

It was put in Build #237 so all is good there.

(server side noClip seems to have solved issue #3 as well)

 

 

As long as a block exists, is solid, and is not a leaf block, Minecraft calls it a valid spawn block.

I located where this was happening and submitted a new hook, others may find it helpful also.

But it if doesn't make it in I'll just continue pushing my blocks away from the map spawn point. (and hope no server admins move it)

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Ok, so I did some investigations and after a lot of trial and error, I finally came up with a solution. I will try to explain what I did, and why, for anyone who might need it. From what I understood, implementation will add a depedency for both compiling and runtime (pretty sure it will only include API files for compiling if there are, but I'm not 100% sure), and will resolve any nested depedencies aswell, so its kinda neat if one's mod permenently depends on other's mod or API ! Though I need to control whether a mod is included during runtime or not, so I need to specify the scope of my depedencies. I did some searches, and it turned out that Gradle will consume either jars or source folders regardless, so there is not a specific way to deal with one or the other it seems. I then tried the following and it worked like a charm (modified the commit branch / tags so its pointing to a permanent commit, more info here) ! depedencies { compileOnly 'com.github.lazyMods:baubles:1.10.0.0-1.18:api' runtimeOnly 'com.github.lazyMods:baubles:1.10.0.0-1.18' } But, whenever I try to run, the game crashes with a NoSuchMethod exception, pointing towards a method MenuScreens::m_96206_ called within the Baubles main class during ClientSetup (which is the unmapped name of MenuScreens::register) ; which is clearly a mapping issue. It confused me at first, but now that I think of it it's quite obvious : trying to run the game with uncompiled source files will cause all sorts of issues. And even if Jitpack seems to compile on the go those files, it will lack any metadata expected by Forge or ForgeGradle, so it's no use anyway. The only two solutions I can think of are : Download the mod jar, put it in a libs folder inside your workingDir that you can settup as a local repository, then add that jar as a runtime depedency Use CurseMaven as a repository (as @diesieben07 suggested), and add the correct mod jar as a depedency (more info here) I chose the latter, so now I have the following in my build.gradle file, and it works perfectly (one can even remove the ":api" from the baubles depedency to show the entire mod source files in Eclipse) : repositories { maven { url "https://cursemaven.com" content { includeGroup "curse.maven" } } maven { url "https://jitpack.io" } } depedencies { compileOnly "com.github.lazyMods:baubles:1.10.0.0-1.18:api" runtimeOnly fg.deobf("curse.maven:baubles-366844:3576950") // Points toward Baubles: Reborn? v1.10.0.1-1.18.1 on curseforge.com } I couldn't use CurseMaven straight up as lazynessmind didn't provide a source jar or an api jar on curse forge just yet, so I had to use its Github instead to get the API, hence the struggle. I could have added the mod jar itself as an API, but then I would have to manualy add the source files for Eclipse, which then makes this whole "manage your depedencies solely with Gradle" obsolete...   Thanks for the help, as I could not figure out those things on my own ! I hope that may be usefull to someone some day !
    • I am not sure where in your code the icon and tab name text are rendered.
    • So I've got myself a GUI similar to that of the Advancements screen or the Creative screen where I've got a main screen that renders the window, and tabs that render their own info. Everything works fine and dandy, until I have one of the tabs render text. When that happens, all other text rendered by the screen, along with the tab icon are no longer rendered. There seemingly are no errors, and when I try debugging I can see that each code path is still called so I'm not sure what's going on. So within my screen the main render function looks as follows public void render(MatrixStack matrixStack, int mouseX, int mouseY, float partialTicks) { int i = (this.width - GUI_WIDTH) / 2; int j = (this.height - GUI_HEIGHT) / 2; this.renderBackground(matrixStack); if (maxPages != 0) { ITextComponent page = new StringTextComponent(String.format("%d / %d", tabPage + 1, maxPages + 1)); int width = this.font.width(page); RenderSystem.disableLighting(); this.font.draw(matrixStack, page.getString(), i + (GUI_WIDTH / 2) - (width / 2), j - 44, -1); } this.drawWindowBackground(matrixStack, mouseX, mouseY, i, j); this.renderWindow(matrixStack, i, j); this.drawWindowTooltips(matrixStack, mouseX, mouseY, i, j); } The errant line is within this.drawWindowBackground(matrixStack, mouseX, mouseY, i, j);. Here we render the tab window itself. private void drawWindowBackground(MatrixStack matrixStack, int mouseX, int mouseY, int offsetX, int offsetY) { if (this.selectedTab == null) { fill(matrixStack, offsetX + 9, offsetY + 18, offsetX + 9 + 234, offsetY + 18 + 113, -16777216); int i = offsetX + 9 + 117; drawCenteredString(matrixStack, this.font, EMPTY, i, offsetY + 18 + 56 - 9 / 2, -1); drawCenteredString(matrixStack, this.font, SAD_LABEL, i, offsetY + 18 + 113 - 9, -1); } else { RenderSystem.pushMatrix(); RenderSystem.translatef((float)(offsetX + 9), (float)(offsetY + 18), 0.0F); this.selectedTab.drawTabBackground(matrixStack); RenderSystem.popMatrix(); RenderSystem.depthFunc(515); RenderSystem.disableDepthTest(); } } From there the tab draws itself as follows: public void drawTabBackground(MatrixStack matrixStack) { if (!this.centered) { this.scrollX = 117 - (this.maxX + this.minX) / 2.0D; this.scrollY = 56 - (this.maxY + this.minY) / 2.0D; this.centered = true; } RenderSystem.pushMatrix(); RenderSystem.enableDepthTest(); RenderSystem.translatef(0.0F, 0.0F, 950.0F); RenderSystem.colorMask(false, false, false, false); fill(matrixStack, 4680, 2260, -4680, -2260, -16777216); RenderSystem.colorMask(true, true, true, true); RenderSystem.translatef(0.0F, 0.0F, -950.0F); RenderSystem.depthFunc(518); fill(matrixStack, MAX_WIDTH, MAX_HEIGHT, 0, 0, -16777216); RenderSystem.depthFunc(515); this.minecraft.getTextureManager().bind(background); int i = MathHelper.floor(this.scrollX); int j = MathHelper.floor(this.scrollY); int k = i % 16; int l = j % 16; for(int i1 = -1; i1 <= 15; ++i1) { for(int j1 = -1; j1 <= 8; ++j1) { blit(matrixStack, k + 16 * i1, l + 16 * j1, 0.0F, 0.0F, 16, 16, 16, 16); } } this.renderWindow(matrixStack); RenderSystem.depthFunc(518); RenderSystem.translatef(0.0F, 0.0F, -950.0F); RenderSystem.colorMask(false, false, false, false); fill(matrixStack, 4680, 2260, -4680, -2260, -16777216); RenderSystem.colorMask(true, true, true, true); RenderSystem.translatef(0.0F, 0.0F, 950.0F); RenderSystem.depthFunc(515); RenderSystem.popMatrix(); } And finally we get to the errant line: this.renderWindow(matrixStack);. This method is overridden by each tab and renders the content of the tab. For my tab it is simple, we render a piece of text at the center of the tab. This text renders fine, however it breaks the tab icon and window name. @Override protected void renderWindow(MatrixStack matrixStack) { ITextComponent divineFavourText = new TranslationTextComponent("screen.mesoamericamythology.divine_relationships.favour.divine_favour", this.getRelationship().getDivineFavour()); // x, y, colour // This line breaks the rendering :( drawCenteredString(matrixStack, this.minecraft.font, divineFavourText, MAX_WIDTH / 2, MAX_HEIGHT / 2, Integer.parseInt("FFFFFF", 16)); } Below I have two screenshots. The one on the left is what the UI looks like when I don't draw the string in renderWindow. The right is what happens when I do. I'm a little befuddled at the moment. Hoping someone has more pointers that would help me understand what is going on.
    • User was banned for piracy. Buy the game.
    • Well, the errors seem as though they're tconstruct/jei, have you tried updating those? There are newer versions for 1.16 on curseforge for both of those mods. If you're convinced it's one of your dimensions mods, remove them 1 by one, or remove all and add them back 1 by 1, until you find the culprit.   *edit: what is tlskincape?
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.