Jump to content

[1.7.2] LivingHurtEvent doesn't work?


sep87x

Recommended Posts

Hey, I'm back with another problem,

 

At first, thanks to everyone who was helping me in my previous question about how to come along with the "new" event system. However, I discovered another hurdle on my way to a new release. I set up a LivingHurtEvent and want to find out the distance between the player and the dead hurt entity, but for some reason Forge won't let me know if there's been an entity murdered hurted. Here the most important code snippets:

 

Main Mod Class:

 

	@EventHandler
public void onInit(FMLInitializationEvent event) {
	ForgeUtils.getForgeEventBus().register(new SkillCombatListener()); // registered at MinecraftForge.EVENT_BUS
}

 

Death Handler:

 

	@SubscribeEvent
public void onLivingHurt(LivingHurtEvent event) {
	if (event.entity instanceof EntityLiving && !(event.entity instanceof EntityPlayer)) {
		System.out.println(event.entity.getDistanceToEntity(ForgeUtils.getPlayer()) + " " + event.source.damageType);
	}
}

 

I've tried to find typos in the code with some basic console logging but Forge doesn't even seem to call the LivingHurtEvent. Though LivingHurtEvent extends LivingEvent it doesn't seem to do anything. Am I just missing something or is this a bug?

 

Greets from Germany

~sep87x

Link to comment
Share on other sites

Hello sep87x,

 

You are using the wrong event. To see al entityLiving events, go to the package called net.minecraftforge.event.entity.living.

To check if an entity has been murdered, you should use the LivingDeathEvent event. The LivingHurtEvent event only fires when an entity

is hurt, not killed. Also, make sure that the event only runs on the server side using;

if(event.entityPlayer.worldObj.isRemote) return;

 

Hope this helps you!

 

Follow me on twitter: https://twitter.com/CoderAce_

Link to comment
Share on other sites

Also, you should note that the if-statement contains unnecessery code.

 

	@SubscribeEvent
public void onLivingHurt(LivingHurtEvent event) {
	System.out.println("FEHFOUHUOjhgriwgwrg");
	if (!(event.entity instanceof EntityPlayer)) {
		System.out.println(event.entity.getDistanceToEntity(ForgeUtils.getPlayer()) + " " + event.source.damageType);
	}
}

 

I already expected that, but I was too lazy to change this. However, this wouldn't change anything in how the handler works. As I said in my first post, I've already tried some standard logging (like above) but it doesn't even send the output to the console. It should work and that's my main problem here.

Link to comment
Share on other sites

I register my events using this code; MinecraftForge.EVENT_BUS.register(new ItemPickupHandler());

Maybe try that? It seems like it goes wrong at the registring part.

 

ForgeUtils.getForgeEventBus().register(new SkillCombatListener());

 

is basically just an alias for

 

MinecraftForge.EVENT_BUS.register(new SkillCombatListener());

 

I wrote the ForgeUtils class for me so it's easier for me to get into the new 1.7.2 system. In the first place I wrote the class to distinguish the Forge event bus from the FML event bus because they're two things on their own ... soooo the typo can't be at this place.

 

Edit: I might just take a nap and make a new attempt tomorrow. I'll let you guys know whether your advice was helping me out or not.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.