Ore not generating...

[Busti]

Hello,

I tried to add an ore to the world gen and I followed the common tutorials. I tried to add some structure to it to make it easier, but somehow it isn't working:

Registration:

public static void Init() {
        //Generators
        OreGen oreGen = new OreGen();
        oreGen.addOre(block_CopperOre, 10);
        GameRegistry.registerWorldGenerator(oreGen, 500);
}

 

Gen Class:

/*
* Copyright (c) 2013-2014 Busti2000.
*
* Technica is distributed under the terms of the Minecraft Mod Public
* License 1.0, or MMPL. Please check the contents of the license located in
* http://www.mod-buildcraft.com/MMPL-1.0.txt
*/

package mlb.technica.core.world;

import cpw.mods.fml.common.IWorldGenerator;
import net.minecraft.block.Block;
import net.minecraft.world.World;
import net.minecraft.world.chunk.IChunkProvider;
import net.minecraft.world.gen.feature.WorldGenMinable;
import net.minecraft.world.gen.feature.WorldGenerator;
import net.minecraftforge.event.terraingen.OreGenEvent;
import net.minecraftforge.event.terraingen.TerrainGen;

import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;
import java.util.Random;

public class OreGen implements IWorldGenerator{

    private final List<WorldGenMinable> oreGenList = new ArrayList<WorldGenMinable>();

    public void addOre(Block block, int number) {
        oreGenList.add(new WorldGenMinable(block, number));
    }

    public void genStandardOre(int count, World world, WorldGenerator worldGen, Random random, int chunkX, int chunkZ, int min, int max) {
        for (int i = 0; i < count; i++) {
            int x = chunkX + random.nextInt(16);
            int y = random.nextInt(max - min) + min;
            int z = chunkZ + random.nextInt(16);
            worldGen.generate(world, random, x, y, z);
        }
    }

    @Override
    public void generate(Random random, int chunkX, int chunkZ, World world, IChunkProvider chunkGenerator, IChunkProvider chunkProvider) {
        Iterator<WorldGenMinable> iter = oreGenList.iterator();
        while(iter.hasNext()) {
            WorldGenMinable ore = iter.next();
            if (TerrainGen.generateOre(world, random, ore, chunkX, chunkZ, OreGenEvent.GenerateMinable.EventType.CUSTOM))
                genStandardOre(20, world, ore, random, chunkX, chunkZ, 0, 96);
        }
    }
}

[Aspect]

I also have this problem, my ore and trees wont generate at all. My code is very similar to yours, I also register my World Generators under the FMLIntializationEvent, I'm guessing you're doing something similar?

[Busti]

Yes I am. The generate method gets called but nothing generates. It also takes a very long time but i cant imagine where the delay comes from.

[Busti]

When I do it with my blocks each chunk takes about 10 seconds more to generate but when I do it with a Vanilla block it doesn't. Even though nothing is really generating

[TLHPoE]

You need to multiply chunkX and chunkZ by 16 before passing it on to the other generate methods.

[sequituri]

Change this:

    genStandardOre(20, world, ore, random, chunkX, chunkZ, 0, 96);

to this:

    genStandardOre(20, world, ore, random, chunkX*16, chunkZ*16, 0, 96);

[Jwosty]

*ahem* bitshift *ahem*

[sequituri]

The multiply will automagically get implemented by a <<4 in the JVM optimizer (Bytecode compiler), no need to fret. Same as divide by constant power of 2.