Jump to content

[1.7.2]World Generation Not Working


Aspect

Recommended Posts

You have to multiply the chunkX and chunkZ by 16. Or just use my class:

Then just use the addOre method in your Registry...

 

import cpw.mods.fml.common.IWorldGenerator;
import net.minecraft.block.Block;
import net.minecraft.world.World;
import net.minecraft.world.chunk.IChunkProvider;
import net.minecraft.world.gen.feature.WorldGenMinable;
import net.minecraft.world.gen.feature.WorldGenerator;
import net.minecraftforge.event.terraingen.OreGenEvent;
import net.minecraftforge.event.terraingen.TerrainGen;

import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;
import java.util.Random;

public class OreGen implements IWorldGenerator{

    private class OreData {
        protected final WorldGenMinable oreGen;
        protected final int min;
        protected final int max;
        protected final int count;

        protected OreData(WorldGenMinable ore, int minHeight, int maxHeight, int clusterCount) {
            oreGen = ore;
            min = minHeight;
            max = maxHeight;
            count = clusterCount;
        }
    }

    private final List<OreData> oreGenList = new ArrayList<OreData>();

    public void addOre(Block block, int size, int minHeight, int maxHeight, int clusterCount) {
        OreData data = new OreData(new WorldGenMinable(block, size), minHeight, maxHeight, clusterCount);
        oreGenList.add(data);
    }

    public void addOre(Block block, int size) {
        OreData data = new OreData(new WorldGenMinable(block, size), 0, 64, 20);
        oreGenList.add(data);
    }

    public void addOre(Block block) {
        OreData data = new OreData(new WorldGenMinable(block, , 0, 64, 20);
        oreGenList.add(data);
    }

    public void genStandardOre(int count, World world, WorldGenerator worldGen, Random rand, int chunkX, int chunkZ, int min, int max) {
        for (int i = 0; i < count; i++) {
            int x = chunkX + rand.nextInt(16);
            int y = rand.nextInt(max - min) + min;
            int z = chunkZ + rand.nextInt(16);
            worldGen.generate(world, rand, x, y, z);
        }
    }

    @Override
    public void generate(Random rand, int chunkX, int chunkZ, World world, IChunkProvider chunkGenerator, IChunkProvider chunkProvider) {
        Iterator<OreData> iter = oreGenList.iterator();
        while(iter.hasNext()) {
            OreData ore = iter.next();
            if (TerrainGen.generateOre(world, rand, ore.oreGen, chunkX, chunkZ, OreGenEvent.GenerateMinable.EventType.CUSTOM))
                genStandardOre(ore.count, world, ore.oreGen, rand, chunkX * 16, chunkZ * 16, ore.min, ore.max);
        }
    }
}

 

 

EDIT: I forgot the package :/

PM's regarding modding questions should belong in the Modder Support sub-forum and won't be answered.

Link to comment
Share on other sites

I'm wondering why everybody following some tutorial is making the same mistake in oreGen? Maybe we should blacklist the tutorial.

Link to comment
Share on other sites

You have to multiply the chunkX and chunkZ by 16. Or just use my class:

Then just use the addOre method in your Registry...

 

import cpw.mods.fml.common.IWorldGenerator;
import net.minecraft.block.Block;
import net.minecraft.world.World;
import net.minecraft.world.chunk.IChunkProvider;
import net.minecraft.world.gen.feature.WorldGenMinable;
import net.minecraft.world.gen.feature.WorldGenerator;
import net.minecraftforge.event.terraingen.OreGenEvent;
import net.minecraftforge.event.terraingen.TerrainGen;

import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;
import java.util.Random;

public class OreGen implements IWorldGenerator{

    private class OreData {
        protected final WorldGenMinable oreGen;
        protected final int min;
        protected final int max;
        protected final int count;

        protected OreData(WorldGenMinable ore, int minHeight, int maxHeight, int clusterCount) {
            oreGen = ore;
            min = minHeight;
            max = maxHeight;
            count = clusterCount;
        }
    }

    private final List<OreData> oreGenList = new ArrayList<OreData>();

    public void addOre(Block block, int size, int minHeight, int maxHeight, int clusterCount) {
        OreData data = new OreData(new WorldGenMinable(block, size), minHeight, maxHeight, clusterCount);
        oreGenList.add(data);
    }

    public void addOre(Block block, int size) {
        OreData data = new OreData(new WorldGenMinable(block, size), 0, 64, 20);
        oreGenList.add(data);
    }

    public void addOre(Block block) {
        OreData data = new OreData(new WorldGenMinable(block, , 0, 64, 20);
        oreGenList.add(data);
    }

    public void genStandardOre(int count, World world, WorldGenerator worldGen, Random rand, int chunkX, int chunkZ, int min, int max) {
        for (int i = 0; i < count; i++) {
            int x = chunkX + rand.nextInt(16);
            int y = rand.nextInt(max - min) + min;
            int z = chunkZ + rand.nextInt(16);
            worldGen.generate(world, rand, x, y, z);
        }
    }

    @Override
    public void generate(Random rand, int chunkX, int chunkZ, World world, IChunkProvider chunkGenerator, IChunkProvider chunkProvider) {
        Iterator<OreData> iter = oreGenList.iterator();
        while(iter.hasNext()) {
            OreData ore = iter.next();
            if (TerrainGen.generateOre(world, rand, ore.oreGen, chunkX, chunkZ, OreGenEvent.GenerateMinable.EventType.CUSTOM))
                genStandardOre(ore.count, world, ore.oreGen, rand, chunkX * 16, chunkZ * 16, ore.min, ore.max);
        }
    }
}

 

 

EDIT: I forgot the package :/

Sorry, but...when you say use the addOre with your registry...what do you mean? For my ore I've got:

RadialOre = new RadialOre().setBlockName("radialore").setHardness(5.0F).setResistance(5.0F).setLightLevel(0.8F).setStepSound(Block.soundTypeStone).setCreativeTab(RadialTabs).setBlockTextureName(modid + ":radialore");
	GameRegistry.registerBlock(RadialOre, "radialore").addOre(RadialOre);
	RadialOre.setHarvestLevel("pickaxe", 3);

That gives me an error, though. Am I putting it in the wrong spot?

Link to comment
Share on other sites

SureenInk, Busti is referring to the Forge OreDictionary (i believe). If you are creating new ores, you would do well to register them in the Ore registry so other mods can use them in recipes, too. Or simply not have a conflict about it when there are more than 1 lead ores in the game.

Link to comment
Share on other sites

[quote name="sequituri" post="88900" timestamp="1395475684"]
SureenInk, Busti is referring to the Forge OreDictionary (i believe). If you are creating new ores, you would do well to register them in the Ore registry so other mods can use them in recipes, too. Or simply not have a conflict about it when there are more than 1 lead ores in the game.
[/quote]
Sorry...I'm horribly new at this...so then I just have to add [codepublic static void oreRegistration()
{
	OreDictionary.registerOre("radialore", RadialOre);
}

I'm sorry...I really am new at this (just started the other day), so I'm still very confused x.x

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
    • It is an issue with quark - update it to this build: https://www.curseforge.com/minecraft/mc-mods/quark/files/3642325
    • Remove Instant Massive Structures Mod from your server     Add new crash-reports with sites like https://paste.ee/  
    • Update your drivers: https://www.amd.com/en/support/graphics/amd-radeon-r9-series/amd-radeon-r9-200-series/amd-radeon-r9-280x
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.