Jump to content

[1.7.2] Shapeless Crafting not working for me?


Budboy33

Recommended Posts

I'm a bit new to coding with Minecraft Forge and want to add a shapeless crafting recipe for grass using vines and dirt, and the grass isn't appearing when I put a vine and dirt in, and my code isn't giving any errors telling what's wrong, so what IS wrong?

 

package com.budboy.betterfishing;

 

import com.budboy.betterfishing.Proxy.ProxyCommon;

 

import net.minecraft.init.Blocks;

import net.minecraft.init.Items;

import net.minecraft.item.ItemStack;

import cpw.mods.fml.common.Mod;

import cpw.mods.fml.common.Mod.EventHandler;

import cpw.mods.fml.common.Mod.Instance;

import cpw.mods.fml.common.SidedProxy;

import cpw.mods.fml.common.event.FMLInitializationEvent;

import cpw.mods.fml.common.registry.GameRegistry;

 

@Mod(modid = BetterFishing.MODID, version = BetterFishing.VERSION, name =BetterFishing.MOD_NAME)

public class BetterFishing

public static final String MOD_NAME = "Better Fishing";

    public static final String MODID = "BF";

    public static final String VERSION = "0.0.1";

   

    @Instance(value = MODID)

    public static BetterFishing instance;

   

    @SidedProxy(clientSide = "com.budboy.betterfishing.Proxy.ProxyClient", serverSide = "com.budboy.betterfishing.proxy.proxyCommon")

    public static ProxyCommon proxy;

    @EventHandler

    public void init(FMLInitializationEvent event)

    {

    GameRegistry.addShapelessRecipe(new ItemStack(Blocks.grass), Blocks.vine, 1, Blocks.dirt, 1);

    }

  @EventHandler

public void load(FMLInitializationEvent event){

proxy.registerRenderers();

    {

    }

}

}

 

Proxy Common Code:

 

package com.budboy.betterfishing.Proxy;

 

public class ProxyCommon {

public void registerRenderers(){

}

}

 

Proxy Client Code:

 

package com.budboy.betterfishing.Proxy;

 

public class ProxyClient extends ProxyCommon {

@Override

public void registerRenderers(){

 

}

 

}

Link to comment
Share on other sites

Still didn't work, here's new code:

 

package com.budboy.betterfishing;

 

import com.budboy.betterfishing.Proxy.ProxyCommon;

 

import net.minecraft.init.Blocks;

import net.minecraft.init.Items;

import net.minecraft.item.ItemStack;

import cpw.mods.fml.common.Mod;

import cpw.mods.fml.common.Mod.EventHandler;

import cpw.mods.fml.common.Mod.Instance;

import cpw.mods.fml.common.SidedProxy;

import cpw.mods.fml.common.event.FMLInitializationEvent;

import cpw.mods.fml.common.registry.GameRegistry;

 

@Mod(modid = BetterFishing.MODID, version = BetterFishing.VERSION, name =BetterFishing.MOD_NAME)

public class BetterFishing

public static final String MOD_NAME = "Better Fishing";

    public static final String MODID = "BF";

    public static final String VERSION = "0.0.1";

   

    @Instance(value = MODID)

    public static BetterFishing instance;

   

    @SidedProxy(clientSide = "com.budboy.betterfishing.Proxy.ProxyClient", serverSide = "com.budboy.betterfishing.proxy.proxyCommon")

    public static ProxyCommon proxy;

    @EventHandler

    public void init(FMLInitializationEvent event)

    {

    GameRegistry.addShapelessRecipe(new ItemStack(Blocks.grass), Blocks.vine, Blocks.dirt);

    }

  @EventHandler

public void load(FMLInitializationEvent event){

proxy.registerRenderers();

    {

    }

}

}

 

Link to comment
Share on other sites

I got it working! Just had to rewrite my code a bit. :)

 

package com.budboy.betterfishing;

 

import com.budboy.betterfishing.Proxy.ProxyCommon;

 

import net.minecraft.init.Blocks;

import net.minecraft.init.Items;

import net.minecraft.item.ItemStack;

import cpw.mods.fml.common.*;

import cpw.mods.fml.common.Mod.*;

import cpw.mods.fml.common.event.*;

import cpw.mods.fml.common.registry.*;

 

@Mod(modid = BetterFishing.MODID, version = BetterFishing.VERSION)

public class BetterFishing

{

    public static final String MODID = "tutorial";

    public static final String VERSION = "1.0";

   

    @Instance(value=MODID)

    public static BetterFishing instance;

   

    @SidedProxy(clientSide = "com.budboy.betterfishing.Proxy.ProxyClient", serverSide = "com.budboy.betterfishing.Proxy.ProxyCommon")

    public static ProxyCommon proxy;

   

    @EventHandler

        public void preInit(FMLPreInitializationEvent event)

        {

    GameRegistry.addRecipe(new ItemStack(Blocks.obsidian), new Object[]{

        "AAA",

        "AAA",

        "AAA",

        'A', Items.cookie

        });

        }

        public void load(FMLPreInitializationEvent event)

        {

    }

    @EventHandler

    public void init(FMLInitializationEvent event)

    {

    }

    public void load(FMLInitializationEvent event)

    {

    proxy.registerRenderers();

    {

    }

        }

    @EventHandler

    public void postInit(FMLPostInitializationEvent event)

    {

    }

}

 

Thanks everyone for your help to this modding newb.

Link to comment
Share on other sites

package com.budboy.betterfishing;

 

import com.budboy.betterfishing.Proxy.ProxyCommon;

 

import net.minecraft.init.Blocks;

import net.minecraft.init.Items;

import net.minecraft.item.ItemStack;

import cpw.mods.fml.common.*;

import cpw.mods.fml.common.Mod.*;

import cpw.mods.fml.common.event.*;

import cpw.mods.fml.common.registry.*;

 

@Mod(modid = BetterFishing.MODID, version = BetterFishing.VERSION, name = BetterFishing.NAME)

public class BetterFishing {

 

public static final String MODID = "betterFishing", VERSION = "1.0", NAME = "Better Fishing";

 

@Instance(MODID)

public static BetterFishing instance;

 

@SidedProxy(clientSide = "com.budboy.betterfishing.Proxy.ProxyClient", serverSide = "com.budboy.betterfishing.Proxy.ProxyCommon")

public static ProxyCommon proxy;

 

@EventHandler

public void preInit(FMLPreInitializationEvent event)  { 

proxy.registerRenderers();

addRecipes();

}

 

@EventHandler

public void init(FMLInitializationEvent event){ }

 

@EventHandler

public void postInit(FMLPostInitializationEvent event) { }

 

public void addRecipes(){

GameRegistry.addRecipe(new ItemStack(Blocks.obsidian), new Object[]{"AAA", "AAA", "AAA", 'A', Items.cookie});

}

}

Former developer for DivineRPG, Pixelmon and now the maker of Essence of the Gods

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.