Jump to content

[1.7.2]GameRegistry from custom classes


lorizz

Recommended Posts

Hi guys, I'm starting to think that this forge is bad (for me eh)

When I was modding in 1.5.2 and 1.6.4, I had custom classes and custom registers, called each one in each proxy, example:

 

BlockRegistry:

package it.edennetwork.crystalia.module;

import it.edennetwork.crystalia.extender.BlockDecorativeExtendedRotatable;
import it.edennetwork.crystalia.extender.BlockExtender;
import net.minecraft.block.Block;

public class BlocksDecorative {

public static Block lightBlueMagicLeaves;
public static Block lightOrangeMagicLeaves;

public static Block magicWood;
public static Block whiteMagicWood;

public static Block whiteRock;
public static Block blueRock;

public static void onLoad() {
	lightBlueMagicLeaves = new BlockExtender("FoglieMagicheAzzurre",
			CryTabs.crystaliaDecorativeTab).setHardness(0.2F).setStepSound(
			Block.soundTypeGrass);
	lightOrangeMagicLeaves = new BlockExtender(
			"FoglieMagicheArancioni", CryTabs.crystaliaDecorativeTab)
			.setHardness(0.2F).setStepSound(Block.soundTypeGrass);
	magicWood = new BlockDecorativeExtendedRotatable("LegnoMagico",
			"LegnoMagicoTop");
	whiteMagicWood = new BlockDecorativeExtendedRotatable(
			"LegnoMagicoChiaro", "LegnoMagicoChiaroTop");
	whiteRock = new BlockExtender("RocciaBianca",
			CryTabs.crystaliaDecorativeTab);
	blueRock = new BlockExtender("RocciaBlu",
			CryTabs.crystaliaDecorativeTab);
}
}

 

Then I called the "onLoad" method in the Client/ServerProxy in the preInit function:

 

BlocksDecorative.onLoad();

 

But the problem is that the game registers the blocks but doesn't show them in the CreativeTabs! I can only get it by using the "/give" command, it does even not show them in the "Search Tab".

Why? The custom blocks extend to a class which has a constructor that call this at the end:

 

GameRegistry.registerBlock(this, this.getUnlocalizedName().substring(5));

 

Can someone help me with this? They doesn't show up even using the normal forge method, only for another blocks different from the ones coming from the 1.5.2/1.6.4 version.

Link to comment
Share on other sites

Hi guys, I'm starting to think that this forge is bad (for me eh)

When I was modding in 1.5.2 and 1.6.4, I had custom classes and custom registers, called each one in each proxy, example:

 

BlockRegistry:

package it.edennetwork.crystalia.module;

import it.edennetwork.crystalia.extender.BlockDecorativeExtendedRotatable;
import it.edennetwork.crystalia.extender.BlockExtender;
import net.minecraft.block.Block;

public class BlocksDecorative {

public static Block lightBlueMagicLeaves;
public static Block lightOrangeMagicLeaves;

public static Block magicWood;
public static Block whiteMagicWood;

public static Block whiteRock;
public static Block blueRock;

public static void onLoad() {
	lightBlueMagicLeaves = new BlockExtender("FoglieMagicheAzzurre",
			CryTabs.crystaliaDecorativeTab).setHardness(0.2F).setStepSound(
			Block.soundTypeGrass);
	lightOrangeMagicLeaves = new BlockExtender(
			"FoglieMagicheArancioni", CryTabs.crystaliaDecorativeTab)
			.setHardness(0.2F).setStepSound(Block.soundTypeGrass);
	magicWood = new BlockDecorativeExtendedRotatable("LegnoMagico",
			"LegnoMagicoTop");
	whiteMagicWood = new BlockDecorativeExtendedRotatable(
			"LegnoMagicoChiaro", "LegnoMagicoChiaroTop");
	whiteRock = new BlockExtender("RocciaBianca",
			CryTabs.crystaliaDecorativeTab);
	blueRock = new BlockExtender("RocciaBlu",
			CryTabs.crystaliaDecorativeTab);
}
}

 

Then I called the "onLoad" method in the Client/ServerProxy in the preInit function:

 

BlocksDecorative.onLoad();

 

But the problem is that the game registers the blocks but doesn't show them in the CreativeTabs! I can only get it by using the "/give" command, it does even not show them in the "Search Tab".

Why? The custom blocks extend to a class which has a constructor that call this at the end:

 

GameRegistry.registerBlock(this, this.getUnlocalizedName().substring(5));

 

Can someone help me with this? They doesn't show up even using the normal forge method, only for another blocks different from the ones coming from the 1.5.2/1.6.4 version.

Your mod class? An example block class?

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Link to comment
Share on other sites

I'm not sure if it's changed in 1.7, but when you

lightBlueMagicLeaves = new BlockExtender("FoglieMagicheAzzurre", CryTabs.crystaliaDecorativeTab).setHardness(0.2F).setStepSound(Block.soundTypeGrass);

 

I don't know what your BlockExtender class looks like and why your setting the customTab as a part of the constructor.

In 1.6 mine would look something like this

oreCopper = new BlockRE(oreCopperID, Material.rock).setUnlocalizedName("oreCopper");

 

and my BlockRE would be like

public BlockRE(int id, Material material) {
	super(id, material);
	this.setCreativeTab(RegistryRE.tabRE);
}

 

Also, are you registering the name in the language registry? I know its different in 1.7, but i know you still have to do it a certain way.

Link to comment
Share on other sites

Here's the class extender:

 

package it.edennetwork.crystalia.extender;

import it.edennetwork.crystalia.Crystalia;

import java.util.Random;

import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.client.renderer.texture.IIconRegister;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.init.Blocks;
import cpw.mods.fml.common.registry.GameRegistry;

public class BlockExtender extends Block {
    public final String textureName;
    public final int droppedItemID;
    public final int quantityDrop;

    public BlockExtender(String texture, CreativeTabs tab)
    {
        super(Material.rock);
        textureName = texture;
        setCreativeTab(tab);
        this.setHarvestLevel("pickaxe", 0);
        setBlockName(texture);
        setStepSound(Block.soundTypeStone);
        droppedItemID = this.getIdFromBlock(this);
        quantityDrop = 1;
        GameRegistry.registerBlock(this, this.getUnlocalizedName().substring(5));
    }

    @Override
    public void registerBlockIcons(IIconRegister iconRegister)
    {
        blockIcon = iconRegister.registerIcon(Crystalia.modid + ":" + textureName);
    }

    @Deprecated // Removed in 1.7.2
    public int idDropped(int par1, Random par2Random, int par3)
    {
        return droppedItemID;
    }

    @Deprecated // Removed in 1.7.2
    public int quantityDropped(Random random)
    {
        return quantityDrop;
    }
}

Link to comment
Share on other sites

Here's the class extender:

 


    public BlockExtender(String texture, CreativeTabs tab)
    {
        droppedItemID = this.getIdFromBlock(this);
...
        GameRegistry.registerBlock(this, this.getUnlocalizedName().substring(5));
    }

    @Deprecated // Removed in 1.7.2
    public int idDropped(int par1, Random par2Random, int par3)
    {
        return droppedItemID;
    }

    @Deprecated // Removed in 1.7.2
    public int quantityDropped(Random random)
    {
        return quantityDrop;
    }
}

 

This may not be your main problem, but your code cannot work as written with IDs. Even if you registered your block before trying to use its ID (which you cannot), you are using deprecated methods which have no purpose in 1.7.2. Using the

@deprecated

annotation is the same as saying ignore this error. But, there is no reason to cheat like that.

 

Link to comment
Share on other sites

Here's the class extender:

 


    public BlockExtender(String texture, CreativeTabs tab)
    {
        droppedItemID = this.getIdFromBlock(this);
...
        GameRegistry.registerBlock(this, this.getUnlocalizedName().substring(5));
    }

    @Deprecated // Removed in 1.7.2
    public int idDropped(int par1, Random par2Random, int par3)
    {
        return droppedItemID;
    }

    @Deprecated // Removed in 1.7.2
    public int quantityDropped(Random random)
    {
        return quantityDrop;
    }
}

 

This may not be your main problem, but your code cannot work as written with IDs. Even if you registered your block before trying to use its ID (which you cannot), you are using deprecated methods which have no purpose in 1.7.2. Using the

@deprecated

annotation is the same as saying ignore this error. But, there is no reason to cheat like that.

 

I know, those method also are not being called because they doesn't override nothing, just only for purpose.

Anyway I removed them, still not working.

 

@coolboy

The registry is called in the "preInit" method, even if I try to call it outside the class, doesn't work.

I tried making a "testBlock" directly in the preinit method and registered it with a custom creative tabs, IT WORKS! But I don't know why forge doesn't check this extender...

Expecially the "setCreativeTab(tab)"....

Link to comment
Share on other sites

We need some real verification from Forge.

 

From what I think (in my perspective) I don't think Forge checks for (GameRegistry.#) in custom classes - they only check for it in the PreInit method like I said below.

 

And for the .setCreativeTab(#) - I really don't know.

Like said, above, could be something with your CryTabs class (please show us it).

Link to comment
Share on other sites

I got it, I called the Tabs AFTER the game has registered the blocks/items. Now I need only to make a different "GameRegistry" function that will register the blocks/items AFTER the tables has been loaded and AFTER the blocks/items have been initialized!

Thanks for all to pointing to the tabs! It helped me very much, thanks!

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.