Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

Pre-Brewing Event


Azaka7
 Share

Recommended Posts

Note: I've already written and submitted a PR for this.

 

I would like an event that allows modders to check alter the contents of a brewing stand before the actual brewing takes place. The brewing event that already exists only takes place after vanilla brewing and the ingredient is removed.

 

This event would basically allow for the adding of custom brewing recipes and alter existing recipes. Here's an example mod:

 

 

package examplemod.common;

import net.minecraft.init.Blocks;
import net.minecraft.init.Items;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.potion.Potion;
import net.minecraft.potion.PotionHelper;
import net.minecraftforge.common.MinecraftForge;
import net.minecraftforge.event.brewing.PotionBrewedEvent;
import cpw.mods.fml.common.Mod;
import cpw.mods.fml.common.Mod.EventHandler;
import cpw.mods.fml.common.event.FMLPreInitializationEvent;
import cpw.mods.fml.common.eventhandler.SubscribeEvent;

@Mod(modid = "brewing_example", name = "Brewing Example", version = "0.0.0")
public class BrewingExampleMain {
    @EventHandler
    public void preinit(FMLPreInitializationEvent event)
    {
        Item.getItemFromBlock(Blocks.piston).setPotionEffect(PotionHelper.blazePowderEffect);
        MinecraftForge.EVENT_BUS.register(this);
    }
    
    @SubscribeEvent
    public void handleBrewing(PotionBrewedEvent.Pre event){
        if(event.brewingStacks[3] != null){
            ItemStack jumpyPot = new ItemStack(Items.potionitem, 1, 8194);
            jumpyPot.stackTagCompound = new NBTTagCompound();
            jumpyPot.stackTagCompound.setTag("CustomPotionEffects", new NBTTagList());
            NBTTagCompound jumpyEffect = new NBTTagCompound();
            jumpyEffect.setByte("Id", (byte) Potion.jump.id);
            jumpyEffect.setByte("Amplifier", (byte) 4);
            jumpyEffect.setInteger("Duration", 1000);
            jumpyPot.stackTagCompound.getTagList("CustomPotionEffects", 0).appendTag(jumpyEffect);
            boolean flag = false;
            for(int i = 0; i < 3; i ++){
                if(event.brewingStacks[i]!= null && event.brewingStacks[i].getItem() == Items.potionitem && event.brewingStacks[i].getItemDamage() == 16){

                    if(event.brewingStacks[3] != null && event.brewingStacks[3].getItem() == Item.getItemFromBlock(Blocks.piston)){
                        event.brewingStacks[i] = jumpyPot;
                        flag = true;
                    }
                    
                    //Other ingredient checks can occur.
                }
            }
            if(flag){
                event.brewingStacks[3].stackSize -= 1;
                if (event.brewingStacks[3].stackSize <= 0)
                {
                    event.brewingStacks[3] = null;
                }
                event.setCanceled(true);
            }
        }
    }
}

 

 

This example mod would allow players to brew Jumping potions with Jump Boost (Amplitude 4 and Duration 1000) by brewing a piston into up to 3 awkward potions. The only problem I've encountered is that non-vanilla ingredients aren't normally allowed in the ingredient slot, so they have to be given a fake potion effect string (I applied the blaze powder string to the piston in this case).

 

What this mod is doing is checking the slots for appropriate contents, then replacing the potions and reducing the ingredient stack is brewing occurs.

 

Potion effects added by mods could be used in the brewed potion ItemStacks instead of a vanilla one, allowing mods to add brewing recipes for their own potion effects.

 

I know this all can be achieved by reflection, but if any two mods take up the same brewing recipe identification (same bits used for metadata) they will be incompatible. This event will allow for near complete compatibility between mods adding brewing recipes using this event.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • show the code your use for this is the Event called?, use debugger to check the values in the condition
    • if you add your Biome to the Overworld via BiomeManager#addAdditionalOverworldBiomes, you need to register your Biome via DeferredRegister or RegistryEvent unfortunately a json only Biome does not work in this case
    • use debugger to check the conditions you are using before you render your Entity
    • yes, and then post the correct logs
    • Good Morning, I tried overriding one of the vanilla rock blocks according to instructions in this old thread, but failed for the same reason the org TM did, even though I got a tiny bit farther than he did. I can remove the original block entirely from world spawn, and replace it with custom version, which I want to prevent due to following up workload(adapting recipes etc. to custom block). What I tried solving the issue/actually making replacing(partially) work: 1. I had to use the original Forge variant of registering the block in main class, like that: which actually did use the custom granite block as replacer(not exactly illustrated in the old thread), but didn't consider it on world feature generation... 2. I then believed it was due to not using correct path variables for assets texture/models/blockstates etc., so I created missing asset packets for both, vanilla asset path, and my mod path. This also did not fix the issue with creating holes filled up with Items.AIR on world feature generation. 3. I then tried to remove the vanilla granite block during feature generation, and reimported it after with my replacement set up, during feature generation as well(according to @Luis_ST advice). But the holes were still there, only this time I got my replaced granite block spawned as well. What do I want to achieve(asking myself and you in hope maybe there's a better solution)? Mojang found it a good idea, to give one of the hardest rock materials on this planet, the .harvestLevel(soft as a pillow), so I can harvest it with a wooden pickaxes(which technically is even worth, but doesn't matter since wooden "pickaxe" tools do not exist in my mod). I really just want to compare harvestLevel of any of my tools, against the harvestLevel of the targetBlock, so I can automatically disallow harvesting it, if the tool doesn't match the harvestLevel(which for whatever reason does not work as intended in 1.16.5 Minecraft). Edit: and before you shout "doPlayerHarvestCheck". Yes, I do that! Edit2: Also, why are there Manga Comic Girls, on the right upper corner of my Monitor, stating how can it be that big?(whatever "it" is?)
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.