Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

Problems with Client and Server-Side Proxies


SirEntropy
 Share

Recommended Posts

Hi.

 

I was trying to create a mod proxy to manage client and server-side data. However, it is not behaving the way I expect.

 

This is the mod class:

 

@Mod(modid = "mcmods.common", name = "MCMods Common", version = "0.0.1")
@NetworkMod(
	clientSideRequired = true,
	serverSideRequired = false,
	packetHandler = MCModsPacketHandler.class,
	channels = { "SubWorld" }

	)
public class MCModsCommon {

@Instance
public static MCModsCommon instance;

@SidedProxy(
		clientSide = "mcmods.common.registry.CommonRegistryClient",
		serverSide = "mcmods.common.registry.CommonRegistry")
public static CommonRegistry registry;


@Init
public void load(FMLInitializationEvent evt) {
	System.out.println(registry);
	registry.init(this);
}
}

 

This is the server-side proxy class

public class CommonRegistry extends Registry {

public CommonRegistry() {
	System.out.println("Crated Common Registy Server");
}
...
}

 

and the client-side proxy class

public class CommonRegistryClient extends CommonRegistry {
public CommonRegistryClient() {
	System.out.println("Crated Common Registy Client");
}
        ...
}

 

The problem is that, although both classes are instantiated, only the client-side instance gets assigned to the MCModsCommon.registry attribute.

 

...
2012-09-15 21:06:48 [iNFO] [ForgeModLoader] Forge Mod Loader has identified 5 mods to load
2012-09-15 21:06:48 [iNFO] [sTDOUT] Crated Common Registy Server
2012-09-15 21:06:48 [iNFO] [sTDOUT] Crated Common Registy Client
2012-09-15 21:06:48 [iNFO] [sTDOUT] Starting up SoundSystem...
2012-09-15 21:06:49 [iNFO] [sTDOUT] Initializing LWJGL OpenAL
2012-09-15 21:06:49 [iNFO] [sTDOUT]     (The LWJGL binding of OpenAL.  For more information, see http://www.lwjgl.org)
2012-09-15 21:06:49 [iNFO] [sTDOUT] OpenAL initialized.
2012-09-15 21:06:49 [iNFO] [sTDOUT] mcmods.common.registry.CommonRegistryClient@7f32e910
...

As far as I know, there should be two separate instances of MCModsCommon (one for the client thread and one for the server thread), so when the load method is called, it should print both CommonRegistry and CommonRegistryClient. Currently it only prints CommonRegistryClient (see the last line of the last output).

 

Is it right my assumption that MCModsCommon should have two different instances? If so, what am I doing wrong?

Link to comment
Share on other sites

Umm no are you high? How exactly do you expect a variable to hold two values?

The reason you're getting both of the lines in your log is because both functions are being executed ON THE SAME INSTANCE OF THE CLASS.

Thats how inheritance works...

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Patreon: http://www.patreon.com/lexmanos
Paypal: http://paypal.me/LexManos

BitCoin: 1Q8rWvUNMM2T1ZfDaFeeYQyVXtYoeT6tTn

Link to comment
Share on other sites

Umm no are you high? How exactly do you expect a variable to hold two values?

The reason you're getting both of the lines in your log is because both functions are being executed ON THE SAME INSTANCE OF THE CLASS.

 

I'm well aware of how inheritance works. What you say it's true when you have only one thread running with that instance or two+ threads sharing the same memory. If you run two threads, one for the client and one of the server, as it happens in MC 1.3.2, and you are not sharing memory, you  may have more than one instance, which means that I would have expected that the line "Crated Common Registy Server" should have been printed twice. Perhaps I should reformulate my question: When running MC 1.3.2 in standalone mode (client and embedded server), do both threads (client and server) share the same memory space or do they have different spaces for their variables? If the latter is true the instance of MCModsCommon in the server thread should have the attribute 'registry' of type CommonRegistry, while the instance in the client thread should have the attribute 'registry' of type CommonRegistryClient.

 

Since you say that there is only one instance of the class, the answer might be the former. If so, wouldn't be useful to change MC Forge to create two different instances of the mod class, one for client and one for server, (e.g., using the ThreadLocal class)? That way would make coding for standalone MC be more consistent with coding for MC server and bukkit, since there will be an effective separation between the client and server code.

Link to comment
Share on other sites

Almost never does multiple threads in the same program have a different memory space beyond the thread itself.

 

And yes, MC shares the same instance among all threads, and this isn't gunna change, we are not gunna initialize your mod twice.

The code will be consistent, if you've done it right.

And all of your code should not care what thread it run on, as long as you do not start accessing things you should {like the client world from the server thread} you're fine.

Thats how all of MC is designed, single instances shared amung threads.

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Patreon: http://www.patreon.com/lexmanos
Paypal: http://paypal.me/LexManos

BitCoin: 1Q8rWvUNMM2T1ZfDaFeeYQyVXtYoeT6tTn

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Please stop capitalizing every word... You need to call NetworkHooks.openGui on the server to open your GUI. You also need to register your ScreenFactory on the client.
    • 1.12 is no longer supported on this forum. Please update to a modern version of Minecraft to receive support.
    • Server Version: 1.17.1 Server IP: enhanced.snorkycraft.com Discord:http://discord.snorkycraft.com/ Snorky Craft World is a playground I have designed for myself and friends to enjoy minecraft, with just some difficult enhancing and extra Contents, i'm an active player on my own server, grinding side by side with players. I do have a TLDR down at the bottom, if you're too lazy to read ;P. Showcase:https://www.youtube.com/watch?v=is7JoucsK0s A short 6 minutes video we have showcasing someone fun time in 2 lairs! a mini-world boss and a world boss. Things we have! ● KeepInvetory - You keep inventory but whenever you die, all your tools and armours lose durability. ● GriefPrevention - Well just your good ol' land claiming area to protect base from griefers ● mcMMO - Well, most of you might know what plugin is this, it's the kind of plugin that help you grow stronger the more you play! ● EliteMobs - Enhancing the mobs around you the more stronger you grow! and also allowing us to replace, create contents for you to enjoy! ● PlaytimeRewards Some Fun Features! Ridable Certain Animals, 6-Rows Enderchest!, Bonus ClaimBlocks, and a very spicy rank! ● Some Funzies Feautures: Editable armor stands! want to decorate your home and make it more lovely? you can with editable armorstands!, 6-Rows barrels! just some extra storage for your home! ● Some...lore related features: Some kind of strange disease have infected the cows... they attack!, Chicken are very feisty! Gameplay Changes ● Disabled Spawners AI, what's the point of spawners, they just ruins the game and there's nothing fun about it, also spawners aren't very useful in my server due to how it's setup. ● Removed The End world exploration! replaced it with the final boss stage for a very long grinding journey, one of our grinder has exactly 60+ Hours of playtime and he only reached Prestige 2! there are 10 Prestiges in total in order to have the power to defeat the new Ender Dragon Boss ● Progression changes, The end goal is not just getting to the ender dragon, is ranking up a custom rank system and farming custom items in order to grow stronger, strong enough to challenge very hard bosses! ● Monsters grows stronger the better equipped you are! and the more stronger you grow they harder challenges/dungeons/lairs you can fight! TLDR: You Join, You Lookaround, You Mine, You Build a House, You farm and gear up, Realized Diamond gearset or netherite gearset full set is so weak!, you start to farm small low level dungeons, you gain great gear, you defeat low level boss, you rankup, you get stronger gear, you repeat this progress so many times you have to prestiges too!, it's pretty fun! i been grinding 10-12 hours a day because once you get going it's very enjoyable.
    • The inputs are just a template- in this case it's two strings, but they can be ints, chars, etc. or none at all, depending if you need to initially send info across sides. I'd suggest reading Forge's documentation on packets first if you haven't used them before:  Forge Docs Networking You usually send the packet by invoking handler methods: ModPacketHandler.sendToServer(new C2SPacketForContainer(input1, input2)); Where the handler class has packet registration and the methods: The register methods are called in common setup.
    • Yeah the VillagerUtil was used in conjunction with the POI Forge registry, but you're right it's superfluous and I should stick with the simpler way. Thank you Ash
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.