Jump to content

[1.7.10][Resolved]Crafting with Water buckets


Roymond

Recommended Posts

Hey everyone,

 

I've been playing around with fluids and I want to add a custom recipe to enable a player to get it in survival. I noticed that that when you do craft the item (dust + water bucket), the player gets an extra empty bucket. I assume that this is because Minecraft recognizes that in vanilla recipes (Cake for Example) you don't want to take the bucket from the player.

 

This lead me to believe that I should get a handler that subscribes to ItemCraftedEvent, looks at the event to see if my custom bucket is created and if there is an empty bucket in the players inventory, and removes one bucket using "consumeInventoryItem"

 

However, after further inspection, it appears that empty bucket that is given to the user shows up after the event has been triggered and thus doesn't removed.

 

Is there a good method to handle this situation?

 

Update on 2014/07/30

 

I have discovered a potential answer to this solution. I simply added ".setContainItem(null)" to the "Items.water_bucket" in my crafting recipe. The final code would looks like this (Note, this is just an example:

 

GameRegistry.addShapelessRecipe(
    new ItemStack( myItem ),
    new Object[] {
         Items.ender_pearl,
         Items.water_bucket.setContainerItem(null)}
);

Link to comment
Share on other sites

To provide some further information, here's the event handler class that I have.

 

package net.roymond.testingMod.EventHandler;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Items;
import net.minecraft.inventory.IInventory;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.roymond.testingMod.mainClass;
import cpw.mods.fml.common.eventhandler.SubscribeEvent;
import cpw.mods.fml.common.gameevent.PlayerEvent;
import cpw.mods.fml.common.gameevent.PlayerEvent.ItemCraftedEvent;

public class CraftingHandler {

public static CraftingHandler INSTANCE = new CraftingHandler();

private CraftingHandler(){
}

@SubscribeEvent
public void PlayerEvent(ItemCraftedEvent event){
	ItemStack craftedItem = event.crafting;

	if (event.crafting.getItem() == mainClass.roymondBucket){
		System.out.println("Desired item has been crafted.");
		for (int i=0; i< event.player.inventory.mainInventory.length; i++){
			System.out.println(event.player.inventory.mainInventory[i]);
			//Prints each slot out on a line.
		}

		if (event.player.inventory.hasItem(Items.bucket)){
			System.out.println("Player has Item. Cleared to remove it");
		}
	}
}


}

 

So this will report to me that the desire item has been crafted and will report back the player's inventory but if you go through the player's inventory you will not see a bucket (Items.bucket).

 

Any ideas on how I can capture this bucket so I can get rid of it?

Link to comment
Share on other sites

I have discovered a potential answer to this solution. I simply added ".setContainItem(null)" to the "Items.water_bucket" in my crafting recipe. The final code would looks like this (Note, this is just an example:

 

GameRegistry.addShapelessRecipe(
    new ItemStack( myItem ),
    new Object[] {
         Items.ender_pearl,
         Items.water_bucket.setContainerItem(null)}
);

 

Hopefully this helps someone in the future.

Link to comment
Share on other sites

  • 2 months later...
  • 1 year later...

guys found a pretty easy way

Item lavaNoContainer = Items.lava_bucket;
lavaNoContainer.setContainerItem(null);

Item waterNoContainer = Items.water_bucket;
waterNoContainer.setContainerItem(null);

 

Then use these to items to craft your stuff. This worked for me and shouldn't break other mods. The weird thing is that it worked without registering which is really great

Currently developing a mod called Lot'O'Stuff for 1.7.10 (I know very well its outdated.)

Link to comment
Share on other sites

[me=Draco18s]skips the local variable assignment.[/me]

 

Items.lava_bucket.setContainerItem(null);

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Suggestion: Change ur whole approach to brew a potion instead (3 bottles of water plus dust ingredient yields 3 bottles of new mystery fluid). Then you just need a way to convert your potion into a fluid source block when you use it in the world.

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • i tried downloading the drivers but it says no AMD graphics hardware
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
    • It is an issue with quark - update it to this build: https://www.curseforge.com/minecraft/mc-mods/quark/files/3642325
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.