Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.7.10] Why does this explosion not damage the player / terrain?


Roymond
 Share

Recommended Posts

Hey Modders,

 

I'm testing an idea of an ultra sensitive block that has to be harvested with silk touch else it will explode upon being harvested. For this, I created an event handler which subscribed to the harvest drop event and checks to see if the block was harvested with silk touch and if it isn't, it creates an explosion (Code below)

 

@SubscribeEvent
public void explosion(BlockEvent.HarvestDropsEvent event){

	if(event.block == Blocks.grass || event.block == Blocks.dirt){
		if(event.isSilkTouching == false){
			event.world.createExplosion(event.harvester, event.harvester.posX, event.harvester.posY, event.harvester.posZ, 10, false);
		}
	}
}

 

However, when I load up a newly generated world, I am able to mine up the block, and able to see the explosion but the terrain and the player are unaffected. Could you guys please tell me what I am missing? I've taken a look at the Creeper code as well as the TNT code and it looks to be the same (I've even tried throwing in the condition to check and see if the world is remote and it doesn't change anything)

Link to comment
Share on other sites

I'm noticing now that I am getting a pretty consistent crash with a Null Point Exception and after poking at it with a stick, it seems like the EntityPlayer is being set to null before getting passed to the create explosion.

 

Is there a way to make this more stable? I've thought about checking whether or not the event.Harvester is null before going to the create explosion, but is that the best way?

Link to comment
Share on other sites

One follow up question: When I implement the resulting explosion, it destroys the terrain but does not damage the player.

 

Is this because of the fact that I am implementing the create explosion in the event? Here's the updated code:

 

@SubscribeEvent
public void explosion(BlockEvent.BreakEvent event){
	Block block = event.block;
	EntityPlayer player = event.getPlayer();
	World world = event.world;
	int x = event.x;
	int y = event.y;
	int z = event.z;
	int blockMetadata = event.blockMetadata;

	if (!world.isRemote)
        	{       
		if((block == Blocks.grass || block == Blocks.dirt) && EnchantmentHelper.getSilkTouchModifier(player)!=true) {
			world.createExplosion(player, x, y, z, 3, true);

			}
		}
        }

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • [15Aug2022 20:46:23.662] [Render thread/ERROR] [net.minecraft.client.Options/]: Failed to load options java.lang.NullPointerException: Cannot invoke "net.minecraft.client.KeyMapping.m_90865_()" because "keymapping" is null at net.minecraft.client.Options.processOptionsForge(Options.java:897) ~[client-1.19-20220607.102129-srg.jar%23381!/:?] at net.minecraft.client.Options.load(Options.java:973) ~[client-1.19-20220607.102129-srg.jar%23381!/:?] at net.minecraftforge.client.loading.ClientModLoader.lambda$finishModLoading$7(ClientModLoader.java:129) ~[forge-1.19-41.1.0-universal.jar%23386!/:?] This error looks very dubious. It basically says a mod has changed the Options.keyMappings and inserted a null value. If the mod used the correct way to do this, it would be impossible, there would be an error when it tries to do it. Unfortunately, the error does not say which mod causes the problem.
    • You should init the SimpleChannel instance at the end of the register method. No you need to cancel the Event and then send the Packet via the SimpleChannel to the client: // inside your LivingDeathEvent EventHandler event.setCanceled(true); if (event.getEntity() instance ServerPlayer player) { ModMessages.sendToPlayer(new TotemBellotoClientPacket(), player); } This code above is an example which is not tested.
    • The log you post does not contains any error which cause the game to crash. The file is called "debug (2).log" so it could be from a different (not the latest) run of Minecraft. If there is a file called debug.log please post it if there is no debug.log try to run the game again produced the error then. If there is still not debug.log please post launcher_log.txt as well.
    • Do you mean like the "World Type" button in the "Create New World Screen"? e.g. flat, large biomes, etc. It's not something I have looked at in recent versions. But you should look at WorldPreset which has a vanilla registry key in the Registry class you can use for DeferredRegister.   I believe you can also add them with using the datapack mechanism if you only want to resuse vanilla logic. The only thing I can find on the json format (beyond reading the codec) is this? https://misode.github.io/worldgen/world-preset/ 
    • Like this? SimpleMessage -> import net.minecraft.network.FriendlyByteBuf; import net.minecraft.resources.ResourceLocation; import net.minecraft.server.level.ServerPlayer; import net.minecraftforge.network.NetworkDirection; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.PacketDistributor; import net.minecraftforge.network.simple.SimpleChannel; import java.util.function.BiConsumer; public class ModMessages { private static SimpleChannel INSTANCE; private static int packetId = 0; private static int id() { return packetId++; } public static void register() { SimpleChannel net = NetworkRegistry.ChannelBuilder .named(new ResourceLocation(Belloto.MOD_ID, "messages")) .networkProtocolVersion(() -> "1.0") .clientAcceptedVersions(s -> true) .serverAcceptedVersions(s -> true) .simpleChannel(); INSTANCE = net; net.messageBuilder(TotemBellotoPacket.class, id(), NetworkDirection.PLAY_TO_SERVER) .decoder(TotemBellotoPacket::new) .encoder(TotemBellotoPacket::toBytes) .consumer(TotemBellotoPacket::handle) .add(); net.messageBuilder(TotemBellotoClientPacket.class, id(), NetworkDirection.PLAY_TO_CLIENT) .decoder(TotemBellotoClientPacket::new) .encoder(TotemBellotoClientPacket::toBytes) .consumer(TotemBellotoClientPacket::handle) .add(); } public static <MSG> void sendToServer(MSG message) { INSTANCE.sendToServer(message); } public static <MSG> void sendToPlayer(MSG message, ServerPlayer player) { INSTANCE.send(PacketDistributor.PLAYER.with(() -> player), message); } } TotemClientPacket-> package com.naim.belloto.networking.packet; import com.naim.belloto.Init.ItemInit; import com.naim.belloto.networking.handler.ClientPacketHandlerClass; import net.minecraft.client.Minecraft; import net.minecraft.client.multiplayer.ClientLevel; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.sounds.SoundEvents; import net.minecraft.sounds.SoundSource; import net.minecraft.world.entity.player.Player; import net.minecraft.world.item.ItemStack; import net.minecraftforge.api.distmarker.Dist; import net.minecraftforge.fml.DistExecutor; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; import java.util.logging.Level; public class TotemBellotoClientPacket { public TotemBellotoClientPacket() { } public TotemBellotoClientPacket(FriendlyByteBuf buf) { } public void toBytes(FriendlyByteBuf buf) { } public boolean handle(Supplier<NetworkEvent.Context> ctx) { NetworkEvent.Context context = ctx.get(); context.enqueueWork(() -> { // Client DistExecutor.unsafeCallWhenOn(Dist.CLIENT,() -> () -> ClientPacketHandlerClass.handlePacket(ctx)); }); return true; } } And the handler like u say package com.naim.belloto.networking.handler; import com.naim.belloto.Init.ItemInit; import net.minecraft.client.Minecraft; import net.minecraft.client.multiplayer.ClientLevel; import net.minecraft.world.entity.player.Player; import net.minecraft.world.item.ItemStack; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class ClientPacketHandlerClass { public static boolean handlePacket(Supplier<NetworkEvent.Context> ctx) { Player player = Minecraft.getInstance().player; ClientLevel level = Minecraft.getInstance().level; Minecraft.getInstance().gameRenderer.displayItemActivation(new ItemStack(ItemInit.TOTEM_BELLOTO.get())); //level.playSound(null, player.getOnPos(), SoundEvents.TOTEM_USE, SoundSource.PLAYERS, 0.5F, level.random.nextFloat() *0.1F + 0.9F); return true; } } And u said to me i need to cancel LivingDeathEvent via my simpleChannel, but i need to put it in a packet? or what, im lerning about Networking im really confuse. can u give me an example or pseudocode pls 
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.