[1.7.10] Adding a potion effect to armor

[untamemadman 0]

How do I add a potion effect to armor in 1.7.10

I found a tutorial for 1.7.2 that said I just have to add:

 

    @Override

    public void onArmorTick(World world, EntityPlayer player, ItemStack armor)

    {

        player.addPotionEffect(new PotionEffect(Potion.nightVision.id, 500, 1, true));

    }

 

to my Armor code but it doesn't give the player Night vision when he equip it. any help?

[diesieben07 7609]

That should work, but I am not sure why you are specifying a duration of 500 ticks.

Also you should probably only add the effect on the server side not the client.

[untamemadman 0]

Would it be better to only have it for maybe 10 ticks and it will refresh?

Also just checking, I do make it server side using    @SideOnly(Server)?

[diesieben07 7609]

onArmorTick is called every tick so even a duration of just 2 ticks would be enough.

And you should read this about @SideOnly: http://www.minecraftforge.net/forum/index.php/topic,22764.0.html

[untamemadman 0]

I made it server side and changed the tick time but it still doesn't work.

here is my code: http://goo.gl/XNE7vO

[diesieben07 7609]

You either did not read or did not understand the tutorial I posted. The title already tells you your mistake.

[untamemadman 0]

You either did not read or did not understand the tutorial I posted. The title already tells you your mistake.

 

I understand the difference between Server and Client, but I don't understand what you mean by the alternatives

[diesieben07 7609]

Read the title of the tutorial. Do not use @SideOnly. It does not do what you think it does. Read the tutorial to learn what it actually does.

[untamemadman 0]

Ok, say I don't use @SideOnly. Why won't my code work still

[diesieben07 7609]

Because you are adding it on the client side as well. Only add the potion effect on the server.

[untamemadman 0]

And how would I do that without using "@SideOnly", because your tutorial isn't clear on that

[daafganggdg 3]

u can simply check with world.isRemote

[diesieben07 7609]

And how would I do that without using "@SideOnly", because your tutorial isn't clear on that

Yes, it is clear. There's a section about what to use instead.

[untamemadman 0]

And how would I do that without using "@SideOnly", because your tutorial isn't clear on that

Yes, it is clear. There's a section about what to use instead.

 

Well I was confused by it.

[untamemadman 0]

I have this now:

 

    @Override

    public void onArmorTick(World world, EntityPlayer player, ItemStack armor)

    {

        if(world.isRemote == true)

        {

            player.addPotionEffect(new PotionEffect(Potion.nightVision.id, 2, 1, true));

        }

    }

 

Can you tell me if that is done correctly?

[diesieben07 7609]

You didn't understand the meaning of .isRemote. If it's false, you are on the server. If it's true, you are on the client.

Also doing if (x == true) is redundant. if (x) is the same.

[untamemadman 0]

So how should I do it?

[diesieben07 7609]

Check for the server, not the client.

[untamemadman 0]

Check for the server, not the client.

 

So "if(world.isRemote = false)"

[Eternaldoom 110]

if(!world.isRemote)

[untamemadman 0]

if(!world.isRemote)

 

My code is:

 

    @Override

    public void onArmorTick(World world, EntityPlayer player, ItemStack armor)

    {

        if(!world.isRemote)

        {

            player.addPotionEffect(new PotionEffect(Potion.nightVision.id, 2, 1, true));

        }

    }

 

But the player still doesn't get night vision

[diesieben07 7609]

So "if(world.isRemote = false)"

*facedesk*

Please, for the love of god, learn basic java before modding. Thank you.

 

Add a breakpoint in your method and check if it's actually being called.

[Eternaldoom 110]

I use a PlayerTickEvent for armor bonuses. Maybe try that?

[untamemadman 0]

Can someone just give me a chunk of code that will give the user of a peace of armor Night Vision

[diesieben07 7609]

You already have the right code. The cause must be somewhere else. As I said, please use a breakpoint to determine if the method is actually getting called.