Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

DamageSource.getEntity() and DamageSource.getSourceOfDamage() return the same?


Goz3rr
 Share

Recommended Posts

I've read the sticky, but a console log doesn't really seem needed here.

 

I'm using MC1.3.2, Forge 4.1.4.272 and FML 3.1.15.378

 

To reproduce this:

Make a class subscribed to LivingDropsEvent, run this code on that event:

	ModLoader.getMinecraftInstance().thePlayer.addChatMessage(event.source.getSourceOfDamage().getClass().toString());		
	ModLoader.getMinecraftInstance().thePlayer.addChatMessage(event.source.getEntity().getClass().toString());	

 

Kill an animal, chat will show "class net.minecraft.src.EntityPlayerMP" twice, which is the player. Shouldn't getEntity() return the entity that died?

 

The wiki says:

Calling source.getEntity() will return an Entity if the damage source is an entity or null otherwise.

 

And when looking at DamageSource.java:

    public Entity getSourceOfDamage()
    {
        return this.getEntity();
    }

    public Entity getEntity()
    {
        return null;
    }

 

what.

Link to comment
Share on other sites

EntityDamageSource

Basic vanilla functionality.

^ this

 

Also there is a difference between those two methods, but only in certain DamageSource instances. For example the damage source from an arrow returns the arrow entity itself with getSourceOfDamage() and the entity which shot that arrow (e.g. the player) with getEntity(), or the arrow itself again if the shooting entity instance is null.

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.