Jump to content

[1.7.10] Give player random items


Bugzoo

Recommended Posts

You should double the list if you need it twice.

 

Random rand = new Random();

for(int m = 0; m < 6; m++)
{
          int r = rand.nextInt(YOURLIST.size() - 1);
          ItemStack stack = YOURLIST.get(r);
          player.inventory.addItemStackToInventory(stack);

   //if you want not 2 times the same one
          YOURLIST.remove(r); 
}

Link to comment
Share on other sites

You should double the list if you need it twice.

 

Random rand = new Random();

for(int m = 0; m < 6; m++)
{
          int r = rand.nextInt(YOURLIST.size() - 1);
          ItemStack stack = YOURLIST.get(r);
          player.inventory.addItemStackToInventory(stack);

   //if you want not 2 times the same one
          YOURLIST.remove(r); 
}

 

MyList.get and MyList.remove dont work

Link to comment
Share on other sites

With a Array I don't know how to delete, but you get it in this way.

 

Random rand = new Random();

for(int m = 0; m < 6; m++)
{
          int r = rand.nextInt(YOURLIST.size() - 1);
          ItemStack stack = YOURLIST[r];
          player.inventory.addItemStackToInventory(stack);
}

 

I would use a ArrayList in your situation.

Link to comment
Share on other sites

With a Array I don't know how to delete, but you get it in this way.

 

Random rand = new Random();

for(int m = 0; m < 6; m++)
{
          int r = rand.nextInt(YOURLIST.size() - 1);
          ItemStack stack = YOURLIST[r];
          player.inventory.addItemStackToInventory(stack);
}

 

I would use a ArrayList in your situation.

 

That doesnt seem to be giving me any items at all

Link to comment
Share on other sites

In this case I need your full code

 

package com.bugzoo.Lootcube;

import java.util.Random;

import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.world.World;

public class ItemPokepack extends Item{
public ItemPokepack(){
	setMaxStackSize(1);
	setUnlocalizedName("pokePack");
}

@Override
public ItemStack onItemRightClick(ItemStack itemStack, World world, EntityPlayer player){
	Random rand = new Random();

	for(int m = 0; m < 6; m++)
	{
	          int r = rand.nextInt(Lootcube.pokelist.length - 1);
	          ItemStack stack = Lootcube.pokelist[r];
	          player.inventory.addItemStackToInventory(stack);
	}
	return itemStack;
}


}

 

MyList:

public static ItemStack[] pokelist = {new ItemStack(Cascoon), new ItemStack(Silcoon), new ItemStack(Purugly), new ItemStack(Gothita), new ItemStack(Watchog), new ItemStack(Dunsparce), new ItemStack(Sunkern), new ItemStack(Wormadam), new ItemStack(Patrat), new ItemStack(Luvdisk), new ItemStack(Mewtwo), new ItemStack(Charizard), new ItemStack(Arceus), new ItemStack(Lugia), new ItemStack(Slaking), new ItemStack(Dragonite), new ItemStack(Mew)};
   

Link to comment
Share on other sites

Store Item links (Mymod.someitem etc.) in your array. NOT ItemStacks. Create new ItemStacks from items in your loop.

Still doesnt give me any items

ItemClass:

package com.bugzoo.Lootcube;

import java.util.List;
import java.util.Random;

import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;

import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.world.World;

public class ItemPokepack extends Item{
public ItemPokepack(){
	setMaxStackSize(1);
	setUnlocalizedName("pokePack");
}

public Item stack;

@Override
public ItemStack onItemRightClick(ItemStack itemStack, World world, EntityPlayer player){
	Random rand = new Random();

	for(int m = 0; m < 6; m++)
	{
	          int r = rand.nextInt(Lootcube.pokelist.length - 1);
	          stack = Lootcube.pokelist[r];
	          player.inventory.addItemStackToInventory(new ItemStack(stack));
	          player.inventory.consumeInventoryItem(this);
	}
	return new ItemStack(stack);
}

@SideOnly(Side.CLIENT)
@Override
public void addInformation(ItemStack itemstack, EntityPlayer player, List dataList, boolean b){
	dataList.add("Pack Of Random Pokemon Cards");
}
}

List:

public static Item[] pokelist = {Cascoon, Silcoon, Purugly, Gothita, Watchog, Dunsparce};

Link to comment
Share on other sites

You IDE is not giving you an error message about this nonsense:

public static Item[] pokelist = {Cascoon, Silcoon, Purugly, Gothita, Watchog, Dunsparce};

Class names are not items. Do you even read error messages? On the other hand, many new coders name instances with initial cap... either is very wrong.

Link to comment
Share on other sites

public Item stack;

 

@Override

public ItemStack onItemRightClick(ItemStack itemStack, World world, EntityPlayer player){

Random rand = new Random(); //itemRand

 

for(int m = 0; m < 6; m++) //you said 5

{

          int r = rand.nextInt(Lootcube.pokelist.length - 1); //nextInt counts from 0

                          stack = Lootcube.pokelist[r];

          player.inventory.addItemStackToInventory(new ItemStack(stack));

          player.inventory.consumeInventoryItem(this);

                          itemStack.stackSize--;

 

}

 

return new ItemStack(stack); //why?

                return itemStack;

 

}

 

 

 

 

    public static Item[] pokelist = {Items.apple, Items.carrot, Items.potato, Items.slime_ball, Items.arrow, Items.beef, Items.shears};

 

    @Override

    public ItemStack onItemRightClick(ItemStack itemStack, World world, EntityPlayer player){

        if(world.isRemote)return itemStack; //because ghost items

 

        List<Item> tempList = new ArrayList<Item>();

        tempList.addAll(Arrays.asList(pokelist)); //because remove() causes UnsupportedOperationException

 

        for(int m = 0; m < 5; m++)

        {

            player.inventory.addItemStackToInventory(new ItemStack(tempList.remove(itemRand.nextInt(tempList.size())))); //because science

            itemStack.stackSize--;

        }

        return itemStack;

    }

 

Link to comment
Share on other sites

public Item stack;

 

@Override

public ItemStack onItemRightClick(ItemStack itemStack, World world, EntityPlayer player){

Random rand = new Random(); //itemRand

 

for(int m = 0; m < 6; m++) //you said 5

{

          int r = rand.nextInt(Lootcube.pokelist.length - 1); //nextInt counts from 0

                          stack = Lootcube.pokelist[r];

          player.inventory.addItemStackToInventory(new ItemStack(stack));

          player.inventory.consumeInventoryItem(this);

                          itemStack.stackSize--;

 

}

 

return new ItemStack(stack); //why?

                return itemStack;

 

}

 

 

 

 

    public static Item[] pokelist = {Items.apple, Items.carrot, Items.potato, Items.slime_ball, Items.arrow, Items.beef, Items.shears};

 

    @Override

    public ItemStack onItemRightClick(ItemStack itemStack, World world, EntityPlayer player){

        if(world.isRemote)return itemStack; //because ghost items

 

        List<Item> tempList = new ArrayList<Item>();

        tempList.addAll(Arrays.asList(pokelist)); //because remove() causes UnsupportedOperationException

 

        for(int m = 0; m < 5; m++)

        {

            player.inventory.addItemStackToInventory(new ItemStack(tempList.remove(itemRand.nextInt(tempList.size())))); //because science

            itemStack.stackSize--;

        }

        return itemStack;

    }

I'm still not getting any items when I right click

Link to comment
Share on other sites

I'd just use this:

    
Random rand = new Random();
        ItemStack[] itemstack = new ItemStack[20];
        itemstack[0] = new ItemStack(Items.apple, 2);
        itemstack[1] = new ItemStack(Items.bread, 34);
        //...
        for(int i = 0; i < 5; i++) {
        	player.inventory.addItemStackToInventory(itemstack[rand.nextInt(20)]);
        }

Link to comment
Share on other sites

I'd just use this:

    
Random rand = new Random();
        ItemStack[] itemstack = new ItemStack[20];
        itemstack[0] = new ItemStack(Items.apple, 2);
        itemstack[1] = new ItemStack(Items.bread, 34);
        //...
        for(int i = 0; i < 5; i++) {
        	player.inventory.addItemStackToInventory(itemstack[rand.nextInt(20)]);
        }

Thank you, this works. I dont know how I didnt think of that earlier. But im having a problem where sometimes it gives me 3 items, sometimes 4 and sometimes 5

Link to comment
Share on other sites

I'd just use this:

    
Random rand = new Random();
        ItemStack[] itemstack = new ItemStack[20];
        itemstack[0] = new ItemStack(Items.apple, 2);
        itemstack[1] = new ItemStack(Items.bread, 34);
        //...
        for(int i = 0; i < 5; i++) {
        	player.inventory.addItemStackToInventory(itemstack[rand.nextInt(20)]);
        }

Thank you, this works. I dont know how I didnt think of that earlier. But im having a problem where sometimes it gives me 3 items, sometimes 4 and sometimes 5

 

uhhm, U have to put itemstack[2] = new ItemStack(theItemYouWant, TheAmountUWant);

and so on ofc into there too (up too 19).

If you have already done that and its still not working show your code. And if its adding e.g. 5 eggs 3 eggs u dont get 5 and 3 eggs but 8 in one stack ofc. And I dont know if you want to deny the chance of an ItemStack beeing added twice, if so u have to put in a check for that.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Minecraft Version: 1.8-1.20.X Forge Version: All (Tested on 49.0.27, 11.14.4.1577 and some others) Steps to Reproduce: Setup a server with IPV6 only Setup a docker container with forge Try to connect to the Forge Server Description of issue: Hello, I am reaching out to seek your expertise within this forum to clarify a technical situation I am encountering, suspecting a potential issue related to Forge in a Docker environment, specifically in an IPv6 context. Initial Configuration: Debian 12 server, configured exclusively for IPv6, with Docker installed. Using the Docker image ghcr.io/pterodactyl/yolks:java_17, launching a Minecraft Vanilla server version 1.20.4 proceeds without any issues. Problem: The issue arises when deploying a Minecraft Forge server version 1.20.4 with the same Docker image (ghcr.io/pterodactyl/yolks:java_17), where connecting to the server becomes impossible. Notably, this issue does not occur when launching outside of Docker, where the server functions as expected. Hypothesis: This situation leads me to question the interaction between Forge and Docker, particularly in an IPv6-only configuration, despite several resolution attempts (testing with different versions of Forge, adjusting container network configurations (0.0.0.0, ::/0, and the server's ipv6), trials with various network settings, and modifications of Java options). Further testing was conducted with and without the use of the Pterodactyl game panel, unsuccessfully. The parameter -Djava.net.preferIPv4Stack=false also did not provide a solution. I tried to do the same things on multiple Minecraft server (include vanilla,spigot,fabric,sponge) and this work fine. The problem only happend with Forge. This issue seem to happend on all forge versions.   I appreciate your time and assistance in advance.
    • The game crashed whilst exception ticking world Error: java.lang.NullPointerException: Cannot invoke "net.minecraft.resources.ResourceLocation.equals(Object)" because "this.lootTableId" is null Error given is above. I was already playing for around 15 minutes and wasn't doing anything specific or even breaking anything when the crashed happened. This is update 1.19.2 forge: 43.2.23 Mod list: ESSENTIAL Mod (by SparkUniverse_) Traveler's Titles (Forge) (by YUNGNICKYOUNG) Resourceful Config (by ThatGravyBoat) Dynamic Lights (by atomicstrykergrumpy) TenzinLib (by CommodoreThrawn) Nature's Compass (by Chaosyr) Library Ferret - Forge (by jtl_elisa) Cold Sweat (by Mikul) Simple Voice Chat (by henkelmax) Waystones (by BlayTheNinth) Carry On (by Tschipp) [Let's Do] Meadow (by satisfy) Creeper Overhaul (by joosh_7889) AutoRegLib (by Vazkii) Moonlight Lib (by MehVahdJukaar) AppleSkin (by squeek502) Xaero's World Map (by xaero96) Rotten Creatures (by fusionstudiomc) YUNG's API (Forge) (by YUNGNICKYOUNG) Village Artifacts (by Lothrazar) Right Click, Get Crops (by TeamCoFH) Supplementaries (by MehVahdJukaar) Automatic Tool Swap (by MelanX) Better Third Person (by Socolio) Supplementaries Squared (by plantspookable) Traveler's Backpack (by Tiviacz1337) Caelus API (Forge/NeoForge) (by TheIllusiveC4) Creatures and Beasts (by joosh_7889) Architectury API (Fabric/Forge/NeoForge) (by shedaniel) Quark Oddities (by Vazkii) Origins (Forge) (by EdwinMindcraft) Villager Names (by Serilum) GeckoLib (by Gecko) Realistic Bees (by Serilum) Illuminations Forge 🔥 (by dimadencep) Serene Seasons (by TheAdubbz) Critters and Companions (by joosh_7889) [Let's Do] Bakery (by satisfy) Falling Leaves (Forge) (by Cheaterpaul) Jade 🔍 (by Snownee) Collective (by Serilum) TerraBlender (Forge) (by TheAdubbz) [Let's Do] API (by Cristelknight) Towns and Towers (by Biban_Auriu) More Villagers (by SameDifferent) Biomes O' Plenty (by Forstride) Goblin Traders (by MrCrayfish) Corpse (by henkelmax) Tree Harvester (by Serilum) Balm (Forge Edition) (by BlayTheNinth) Mouse Tweaks (by YaLTeR) Sound Physics Remastered (by henkelmax) Xaero's Minimap (by xaero96) Just Enough Items (JEI) (by mezz) Terralith (by Starmute) Quark (by Vazkii) [Let's Do] Vinery (by satisfy) [Let's Do] Candlelight (by satisfy) Repurposed Structures (Neoforge/Forge) (by telepathicgrunt) Dusty Decorations (by flint_mischiff) Immersive Armors [Fabric/Forge] (by Conczin) Serene Seasons Fix (by Or_OS) Shutup Experimental Settings! (by Corgi_Taco) Skin Layers 3D (Fabric/Forge) (by tr7zw)
    • Make sure Java is running via Nvidia GPU https://windowsreport.com/minecraft-not-using-gpu/  
    • Also make a test with other Custom Launchers like AT Launcher, MultiMC or Technic Launcher
    • Embeddium and valkyrienskies are not working together - remove one of these mods With removing Embeddium, also remove Oculus, TexTrue's Embeddium Options and Embeddium Extras Or use Rubidium instead
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.