Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

Biome Dictionary, inconsistency in default registrations


keybounce
 Share

Recommended Posts

BiomeDictionary.java has the following registration:

        registerBiomeType(extremeHills,        MOUNTAIN, HILLS                              );

 

In MakeBestGuess(), Hills and Mountain are exclusive; all the other extreme hills variants are either hills or mountains.

 

Equally, Extreme Hills + (162) and Extreme Hills M (131) are marked as hills, not mountains.

 

===

 

MakeBestGuess() is using a comparison of height variation against 1.5F. This value being tested used to be the max height (in 164 and earlier); none of the vanilla biomes have a height variation that large in 1.7. Even the savannah variants at 163/164 don't hit that, and they are the largest in vanilla 1.7. I think this test is definitely bugged.

 

Jeb! The sheep! The fence pens, they do nothing still leak!

Link to comment
Share on other sites

  • 1 month later...

Additional flaws:

 

1. Ice Mountains, despite the name, has the same base height 0.45 and variation 0.3 as all the hills. It should have the hills tag, not the mountains (it is not in the same category with extreme hills).

2. Mesa Plateau F M and Mesa Plateau M also have the same 0.45 and 0.3. Yet "FM" has no height tag, and "M" has the "plains" tag. (biomes 166 and 167)

3. "Savanna Plateau M" has the biggest heights in the game -- base 1.05, variation 1.2125, can get really high, yet is only "hills" -- that's like calling the Himalayas "hills".

 

Jeb! The sheep! The fence pens, they do nothing still leak!

Link to comment
Share on other sites

Where can I find instructions on submitting a pull request to forge?

 

(I'm serious: I don't know how to fetch the source, compile it, test it, make changes, and then get those changes sent back to you. What little I understand is that forge is not quite the same as normal mods and has a different behavior, and I have enough trouble getting a github pull request for mods I play around with a lot.)

Jeb! The sheep! The fence pens, they do nothing still leak!

Link to comment
Share on other sites

Where can I find instructions on submitting a pull request to forge?

 

(I'm serious: I don't know how to fetch the source, compile it, test it, make changes, and then get those changes sent back to you. What little I understand is that forge is not quite the same as normal mods and has a different behavior, and I have enough trouble getting a github pull request for mods I play around with a lot.)

 

Goto https://github.com/MinecraftForge/MinecraftForge and read the

For Contributors

part of the readme.txt

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Hello there! I am playing with a collection of mods on a server. One of those mods is Ice and Fire. When I attempt to mount a dragon, I repeatedly crash for some sort of rendering error, until I kill the dragon using the console. In my experience the mod seems to work well on it's own, including the dragon riding. Can anyone decipher what is causing it to crash? Is it conflicting with something, perhaps? https://paste.gg/p/anonymous/52973aea80f74c3797353f1d97ef95ae Thanks!
    • Failed to run processor: javax.net.ssl.SSLHandshakeException:sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
    • I want to play Hypixel Skyblock and my friend told me a bunch of mods I should use, but when I went to install 1.8.9 forge to install said mods it would say that the installation has completed succesfully but it wouldn't be in the launcher, please help - btw I am using the official launcher  edit: nvm I saw that 1.8.9 isn't supported on the forums  
    • I found out that my modpack didn't have the textures file so I transferred it over and it's still giving me the same error but the den file is raid_den.png and its wants a raid.den.pqc
    • I was add NPC's and shop items and after i finished changing them and having the .json files checked for errors (said all files that were edited were good) but when I launch the game it give me this error. Caused by: java.io.FileNotFoundException: pixelmon:models/blocks/den/raid_den.pqc       ---- Minecraft Crash Report ---- // I bet Cylons wouldn't have this problem. Time: 1/16/22 2:42 AM Description: Initializing game java.lang.RuntimeException: java.io.FileNotFoundException: pixelmon:models/blocks/den/raid_den.pqc     at com.pixelmonmod.pixelmon.client.ClientProxy.getStreamForResourceLocation(ClientProxy.java:844)     at com.pixelmonmod.pixelmon.client.models.smd.ValveStudioModel.loadQC(ValveStudioModel.java:223)     at com.pixelmonmod.pixelmon.client.models.smd.ValveStudioModel.<init>(ValveStudioModel.java:66)     at com.pixelmonmod.pixelmon.client.models.smd.ValveStudioModelLoader.loadModel(ValveStudioModelLoader.java:53)     at com.pixelmonmod.pixelmon.client.models.blocks.GenericSmdModel.reloadModel(GenericSmdModel.java:39)     at com.pixelmonmod.pixelmon.client.models.blocks.GenericSmdModel.<init>(GenericSmdModel.java:25)     at com.pixelmonmod.pixelmon.client.render.GenericModelHolder.loadModel(GenericModelHolder.java:61)     at com.pixelmonmod.pixelmon.client.models.ModelHolder.getModel(ModelHolder.java:27)     at com.pixelmonmod.pixelmon.client.render.RenderDen.<init>(RenderDen.java:38)     at net.minecraftforge.fml.client.registry.RenderingRegistry.register(RenderingRegistry.java:77)     at net.minecraftforge.fml.client.registry.RenderingRegistry.loadEntityRenderers(RenderingRegistry.java:70)     at net.minecraft.client.renderer.entity.RenderManager.<init>(RenderManager.java:230)     at net.minecraft.client.Minecraft.func_71384_a(Minecraft.java:518)     at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:378)     at net.minecraft.client.main.Main.main(SourceFile:123)     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)     at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)     at java.lang.reflect.Method.invoke(Method.java:498)     at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)     at net.minecraft.launchwrapper.Launch.main(Launch.java:28) Caused by: java.io.FileNotFoundException: pixelmon:models/blocks/den/raid_den.pqc     at net.minecraft.client.resources.FallbackResourceManager.func_110536_a(FallbackResourceManager.java:69)     at net.minecraft.client.resources.SimpleReloadableResourceManager.func_110536_a(SimpleReloadableResourceManager.java:65)     at com.pixelmonmod.pixelmon.client.ClientProxy.getStreamForResourceLocation(ClientProxy.java:842)     ... 20 more A detailed walkthrough of the error, its code path and all known details is as follows: --------------------------------------------------------------------------------------- -- Head -- Thread: Client thread Stacktrace:     at com.pixelmonmod.pixelmon.client.ClientProxy.getStreamForResourceLocation(ClientProxy.java:844)     at com.pixelmonmod.pixelmon.client.models.smd.ValveStudioModel.loadQC(ValveStudioModel.java:223)     at com.pixelmonmod.pixelmon.client.models.smd.ValveStudioModel.<init>(ValveStudioModel.java:66)     at com.pixelmonmod.pixelmon.client.models.smd.ValveStudioModelLoader.loadModel(ValveStudioModelLoader.java:53)     at com.pixelmonmod.pixelmon.client.models.blocks.GenericSmdModel.reloadModel(GenericSmdModel.java:39)     at com.pixelmonmod.pixelmon.client.models.blocks.GenericSmdModel.<init>(GenericSmdModel.java:25)     at com.pixelmonmod.pixelmon.client.render.GenericModelHolder.loadModel(GenericModelHolder.java:61)     at com.pixelmonmod.pixelmon.client.models.ModelHolder.getModel(ModelHolder.java:27)     at com.pixelmonmod.pixelmon.client.render.RenderDen.<init>(RenderDen.java:38)     at net.minecraftforge.fml.client.registry.RenderingRegistry.register(RenderingRegistry.java:77)     at net.minecraftforge.fml.client.registry.RenderingRegistry.loadEntityRenderers(RenderingRegistry.java:70)     at net.minecraft.client.renderer.entity.RenderManager.<init>(RenderManager.java:230)     at net.minecraft.client.Minecraft.func_71384_a(Minecraft.java:518) -- Initialization -- Details: Stacktrace:     at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:378)     at net.minecraft.client.main.Main.main(SourceFile:123)     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)     at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)     at java.lang.reflect.Method.invoke(Method.java:498)     at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)     at net.minecraft.launchwrapper.Launch.main(Launch.java:28)  
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.