Jump to content

IExtendedEntityProperties not saving after death


starwarsmace

Recommended Posts

Hello people. For my mod I made an extended properties for a player and I store my properties in my common proxy for the players death.(Following CoolAlias's tutorial: http://www.minecraftforum.net/forums/mapping-and-modding/mapping-and-modding-tutorials/1571567-1-7-2-1-6-4-eventhandler-and ). But when the player does die and respawn it doesnt work.

 

Extended Player Class:

public class ExtendedPlayer implements IExtendedEntityProperties {

public final static String EXT_PROP_NAME = "ExtendedPlayer";
private final EntityPlayer player;
private int gold;
private int elixer;
private int gold_storage;
private int elixer_storage;
private boolean flag;

public ExtendedPlayer(EntityPlayer player)
{
this.player = player;
this.elixer=0;
this.gold=0;
this.gold_storage=0;
this.elixer_storage=0;
this.flag=false;
}
@Override
public void init(Entity entity, World world) {

}
@Override
public void saveNBTData(NBTTagCompound properties) {
	NBTTagCompound compound = new NBTTagCompound(); 
	compound.setInteger("Elixer",this.elixer);
	compound.setInteger("Gold", this.gold);
	compound.setInteger("Gold_Storage", this.gold_storage);
	compound.setInteger("Elixer_Storage", this.elixer_storage);
	compound.setBoolean("Flag", this.flag);

	compound.setTag(EXT_PROP_NAME, compound);
}

@Override
public void loadNBTData(NBTTagCompound properties) {
	NBTTagCompound compound = (NBTTagCompound) properties.getCompoundTag(EXT_PROP_NAME);
	this.gold=compound.getInteger("Gold");
	this.elixer=compound.getInteger("Elixer");
	this.gold_storage=compound.getInteger("Gold_Storage");
	this.elixer_storage=compound.getInteger("Elixer_Storage");
	this.flag=compound.getBoolean("Flag");
}
public static final void register(EntityPlayer player)
{
player.registerExtendedProperties(ExtendedPlayer.EXT_PROP_NAME, new ExtendedPlayer(player));
}
public static final ExtendedPlayer get(EntityPlayer player)
{
	return (ExtendedPlayer) player.getExtendedProperties(EXT_PROP_NAME);
}



public void changeResources(int id,int change){
	if (id==0){
		this.elixer=elixer+change;
	}
	if(id==1){
		this.gold=gold+change;
	}
}
public void changeStorage(int id,int change){
	if (id==0){
		this.elixer_storage=change;
	}
	if(id==1){
		this.gold_storage=change;
	}
}
public int getResources(int id){
	int resource = 0;
	if (id==0){
		resource=this.elixer;
	}
	if(id==1){
		resource=this.gold;
	}
	return resource;
}
public int getStorage(int id){
	int resource=0;
	if (id==0){
		resource=this.elixer_storage;
	}
	if(id==1){
		resource=this.gold_storage;
	}
	return resource;
}
public void changeFlag(boolean par1){
	this.flag=par1;
}
public boolean getFlag(){
	return this.flag;
}
private static final String getSaveKey(EntityPlayer player) {
	// no longer a username field, so use the command sender name instead:
	return player.getCommandSenderName() + ":" + EXT_PROP_NAME;
}
public static void saveProxyData(EntityPlayer player) {
	ExtendedPlayer playerData = ExtendedPlayer.get(player);
	NBTTagCompound savedData = new NBTTagCompound();

	playerData.saveNBTData(savedData);
	// Note that we made the CommonProxy method storeEntityData static,
	// so now we don't need an instance of CommonProxy to use it! Great!
	CommonProxyCoc.storeEntityData(getSaveKey(player), savedData);
}

	/**
	* This cleans up the onEntityJoinWorld event by replacing most of the code
	* with a single line: ExtendedPlayer.loadProxyData((EntityPlayer) event.entity));
	*/
	public static void loadProxyData(EntityPlayer player) {
	ExtendedPlayer playerData = ExtendedPlayer.get(player);
	NBTTagCompound savedData = CommonProxyCoc.getEntityData(getSaveKey(player));

	if(savedData != null) {
		playerData.loadNBTData(savedData);
	}

	ClashOfCraft.packetPipeline.sendTo(new SyncPlayerPropsPacket(player), (EntityPlayerMP) player);
}

}

 

EventHandler:

 

public class RegularEventHandler {
//	public boolean collect;
//	public EntityPlayer player;
@SubscribeEvent
public void onEntityConstructing(EntityConstructing event){
	if (event.entity instanceof EntityPlayer && ExtendedPlayer.get((EntityPlayer) event.entity) == null){
		ExtendedPlayer.register((EntityPlayer) event.entity);
	}
}
@SubscribeEvent
public void onLivingDeathEvent(LivingDeathEvent event){

	if (!event.entity.worldObj.isRemote && event.entity instanceof EntityPlayer){
		ExtendedPlayer.saveProxyData((EntityPlayer) event.entity);

	}
}

// we already have this event, but we need to modify it some
@SubscribeEvent
public void onEntityJoinWorld(EntityJoinWorldEvent event){
	if (!event.entity.worldObj.isRemote && event.entity instanceof EntityPlayer){
		ExtendedPlayer.loadProxyData((EntityPlayer)	 event.entity);
		ClashOfCraft.packetPipeline.sendTo(new SyncPlayerPropsPacket(), (EntityPlayerMP) event.entity);
	}
}

 

CommonProxy:

 

public class CommonProxyCoc implements IGuiHandler{
private static final Map<String, NBTTagCompound> extendedEntityData = new HashMap<String, NBTTagCompound>();
public void registerRenderers() {

}
public static void storeEntityData(String name, NBTTagCompound compound) {
	extendedEntityData.put(name, compound);
}

	/**
	 */
public static NBTTagCompound getEntityData(String name) {
	return extendedEntityData.remove(name);
}
	@Override
	public Object getServerGuiElement(int ID, EntityPlayer player,World world, int x, int y, int z) {
		return null;
	}
	@Override
	public Object getClientGuiElement(int ID, EntityPlayer player,World world, int x, int y, int z) {
		if(ID==GuiBasic.GUI_ID){
			EntityGoldMine mine =new EntityGoldMine(world);
			GuiBasic gui=new GuiBasic((EntityGoldMine) world.getEntityByID(x));
			return gui;
		}else{
			return null;
		}

	}

}


 

I'm back from being gone for... I think its been about a year. I'm pretty sure nobody remembers me, but hello anybody who does!

Link to comment
Share on other sites

Remove all that "saveProxyData" stuff. It is obsolete and not needed anymore.

Subscribe to the

PlayerEvent.Clone

event. In there you have to copy the data from the old player (

event.original

) to the new player (

event.player

). The easiest, but not the most efficient, method would be something like this:

 

void onClone(PlayerEvent.Clone event) {
    NBTTagCompound temp = new NBTTagCompound();
    event.original.getExtendedProperties(<myPropsID>).saveNBTData(temp);
    event.player.getExtendedProperties(<myPropsID>).loadNBTData(temp);
}

 

Unfortanutly that didn't work. Should I try saving it with the saveNBTData in my extended player class?

I'm back from being gone for... I think its been about a year. I'm pretty sure nobody remembers me, but hello anybody who does!

Link to comment
Share on other sites

Not sure what you mean. Show your IEEP class and your event handler.

 

Extended Player:

public class ExtendedPlayer implements IExtendedEntityProperties {

public final static String EXT_PROP_NAME = "ExtendedPlayer";
private final EntityPlayer player;
private int gold;
private int elixer;
private int gold_storage;
private int elixer_storage;
private boolean flag;

public ExtendedPlayer(EntityPlayer player)
{
this.player = player;
this.elixer=0;
this.gold=0;
this.gold_storage=0;
this.elixer_storage=0;
this.flag=false;

}
@Override
public void init(Entity entity, World world) {

}
@Override
public void saveNBTData(NBTTagCompound properties) {
	NBTTagCompound compound = new NBTTagCompound(); 
	compound.setInteger("Elixer",this.elixer);
	compound.setInteger("Gold", this.gold);
	compound.setInteger("Gold_Storage", this.gold_storage);
	compound.setInteger("Elixer_Storage", this.elixer_storage);
	compound.setBoolean("Flag", this.flag);

	compound.setTag(EXT_PROP_NAME, compound);
}

@Override
public void loadNBTData(NBTTagCompound properties) {
	NBTTagCompound compound = (NBTTagCompound) properties.getCompoundTag(EXT_PROP_NAME);
	this.gold=compound.getInteger("Gold");
	this.elixer=compound.getInteger("Elixer");
	this.gold_storage=compound.getInteger("Gold_Storage");
	this.elixer_storage=compound.getInteger("Elixer_Storage");
	this.flag=compound.getBoolean("Flag");
}
public static final void register(EntityPlayer player)
{
player.registerExtendedProperties(ExtendedPlayer.EXT_PROP_NAME, new ExtendedPlayer(player));
}
public static final ExtendedPlayer get(EntityPlayer player)
{
	return (ExtendedPlayer) player.getExtendedProperties(EXT_PROP_NAME);
}



public void changeResources(int id,int change){
	if (id==0){
		this.elixer=elixer+change;
	}
	if(id==1){
		this.gold=gold+change;
	}
}
public void changeStorage(int id,int change){
	if (id==0){
		this.elixer_storage=change;
	}
	if(id==1){
		this.gold_storage=change;
	}
}
public int getResources(int id){
	int resource = 0;
	if (id==0){
		resource=this.elixer;
	}
	if(id==1){
		resource=this.gold;
	}
	return resource;
}
public int getStorage(int id){
	int resource=0;
	if (id==0){
		resource=this.elixer_storage;
	}
	if(id==1){
		resource=this.gold_storage;
	}
	return resource;
}
public void changeFlag(boolean par1){
	this.flag=par1;
}
public boolean getFlag(){
	return this.flag;
}

public static void sync(EntityPlayer player) {

	ClashOfCraft.packetPipeline.sendTo(new SyncPlayerPropsPacket(player), (EntityPlayerMP) player);
}

}

 

Event Handler:

 

public class RegularEventHandler {
//	public boolean collect;
//	public EntityPlayer player;
@SubscribeEvent
public void onEntityConstructing(EntityConstructing event){
	if (event.entity instanceof EntityPlayer && ExtendedPlayer.get((EntityPlayer) event.entity) == null){
		ExtendedPlayer.register((EntityPlayer) event.entity);
	}
}
@SubscribeEvent
public void onLivingDeathEvent(LivingDeathEvent event){

}
// we already have this event, but we need to modify it some
@SubscribeEvent
public void onEntityJoinWorld(EntityJoinWorldEvent event){

}
@SubscribeEvent
public void onClone(PlayerEvent.Clone event) {
    NBTTagCompound temp = new NBTTagCompound();
    event.original.getExtendedProperties(ExtendedPlayer.EXT_PROP_NAME).saveNBTData(temp);
    event.entityPlayer.getExtendedProperties(ExtendedPlayer.EXT_PROP_NAME).loadNBTData(temp);
    ExtendedPlayer.sync(event.entityPlayer);
}
}

I'm back from being gone for... I think its been about a year. I'm pretty sure nobody remembers me, but hello anybody who does!

Link to comment
Share on other sites

Your saveNBTData method is broken. Look closely at the last line. You never save anything to the player's NBT.

Not sure what you mean. Can you explain more? Thanks.

I'm back from being gone for... I think its been about a year. I'm pretty sure nobody remembers me, but hello anybody who does!

Link to comment
Share on other sites

properties

is the NBTTagCompound that gets saved to disk. You never store anything into it.

 

Wait in this :

public void saveNBTData(NBTTagCompound properties) {
	NBTTagCompound compound = new NBTTagCompound(); 
	compound.setInteger("Elixer",this.elixer);
	compound.setInteger("Gold", this.gold);
	compound.setInteger("Gold_Storage", this.gold_storage);
	compound.setInteger("Elixer_Storage", this.elixer_storage);
	compound.setBoolean("Flag", this.flag);

	compound.setTag(EXT_PROP_NAME, compound);
}

I save it to the compound I make. And properties is just a parameter name right?

I'm back from being gone for... I think its been about a year. I'm pretty sure nobody remembers me, but hello anybody who does!

Link to comment
Share on other sites

Yes, you create a new NBTTagCompound named "compound". Then you store data into it. Then your method exits and the Garbage collector takes care of the object. It never goes anywhere.

But didn't I use a load function in which I get the compund tag which I set back in my save function?

I'm back from being gone for... I think its been about a year. I'm pretty sure nobody remembers me, but hello anybody who does!

Link to comment
Share on other sites

Your last line is wrong - it should be 'properties.setTag(EXT_PROP_NAME, compound);' rather than 'compound.setTag(EXT_PROP_NAME, compound);'

 

Personally, I think you may have confused yourself by naming your parameter 'properties' here:

public void saveNBTData(NBTTagCompound properties) {

 

That tag compound is NOT your properties, it is the tag compound given to you to which you are going to add the new tag storing your properties. I would have swapped the names 'properties' and 'compound' - semantics, but names are powerful.

Link to comment
Share on other sites

Your last line is wrong - it should be 'properties.setTag(EXT_PROP_NAME, compound);' rather than 'compound.setTag(EXT_PROP_NAME, compound);'

 

Personally, I think you may have confused yourself by naming your parameter 'properties' here:

public void saveNBTData(NBTTagCompound properties) {

 

That tag compound is NOT your properties, it is the tag compound given to you to which you are going to add the new tag storing your properties. I would have swapped the names 'properties' and 'compound' - semantics, but names are powerful.

Oh....................

Oops.

Well I tried this.

And it still didn't work when I killed myself.

I'm back from being gone for... I think its been about a year. I'm pretty sure nobody remembers me, but hello anybody who does!

Link to comment
Share on other sites

Show your updated IEEP code.

Here

ublic class ExtendedPlayer implements IExtendedEntityProperties {

public final static String EXT_PROP_NAME = "ExtendedPlayer";
private final EntityPlayer player;
private int gold;
private int elixer;
private int gold_storage;
private int elixer_storage;
private boolean flag;

public ExtendedPlayer(EntityPlayer player)
{
this.player = player;
this.elixer=0;
this.gold=0;
this.gold_storage=0;
this.elixer_storage=0;
this.flag=false;

}
@Override
public void init(Entity entity, World world) {

}
@Override
public void saveNBTData(NBTTagCompound properties) {
	NBTTagCompound compound = new NBTTagCompound(); 
	compound.setInteger("Elixer",this.elixer);
	compound.setInteger("Gold", this.gold);
	compound.setInteger("Gold_Storage", this.gold_storage);
	compound.setInteger("Elixer_Storage", this.elixer_storage);
	compound.setBoolean("Flag", this.flag);

	properties.setTag(EXT_PROP_NAME, compound);
}

@Override
public void loadNBTData(NBTTagCompound properties) {
	NBTTagCompound compound = (NBTTagCompound) properties.getCompoundTag(EXT_PROP_NAME);
	this.gold=compound.getInteger("Gold");
	this.elixer=compound.getInteger("Elixer");
	this.gold_storage=compound.getInteger("Gold_Storage");
	this.elixer_storage=compound.getInteger("Elixer_Storage");
	this.flag=compound.getBoolean("Flag");
}
public static final void register(EntityPlayer player)
{
player.registerExtendedProperties(ExtendedPlayer.EXT_PROP_NAME, new ExtendedPlayer(player));
}
public static final ExtendedPlayer get(EntityPlayer player)
{
	return (ExtendedPlayer) player.getExtendedProperties(EXT_PROP_NAME);
}



public void changeResources(int id,int change){
	if (id==0){
		this.elixer=elixer+change;
	}
	if(id==1){
		this.gold=gold+change;
	}
}
public void changeStorage(int id,int change){
	if (id==0){
		this.elixer_storage=change;
	}
	if(id==1){
		this.gold_storage=change;
	}
}
public int getResources(int id){
	int resource = 0;
	if (id==0){
		resource=this.elixer;
	}
	if(id==1){
		resource=this.gold;
	}
	return resource;
}
public int getStorage(int id){
	int resource=0;
	if (id==0){
		resource=this.elixer_storage;
	}
	if(id==1){
		resource=this.gold_storage;
	}
	return resource;
}
public void changeFlag(boolean par1){
	this.flag=par1;
}
public boolean getFlag(){
	return this.flag;
}

public static void sync(EntityPlayer player) {

	ClashOfCraft.packetPipeline.sendTo(new SyncPlayerPropsPacket(player), (EntityPlayerMP) player);
}

}

I'm back from being gone for... I think its been about a year. I'm pretty sure nobody remembers me, but hello anybody who does!

Link to comment
Share on other sites

Hrm, I can't see anything wrong with it on a first glance. Does your data save when you exist the world and rejoin? If so, please show your event handler again and where you register it.

No it does not save when I exit the world and rejoin. I can show the event handler if you want again.

I'm back from being gone for... I think its been about a year. I'm pretty sure nobody remembers me, but hello anybody who does!

Link to comment
Share on other sites

No it does not save when I exit the world and rejoin. I can show the event handler if you want again.

That's what he already asked you to do... no one can help you if you don't show your code.

Sorry.

 

@SubscribeEvent
public void onEntityConstructing(EntityConstructing event){
	if (event.entity instanceof EntityPlayer && ExtendedPlayer.get((EntityPlayer) event.entity) == null){
		ExtendedPlayer.register((EntityPlayer) event.entity);
	}
}
@SubscribeEvent
public void onLivingDeathEvent(LivingDeathEvent event){

}
// we already have this event, but we need to modify it some
@SubscribeEvent
public void onEntityJoinWorld(EntityJoinWorldEvent event){

}
@SubscribeEvent
public void onClone(PlayerEvent.Clone event) {
    NBTTagCompound temp = new NBTTagCompound();
    event.original.getExtendedProperties(ExtendedPlayer.EXT_PROP_NAME).saveNBTData(temp);
    event.entityPlayer.getExtendedProperties(ExtendedPlayer.EXT_PROP_NAME).loadNBTData(temp);
    ExtendedPlayer.sync(event.entityPlayer);
}



}

I'm back from being gone for... I think its been about a year. I'm pretty sure nobody remembers me, but hello anybody who does!

Link to comment
Share on other sites

Ok, that is weird. How did you diagnose that it does not save when you save and relog?

I added some gold to my extended properties and I saw the change. And then I exited the world and then came back on and it was gone. To check this I was using a gui could it be I didn't sync it when I reloged. Ill go check with the console and see if that changes anything.

I'm back from being gone for... I think its been about a year. I'm pretty sure nobody remembers me, but hello anybody who does!

Link to comment
Share on other sites

Ok, that is weird. How did you diagnose that it does not save when you save and relog?

I added some gold to my extended properties and I saw the change. And then I exited the world and then came back on and it was gone. To check this I was using a gui could it be I didn't sync it when I reloged. Ill go check with the console and see if that changes anything.

Nope it wasnt a syncing problem the console didn't show it saved either.

I'm back from being gone for... I think its been about a year. I'm pretty sure nobody remembers me, but hello anybody who does!

Link to comment
Share on other sites

Hello guys. Well I found something out. I call my init everytime the class is called. And I say in my init that the variable is equel to 0. Is there a way to call the gold=0 only the first time the player enters the world and then later keep it as is?

I'm back from being gone for... I think its been about a year. I'm pretty sure nobody remembers me, but hello anybody who does!

Link to comment
Share on other sites

Well I have just got some code from a friend. And it works but I have NO idea how.

 

EntityGoldMine

public class EntityGoldMine extends EntityLiving{
public int level;
public int effeciancy;
public int capacity;
public static int full;
public int tick;
public boolean isUpgrading;
public static int goldMath;

public String name;

public EntityGoldMine(World p_i1582_1_) {
	super(p_i1582_1_);

}
public void setOwnerName(String par1){
	this.name=par1;
}
  
public void entityInit(){
	this.effeciancy=1;
	this.level=1;
	this.capacity=500;
	this.full=0;
	this.tick=0;
	this.isUpgrading=false;
	super.entityInit();

}
protected void applyEntityAttributes()
    {
        super.applyEntityAttributes();
        this.getEntityAttribute(SharedMonsterAttributes.maxHealth).setBaseValue(30.0D);
        
    }
public boolean canDespawn(){
	return false;
}
  public void writeEntityToNBT(NBTTagCompound tag)
    {
	super.writeEntityToNBT(tag);

	tag.setInteger("Level", this.level);
	tag.setInteger("Effeciany", this.effeciancy);
	tag.setInteger("Capacity", this.capacity);
	tag.setInteger("Full",this.full);
	tag.setString("Owner", this.name);

    }
public void readEntityFromNBT(NBTTagCompound tag) {
	super.readEntityFromNBT(tag);
	this.level=tag.getInteger("Level");
	this.effeciancy=tag.getInteger("Effeciany");
	this.capacity=tag.getInteger("Capacity");
	this.full=tag.getInteger("Full");
	this.name=tag.getString("Owner");
}

public void onEntityUpdate(){

	switch(level){
		case 1:this.capacity=500;
		this.effeciancy=1;	
		break;

		case 2:this.capacity=1000;
		this.effeciancy=3;
	}
	if(this.worldObj.isRemote==true){
		if(this.full<this.capacity){
			if(this.isUpgrading==false){
				tick++;
			}
			if(tick==20){
				this.full++;
				this.tick=0;
			}
		}
	}
	super.onEntityUpdate();
}
public void collect(EntityPlayer par1){
	EntityPlayer player=par1;
	ExtendedPlayer data=ExtendedPlayer.get(player);
	data.changeResources(1, this.full);
	System.out.println("The button has been pressed!");
	this.goldMath = goldMath + full;
	this.full=0;
}
 protected boolean interact(EntityPlayer player)
 {	

	 player.openGui(ClashOfCraft.instance, 20, player.worldObj, (int)this.getEntityId(), (int)player.posY,(int) player.posZ);


     return true;
 }

 

ExtendedPlayer

 

And this is the part I find wierd in here he says

{
this.player = player;
this.elixer=0;
this.gold=EntityGoldMine.goldMath;
this.gold_storage=0;
this.elixer_storage=0;

}

How the heck does EntityGoldMine.goldMath work????????

Doesnt that make a new object and take it from there.

But somehow  it works

Anyone know how.

I'm back from being gone for... I think its been about a year. I'm pretty sure nobody remembers me, but hello anybody who does!

Link to comment
Share on other sites

Static variables? That sounds like a very bad idea.

Getters and setters would be better right? <---- I dont know why I said that.

And also how does the EntityGoldMine.goldmath work. Doesnt it make a new object and then take goldmath (which is 0 because its a new object) and then deletes the object. Or does it not work like that?

I'm back from being gone for... I think its been about a year. I'm pretty sure nobody remembers me, but hello anybody who does!

Link to comment
Share on other sites

No, that is not how static fields work. You should read up on what static means.

Ok I went and saw what it is. And that is totally not what we want. So how can we do it so that variales not static?

I'm back from being gone for... I think its been about a year. I'm pretty sure nobody remembers me, but hello anybody who does!

Link to comment
Share on other sites

Don't use the static keyword then...

Could you please describe what you are actually trying to achieve here?

To save the players data after death and after reloging into the world. Its seems like it has something to do when I initalize the variable.

I'm back from being gone for... I think its been about a year. I'm pretty sure nobody remembers me, but hello anybody who does!

Link to comment
Share on other sites

Are you sure the variables are read and written to NBT correctly? (Use println statements and an NBT editor to see if the data is stored).

If that is correct, your syncing is broken (I suspect it).

Will check.

I'm back from being gone for... I think its been about a year. I'm pretty sure nobody remembers me, but hello anybody who does!

Link to comment
Share on other sites

Welll actually I am sure that everything is being saved and read. Because when my friend put the code. Even though static is a bad way of doing things it saved it and loaded the numbers fine. And there was no syncing being changed there. So it must be my variable is not initialized or something?

I'm back from being gone for... I think its been about a year. I'm pretty sure nobody remembers me, but hello anybody who does!

Link to comment
Share on other sites

You need to stop with that vague shit. Give me code and console output to prove what you have done and what happens.

Or a proper git repo so I can do things myself.

1.Sorry about that.

2. didnt change any code so the code is on the thread already.

3. Heres a github anyway.  https://github.com/starwarsmace/Clash-of-Craft/

 

4.And I put a println statement in onLivingUpdateEvent and it reset to 0 after I respawned or reloged.

@SubscribeEvent
public void onLivingUpdateEvent(LivingUpdateEvent event){
	if(event.entity!=null && event.entity instanceof EntityPlayer){

		ExtendedPlayer player = ExtendedPlayer.get((EntityPlayer) event.entity);
		System.out.println("Gold: "+player.getResources(1));
	}
}

I'm back from being gone for... I think its been about a year. I'm pretty sure nobody remembers me, but hello anybody who does!

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hello, I'm trying to modify the effects of native enchantments for bows and arrows in Minecraft. After using a decompilation tool, I found that the specific implementations of native bow and arrow enchantments (including `ArrowDamageEnchantment`, `ArrowKnockbackEnchantment`, `ArrowFireEnchantment`, `ArrowInfiniteEnchantment`, `ArrowPiercingEnchantment`) do not contain any information about the enchantment effects (such as the `getDamageProtection` function for `ProtectionEnchantment`, `getDamageBonus` function for `DamageEnchantment`, etc.). Upon searching for the base class of arrows, `AbstractArrow`, I found a function named setEnchantmentEffectsFromEntity`, which seems to be used to retrieve the enchantment levels of the tool held by a `LivingEntity` and calculate the specific values of the enchantment effects. However, after testing with the following code, I found that this function is not being called:   @Mixin(AbstractArrow.class) public class ModifyArrowEnchantmentEffects {     private static final Logger LOGGER = LogUtils.getLogger();     @Inject(         method = "setEnchantmentEffectsFromEntity",         at = @At("HEAD")     )     private void logArrowEnchantmentEffectsFromEntity(CallbackInfo ci) {         LOGGER.info("Arrow enchantment effects from entity");     } }   Upon further investigation, I found that within the onHitEntity method, there are several lines of code:               if (!this.level().isClientSide &amp;&amp; entity1 instanceof LivingEntity) {                EnchantmentHelper.doPostHurtEffects(livingentity, entity1);                EnchantmentHelper.doPostDamageEffects((LivingEntity)entity1, livingentity);             }   These lines of code actually call the doPostHurt and doPostAttack methods of each enchantment in the enchantment list. However, this leads back to the issue because native bow and arrow enchantments do not implement these functions. Although their base class defines the functions, they are empty. At this point, I'm completely stumped and seeking assistance. Thank you.
    • I have been trying to make a server with forge but I keep running into an issue. I have jdk 22 installed as well as Java 8. here is the debug file  
    • it crashed again     What the console says : [00:02:03] [Server thread/INFO] [Easy NPC/]: [EntityManager] Server started! [00:02:03] [Server thread/INFO] [co.gi.al.ic.IceAndFire/]: {iceandfire:fire_dragon_roost=true, iceandfire:fire_lily=true, iceandfire:spawn_dragon_skeleton_fire=true, iceandfire:lightning_dragon_roost=true, iceandfire:spawn_dragon_skeleton_lightning=true, iceandfire:ice_dragon_roost=true, iceandfire:ice_dragon_cave=true, iceandfire:lightning_dragon_cave=true, iceandfire:cyclops_cave=true, iceandfire:spawn_wandering_cyclops=true, iceandfire:spawn_sea_serpent=true, iceandfire:frost_lily=true, iceandfire:hydra_cave=true, iceandfire:lightning_lily=true, iceandfireixie_village=true, iceandfire:myrmex_hive_jungle=true, iceandfire:myrmex_hive_desert=true, iceandfire:silver_ore=true, iceandfire:siren_island=true, iceandfire:spawn_dragon_skeleton_ice=true, iceandfire:spawn_stymphalian_bird=true, iceandfire:fire_dragon_cave=true, iceandfire:sapphire_ore=true, iceandfire:spawn_hippocampus=true, iceandfire:spawn_death_worm=true} [00:02:03] [Server thread/INFO] [co.gi.al.ic.IceAndFire/]: {TROLL_S=true, HIPPOGRYPH=true, AMPHITHERE=true, COCKATRICE=true, TROLL_M=true, DREAD_LICH=true, TROLL_F=true} [00:02:03] [Server thread/INFO] [ne.be.lo.WeaponRegistry/]: Encoded Weapon Attribute registry size (with package overhead): 41976 bytes (in 5 string chunks with the size of 10000) [00:02:03] [Server thread/INFO] [patchouli/]: Sending reload packet to clients [00:02:03] [Server thread/WARN] [voicechat/]: [voicechat] Running in offline mode - Voice chat encryption is not secure! [00:02:03] [VoiceChatServerThread/INFO] [voicechat/]: [voicechat] Using server-ip as bind address: 0.0.0.0 [00:02:03] [Server thread/WARN] [ModernFix/]: Dedicated server took 22.521 seconds to load [00:02:03] [VoiceChatServerThread/INFO] [voicechat/]: [voicechat] Voice chat server started at 0.0.0.0:25565 [00:02:03] [Server thread/WARN] [minecraft/SynchedEntityData]: defineId called for: class net.minecraft.world.entity.player.Player from class tschipp.carryon.common.carry.CarryOnDataManager [00:02:03] [Server thread/INFO] [ne.mi.co.AdvancementLoadFix/]: Using new advancement loading for net.minecraft.server.PlayerAdvancements@2941ffd5 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 0 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 1 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 2 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 3 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 4 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 5 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 6 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 7 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 8 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 9 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 10 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 11 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 12 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 13 [00:02:10] [Netty Epoll Server IO #2/INFO] [Calio/]: Received acknowledgment for login packet with id 14 [00:02:19] [Server thread/INFO] [ne.mi.co.AdvancementLoadFix/]: Using new advancement loading for net.minecraft.server.PlayerAdvancements@ebc7ef2 [00:02:19] [Server thread/INFO] [minecraft/PlayerList]: ZacAdos[/90.2.17.162:49242] logged in with entity id 1062 at (-1848.6727005281205, 221.0, -3054.2468255848935) [00:02:19] [Server thread/ERROR] [ModernFix/]: Skipping entity ID sync for com.talhanation.smallships.world.entity.ship.Ship: java.lang.NoClassDefFoundError: net/minecraft/client/CameraType [00:02:19] [Server thread/INFO] [minecraft/MinecraftServer]: - Gloop - ZacAdos joined the game [00:02:19] [Server thread/INFO] [xa.pa.OpenPartiesAndClaims/]: Updating all forceload tickets for cc56befd-d376-3526-a760-340713c478bd [00:02:19] [Server thread/INFO] [se.mi.te.da.DataManager/]: Sending data to client: ZacAdos [00:02:19] [Server thread/INFO] [voicechat/]: [voicechat] Received secret request of - Gloop - ZacAdos (17) [00:02:19] [Server thread/INFO] [voicechat/]: [voicechat] Sent secret to - Gloop - ZacAdos [00:02:21] [VoiceChatPacketProcessingThread/INFO] [voicechat/]: [voicechat] Successfully authenticated player cc56befd-d376-3526-a760-340713c478bd [00:02:22] [VoiceChatPacketProcessingThread/INFO] [voicechat/]: [voicechat] Successfully validated connection of player cc56befd-d376-3526-a760-340713c478bd [00:02:22] [VoiceChatPacketProcessingThread/INFO] [voicechat/]: [voicechat] Player - Gloop - ZacAdos (cc56befd-d376-3526-a760-340713c478bd) successfully connected to voice chat stop [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: Stopping the server [00:02:34] [Server thread/INFO] [mo.pl.ar.ArmourersWorkshop/]: stop local service [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: Stopping server [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: Saving players [00:02:34] [Server thread/INFO] [minecraft/ServerGamePacketListenerImpl]: ZacAdos lost connection: Server closed [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: - Gloop - ZacAdos left the game [00:02:34] [Server thread/INFO] [xa.pa.OpenPartiesAndClaims/]: Updating all forceload tickets for cc56befd-d376-3526-a760-340713c478bd [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: Saving worlds [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: Saving chunks for level 'ServerLevel[world]'/minecraft:overworld [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: Saving chunks for level 'ServerLevel[world]'/minecraft:the_end [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: Saving chunks for level 'ServerLevel[world]'/minecraft:the_nether [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: ThreadedAnvilChunkStorage (world): All chunks are saved [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: ThreadedAnvilChunkStorage (DIM1): All chunks are saved [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: ThreadedAnvilChunkStorage (DIM-1): All chunks are saved [00:02:34] [Server thread/INFO] [minecraft/MinecraftServer]: ThreadedAnvilChunkStorage: All dimensions are saved [00:02:34] [Server thread/INFO] [xa.pa.OpenPartiesAndClaims/]: Stopping IO worker... [00:02:34] [Server thread/INFO] [xa.pa.OpenPartiesAndClaims/]: Stopped IO worker! [00:02:34] [Server thread/INFO] [Calio/]: Removing Dynamic Registries for: net.minecraft.server.dedicated.DedicatedServer@7dc879e1 [MineStrator Daemon]: Checking server disk space usage, this could take a few seconds... [MineStrator Daemon]: Updating process configuration files... [MineStrator Daemon]: Ensuring file permissions are set correctly, this could take a few seconds... [MineStrator Daemon]: Pulling Docker container image, this could take a few minutes to complete... [MineStrator Daemon]: Finished pulling Docker container image container@pterodactyl~ java -version openjdk version "17.0.10" 2024-01-16 OpenJDK Runtime Environment Temurin-17.0.10+7 (build 17.0.10+7) OpenJDK 64-Bit Server VM Temurin-17.0.10+7 (build 17.0.10+7, mixed mode, sharing) container@pterodactyl~ java -Xms128M -Xmx6302M -Dterminal.jline=false -Dterminal.ansi=true -Djline.terminal=jline.UnsupportedTerminal -p libraries/cpw/mods/bootstraplauncher/1.1.2/bootstraplauncher-1.1.2.jar:libraries/cpw/mods/securejarhandler/2.1.4/securejarhandler-2.1.4.jar:libraries/org/ow2/asm/asm-commons/9.5/asm-commons-9.5.jar:libraries/org/ow2/asm/asm-util/9.5/asm-util-9.5.jar:libraries/org/ow2/asm/asm-analysis/9.5/asm-analysis-9.5.jar:libraries/org/ow2/asm/asm-tree/9.5/asm-tree-9.5.jar:libraries/org/ow2/asm/asm/9.5/asm-9.5.jar:libraries/net/minecraftforge/JarJarFileSystems/0.3.16/JarJarFileSystems-0.3.16.jar --add-modules ALL-MODULE-PATH --add-opens java.base/java.util.jar=cpw.mods.securejarhandler --add-opens java.base/java.lang.invoke=cpw.mods.securejarhandler --add-exports java.base/sun.security.util=cpw.mods.securejarhandler --add-exports jdk.naming.dns/com.sun.jndi.dns=java.naming -Djava.net.preferIPv6Addresses=system -DignoreList=bootstraplauncher-1.1.2.jar,securejarhandler-2.1.4.jar,asm-commons-9.5.jar,asm-util-9.5.jar,asm-analysis-9.5.jar,asm-tree-9.5.jar,asm-9.5.jar,JarJarFileSystems-0.3.16.jar -DlibraryDirectory=libraries -DlegacyClassPath=libraries/cpw/mods/securejarhandler/2.1.4/securejarhandler-2.1.4.jar:libraries/org/ow2/asm/asm/9.5/asm-9.5.jar:libraries/org/ow2/asm/asm-commons/9.5/asm-commons-9.5.jar:libraries/org/ow2/asm/asm-tree/9.5/asm-tree-9.5.jar:libraries/org/ow2/asm/asm-util/9.5/asm-util-9.5.jar:libraries/org/ow2/asm/asm-analysis/9.5/asm-analysis-9.5.jar:libraries/net/minecraftforge/accesstransformers/8.0.4/accesstransformers-8.0.4.jar:libraries/org/antlr/antlr4-runtime/4.9.1/antlr4-runtime-4.9.1.jar:libraries/net/minecraftforge/eventbus/6.0.3/eventbus-6.0.3.jar:libraries/net/minecraftforge/forgespi/6.0.0/forgespi-6.0.0.jar:libraries/net/minecraftforge/coremods/5.0.1/coremods-5.0.1.jar:libraries/cpw/mods/modlauncher/10.0.8/modlauncher-10.0.8.jar:libraries/net/minecraftforge/unsafe/0.2.0/unsafe-0.2.0.jar:libraries/com/electronwill/night-config/core/3.6.4/core-3.6.4.jar:libraries/com/electronwill/night-config/toml/3.6.4/toml-3.6.4.jar:libraries/org/apache/maven/maven-artifact/3.8.5/maven-artifact-3.8.5.jar:libraries/net/jodah/typetools/0.8.3/typetools-0.8.3.jar:libraries/net/minecrell/terminalconsoleappender/1.2.0/terminalconsoleappender-1.2.0.jar:libraries/org/jline/jline-reader/3.12.1/jline-reader-3.12.1.jar:libraries/org/jline/jline-terminal/3.12.1/jline-terminal-3.12.1.jar:libraries/org/spongepowered/mixin/0.8.5/mixin-0.8.5.jar:libraries/org/openjdk/nashorn/nashorn-core/15.3/nashorn-core-15.3.jar:libraries/net/minecraftforge/JarJarSelector/0.3.16/JarJarSelector-0.3.16.jar:libraries/net/minecraftforge/JarJarMetadata/0.3.16/JarJarMetadata-0.3.16.jar:libraries/net/minecraftforge/fmlloader/1.19.2-43.3.0/fmlloader-1.19.2-43.3.0.jar:libraries/net/minecraft/server/1.19.2-20220805.130853/server-1.19.2-20220805.130853-extra.jar:libraries/com/github/oshi/oshi-core/5.8.5/oshi-core-5.8.5.jar:libraries/com/google/code/gson/gson/2.8.9/gson-2.8.9.jar:libraries/com/google/guava/failureaccess/1.0.1/failureaccess-1.0.1.jar:libraries/com/google/guava/guava/31.0.1-jre/guava-31.0.1-jre.jar:libraries/com/mojang/authlib/3.11.49/authlib-3.11.49.jar:libraries/com/mojang/brigadier/1.0.18/brigadier-1.0.18.jar:libraries/com/mojang/datafixerupper/5.0.28/datafixerupper-5.0.28.jar:libraries/com/mojang/javabridge/1.2.24/javabridge-1.2.24.jar:libraries/com/mojang/logging/1.0.0/logging-1.0.0.jar:libraries/commons-io/commons-io/2.11.0/commons-io-2.11.0.jar:libraries/io/netty/netty-buffer/4.1.77.Final/netty-buffer-4.1.77.Final.jar:libraries/io/netty/netty-codec/4.1.77.Final/netty-codec-4.1.77.Final.jar:libraries/io/netty/netty-common/4.1.77.Final/netty-common-4.1.77.Final.jar:libraries/io/netty/netty-handler/4.1.77.Final/netty-handler-4.1.77.Final.jar:libraries/io/netty/netty-resolver/4.1.77.Final/netty-resolver-4.1.77.Final.jar:libraries/io/netty/netty-transport/4.1.77.Final/netty-transport-4.1.77.Final.jar:libraries/io/netty/netty-transport-classes-epoll/4.1.77.Final/netty-transport-classes-epoll-4.1.77.Final.jar:libraries/io/netty/netty-transport-native-epoll/4.1.77.Final/netty-transport-native-epoll-4.1.77.Final-linux-x86_64.jar:libraries/io/netty/netty-transport-native-epoll/4.1.77.Final/netty-transport-native-epoll-4.1.77.Final-linux-aarch_64.jar:libraries/io/netty/netty-transport-native-unix-common/4.1.77.Final/netty-transport-native-unix-common-4.1.77.Final.jar:libraries/it/unimi/dsi/fastutil/8.5.6/fastutil-8.5.6.jar:libraries/net/java/dev/jna/jna/5.10.0/jna-5.10.0.jar:libraries/net/java/dev/jna/jna-platform/5.10.0/jna-platform-5.10.0.jar:libraries/net/sf/jopt-simple/jopt-simple/5.0.4/jopt-simple-5.0.4.jar:libraries/org/apache/commons/commons-lang3/3.12.0/commons-lang3-3.12.0.jar:libraries/org/apache/logging/log4j/log4j-api/2.17.0/log4j-api-2.17.0.jar:libraries/org/apache/logging/log4j/log4j-core/2.17.0/log4j-core-2.17.0.jar:libraries/org/apache/logging/log4j/log4j-slf4j18-impl/2.17.0/log4j-slf4j18-impl-2.17.0.jar:libraries/org/slf4j/slf4j-api/1.8.0-beta4/slf4j-api-1.8.0-beta4.jar cpw.mods.bootstraplauncher.BootstrapLauncher --launchTarget forgeserver --fml.forgeVersion 43.3.0 --fml.mcVersion 1.19.2 --fml.forgeGroup net.minecraftforge --fml.mcpVersion 20220805.130853 [00:02:42] [main/INFO] [cp.mo.mo.Launcher/MODLAUNCHER]: ModLauncher running: args [--launchTarget, forgeserver, --fml.forgeVersion, 43.3.0, --fml.mcVersion, 1.19.2, --fml.forgeGroup, net.minecraftforge, --fml.mcpVersion, 20220805.130853] [00:02:42] [main/INFO] [cp.mo.mo.Launcher/MODLAUNCHER]: ModLauncher 10.0.8+10.0.8+main.0ef7e830 starting: java version 17.0.10 by Eclipse Adoptium; OS Linux arch amd64 version 6.1.0-12-amd64 [00:02:43] [main/INFO] [mixin/]: SpongePowered MIXIN Subsystem Version=0.8.5 Source=union:/home/container/libraries/org/spongepowered/mixin/0.8.5/mixin-0.8.5.jar%2363!/ Service=ModLauncher Env=SERVER [00:02:43] [main/WARN] [ne.mi.fm.lo.mo.ModFileParser/LOADING]: Mod file /home/container/libraries/net/minecraftforge/fmlcore/1.19.2-43.3.0/fmlcore-1.19.2-43.3.0.jar is missing mods.toml file [00:02:43] [main/WARN] [ne.mi.fm.lo.mo.ModFileParser/LOADING]: Mod file /home/container/libraries/net/minecraftforge/javafmllanguage/1.19.2-43.3.0/javafmllanguage-1.19.2-43.3.0.jar is missing mods.toml file [00:02:43] [main/WARN] [ne.mi.fm.lo.mo.ModFileParser/LOADING]: Mod file /home/container/libraries/net/minecraftforge/lowcodelanguage/1.19.2-43.3.0/lowcodelanguage-1.19.2-43.3.0.jar is missing mods.toml file [00:02:43] [main/WARN] [ne.mi.fm.lo.mo.ModFileParser/LOADING]: Mod file /home/container/libraries/net/minecraftforge/mclanguage/1.19.2-43.3.0/mclanguage-1.19.2-43.3.0.jar is missing mods.toml file [00:02:44] [main/WARN] [ne.mi.ja.se.JarSelector/]: Attempted to select two dependency jars from JarJar which have the same identification: Mod File: and Mod File: . Using Mod File: [00:02:44] [main/WARN] [ne.mi.ja.se.JarSelector/]: Attempted to select a dependency jar for JarJar which was passed in as source: resourcefullib. Using Mod File: /home/container/mods/resourcefullib-forge-1.19.2-1.1.24.jar [00:02:44] [main/INFO] [ne.mi.fm.lo.mo.JarInJarDependencyLocator/]: Found 13 dependencies adding them to mods collection Latest log [29Mar2024 00:02:42.803] [main/INFO] [cpw.mods.modlauncher.Launcher/MODLAUNCHER]: ModLauncher running: args [--launchTarget, forgeserver, --fml.forgeVersion, 43.3.0, --fml.mcVersion, 1.19.2, --fml.forgeGroup, net.minecraftforge, --fml.mcpVersion, 20220805.130853] [29Mar2024 00:02:42.805] [main/INFO] [cpw.mods.modlauncher.Launcher/MODLAUNCHER]: ModLauncher 10.0.8+10.0.8+main.0ef7e830 starting: java version 17.0.10 by Eclipse Adoptium; OS Linux arch amd64 version 6.1.0-12-amd64 [29Mar2024 00:02:43.548] [main/INFO] [mixin/]: SpongePowered MIXIN Subsystem Version=0.8.5 Source=union:/home/container/libraries/org/spongepowered/mixin/0.8.5/mixin-0.8.5.jar%2363!/ Service=ModLauncher Env=SERVER [29Mar2024 00:02:43.876] [main/WARN] [net.minecraftforge.fml.loading.moddiscovery.ModFileParser/LOADING]: Mod file /home/container/libraries/net/minecraftforge/fmlcore/1.19.2-43.3.0/fmlcore-1.19.2-43.3.0.jar is missing mods.toml file [29Mar2024 00:02:43.877] [main/WARN] [net.minecraftforge.fml.loading.moddiscovery.ModFileParser/LOADING]: Mod file /home/container/libraries/net/minecraftforge/javafmllanguage/1.19.2-43.3.0/javafmllanguage-1.19.2-43.3.0.jar is missing mods.toml file [29Mar2024 00:02:43.877] [main/WARN] [net.minecraftforge.fml.loading.moddiscovery.ModFileParser/LOADING]: Mod file /home/container/libraries/net/minecraftforge/lowcodelanguage/1.19.2-43.3.0/lowcodelanguage-1.19.2-43.3.0.jar is missing mods.toml file [29Mar2024 00:02:43.878] [main/WARN] [net.minecraftforge.fml.loading.moddiscovery.ModFileParser/LOADING]: Mod file /home/container/libraries/net/minecraftforge/mclanguage/1.19.2-43.3.0/mclanguage-1.19.2-43.3.0.jar is missing mods.toml file [29Mar2024 00:02:44.033] [main/WARN] [net.minecraftforge.jarjar.selection.JarSelector/]: Attempted to select two dependency jars from JarJar which have the same identification: Mod File: and Mod File: . Using Mod File: [29Mar2024 00:02:44.034] [main/WARN] [net.minecraftforge.jarjar.selection.JarSelector/]: Attempted to select a dependency jar for JarJar which was passed in as source: resourcefullib. Using Mod File: /home/container/mods/resourcefullib-forge-1.19.2-1.1.24.jar [29Mar2024 00:02:44.034] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.JarInJarDependencyLocator/]: Found 13 dependencies adding them to mods collection
    • I am unable to do that. Brigadier is a mojang library that parses commands.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.