Return true for isItemEqual() with any itemDamage

[grand_mind1]

Hey, title pretty much says it all. I want to use isItemEqual() in my container, but I need it to return true for any item damage. At the moment, it only returns true if the item is not damaged.

[grand_mind1]

Well... what method would I use?

[brandon3055]

Quick question related to this topic. You can use either

stack.getItem() instanceof ItemClass

or

stack.getItem() == ModItems.item

I use both interchangeably but which is better?

 

[brandon3055]

Well in what situation would you use one rather then the other?

[brandon3055]

Pretty much what i expected. But in the past i have used instanceof in a lot of places i could have used == would it be worth the time to go back and change them? (is there any disadvantage to using instanceof in place of ==)

[Draco18s]

Theoretically == is faster than instanceof, but in practice it does not matter.

 

This is pretty much true.  You'd have to be calling instanceof like 10,000 times a tick to see a difference.  There are other, similar "micro optimizations" you can make as well, for instance using ++i instead of i++ (because of the way values are returned, i++ has to use a little extra stack space and a pop).  But for the most part you'd only notice a difference when it's being used tens, if not hundreds, of thousands of times every frame.

[Draco18s]

for instance using ++i instead of i++ (because of the way values are returned, i++ has to use a little extra stack space and a pop)

Actually javac compiles these two to the same thing:

int i = 1;
i++;

int i = 1;
++i;

 

If the value is not used, it does not matter.

 

Ah, cool.  The last time I saw the test done for various ways was on AS3 (which does create a temporary variable).