Jump to content

[1.8][Solved] Server-side packet handler doesn't work.


vilu

Recommended Posts

I'm using SimpleNetworkWrapper to send packets that implements IMessage. Everything worked fine on 1.7.10 but now if I send packet from client side to server, I can see from console that it's the client that handles packet when its handler is registered to be on server-side. So here is some code.

 

@EventHandler
public void preInit(FMLPreInitializationEvent event)
{
network = NetworkRegistry.INSTANCE.newSimpleChannel(Info.modChannel);
network.registerMessage(BlockPacket.HandlerServer.class, BlockPacket.class, 1, Side.SERVER);
network.registerMessage(BlockPacket.HandlerClient.class, BlockPacket.class, 2, Side.CLIENT);
}

 

BlockPacket.ServerHandler:

 

public static class HandlerServer extends BlockPacket implements IMessageHandler<BlockPacket, IMessage> {
        @Override
        public IMessage onMessage(BlockPacket message, MessageContext ctx) {
	int receivedInt = message.someInteger;
	System.out.printf("BlockPacket.HandlerServer.onMessage: Received integer was %s", receivedInt);
	return null;
    	}
}

 

I'm trying to send packet from GUI:

modname.network.sendToServer(new BlockPacket(1234));

and then I can see from console that it's send and received but:

 

[modname-CLIENT] BlockPacket.HandlerServer.onMessage: Received integer was 1234

 

Let's say I want to send packet from a gui to the server, and there are values I want to set to the tileentity. If I set those values by using received packet it will update only client side tileentity, not server side as it should.

 

So any ideas how to fix this? And this same thing happens for all packets sent to server handler.

Link to comment
Share on other sites

BlockPacket.ServerHandler:

public static class HandlerServer extends BlockPacket implements IMessageHandler<BlockPacket, IMessage> {
@Override
public IMessage onMessage(BlockPacket message, MessageContext ctx) {
	int receivedInt = message.someInteger;
	System.out.printf("BlockPacket.HandlerServer.onMessage: Received integer was %s", receivedInt);

	EntityPlayer player = ctx.getServerHandler().playerEntity;
	if(player != null) {
		Container container = player.openContainer;
		if (container != null && container instanceof SomeContainer) {
			//Note: IGuiHandler returns SomeContainer that extends Container for server.
			BlockPos pos = ((SomeContainer)container).getTileEntity().getPos();
			TileEntity te = player.worldObj.getTileEntity(pos);
			if(te != null && te instanceof BlockTileEntity) {
				((BlockTileEntity)te).setDataFromPacket(receivedInt);
			} else {
				System.out.printf("BlockPacket.HandlerServer.onMessage: No tileentity found at %s", pos.toString);
			}
		}
	}
	return null;
}
}

 

and console says:

[modname-CLIENT] BlockPacket.HandlerServer.onMessage: Received integer was 1234
[modname-CLIENT] BlockTileEntity.setDataFromPacket: Got data 1234

 

but if I run exactly the same code (except blockPos, it were x y z coordinates) in 1.7.10 console says:

[modname-SERVER] BlockPacket.HandlerServer.onMessage: Received integer was 1234
[modname-SERVER] BlockTileEntity.setDataFromPacket: Got data 1234

Link to comment
Share on other sites

I was thinking the same, but it's weird because there are lot of cases that logger recognizes server as it should.

After I did some debugging I see that tileentity losts given data after changing associated block metadata...

 

Link to comment
Share on other sites

Well, no specific reason why =D Actually its much efficient and easier way to do all those things I do.. just never thought it. I think that there were some case that I had problems with containers or something and therefore I made sure that Container would never return null value for getTileEntity() or something. And I just left it like that so, that's the background story behind.

 

But back to the problem. I did more digging and I've noticed that every time I set blockstate (aka. metadata) tileentity resets. Something like this:

 

worldIn.setBlockState(pos, previousState.withProperty(POWERED, Boolean.valueOf(powered)), 3);
worldIn.notifyNeighborsOfStateChange(pos, worldIn.getBlockState(pos).getBlock());

 

Link to comment
Share on other sites

That worked! Thank you so much :)

 

So it was, just like you said, the logger messing up sides. Packet were handled in server-side just like it should be. It just looked like it is the client that receives server-side packet because tileentity did reset everytime when its metadata (blockstate) changed. I added console debug print to onBlockActivated and checked what it prints after sending packet and it did show same nbt tag compound for both sides. Then I changed current blockstate with one Boolean property and checked nbt tags again so then it reset tileentity.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.