Jump to content

Trouble with for loops for a simple multiblock


turbodiesel4598

Recommended Posts

Hey there,

 

I'm not too experienced with modding, but have been making a mod for the past month or so, and have certainly improved. However, I'm attempting to make my currently extremely crude code more compact and simplified by using for loops to detect whether all of the blocks needed for the multiblock structure are there.

 

However, I am clearly doing something wrong: the block is only caring about 6 of the blocks out of the 150 of the structure, and only searches in those places - here is the block class, where everything important is, and the multiblock detection method is at the bottom, with the commented out section at the beginning of the method being the old system.

 

package com.nr.mod.blocks.tileentities;

import java.util.Random;

import net.minecraft.block.Block;
import net.minecraft.block.BlockContainer;
import net.minecraft.block.material.Material;
import net.minecraft.client.renderer.texture.IIconRegister;
import net.minecraft.command.ICommandSender;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.item.EntityItem;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.inventory.Container;
import net.minecraft.inventory.IInventory;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.IChatComponent;
import net.minecraft.util.IIcon;
import net.minecraft.util.MathHelper;
import net.minecraft.world.World;

import com.nr.mod.NuclearRelativistics;
import com.nr.mod.blocks.NRBlocks;

import cpw.mods.fml.common.network.internal.FMLNetworkHandler;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;

public class BlockFissionReactorGraphite extends BlockContainer
{
private Random rand = new Random();

private final boolean isActive;
public static int MBNumber;

@SideOnly(Side.CLIENT)
private IIcon iconFront;

private static boolean keepInventory;

public BlockFissionReactorGraphite(boolean isActive)
{
super(Material.iron);

this.isActive = isActive;
}

@SideOnly(Side.CLIENT)
@Override
public void registerBlockIcons(IIconRegister iconRegister)
{
this.blockIcon = iconRegister.registerIcon("nr:" + "reactorBlock");
this.iconFront = iconRegister.registerIcon("nr:" + "fissionReactorGraphite" + "Front" + (this.isActive ? "Active" : "Idle"));
}

public Item getItemDropped(int par1, Random random, int par3)
{
	return Item.getItemFromBlock(NRBlocks.fissionReactorGraphiteIdle);
}

public void onBlockAdded(World world, int x, int y, int z)
{
	super.onBlockAdded(world, x, y, z);
	this.setDefaultDirection(world, x, y, z);
}

private void setDefaultDirection(World world, int x, int y, int z)
 {
        if (!world.isRemote)
        {
            Block block = world.getBlock(x, y, z - 1);
            Block block1 = world.getBlock(x, y, z + 1);
            Block block2 = world.getBlock(x - 1, y, z);
            Block block3 = world.getBlock(x + 1, y, z);
            byte b0 = 3;

            if (block.func_149730_j() && !block1.func_149730_j())
            {
                b0 = 3;
            }

            if (block1.func_149730_j() && !block.func_149730_j())
            {
                b0 = 2;
            }

            if (block2.func_149730_j() && !block3.func_149730_j())
            {
                b0 = 5;
            }

            if (block3.func_149730_j() && !block2.func_149730_j())
            {
                b0 = 4;
            }

            world.setBlockMetadataWithNotify(x, y, z, b0, 2);
        }
    }

@SideOnly(Side.CLIENT)
 public IIcon getIcon(int side, int metadata) {
	return metadata == 0 && side == 3 ? this.iconFront : (side == metadata ? this.iconFront : this.blockIcon);
    }

public boolean onBlockActivated(World world, int x, int y, int z, EntityPlayer player, int side, float hitX, float hitY, float hitZ)
{
	 if(world.isRemote)
	 {
		 return true; 
	 }
	 else
	 {
		 FMLNetworkHandler.openGui(player, NuclearRelativistics.instance, NuclearRelativistics.guiIdFissionReactorGraphite, world, x, y, z);
	 }
	 return true;
 }

public TileEntity createNewTileEntity(World world, int par1)
{
	return new TileEntityFissionReactorGraphite();
}

public void onBlockPlacedBy(World world, int x, int y, int z, EntityLivingBase entityLivingBase, ItemStack itemstack)
{
	 int l = MathHelper.floor_double((double)(entityLivingBase.rotationYaw * 4.0F / 360.0F) + 0.5D) & 3;

        if (l == 0)
        {
            world.setBlockMetadataWithNotify(x, y, z, 2, 2);
        }

        if (l == 1)
        {
        	world.setBlockMetadataWithNotify(x, y, z, 5, 2);
        }

        if (l == 2)
        {
        	world.setBlockMetadataWithNotify(x, y, z, 3, 2);
        }

        if (l == 3)
        {
        	world.setBlockMetadataWithNotify(x, y, z, 4, 2);
        }

        if (itemstack.hasDisplayName())
        {
            ((TileEntityFissionReactorGraphite)world.getTileEntity(x, y, z)).setGuiDisplayName(itemstack.getDisplayName());
        }
        
        //itemstack = new ItemStack(NRItems.book, 1);
    	//player.inventory.addItemStackToInventory(itemstack);
    	
    	IChatComponent localIChatComponent;
    	localIChatComponent = IChatComponent.Serializer.func_150699_a("[{text:\"Click here to see how to build the multiblock reactor\",color:aqua,italic:false,clickEvent:{action:open_url,value:\"https://www.dropbox.com/s/vy7ld0dgd71utxu/fission%20reactor%20setup.bmp?dl=0\"}}]");

    	((ICommandSender) entityLivingBase).addChatMessage(localIChatComponent);
    }

public static void updateFissionReactorGraphiteBlockState(boolean active, World worldObj, int xCoord, int yCoord, int zCoord)
{
	int i = worldObj.getBlockMetadata(xCoord, yCoord, zCoord);

	TileEntity tileentity = worldObj.getTileEntity(xCoord, yCoord, zCoord);
	keepInventory = true;

	if(active)
	{
		worldObj.setBlock(xCoord, yCoord, zCoord, NRBlocks.fissionReactorGraphiteActive);
	}
	else
	{
		worldObj.setBlock(xCoord, yCoord, zCoord, NRBlocks.fissionReactorGraphiteIdle);
	}

	keepInventory = false;

	worldObj.setBlockMetadataWithNotify(xCoord, yCoord, zCoord, i, 2);

	if(tileentity != null)
	{
		tileentity.validate();
		worldObj.setTileEntity(xCoord, yCoord, zCoord, tileentity);
	}
}

public void breakBlock(World world, int x, int y, int z, Block oldBlockID, int oldMetadata)
{
	if(!keepInventory)
	{
		TileEntityFissionReactorGraphite tileentity = (TileEntityFissionReactorGraphite) world.getTileEntity(x, y, z);

		if(tileentity != null)
		{
			for(int i = 0; i < tileentity.getSizeInventory(); i++)
			{
				ItemStack itemstack = tileentity.getStackInSlot(i);

				if(itemstack != null)
				{
					float f = this.rand.nextFloat() * 0.8F + 0.1F;
					float f1 = this.rand.nextFloat() * 0.8F + 0.1F;
					float f2 = this.rand.nextFloat() * 0.8F + 0.1F;

					while(itemstack.stackSize > 0)
					{
						int j = this.rand.nextInt(21) + 10;

						if(j > itemstack.stackSize)
						{
							j = itemstack.stackSize;
						}

						itemstack.stackSize -= 	j;
						EntityItem item = new EntityItem(world, (double) ((float) x + f), ((float) y + f1), ((float) z + f2),
						new ItemStack (itemstack.getItem(), j, itemstack.getItemDamage()));

						if(itemstack.hasTagCompound())
						{
							item.getEntityItem().setTagCompound((NBTTagCompound) itemstack.getTagCompound().copy());
						}

						float f3 = 0.05F;
						item.motionX = (double)((float) this.rand.nextGaussian() * f3);
						item.motionY = (double)((float) this.rand.nextGaussian() * f3 + 0.2F);
						item.motionZ = (double)((float) this.rand.nextGaussian() * f3);

						world.spawnEntityInWorld(item);

					}
				}
			}

			world.func_147453_f(x, y, z, oldBlockID);
		}
	}

	super.breakBlock(world, x, y, z, oldBlockID, oldMetadata);
}

public boolean hasComparatorInputOverride()
{
	return true;
}

public int getComparatorInputOverride(World world, int x, int y, int z, int i)
{
	return Container.calcRedstoneFromInventory((IInventory)world.getTileEntity(x, y, z));
}

public Block idPicked(World world, int x, int y, int z)
{
	return NRBlocks.fissionReactorGraphiteIdle;
}

    public static boolean isMultiBlock(World world, int x, int y, int z)
    {
    	/*if (world.getBlock(x-2, y, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y, z-5) == NRBlocks.reactorBlock
    			
    			&& world.getBlock(x-2, y+6, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+6, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+6, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+6, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+6, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+6, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+6, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+6, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+6, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+6, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+6, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+6, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+6, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+6, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+6, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+6, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+6, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+6, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+6, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+6, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+6, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+6, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+6, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+6, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+6, z-5) == NRBlocks.reactorBlock
    			
    			&& world.getBlock(x-3, y+1, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+1, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+1, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+1, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+1, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+2, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+2, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+2, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+2, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+2, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+3, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+3, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+3, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+3, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+3, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+4, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+4, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+4, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+4, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+4, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+5, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+5, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+5, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+5, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x-3, y+5, z-5) == NRBlocks.reactorBlock
    			
    			&& world.getBlock(x+3, y+1, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+1, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+1, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+1, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+1, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+2, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+2, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+2, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+2, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+2, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+3, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+3, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+3, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+3, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+3, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+4, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+4, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+4, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+4, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+4, z-5) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+5, z-1) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+5, z-2) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+5, z-3) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+5, z-4) == NRBlocks.reactorBlock
    			&& world.getBlock(x+3, y+5, z-5) == NRBlocks.reactorBlock
    			
    			&& world.getBlock(x-2, y+1, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+1, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+1, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+1, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+1, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+2, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+2, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+2, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+2, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+2, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+3, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+3, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+3, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+3, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+3, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+4, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+4, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+4, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+4, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+4, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+5, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+5, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+5, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+5, z) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+5, z) == NRBlocks.reactorBlock
    			
    			&& world.getBlock(x-2, y+1, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+1, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+1, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+1, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+1, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+2, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+2, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+2, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+2, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+2, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+3, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+3, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+3, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+3, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+3, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+4, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+4, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+4, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+4, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+4, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x-2, y+5, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x-1, y+5, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x, y+5, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x+1, y+5, z-6) == NRBlocks.reactorBlock
    			&& world.getBlock(x+2, y+5, z-6) == NRBlocks.reactorBlock
    			
    			&& world.getBlock(x-3, y, z-1) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x-3, y, z-2) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x-3, y, z-3) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x-3, y, z-4) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x-3, y, z-5) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x+3, y, z-1) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x+3, y, z-2) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x+3, y, z-3) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x+3, y, z-4) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x+3, y, z-5) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x-2, y, z) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x-1, y, z) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x+1, y, z) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x+2, y, z) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x-2, y, z-6) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x-1, y, z-6) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x, y, z-6) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x+1, y, z-6) != NRBlocks.fissionReactorGraphiteIdle
    			&& world.getBlock(x+2, y, z-6) != NRBlocks.fissionReactorGraphiteIdle
    			
    			&& world.getBlock(x-3, y, z-1) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x-3, y, z-2) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x-3, y, z-3) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x-3, y, z-4) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x-3, y, z-5) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x+3, y, z-1) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x+3, y, z-2) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x+3, y, z-3) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x+3, y, z-4) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x+3, y, z-5) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x-2, y, z) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x-1, y, z) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x+1, y, z) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x+2, y, z) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x-2, y, z-6) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x-1, y, z-6) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x, y, z-6) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x+1, y, z-6) != NRBlocks.fissionReactorGraphiteActive
    			&& world.getBlock(x+2, y, z-6) != NRBlocks.fissionReactorGraphiteActive
    			
        		)*/
    	for (int i1 = 0; i1 < 5; i1++) {
    		for (int i2 = 0; i2 < 5; i2++) {
    			if (world.getBlock(x-2+i1, y, z-1-i2) == NRBlocks.reactorBlock
    				&& world.getBlock(x-2+i1, y+6, z-1-i2) == NRBlocks.reactorBlock
    				&& world.getBlock(x-3, y+1+i1, z-1-i2) == NRBlocks.reactorBlock
    				&& world.getBlock(x+3, y+1+i1, z-1-i2) == NRBlocks.reactorBlock
    				&& world.getBlock(x-2+i1, y+1+i2, z) == NRBlocks.reactorBlock
    				&& world.getBlock(x-2+i1, y+1+i2, z-6) == NRBlocks.reactorBlock) {
    				MBNumber = 1;
    				return true;
    			}
    	
    						/*else if (world.getBlock(x-1, y, z-1) == NRBlocks.reactorBlock
    								&& world.getBlock(x-1, y, z-1) == NRBlocks.reactorBlock) {
    							MBNumber = 2;
    							return true;
    						}
    						else if (world.getBlock(x+2, y, z-6) != NRBlocks.fissionReactorGraphiteActive) {
    							MBNumber = 3;
    							return true;
    						}
    						else if (world.getBlock(x+2, y, z-6) != NRBlocks.fissionReactorGraphiteActive) {
    							MBNumber = 4;
    							return true;
    						}*/

    		}
    	} MBNumber = 0; return false;
    }
}

 

Thanks in advance for anyone better at this than me for noticing why this won't work :)

Link to comment
Share on other sites

Because you return true if the first time the loop runs it finds the blocks.  You didn't let the loop finish.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

loop {
    if(condition == true) {
        //your current return true, commented out
    }
    else {
        return false; //new
    }
    return true; //new
}

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hello. I've been having a problem when launching minecraft forge. It just doesn't open the game, and leaves me with this "(exit code 1)" error. Both regular and optifine versions of minecraft launch just fine, tried both with 1.18.2 and 1.20.1. I can assure that my drivers are updated so that can't be it, and i've tried using Java 17, 18 and 21 to no avail. Even with no mods installed, the thing won't launch. I'll leave the log here, although it's in spanish: https://jmp.sh/s/FPqGBSi30fzKJDt2M1gc My specs are this: Ryzen 3 4100 || Radeon R9 280x || 16gb ram || Windows 10 I'd appreciate any help, thank you in advance.
    • Hey, Me and my friends decided to start up a Server with "a few" mods, the last few days everything went well we used all the items we wanted. Now our Game crashes the moment we touch a Lava Bucket inside our Inventory. It just instantly closes and gives me an "Alc Cleanup"  Crash screen (Using GDLauncher). I honestly dont have a clue how to resolve this error. If anyone could help id really appreciate it, I speak German and Englisch so you can choose whatever you speak more fluently. Thanks in Advance. Plus I dont know how to link my Crash Report help for that would be nice too whoops
    • I hosted a minecraft server and I modded it, and there is always an error on the console which closes the server. If someone knows how to repair it, it would be amazing. Thank you. I paste the crash report down here: ---- Minecraft Crash Report ---- WARNING: coremods are present:   llibrary (llibrary-core-1.0.11-1.12.2.jar)   WolfArmorCore (WolfArmorAndStorage-1.12.2-3.8.0-universal-signed.jar)   AstralCore (astralsorcery-1.12.2-1.10.27.jar)   CreativePatchingLoader (CreativeCore_v1.10.71_mc1.12.2.jar)   SecurityCraftLoadingPlugin ([1.12.2] SecurityCraft v1.9.8.jar)   ForgelinPlugin (Forgelin-1.8.4.jar)   midnight (themidnight-0.3.5.jar)   FutureMC (Future-MC-0.2.19.jar)   SpartanWeaponry-MixinLoader (SpartanWeaponry-1.12.2-1.5.3.jar)   Backpacked (backpacked-1.4.3-1.12.2.jar)   LoadingPlugin (Reskillable-1.12.2-1.13.0.jar)   LoadingPlugin (Bloodmoon-MC1.12.2-1.5.3.jar) Contact their authors BEFORE contacting forge // There are four lights! Time: 3/28/24 12:17 PM Description: Exception in server tick loop net.minecraftforge.fml.common.LoaderException: java.lang.NoClassDefFoundError: net/minecraft/client/multiplayer/WorldClient     at net.minecraftforge.fml.common.AutomaticEventSubscriber.inject(AutomaticEventSubscriber.java:89)     at net.minecraftforge.fml.common.FMLModContainer.constructMod(FMLModContainer.java:612)     at sun.reflect.GeneratedMethodAccessor10.invoke(Unknown Source)     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)     at java.lang.reflect.Method.invoke(Method.java:498)     at com.google.common.eventbus.Subscriber.invokeSubscriberMethod(Subscriber.java:91)     at com.google.common.eventbus.Subscriber$SynchronizedSubscriber.invokeSubscriberMethod(Subscriber.java:150)     at com.google.common.eventbus.Subscriber$1.run(Subscriber.java:76)     at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:399)     at com.google.common.eventbus.Subscriber.dispatchEvent(Subscriber.java:71)     at com.google.common.eventbus.Dispatcher$PerThreadQueuedDispatcher.dispatch(Dispatcher.java:116)     at com.google.common.eventbus.EventBus.post(EventBus.java:217)     at net.minecraftforge.fml.common.LoadController.sendEventToModContainer(LoadController.java:219)     at net.minecraftforge.fml.common.LoadController.propogateStateMessage(LoadController.java:197)     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)     at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)     at java.lang.reflect.Method.invoke(Method.java:498)     at com.google.common.eventbus.Subscriber.invokeSubscriberMethod(Subscriber.java:91)     at com.google.common.eventbus.Subscriber$SynchronizedSubscriber.invokeSubscriberMethod(Subscriber.java:150)     at com.google.common.eventbus.Subscriber$1.run(Subscriber.java:76)     at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:399)     at com.google.common.eventbus.Subscriber.dispatchEvent(Subscriber.java:71)     at com.google.common.eventbus.Dispatcher$PerThreadQueuedDispatcher.dispatch(Dispatcher.java:116)     at com.google.common.eventbus.EventBus.post(EventBus.java:217)     at net.minecraftforge.fml.common.LoadController.distributeStateMessage(LoadController.java:136)     at net.minecraftforge.fml.common.Loader.loadMods(Loader.java:595)     at net.minecraftforge.fml.server.FMLServerHandler.beginServerLoading(FMLServerHandler.java:98)     at net.minecraftforge.fml.common.FMLCommonHandler.onServerStart(FMLCommonHandler.java:333)     at net.minecraft.server.dedicated.DedicatedServer.func_71197_b(DedicatedServer.java:125)     at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:486)     at java.lang.Thread.run(Thread.java:750) Caused by: java.lang.NoClassDefFoundError: net/minecraft/client/multiplayer/WorldClient     at java.lang.Class.getDeclaredMethods0(Native Method)     at java.lang.Class.privateGetDeclaredMethods(Class.java:2701)     at java.lang.Class.privateGetPublicMethods(Class.java:2902)     at java.lang.Class.getMethods(Class.java:1615)     at net.minecraftforge.fml.common.eventhandler.EventBus.register(EventBus.java:82)     at net.minecraftforge.fml.common.AutomaticEventSubscriber.inject(AutomaticEventSubscriber.java:82)     ... 31 more Caused by: java.lang.ClassNotFoundException: net.minecraft.client.multiplayer.WorldClient     at net.minecraft.launchwrapper.LaunchClassLoader.findClass(LaunchClassLoader.java:191)     at java.lang.ClassLoader.loadClass(ClassLoader.java:418)     at java.lang.ClassLoader.loadClass(ClassLoader.java:351)     ... 37 more Caused by: net.minecraftforge.fml.common.asm.ASMTransformerWrapper$TransformerException: Exception in class transformer net.minecraftforge.fml.common.asm.transformers.SideTransformer@4e558728 from coremod FMLCorePlugin     at net.minecraftforge.fml.common.asm.ASMTransformerWrapper$TransformerWrapper.transform(ASMTransformerWrapper.java:260)     at net.minecraft.launchwrapper.LaunchClassLoader.runTransformers(LaunchClassLoader.java:279)     at net.minecraft.launchwrapper.LaunchClassLoader.findClass(LaunchClassLoader.java:176)     ... 39 more Caused by: java.lang.RuntimeException: Attempted to load class bsb for invalid side SERVER     at net.minecraftforge.fml.common.asm.transformers.SideTransformer.transform(SideTransformer.java:62)     at net.minecraftforge.fml.common.asm.ASMTransformerWrapper$TransformerWrapper.transform(ASMTransformerWrapper.java:256)     ... 41 more A detailed walkthrough of the error, its code path and all known details is as follows: --------------------------------------------------------------------------------------- -- System Details -- Details:     Minecraft Version: 1.12.2     Operating System: Linux (amd64) version 5.10.0-28-cloud-amd64     Java Version: 1.8.0_382, Temurin     Java VM Version: OpenJDK 64-Bit Server VM (mixed mode), Temurin     Memory: 948745536 bytes (904 MB) / 1564999680 bytes (1492 MB) up to 7635730432 bytes (7282 MB)     JVM Flags: 2 total; -Xmx8192M -Xms256M     IntCache: cache: 0, tcache: 0, allocated: 0, tallocated: 0     FML: MCP 9.42 Powered by Forge 14.23.5.2860 63 mods loaded, 63 mods active     States: 'U' = Unloaded 'L' = Loaded 'C' = Constructed 'H' = Pre-initialized 'I' = Initialized 'J' = Post-initialized 'A' = Available 'D' = Disabled 'E' = Errored     | State | ID                 | Version                 | Source                                                | Signature                                |     |:----- |:------------------ |:----------------------- |:----------------------------------------------------- |:---------------------------------------- |     | LC    | minecraft          | 1.12.2                  | minecraft.jar                                         | None                                     |     | LC    | mcp                | 9.42                    | minecraft.jar                                         | None                                     |     | LC    | FML                | 8.0.99.99               | forge-1.12.2-14.23.5.2860.jar                         | e3c3d50c7c986df74c645c0ac54639741c90a557 |     | LC    | forge              | 14.23.5.2860            | forge-1.12.2-14.23.5.2860.jar                         | e3c3d50c7c986df74c645c0ac54639741c90a557 |     | LC    | creativecoredummy  | 1.0.0                   | minecraft.jar                                         | None                                     |     | LC    | backpacked         | 1.4.2                   | backpacked-1.4.3-1.12.2.jar                           | None                                     |     | LC    | itemblacklist      | 1.4.3                   | ItemBlacklist-1.4.3.jar                               | None                                     |     | LC    | securitycraft      | v1.9.8                  | [1.12.2] SecurityCraft v1.9.8.jar                     | None                                     |     | LC    | aiimprovements     | 0.0.1.3                 | AIImprovements-1.12-0.0.1b3.jar                       | None                                     |     | LC    | jei                | 4.16.1.301              | jei_1.12.2-4.16.1.301.jar                             | None                                     |     | LC    | appleskin          | 1.0.14                  | AppleSkin-mc1.12-1.0.14.jar                           | None                                     |     | LC    | baubles            | 1.5.2                   | Baubles-1.12-1.5.2.jar                                | None                                     |     | LC    | astralsorcery      | 1.10.27                 | astralsorcery-1.12.2-1.10.27.jar                      | a0f0b759d895c15ceb3e3bcb5f3c2db7c582edf0 |     | LC    | attributefix       | 1.0.12                  | AttributeFix-Forge-1.12.2-1.0.12.jar                  | None                                     |     | LC    | atum               | 2.0.20                  | Atum-1.12.2-2.0.20.jar                                | None                                     |     | LC    | bloodmoon          | 1.5.3                   | Bloodmoon-MC1.12.2-1.5.3.jar                          | d72e0dd57935b3e9476212aea0c0df352dd76291 |     | LC    | forgelin           | 1.8.4                   | Forgelin-1.8.4.jar                                    | None                                     |     | LC    | bountiful          | 2.2.2                   | Bountiful-2.2.2.jar                                   | None                                     |     | LC    | camera             | 1.0.10                  | camera-1.0.10.jar                                     | None                                     |     | LC    | chisel             | MC1.12.2-1.0.2.45       | Chisel-MC1.12.2-1.0.2.45.jar                          | None                                     |     | LC    | collective         | 3.0                     | collective-1.12.2-3.0.jar                             | None                                     |     | LC    | reskillable        | 1.12.2-1.13.0           | Reskillable-1.12.2-1.13.0.jar                         | None                                     |     | LC    | compatskills       | 1.12.2-1.17.0           | CompatSkills-1.12.2-1.17.0.jar                        | None                                     |     | LC    | creativecore       | 1.10.0                  | CreativeCore_v1.10.71_mc1.12.2.jar                    | None                                     |     | LC    | customnpcs         | 1.12                    | CustomNPCs_1.12.2-(05Jul20).jar                       | None                                     |     | LC    | darknesslib        | 1.1.2                   | DarknessLib-1.12.2-1.1.2.jar                          | 220f10d3a93b3ff5fbaa7434cc629d863d6751b9 |     | LC    | dungeonsmod        | @VERSION@               | DungeonsMod-1.12.2-1.0.8.jar                          | None                                     |     | LC    | enhancedvisuals    | 1.3.0                   | EnhancedVisuals_v1.4.4_mc1.12.2.jar                   | None                                     |     | LC    | extrautils2        | 1.0                     | extrautils2-1.12-1.9.9.jar                            | None                                     |     | LC    | futuremc           | 0.2.6                   | Future-MC-0.2.19.jar                                  | None                                     |     | LC    | geckolib3          | 3.0.30                  | geckolib-forge-1.12.2-3.0.31.jar                      | None                                     |     | LC    | gottschcore        | 1.15.1                  | GottschCore-mc1.12.2-f14.23.5.2859-v1.15.1.jar        | None                                     |     | LC    | hardcorerevival    | 1.2.0                   | HardcoreRevival_1.12.2-1.2.0.jar                      | None                                     |     | LC    | waila              | 1.8.26                  | Hwyla-1.8.26-B41_1.12.2.jar                           | None                                     |     | LE    | imsm               | 1.12                    | Instant Massive Structures Mod 1.12.2.jar             | None                                     |     | L     | journeymap         | 1.12.2-5.7.1p2          | journeymap-1.12.2-5.7.1p2.jar                         | None                                     |     | L     | mobsunscreen       | @version@               | mobsunscreen-1.12.2-3.1.5.jar                         | None                                     |     | L     | morpheus           | 1.12.2-3.5.106          | Morpheus-1.12.2-3.5.106.jar                           | None                                     |     | L     | llibrary           | 1.7.20                  | llibrary-1.7.20-1.12.2.jar                            | None                                     |     | L     | mowziesmobs        | 1.5.8                   | mowziesmobs-1.5.8.jar                                 | None                                     |     | L     | nocubessrparmory   | 3.0.0                   | NoCubes_SRP_Combat_Addon_3.0.0.jar                    | None                                     |     | L     | nocubessrpnests    | 3.0.0                   | NoCubes_SRP_Nests_Addon_3.0.0.jar                     | None                                     |     | L     | nocubessrpsurvival | 3.0.0                   | NoCubes_SRP_Survival_Addon_3.0.0.jar                  | None                                     |     | L     | nocubesrptweaks    | V4.1                    | nocubesrptweaks-V4.1.jar                              | None                                     |     | L     | patchouli          | 1.0-23.6                | Patchouli-1.0-23.6.jar                                | None                                     |     | L     | artifacts          | 1.1.2                   | RLArtifacts-1.1.2.jar                                 | None                                     |     | L     | rsgauges           | 1.2.8                   | rsgauges-1.12.2-1.2.8.jar                             | None                                     |     | L     | rustic             | 1.1.7                   | rustic-1.1.7.jar                                      | None                                     |     | L     | silentlib          | 3.0.13                  | SilentLib-1.12.2-3.0.14+168.jar                       | None                                     |     | L     | scalinghealth      | 1.3.37                  | ScalingHealth-1.12.2-1.3.42+147.jar                   | None                                     |     | L     | lteleporters       | 1.12.2-3.0.2            | simpleteleporters-1.12.2-3.0.2.jar                    | None                                     |     | L     | spartanshields     | 1.5.5                   | SpartanShields-1.12.2-1.5.5.jar                       | None                                     |     | L     | spartanweaponry    | 1.5.3                   | SpartanWeaponry-1.12.2-1.5.3.jar                      | None                                     |     | L     | srparasites        | 1.9.18                  | SRParasites-1.12.2v1.9.18.jar                         | None                                     |     | L     | treasure2          | 2.2.0                   | Treasure2-mc1.12.2-f14.23.5.2859-v2.2.1.jar           | None                                     |     | L     | treeharvester      | 4.0                     | treeharvester_1.12.2-4.0.jar                          | None                                     |     | L     | twilightforest     | 3.11.1021               | twilightforest-1.12.2-3.11.1021-universal.jar         | None                                     |     | L     | variedcommodities  | 1.12.2                  | VariedCommodities_1.12.2-(31Mar23).jar                | None                                     |     | L     | voicechat          | 1.12.2-2.4.32           | voicechat-forge-1.12.2-2.4.32.jar                     | None                                     |     | L     | wolfarmor          | 3.8.0                   | WolfArmorAndStorage-1.12.2-3.8.0-universal-signed.jar | None                                     |     | L     | worldborder        | 2.3                     | worldborder_1.12.2-2.3.jar                            | None                                     |     | L     | midnight           | 0.3.5                   | themidnight-0.3.5.jar                                 | None                                     |     | L     | structurize        | 1.12.2-0.10.277-RELEASE | structurize-1.12.2-0.10.277-RELEASE.jar               | None                                     |     Loaded coremods (and transformers):  llibrary (llibrary-core-1.0.11-1.12.2.jar)   net.ilexiconn.llibrary.server.core.plugin.LLibraryTransformer   net.ilexiconn.llibrary.server.core.patcher.LLibraryRuntimePatcher WolfArmorCore (WolfArmorAndStorage-1.12.2-3.8.0-universal-signed.jar)    AstralCore (astralsorcery-1.12.2-1.10.27.jar)    CreativePatchingLoader (CreativeCore_v1.10.71_mc1.12.2.jar)    SecurityCraftLoadingPlugin ([1.12.2] SecurityCraft v1.9.8.jar)    ForgelinPlugin (Forgelin-1.8.4.jar)    midnight (themidnight-0.3.5.jar)   com.mushroom.midnight.core.transformer.MidnightClassTransformer FutureMC (Future-MC-0.2.19.jar)   thedarkcolour.futuremc.asm.CoreTransformer SpartanWeaponry-MixinLoader (SpartanWeaponry-1.12.2-1.5.3.jar)    Backpacked (backpacked-1.4.3-1.12.2.jar)   com.mrcrayfish.backpacked.asm.BackpackedTransformer LoadingPlugin (Reskillable-1.12.2-1.13.0.jar)   codersafterdark.reskillable.base.asm.ClassTransformer LoadingPlugin (Bloodmoon-MC1.12.2-1.5.3.jar)   lumien.bloodmoon.asm.ClassTransformer     Profiler Position: N/A (disabled)     Is Modded: Definitely; Server brand changed to 'fml,forge'     Type: Dedicated Server (map_server.txt)
    • When i add mods like falling leaves, visuality and kappas shaders, even if i restart Minecraft they dont show up in the mods menu and they dont work
    • Delete the forge-client.toml file in your config folder  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.